- 15 May, 2018 40 commits
-
-
Chris Pickel authored
This reverts commit b54641a0. Reason for revert: Findit has detected a flake at test All/PasswordManagerBrowserTestWithViewsFeature.NoFormElementTest/1. Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I4dd593c829c25e8f45ad816f6a3ddd3b941d76af Regression range: None Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzM4NDY3L2Jyb3dzZXJfdGVzdHMvUVd4c0wxQmhjM04zYjNKa1RXRnVZV2RsY2tKeWIzZHpaWEpVWlhOMFYybDBhRlpwWlhkelJtVmhkSFZ5WlM1T2IwWnZjbTFGYkdWdFpXNTBWR1Z6ZEM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Original change's description: > Change some password browser tests to produce user input. > > This is a preparation CL for removing some code from PasswordAutofillAgent. Most of the tests in the file do not test the real behavior. We fill the username/password using JavaScript and it's a different code path from typing them manually. > The tests changed here are necessary to update. Let's land them first and observe if it introduces some flakiness before proceeding. > > Bug: 842643 > Change-Id: I4dd593c829c25e8f45ad816f6a3ddd3b941d76af > Reviewed-on: https://chromium-review.googlesource.com/1054675 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558296} TBR=battre@chromium.org,vasilii@chromium.org Change-Id: I3f54c76a4e3bb797f894750b16e1cdd6970e0d2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842643 Reviewed-on: https://chromium-review.googlesource.com/1059168Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#558651}
-
Marton Hunyady authored
kErrorCodeNoUpdate introduced in http://crrev.com/c/1055857 kRollbackNotPossible introduced in http://crrev.com/c/1047610 BUG=840432 Change-Id: Id6a7697b6db70a01503e10196997c800a3522a5a Reviewed-on: https://chromium-review.googlesource.com/1047866Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#558650}
-
Ricky Liang authored
The original CL broke the component build due to a typo in the export macro. It should have been CAPTURE_EXPORT instead of MEDIA_EXPORT in camera_3a_controller.h, and the functions in camera_metadata_utils.h should be exported as well. Original change's description -------------------------------------------------- media: implement TakePhoto in Chrome OS camera HAL VideoCaptureDevice This CL implements the TakePhoto() API for the Chrome OS camera HAL VideoCaptureDevice, including the following features: - Full size still capture - Auto-focus, auto-exposure, and auto-white-balancing stabilization BUG=chromium:832772 TEST=Run capture_unittests on DUT TEST=Make sure TakePhoto() API works on https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html TBR=wuchengli@chromium.org,emircan@chromium.org Change-Id: Ia44506b30315df2aaff9047ff725fff95d3ba118 Reviewed-on: https://chromium-review.googlesource.com/1058881 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558649}
-
Hans Wennborg authored
Apparently lambdas are non-literal types before C++17, and Clang errors about this after r332286. TBR=thakis Bug: 843046 Change-Id: I9ec058e9e4e74e418d36d1875f7e51bf0d1165c1 Reviewed-on: https://chromium-review.googlesource.com/1059111Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558648}
-
Matt Falkenhagen authored
Pass the network factory instead of the URLLoaderFactoryGetter, as they only need the network factory. Change-Id: Ie421f779d18edec9217bc8f3a5fe4946b75719d6 Reviewed-on: https://chromium-review.googlesource.com/1058746 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558647}
-
Gustav Sennton authored
To ensure support library methods calls are only called on webview / support library versions where they're supported we use feature flags. This CL adds feature flags for APIs related to WebMessages (postmessages). Bug: 813118 Change-Id: Ic0d06df79da079a0d9c87ce09cd9fc720d6a244c Reviewed-on: https://chromium-review.googlesource.com/1041931 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558646}
-
Mike Frysinger authored
Bug: None Change-Id: Ib1079c2c37ba772ac3c9a73927c24ecf0cf19d98 Reviewed-on: https://chromium-review.googlesource.com/1058699Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#558645}
-
Yoshifumi Inoue authored
This patch gets rid of unused declaration |Element::RecalcOwnStyleForReattach()| for improving code health. Change-Id: I9c9b1331a59614d8bdf8f1ced03e4e8348db0da0 Reviewed-on: https://chromium-review.googlesource.com/1058877 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558644}
-
Philip Jägenstedt authored
These tests are already doing fairly well on Chrome: https://wpt.fyi/css/css-masking However, there's also at least one Chrome-only failure: https://wpt.fyi/css/css-masking/parsing/clip-path-invalid.html Note that some of the tests are still problematic: https://wpt.fyi/css/css-masking/clip-path https://github.com/w3c/web-platform-tests/issues/7543#issuecomment-388744004 No-Try: true Change-Id: I036e08fd44b12291f8fcce386b67b7d5897365da Reviewed-on: https://chromium-review.googlesource.com/1057090Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#558643}
-
Hans Wennborg authored
Bug: 843032 Change-Id: I0aabddd2f0ae520fcd46a5c6532289547da7cde3 Reviewed-on: https://chromium-review.googlesource.com/1058796Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558642}
-
Alan Cutter authored
This is a small code clean up to use ranged based for loops instead of manual iterator logic. This reduces the line wrapping and makes the type of the iterated values more obvious in some cases. Bug: 809816 Change-Id: I4f6e856a4dcd052d3d7ec5befd5792b9c1f09602 Reviewed-on: https://chromium-review.googlesource.com/1058987Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#558641}
-
Vasilii Sukhanov authored
Currently the function always generates capital letters regardless of the parameters. Change-Id: I7b1f11743c3ba2463e7fd5268d29400d3c71792b Reviewed-on: https://chromium-review.googlesource.com/1056533Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#558640}
-
Matt Falkenhagen authored
This ships updateViaCache which controls whether the browser cache is used for service worker update checks. Importantly, this changes the default behavior, since the default value of updateViaCache is 'imports', which skips the browser cache for the main service worker script and uses it only for import scripts. However, actually checking import script contents for updates is not yet implemented, so effectively the default is 'none': https://crbug.com/648295. Thanks to Emma Haruka Iwao (yuryu@) for doing the bulk of the implementation work. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/RwjXGTAbuuA/7Q3NPlJ4BAAJ Bug: 675540 Change-Id: Ifdbaaa76b028e07ac26b9db28d9c59c7b8bd055f Reviewed-on: https://chromium-review.googlesource.com/1056756 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#558639}
-
Hiroki Nakagawa authored
Worklets don't support dynamic import (see the issue) Bug: 782538 Change-Id: Iea9b4352122e78d1ff671ae09a9947f6a7f1ef3b TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1058883Reviewed-by:
-
Christopher Lam authored
This CL fixes an issue with JS externs generation for Interface types in mojo. This was blocking https://chromium-review.googlesource.com/c/chromium/src/+/1053381. Bug: 632206 Change-Id: I164bc3d9e9b0fd43f438dfefeaa2bc6e731fd1e7 Reviewed-on: https://chromium-review.googlesource.com/1053332Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#558637}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=oshima@chromium.org Change-Id: Icb169f38374388d9acada35cb4ced2bdc4cc7509 Reviewed-on: https://chromium-review.googlesource.com/1058696Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558636}
-
Marc Treib authored
TBRing trivial call site update in avatar_button_error_controller.cc TBR=msarda Bug: 839834 Change-Id: I3f01a7fd80d4699101e6d7002e85b9829d0aa881 Reviewed-on: https://chromium-review.googlesource.com/1057672 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558635}
-
Hitoshi Yoshida authored
To merge common processes into one place, this CL make CodeGeneratorV8 inheritances to use CodeGeneratorBase.render_templates(), which was renamed from render_template(). This CL also make normalize_and_sort_includes() to use set() type to avoid include duplicates. Bug: 830255 Change-Id: I7e723153930ae55cab04d5a5fdb38b51c3494434 Reviewed-on: https://chromium-review.googlesource.com/1058743Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/08d96f1cadb1..473b4ae489e8 $ git log 08d96f1ca..473b4ae48 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 thestig Lower the limit of image dimensions for fax codecs. 2018-05-15 thestig Read data in bigger chunks in fax codec code. 2018-05-15 thestig Clean up CBC_ASCIIEncoder. 2018-05-15 thestig Return earlier in CPDF_TextPage::ProcessInsertObject() when possible. Created with: roll-dep src/third_party/pdfium BUG=chromium:834633,chromium:834633 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I67c2cecc2867cf1ea9506e502702c67a3b1f5843 Reviewed-on: https://chromium-review.googlesource.com/1058927Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558633}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7e9e7b065a98..c8e4e795ed75 $ git log 7e9e7b065..c8e4e795e --date=short --no-merges --format='%ad %ae %s' 2018-05-14 bpastene Revert "[chromite] Capture job_name and git timing for ts_mon in cbuildbot runs." Created with: roll-dep src/third_party/chromite BUG=chromium:829289 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifcc9ffe22c45cf58facf0522b1e9604c3638b9b9 Reviewed-on: https://chromium-review.googlesource.com/1058980Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558632}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60f2c3c7. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17636 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=markdittmer No-Export: true Change-Id: I0dc71858072594d862992196ba0d94f72b057f43 Reviewed-on: https://chromium-review.googlesource.com/1058911 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558631}
-
Ben Wells authored
They have been reordered to match the header file. Bug: None Change-Id: Ia3ff219d28c4b99d88235447672168cdc4f4cde8 Reviewed-on: https://chromium-review.googlesource.com/1056900Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#558630}
-
Kent Tamura authored
Now we have no Blink-relative #includes. Bug: 836071 Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b Reviewed-on: https://chromium-review.googlesource.com/1058876Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558629}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb85cead4784..3136ebfa0a62 $ git log eb85cead4..3136ebfa0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:819426,chromium:807366 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I494cef0cc7c8557a2d3b99c72af41bc4efd7b0c4 Reviewed-on: https://chromium-review.googlesource.com/1058720Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558628}
-
Nicholas Verne authored
Crostini multiprofile support is going to wait until the successor for multiprofile is landed on ChromeOS. Until then, we restrict Crostini to the primary (i.e. first signed in) profile per session. This means that you can still have Linux containers per profile, but to use then you need to sign out then sign in to the desired profile. Note, this prevents UI from being shown to the non-primary profile. It doesn't prevent non-primary users from using crosh and vmc. Bug: 842561 Change-Id: I119359b332e7a3afa02071c1e9d9e6f41164fe4d Reviewed-on: https://chromium-review.googlesource.com/1058738 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
TBR=rdevlin.cronin@chromium.org Bug: 833655 Change-Id: Iace4691833cde898e1545601fee1444139ae717a Reviewed-on: https://chromium-review.googlesource.com/1058878Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#558626}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/493cfb68..558cf7d7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic22cf44bc99d3d48b3e4b1493e372d80495d4902 Reviewed-on: https://chromium-review.googlesource.com/1058908Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558625}
-
Yoav Weiss authored
While going over the code I found an old TODO indicating I should replace a `CHECK` with a `DCHECK` if no crash report would come in. Since the `CHECK` landed 17 months ago, I think it's now safe to replace it. Change-Id: Ic133f6a8ecdb654120a5ae4fb34f6f990ff34ca4 Reviewed-on: https://chromium-review.googlesource.com/1058788Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#558624}
-
Zhiling Huang authored
Bug: 790520 Change-Id: I86c5a81b8b5872a2397621cb631a9b820eb28d8d Reviewed-on: https://chromium-review.googlesource.com/1056228 Commit-Queue: Zhiling Huang <hzl@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#558623}
-
Lei Zhang authored
This reverts commit 640eb0c2. Reason for revert: Broke the build. https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5678 Original change's description: > media: implement TakePhoto in Chrome OS camera HAL VideoCaptureDevice > > This CL implements the TakePhoto() API for the Chrome OS camera HAL > VideoCaptureDevice, including the following features: > > - Full size still capture > - Auto-focus, auto-exposure, and auto-white-balancing stabilization > > BUG=chromium:832772 > TEST=Run capture_unittests on DUT > TEST=Make sure TakePhoto() API works on > https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html > > Change-Id: I99e44087006cac28eac7e73c6764f522dac57cfa > Reviewed-on: https://chromium-review.googlesource.com/1018641 > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org> > Commit-Queue: Ricky Liang <jcliang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558603} TBR=jcliang@chromium.org,wuchengli@chromium.org,emircan@chromium.org,shenghao@google.com,hywu@chromium.org,chfremer@chromium.org Change-Id: Ibc2b4547f33d4a505b546079dd118e1d4401a9cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:832772 Reviewed-on: https://chromium-review.googlesource.com/1058568Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558622}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ifc78d42372052bb8b6261021d2d39bf9588c1a4a Reviewed-on: https://chromium-review.googlesource.com/1058846Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558621}
-
Scott Chen authored
This CL creates a new cr-radio-button element with the MD-refresh spec. This CL also replaces all paper-radio-button within Settings with cr-radio-button. Most of the cr-radio-button's functionalities and styles are encapsulated in separate files in a shared location, so that the controlled-radio-button element in settings can reuse them. There will be a follow-up CL to then replace all of paper-radio-button's usage outside of Settings. Bug: 840527 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4fc47fa0b8186b5d6ef0a3b678cc68bbc58a8e3d Reviewed-on: https://chromium-review.googlesource.com/1053299 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#558620}
-
Derek Cheng authored
Broadcast is currently implemented as a cast URL with a special broadcast query parameter. When this URL is received, it is treated as a request to broadcast a message to all cast devices instead of a regular sink query. Bug: 698940 Change-Id: I25cfa6f84c2957f4fb63ec75b7a30007bfe47850 Reviewed-on: https://chromium-review.googlesource.com/944902Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#558619}
-
https://chromium.googlesource.com/angle/angle.git/+log/5730c0bf431e..a00ef3144f70 $ git log 5730c0bf4..a00ef3144 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I0387e6d674f7447b2cc164df32ab60cb1ca50f8e Reviewed-on: https://chromium-review.googlesource.com/1058678Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558618}
-
Yutaka Hirano authored
When the network service is disabled, we are using the same request ID for the preflight request and the actual request as we cannot assign separate IDs. We need to tear down the preflight request first, and then make the actual request: Otherwise we will see a renderer crash caused by RDH_INVALID_REQUEST_ID. Currently we cancel the request by resetting the SimpleURLLoader for the preflight request: That is not enough because destroying a SimpleURLLoader asynchronously cancels a request, and we don't know when it's actually destroyed. This is especially problematic when a server returns a preflight with a long body. This CL fixes the problem by adding a function which cancels the request synchronously. This is a workaround, and we won't need the logic in the end. Bug: 838136, 614281, 842593 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic9d20cfbecc7c5b8749e0dc664d12c6d07e8c673 Reviewed-on: https://chromium-review.googlesource.com/1056941 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Pavel Feldman authored
TBR: Change-Id: I1b488783f04a3bcc20b82feddb079e3f0519d2cb Reviewed-on: https://chromium-review.googlesource.com/1058931Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558616}
-
Darren Shen authored
This patch adds a new attribute to the InputContext object in the IME API called 'shouldDoLearning'. Textfields in incognito tabs will return false for shouldDoLearning so that the IME can keep incognito and non-incognito profiles separate. To implement this, we add a new TextInputClient::ShouldDoLearning() method that is implemented by various types of text fields. The most interesting case is views::Textfield, which doesn't have any notion of incognito, so it should be up to owner of the textfield to decide if it's incognito or not. However, there are ~90 places where we construct a views::Textfield, so to prevent this CL getting too large, we default to 'false' for ShouldDoLearning and then we'll add support for learning on all the different textfields as needed. Bug: 311180 Change-Id: Id33b11505a2eb3154fed8c4747c05205c7bf7c77 Reviewed-on: https://chromium-review.googlesource.com/1049405Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#558615}
-
Yoichi Osato authored
This patch implements painting selection line break. Design doc: https://goo.gl/ovMr8x This patch changes LayoutSelection::SelectionStartEndForNG( text_fragment) to return LayoutSelectionStatus which has selection |start|,|end| and new boolean member |has_line_break|, which means we need expand selection rect of the fragment to paint line break. The caller NGTextFragmentPainter paints line break selection by extending existing selection rect when selection wraps line. This patch fixes 4 selection painting test. Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idef2d7135a5d7f27a217365cc3e8d55b191fa60b Reviewed-on: https://chromium-review.googlesource.com/896780Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#558614}
-
Lei Zhang authored
Fix some lint errors as well. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3dc89035a5bf2cd6b092512d0aa6eb2022704792 Reviewed-on: https://chromium-review.googlesource.com/1039150Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558613}
-
Xiaocheng Hu authored
When computing caret rect for a caret position before/after an atomic inline box, whether the caret rect is to the left or right of the box depends on the resolved direction of the atomic inline, not the CSS 'direction' property. This patch changes the implementation to check the resolved direction. Bug: 822575 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ibc09e6679faf94ad7882bfba7560d44fd36fd7d8 Reviewed-on: https://chromium-review.googlesource.com/1056395Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
