- 31 Jul, 2019 40 commits
-
-
Jan Krcal authored
This CL adds the first version of identity pill -- only the triggering logic to show and to hide the pill. No animation nor UI changes are included in this CL. Bug: 967317 Change-Id: I76c98e9963ba97606bc9458eb111d3a6bc0872ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679764Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#682648}
-
Lowell Manners authored
This reverts commit 109a13b8. Reason for revert: This breaks the BackforwardCache, causing the wrong site to be shown on a back/forward navigation when the document is cached. TBR=alexmos@chromium.org Original change's description: > Do not hide the aura window of RWHVA > > Windows placed in inactive virtual desks will be considered > hidden by the occlusion tracker. This currently end up in > a call to RenderWidgetHostViewAura::Hide() which unnecessarily > hides the aura::Window. This causes issues when reflecting that > window in the desks mini_views. > > This CL keeps the aura::Window visible, while updating only > the occlusion state. > > BUG=866622 > TEST=Added a new test. > > Change-Id: I7f71cfa072240264fea2e4934f2c7350f66a74c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711113 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681459} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866622,988477, 988999 Change-Id: I7a40d0a8695682e08776a05547a36673a40d17ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725645 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#682647}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ac3d131054ac..31590104ec86 git log ac3d131054ac..31590104ec86 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 dneto@google.com Add pass to inject code for robust-buffer-access semantics (#2771) 2019-07-30 zoddicus@users.noreply.github.com Update OpMemoryBarriers rules for WebGPU (#2775) 2019-07-30 dneto@google.com Add opt test fixture method SinglePassRunAndFail (#2770) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@31590104ec86 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I127c2fc7469a886098fa2663811ebd9e2942e3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682646}
-
Himanshu Jaju authored
Integration tests were reverted because of this error: https://chromium-review.googlesource.com/c/chromium/src/+/1727231 Bug: 982229 Change-Id: Id88be2768477a06320ba1f664cdc762c2865d765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728652 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682645}
-
vitaliii authored
Disable {virtual/blink-cors/}http/tests/security/img-crossorigin-redirect-credentials.html (expect Pass and Timeout), because flaky. TBR=yhirano@chromium.org Bug: 989365 Change-Id: I7df6d12e466b6ed626bd338a92ea86daea6e36b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728575 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682644}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5961d93d. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iedcb2912a69154c251e6bb334463f96344fb68be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728510Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682643}
-
Carlos Caballero authored
It is going away soon. Had to fix a lot of includes. Bug: 891670 Change-Id: I7da88b9801a5333a719ada8000a7399edf1957fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728573Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#682642}
-
Michael Ershov authored
Create a new int-enum policy to control CA certificate management permissions for users. It can have one of the following values: 0: Users can manage all CA certificates. 1: Users can manage user CA certificates, but not built-in CA certificates. 2: Disallow users from managing CA certificates CrSettingsCertificateManagerTest.All.ImportButton_CAPolicy, CertificateHandlerTest.* Bug: 958455 Test: CrSettingsCertificateManagerTest.All.MenuOptions_Edit, Change-Id: Idd81c4bb5b1375adc7a76f0c332d8372496ac7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718364 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:Matt Mueller <mattm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#682641}
-
Takuto Ikuta authored
All of 4 builders have less than 6 hour hourly resource usage in p99. http://shortn/_M8BzjMoQXa So I expect this won't add much burden to existing xenial pool. Bug: 954450 Change-Id: I0a6bae69557f8baa40e7abed1895025ded932dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728416Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#682640}
-
Anders Hartvoll Ruud authored
Instead of having an AdditiveKeyframeHook function which "patches" the InterpolationValue after it's created, this CL introduces the MakeAdditive function, which takes an InterpolationValue as input, and returns a new InterpolationValue with necessary flags set. This means we will need to copy the NonInterpolableValue in some cases, which *is* more expensive than poking the existing value. However, I think it's worth it if we can make NonInterpolableValues immutable (which will happen in a subsequent CL). Long term we might want to create the correct NonInterpolableValue in the first place, by passing the state we need to the converters. Bug: 981024 Change-Id: I897e176d38346a1c724e79dea028701bd33f922d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724510 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682639}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63b0b8018380..2c005b52e553 Created with: gclient setdep -r src-internal@2c005b52e553 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I3261d2248d4bb47b4d79143a7ff601ea8bc80bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728035Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682638}
-
Ioana Pandele authored
Users that don't have password sync enabled cannot use this link, so it shouldn't be displayed. Bug: 860248 Change-Id: I52d3311cb637867116443571a6346d6418c92ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720776 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#682637}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0b1b7f03bc17..88aae3b05111 git log 0b1b7f03bc17..88aae3b05111 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 perezju@chromium.org [Telemetry] Allow support of external results_processor 2019-07-31 dberris@chromium.org Add dberris@ to OWNERS Created with: gclient setdep -r src/third_party/catapult@88aae3b05111 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:981349 Change-Id: Iade5959d0f61461a0bbe276918a2fc77cec3465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728034Reviewed-by:
-
Carlos Caballero authored
It is currently just an alias to MessagePump::Type. This patch changes all references to use MessagePump::Type as MessageLoop will eventually disappear. This patch also changes some variable names from message_loop_type to message_pump_type. In particular one field of the GpuPreferences mojo struct. It is weird to see things like message_loop_type = MessagePump::Type::UI BUG=891670 Change-Id: I44680b19c83f009f7fbb0900f4d5b1140d51457f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726050Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
Before this CL, ResourceRequest for browser-initiated worker script loading (PlzDedicatedWorker and PlzSharedWorker) always doesn't set the |upgrade_if_insecure_| flag, and upgrade-insecure-requests handing completely doesn't work. To fix it, this CL plumbs the flag from outside FetchClientSettingsObject in a renderer process to the request created in the browser process. upgrade-insecure-requests handling works only when the browser-initiated request is redirected from a secure context to an insecure context. For non-redirect case where the request is directly sent to an insecure context from a secure context, upgrade-insecure-requests handling doesn't work because of https://crbug.com/917532 Note that this removes expectation files for virtual/omt-worker-fetch, but some tests are still suppressed by another expectation files for non-virtual. Bug: 906991, 917532, 987491 Change-Id: I690db42609133390fc6dc4aae150e0d94eab3199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715899 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Yi Su authored
Some public functions WebFramesManagerImpl are only used for unittests. These functions should be converted to private to improve encapsulation and unittests of WebFramesManagerImpl. Bug: 956516,956511 Change-Id: I9d5b85f9014ffe7cf60a77331cb308a27fb6b1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718408 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#682633}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I4e1d03b3d4a753c5d273a3607cecf1a84d12da08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700835Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#682632}
-
Hajime Hoshi authored
There was no consistent rule what type should be used for isolated world IDs. Let's use int32_t for consistency. This is a following-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1703052 Change-Id: Ida971bc36a1c63cd63e7e77b8d49a9bc9efe39e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708690Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682631}
-
arthursonzogni authored
Test filters were configured to do the exact opposite of what was intended. They were configured to run ONLY the failing test. Adding a '-' before each lines to get the correct behavior. Bug: 511340 Change-Id: Ib3998f2556ae72fe0608965863ac6d470121541f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726057 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682630}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f0162f6..0c98484b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ida335af519e6e003d012a8fb97a6212e00b08615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728509Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682629}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/67d90245bad4..5aab967f546e git log 67d90245bad4..5aab967f546e --date=short --no-merges --format='%ad %ae %s' 2019-07-31 yyanagisawa@chromium.org Choose the Goma client based on where it runs. Created with: gclient setdep -r src/third_party/chromite@5aab967f546e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I009dbae460cc288c40325f9026af4362356673a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728330Reviewed-by:
-
Anders Hartvoll Ruud authored
Instead of passing around scoped_refptr<NonInterpolableValue>&, pass around a virtual UnderlyingValue& which represents the underlying value. This should allow the internal APIs to cooperate better long term, since UnderlyingValue can have multiple implementations depending on what's required by the circumstance. If ::Composite now wants to modify the NonInterpolableValue, it must replace the entire value; it can no longer mutate the incoming scoped_refptr. This property will make it possible to store a scoped_refptr<const NonInterpolableValue> in InterpolationValue. A consequence of this is that ListInterpolationFunctions can no longer modify the underlying NonInterpolableList in-place. Hence NonInterpolableList::AutoBuilder is added to implement copy-on-write-like behavior for those lists. (Note that this in-place mutation of the underlying NonInterpolableList is the main reason why we can't just store a scoped_refptr<const NonInterpolableValue> in InterpolationValue in the first place ...) Bug: 981024 Change-Id: Iadc105beea9ea0006ce638011dd7b3168149449f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722967 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is phase 3.2.2 on the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ G=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I73798ce8683125b515fc02dceb53f2ccf38e46ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724559 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Kamila Śledź authored
SAML public account user type was merged into regular public account user type, which allows SAML public session pods to be shown on the login screen the same way as regular public session pods. Bug: 876287 Change-Id: Ib1e969b9b66efa5ae166aaec58fb94d2bb8c1a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710323 Commit-Queue: Kamila Śledź <kamilasledz@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682625}
-
Carlos Caballero authored
This is a reland of d2d3af26 Also we now call base::PostTaskAndroid::SignalNativeSchedulerShutdown() which on the Java side has the following comment "This is here to make C++ tests work" Probably a good idea to call it :) Also we no longer call ResetForTesting() but Shutdown instead. As this what happens in prod. Original change's description: > Fix flakly content_browsertests > > Looks like BrowserTaskExecutor is being deleted while the IO thread is > still running and thus capable of posting tasks. Also browser tests are > like prod, we shouldn't manually shut down pools and schedulers. > > Bug: 963702 > Change-Id: I1cb953acc4b495631fe269af9e06b94fbe5f2a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628748 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667097} Bug: 963702 Change-Id: I88f2b8d418eeb1a9a44f8f17bd5c1147993e8e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651725Reviewed-by:
-
Kinuko Yasuda authored
Bug: 934009 Change-Id: I338f7e288d1767bfe221f947bdf76e34b4250ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723400 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#682623}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2568b37b25f5..0b1b7f03bc17 git log 2568b37b25f5..0b1b7f03bc17 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 dberris@chromium.org Pinpoint: Update stats to account cancelled jobs Created with: gclient setdep -r src/third_party/catapult@0b1b7f03bc17 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:977488 Change-Id: Id89e1f29f3442486439888e66492ecabc16be131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728254Reviewed-by:
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=msisov@igalia.com Change-Id: Ifd0a66916d58f2357552fd469542650ef94a57b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715361 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#682621}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3667080a. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Icfd7a92021761ef3afe14e261db4d9f0701acf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728209Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a13c7744f154..6808e2d1faac git log a13c7744f154..6808e2d1faac --date=short --no-merges --format='%ad %ae %s' 2019-07-31 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cbabea734cbd..1ebe6014389e (9 commits) Created with: gclient setdep -r src/third_party/skia@6808e2d1faac The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Id1cca862b7d7b72381ddc05856fe8bfad721cff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728252Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e967dfdfc37..e529ecb5bb99 git log 8e967dfdfc37..e529ecb5bb99 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bb33f8cf..1443fbac (682476:682581) Created with: gclient setdep -r src/third_party/webrtc@e529ecb5bb99 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I74ae8b3c9e550e26060d0b168c43141b0cff9168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728253Reviewed-by:
-
Ramin Halavati authored
Omnibox.Search.OffTheRecord histogram metric is added that counts the number of searches from Omnibox on desktop, sliced based on being in regular mode or incognito/guest modes. Bug: 966747 Change-Id: Ifce9992a9bf4d5c4fa84d8668a24e0e024a8230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712673 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#682617}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d08611b7a8dc..351ea23830db git log d08611b7a8dc..351ea23830db --date=short --no-merges --format='%ad %ae %s' 2019-07-31 shaobo.yan@intel.com Dynamic Buffer Offset : D3D Backend Created with: gclient setdep -r src/third_party/dawn@351ea23830db The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I0a72bf73d004a724c069f3f5de11d5e2e34f4204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728250Reviewed-by:
-
Lei Zhang authored
https://pdfium.googlesource.com/pdfium.git/+log/7264bc930f9b..a9d33bd8b6ba Adjust caller to FPDFAnnot_GetFormFieldFlags() in PDFiumEngine to stop passing a useless parameter. Created with: roll-dep src/third_party/pdfium TBR=tsepez@chromium.org Change-Id: I4f360ccacffe51007fa93e59f913410352ddc53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728192Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa48b9720588..63b0b8018380 Created with: gclient setdep -r src-internal@63b0b8018380 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I5bc2f3506e7f587dd55db72be1ac0af114aca7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728249Reviewed-by:
-
Nigel Tao authored
This doesn't change how the code-under-test behaves. It simply adds more (programatically checked) information about what the test expects to happen. Change-Id: Icac601d5a98baf1a2646df78699e357ab23bd002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720229 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Eric Willigers authored
WebAppBrowserController::IsUrlInAppScope is now implemented. All of the web app badging tests are now run with and without BMO enabled. Bug: 966290 Change-Id: I28c2c0dd7bc50a96939e9008693964f0aa8c85e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728170Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#682612}
-
Takashi Toyoshima authored
This patch implements SafeBundledExchangesParser and BundledExchangesReader. SafeBundledExchangesParser manages remote BundledExchangesParser interface to communicate with data_decoder service in a reliable way. BundledExchangesReader uses this trusted parser implementation and provides functionalities to read BundledExchanges resource in the browser process. In this patch, BundledExchangesFactory uses the reader interface to obtain the initial redirect URL. Bug: 966753 Change-Id: I0a03237141bea9639a0cbeac4ae085a87fac6c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712792Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62077a99..3f0162f6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1109260a718f9a1b090bc4a9abae9b6db0af9bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726996Reviewed-by:
-
Yutaka Hirano authored
- "cross-origin-embedder-policy" set's the policy for frame. - dedicated worker's policy is set to the ancestor frame's policy. - nested frames with a conflicting policy is blocked. SharedWorker / ServiceWorker are not yet supported. All the implementation is behind the flag, and tested manually with work in progress WPTs[1]. 1: https://github.com/web-platform-tests/wpt/pull/17606 Bug: 887967 Change-Id: I70ed24841afde1b3c72dad40288744bb92a6f5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715378 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
