GitLab

Remove WebStorageQuotaType and replace users with StorageType in
WebKit/common. This is pre-work to change all users of StorageType to
use the mojo enum instead.

This patch also renames StorageType in StorageArea to
StorageArea::StorageType, to prevent name conflicts.

There is also a small change in DeprecatedStorageQuota.cpp which was
relying on a static cast to WebStorageQuotaType.

Bug: 781643
Change-Id: I8f8a4cafa1faf35a8d09dbcafd697af1ffe251d5
Reviewed-on: https://chromium-review.googlesource.com/828640
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526589}

This reverts commit e4d9e6a3.

Reason for revert: This CL causes an infinite loop for some users. https://bugs.chromium.org/p/chromium/issues/detail?id=798234#c9

Original change's description:
> Expire redirect parents when expiring any history visit.
> 
> This CL fixes an issue with history deletion where Visits that were
> the end of redirect chains were not deleting their redirect parents.
> In effect, removing a single history entry from chrome://history was
> not removing all Visits associated with it, causing similar URLs to
> continue to show up in the omnibox autocomplete.
> 
> Bug: 786878
> Change-Id: Id207dd7810629458d19a847d3ff52c0e562f2ce6
> Reviewed-on: https://chromium-review.googlesource.com/795527
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: calamity <calamity@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#525589}

TBR=calamity@chromium.org,brettw@chromium.org,sdefresne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 786878
Change-Id: I5b10eef437b09b8e61c8ca5d025e9b15e1226935
Reviewed-on: https://chromium-review.googlesource.com/848052Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526588}

When a cache hit occurs for a Resource that supports async cache hits,
Resource::AddClient schedules a task to process the cache hit on the
process-wide loading task runner, rather than a per-frame loading task runner.
This is because a Resource that is fully loaded has no context to determine
which frame it should attribute itself to. Having callers provide a WebTaskRunner*
to AddClient allows the caller to handle that attribution.

Bug: 624696
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic6d00e725cdd9141f83dcb5f8bcd34af3c5ac27d
Reviewed-on: https://chromium-review.googlesource.com/723879
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526587}

This reverts commit e442ea06.

Reason for revert: 
This CL caused major regressions in android webview performance.
See https://crbug.com/798310 

Original change's description:
> Reland "[PageLifecyle] Move the launch process state to Webkit/common"
> 
> This is a reland of 99a51fca
> 
> The failures described in crbug.com/796940 was result of throttling
> the scheduled tasks as a result of the new backgrounding state.
> 
> The fix foregrounds the RendererScheduler before running the tests
> to avoid throttling.
> 
> Original change's description:
> > [PageLifecyle] Move the launch process state to Webkit/common
> >
> > This CL introduces Webkit/common/page/launching_process_state.h that
> > includes the launch background and launch boosted state.
> >
> > The reason this file is needed, is because the state is different per
> > OS but needs to be consistent between the RenderProcessHostImpl and
> > the RendererSchedulerImpl. To prevent future changes in one not
> > reflecting in the other, the code is moved to a common place and
> > shared.
> >
> > This CL fixes an issue where the scheduler assumes that it is
> > foregrounded while it is actually backgrounded during the initial
> > phase on Android.
> >
> > Bug: chromium:780191
> > Change-Id: Ib8dbfb6447f58c8b998a94ae2c69f8bc906d150f
> > Reviewed-on: https://chromium-review.googlesource.com/815678
> > Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> > Reviewed-by: Alexander Timin <altimin@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Bo <boliu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#525563}
> 
> TBR=haraken@chromium.org,boliu@chromium.org
> 
> Bug: chromium:780191,chromium:796940
> Change-Id: I117afad3b910239656dbc7e9dc3a1447291263a9
> Reviewed-on: https://chromium-review.googlesource.com/840340
> Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
> Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#525841}

TBR=boliu@chromium.org,fmeawad@chromium.org,haraken@chromium.org,oysteine@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:780191, chromium:796940, chromium:798310
Change-Id: I0c8b7e075c29761d2a6f0d02461551b651682748
Reviewed-on: https://chromium-review.googlesource.com/847653Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526586}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bb5733a4..a9293af8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If4c3627cf3886111c5d0e2e7d5e059d4c50969bd
Reviewed-on: https://chromium-review.googlesource.com/847287Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526585}

A previous patch crrev.com/c/843490 introduced ShapeResult::GetCharacterRange()
to make usage of the static GetCharacterRange() function easier.

This patch applies the new function to simplify LayoutNG selection painting.

Bug: 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7ece0f54f169f33f0841bd8463acc4d388ace46e
Reviewed-on: https://chromium-review.googlesource.com/846101Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526584}

This CL fixes building with libstdc++ instead of libc++.

BUG=797448
R=sky

Change-Id: I631cbb68511ac76214e07806ace99539ffe49f17
Reviewed-on: https://chromium-review.googlesource.com/848154
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526583}

Bug: 760316
Change-Id: I2e1a5b06e1b3b5e2e1e3151ca2299172b789ffa5
Reviewed-on: https://chromium-review.googlesource.com/827941Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526582}

base::RefCountedBytes tracks its own size so the length parameter can be
replaced by asking the buffer for its length.

Change-Id: If54c6d3bae1fb535c64068f3c09dce782d9be917
Reviewed-on: https://chromium-review.googlesource.com/830655Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526581}

JavascriptInjector in https://crrev.com/c/828000 missed calling
|WebContents::SetUserData|, therefore the newly created instance
is leaked. This CL fixes it.

Bug: 798549
Change-Id: Ia9c95edcba363f5fc5b8aafaf97cec0ea3dd4759
Reviewed-on: https://chromium-review.googlesource.com/848112Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526580}

Bug: 767219
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I677343a47696ed1b4a70dd9c029f2b65fe5d9181
Reviewed-on: https://chromium-review.googlesource.com/843462
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526579}

This is an embedder feature, not the protocol one. As a side bonus,
this unblocks DevToolsAgent migration to blink.

Bug: 776009
Change-Id: I5c8f18ec0d8f07a556a7630f0d534fbb779d7fdf
Reviewed-on: https://chromium-review.googlesource.com/837509Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526578}

This is a re-land of https://codereview.chromium.org/13431004 which was
reverted nearly 5 yrs ago due to performance regressions at https://crbug.com/230147.

Changing an empty layer to 1x1 layer makes it artificially overlap with other layers
so in the test case here a squashing layer gets created when none is needed. This
creates an artificial need to resize the bogus squashing layer when its descendant
objects overflow changes.

It's worth trying again I think.

Bug: 787565
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iff7ca289eef8480f99d30a84c9be77ee2c9e2289
Reviewed-on: https://chromium-review.googlesource.com/842984Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Cr-Commit-Position: refs/heads/master@{#526577}

FrameSelection.h contains a declaration for an UpdateSelectionIfNeeded() method,
whose implementation has since been removed. This CL removes the unused
declaration.

Change-Id: Ic0410d804e7df32e7ed7d3df8371e1cb2a2672ed
Reviewed-on: https://chromium-review.googlesource.com/847698Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526576}

Adds a VR instrumentation test to ensure that clicks from the Daydream
controller are actually registered on the webpage.

Bug: 797299
Change-Id: I604918c57c403de81a8bd673420df912a7f0fa16
Reviewed-on: https://chromium-review.googlesource.com/843451Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526575}

https://webrtc.googlesource.com/src.git/+log/9185bde7ee18..94dc17710fd7

$ git log 9185bde7e..94dc17710 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If7e8ceeb04dad75f5e68e238a4fe8f07d7808bee
Reviewed-on: https://chromium-review.googlesource.com/847910Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526574}

No longer flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fapplication-panel%2Fresources-panel-websql.js

Speculatively, because of this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/792534

TBR=eostroukhov@chromium.org

Bug: 749251
Change-Id: I91e376ad73dae38fc8ae5e960f6eddbb85a1c84f
Reviewed-on: https://chromium-review.googlesource.com/848024Reviewed-by: Will Chen <chenwilliam@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526573}

This patch refactors StylePropertyMap.set to roughly double its speed:
1) Avoid creating CSSParserContext when possible.
2) Optimise for the common case of setting a non list-valued property.
3) Use CSSProperty as much as possible to avoid conversions between
   CSSPropertyID and CSSProperty.

Bug: 785132
Change-Id: Ic57615c8414c03871fb57085de92efbb75bd6413
Reviewed-on: https://chromium-review.googlesource.com/838160Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526572}

This reverts commit 13a1bab9.

Reason for revert:  Windows are shown after XFlush().

> This reverts commit f93b585a.
>
> Reason for revert: Windows don't get shown
>
> Original change's description:
> > Remove ui::X11EventSource::BlockUntilWindowMapped
> >
> > This CL removes BlockUntilWindowMapped() and the 2 references to it.
> >
> > The first reference, in X11WholeScreenMoveLoop, waits until an offscreen window
> > is mapped.  The window is override-redirect (so there's not WM that
> > asynchronously decides when to map the window), so any operations done on the
> > window should succeed after the window is mapped since the X server processes
> > events in sequence.
> >
> > The second reference is from X11WindowBase.  A similar removal was done in
> > DesktopWindowTreeHostX11 in [1], so BlockUntilWindowMapped() shouldn't be needed
> > here either.
> >
> > [1] https://chromium.googlesource.com/chromium/src/+/662c24fc6debb33ee34a927d21dc26154b8973d6
> >
> > R=​sadrul@chromium.org
> >
> > Change-Id: I251e67839dd5216f5164a103a82ad8a906811a03
> > Bug: None
> > Reviewed-on: https://chromium-review.googlesource.com/823212
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#525869}
>
> TBR=sadrul@chromium.org,thomasanderson@chromium.org
>
> Change-Id: I7bc83f409171941ce812ab09e0191b935127a38b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 797358
> Reviewed-on: https://chromium-review.googlesource.com/842685
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#526056}

R=sadrul@chromium.org
BUG=797358

Change-Id: I601defea876f5547b045e8584cb592366c36f4ac
Reviewed-on: https://chromium-review.googlesource.com/842474Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526571}

StatisticsRecorder is now an actual container of collections.

There is only one global recorder at any time, referenced by
StatisticsRecorder::top_.

Each StatisticsRecorder also has a pointer to the previous global recorder.

We now have a stack (singly linked list) of StatisticsRecorder objects, where
the top of the stack (StatisticsRecorder::top_) is the current global recorder.

This pattern is clearer and cleaner. It avoids a bunch of static variables,
indirections, unique_ptrs and calls to operator new. It gets rid of the ugly
hacks of UninitializeForTesting. It reduces memory fragmentation by having fewer
dynamically allocated objects.

Removed methods Reset, UninitializeForTesting and DumpHistogramsToVlog. They are
now unnecessary.

Reviewed, clarified and documented the thread safety status of each method.

Added comments.


Change-Id: Ia1a7611905009d0449068c801464ad0df7813c0d
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/830997
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526570}

CL https://codereview.chromium.org/1872663002 used level_size as a
std::vector<int32_t> initially, but after a few rounds of review was
rewritten to only use it as a int32_t temporary variable. Drop the
std::vector use, and move it closer to the single remaining use.

Change-Id: I53dabcf823514374676a7f1dc95c32e3b761a594
Reviewed-on: https://chromium-review.googlesource.com/847965Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526569}

Bug: 789895
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If3b116a3ea86bd4c1f27ea97f3704a9fd3f00e64
Reviewed-on: https://chromium-review.googlesource.com/846286Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526568}

TBR=dgozman@chromium.org

Bug: chromium:712937
Change-Id: I33ec4f3e9fa0ded7288a4f84d41963c4577da24d
Reviewed-on: https://chromium-review.googlesource.com/848316Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526567}

https://skia.googlesource.com/skia.git/+log/8716b50aae94..e8bb6da08dc6

$ git log 8716b50aa..e8bb6da08 --date=short --no-merges --format='%ad %ae %s'
2018-01-02 fmalita [skotty] Fix native path lerp
2018-01-02 reed fix skipT to use sizeof T
2018-01-02 fmalita [skotty] Native SkPath interpolation
2018-01-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ c33f1e8c3..c8c9a24a1 (1 commit)
2018-01-02 fmalita [skotty] Clip/scale/center animations in Viewer
2018-01-02 bsalomon Avoid initializing SkStrokeRect twice in GrStyle copy constructor.
2018-01-02 liyuqian Document the 2pt conical gradient
2018-01-02 liyuqian Do `gclient sync` before compile
2018-01-02 reed use tool_utils to encapsulate checking for recording canvas and makeSurface
2018-01-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d078c6812..c33f1e8c3 (1 commit)
2018-01-02 rmistry Housekeeper-PerCommit-Bookmaker bot to verify that docs match includes
2018-01-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ ffa2cd04b..d078c6812 (1 commit)
2018-01-02 liyuqian Changes to make 2pt gradient source code better aligned with our future doc
2018-01-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 8c3988c59..ffa2cd04b (6 commits)
2018-01-02 borenet Skip AUTHORS check for Skia service accounts
2018-01-02 fmalita [skotty] Improved shape & layer paint order
2018-01-02 reed simplify/cleanup readbuffer impl
2018-01-02 caryclark update image doc and minor bookmaker fixes
2018-01-02 liyuqian Stronger fix for swapping r0, r1 in 2pt conical gradients
2018-01-02 fmalita [skotty,sksg] Initial RRect support
2018-01-02 reed share impl between makeNonTexture and makeRaster

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: Ia4cbba714b401a62a575d6438ff388b339f4fab0
Reviewed-on: https://chromium-review.googlesource.com/847899Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526566}

Update test expectations for virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-recalculate-styles.js

Bug: 798592
Change-Id: I9cfcf529b495a0c0d8a70ef4cdf40b6536c13540
TBR: jwd@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/848027
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526565}

Remove unused method signatures
Fix a comment

Change-Id: Idf191b76b3e2c2495a7ff3e31d16629c086d87e2
Reviewed-on: https://chromium-review.googlesource.com/847971Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526564}

Use this builder as a canary for the new Xcode / CIPD flow.

BUG=797051
TBR=justincohen@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I59173d9c8ca5ee37fff86cf7795600d84661be9a
Reviewed-on: https://chromium-review.googlesource.com/848294
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526563}

Rebaselined the test, once it lands, we can re-evaluate whether it's actually
flaky.

Bug: 747751
Change-Id: I5a447ed7b8cab1e586f96aec29b3ceb690019f85
Reviewed-on: https://chromium-review.googlesource.com/847895Reviewed-by: Eugene Ostroukhov <eostroukhov@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526562}

A late arriving CompositorFrame should not activate if the dependent CF has
been dropped. This can happen if a CompositorFrame is marked for destruction
and then pulled out of the destruction queue ("surface resurrection").

This CL ensures that when a surface is reset, a SurfaceDiscarded notification
is sent to the SurfaceDependencyTracker followed by SurfaceCreated to mimic
creating a new surface.

Bug: 796602
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I226b23bedbb1855c0da8fada8341c09a2f4fd318
Reviewed-on: https://chromium-review.googlesource.com/847427
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526561}

I previously removed this test from SmokeTests (used to run a subset
of tests on Android) in https://chromium-review.googlesource.com/688512.

Bug: none
Change-Id: I0658ee2e451d84a8f455979ca4ed7ab7aab68a22
Reviewed-on: https://chromium-review.googlesource.com/848021Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526560}

This reverts commit e71979ba.

Reason for revert: mstensho@ reports that this flag is actually still useful and we still want to keep it.

Original change's description:
> Remove --fully-parallel from tests.
> 
> Bug: 692866
> Change-Id: I0530db53a88da0eaf8c813f41047832ed6bbbc0d
> Reviewed-on: https://chromium-review.googlesource.com/741106
> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#525379}

TBR=qyearsley@chromium.org,mjkim610@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 692866
Change-Id: I1d694c1ef7437f784aa2cb2de47850fd68b4d3ab
Reviewed-on: https://chromium-review.googlesource.com/847872Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526559}

Bug: 765378
Change-Id: I20e8e2fac148cfde6114ebf6a7af2a33d056b356
Reviewed-on: https://chromium-review.googlesource.com/846019Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526558}

Bug: 798563
Change-Id: Ie668c5e91689dd7c9128670257176bb3f0b5c378
TBR: tommi@chromium.org,sergeyu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/847962Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526557}

These tests used DeviceDataManager directly, which doesn't work for
mus. The fix is to use InputDeviceClientTestApi. PreferTouchAsPrimary
required an additional call because unit tests don't really bring up
mus.

BUG=776514
TEST=test only changes

Change-Id: Ica853e72d97bada225004bda7d30b507cef4cab0
Reviewed-on: https://chromium-review.googlesource.com/847688
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526556}

This CL does the cases that return
- ZoomAdjustedPixelValue
- ZoomAdjustedPixelValueForLength
- CSSIdentifierValue::Create
- nullprt

Bug: 775360
Change-Id: I92c1f2d8f302ebab37fb17ef54a152f154dceb9b
Reviewed-on: https://chromium-review.googlesource.com/822017Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526555}

If the descendants of an opportunity tree node have exclusions they will
get lost when combining the node's current exclusions, so avoid doing that.

Bug: 798436
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I90cde607c99fcfc808c1dafc531445bc25774cca
Reviewed-on: https://chromium-review.googlesource.com/847595Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526554}

Native error view is triggered when a pending item can't be loaded due
to network error. It is handled by commiting the pending item and
activating the native controller. With WKBasedNavigationManager, the
commit step needs a WKBackForwardListItem in order to commit the pending
item. Injecting a placeholder URL into WKWebView fixes this problem.

Because any URL can trigger a native error view, I also removed the
assertions checking that the URL encoded in a placeholder URL is always
an app-specific URL.

This fixes the following egtest failures:
TabUsageRecorderTest/testOpenFromApp
NavigationTestCase/testHistoryForwardToErrorPage
NavigationTestCase/testHistoryBackNavigation
NavigationTestCase/testWindowLocationReplaceAndChangeHash

Bug: 784951
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie4f61087301774340981ba3661740b1f4e103a1e
Reviewed-on: https://chromium-review.googlesource.com/847907Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526553}

Adding SDK update script to support:
1) downloading new version of SDK package(s) from sdkmanager
2) uploading a package instance and upload to CIPD. At the meanwhile
update the package version in gn file to match what the uploading
package about.


Bug: 659808
Change-Id: I9b5f7c2a544ce8e799c0b1072d3c5462f59e2d21
Reviewed-on: https://chromium-review.googlesource.com/778083
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526552}

On low end android, MaxDecodedImageBytes() might return a value that
is smaller than the size we request. The reason we request a larger
size is that only some of the codecs support decoding to a smaller size,
and for things like PNGs we would still be requesting an intrinsic size
even though the max bytes is smaller than that. This trips up a DCHECK.

The fix, as suggested by the bug reporter, is to take the minimum of
desired bytes and max bytes.

R=chrishtr@chromium.org

Bug: 798110
Change-Id: I092541359164f4e08af68bf0e7939f2a9f8c8237
Reviewed-on: https://chromium-review.googlesource.com/847632Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526551}

Just have legacy layout call the code in ng/.

There were two identical definitions of FragmentainerBreakPrecedence(), which
may cause trouble for Jumbo builds at some point.

Also remove (static) LayoutBox::JoinFragmentainerBreakValues(), since NG
already provides an identical function (with the same name).

Change-Id: I1af407aa1fbde8411176ce23e8a99742f60f4fca
Reviewed-on: https://chromium-review.googlesource.com/846996Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526550}