- 23 Sep, 2018 3 commits
-
-
Andrew Grieve authored
This happens for: com.google.android.play.core.splitcompat.c TBR=wnwen # Fixing official bots Bug: 887876 Change-Id: I37ce1fbc6f282228a33311136980aba509ad1eb8 Reviewed-on: https://chromium-review.googlesource.com/1240015Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#593453}
-
Robert Sesek authored
The feature still exists beacuse tests toggle it, but this removes it from the flags UI. Bug: 832676 Change-Id: I6971276883e19792f962f9e17d4fa50e8265a1d0 Reviewed-on: https://chromium-review.googlesource.com/1239766Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593452}
-
Robert Sesek authored
Bug: 832676 Change-Id: I631e54fef31ed42828aabbe674cb67c1e2165763 Reviewed-on: https://chromium-review.googlesource.com/1239764Reviewed-by:
-
- 22 Sep, 2018 37 commits
-
-
Nico Weber authored
Like the uitest change in https://chromium-review.googlesource.com/c/chromium/src/+/1237454 For some reason the CQ didn't catch this issue. TBR=rsesek Bug: 832676 Change-Id: Ie58e701f0f7d231432c1636366545ee211c5e712 Reviewed-on: https://chromium-review.googlesource.com/1239761Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593450}
-
Emircan Uysaler authored
Bug: 326740 Change-Id: I6cbb658b6fed6bdc7bf48700f60d17a02176f65a Reviewed-on: https://chromium-review.googlesource.com/1239513 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#593449}
-
Nico Weber authored
(NOPRESUBMIT because crbug.com/875886) NOPRESUBMIT=true TBR=blundell Bug: 832676 Change-Id: I94367d0813b7721c6bee355343f17b0f19073a74 Reviewed-on: https://chromium-review.googlesource.com/1239021 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
David Bokan authored
Change-Id: I35e9c2a9998d9c648c5eef4d29ad19ab24398e84 Reviewed-on: https://chromium-review.googlesource.com/1239719Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#593447}
-
Ryan Sleevi authored
In line with docs/code_reviews.md, remove the "emeritus" reviewers. Bug: none Change-Id: Iea5d729f112faa2648ca207ca912890c271612de Reviewed-on: https://chromium-review.googlesource.com/1238787Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593446}
-
Nico Weber authored
Unused now that the cocoa find_bar code is deleted. Bug: 832676 Change-Id: I9a29167cde164656f6e51182e50ba300fd93419d Reviewed-on: https://chromium-review.googlesource.com/1239633Reviewed-by:
-
Leszek Swirski authored
Currently, the small script streaming disabled heuristic is disabled for the scheduled script streaming flag. Remove this for now, so that we can test the scheduling perf impact independently from heuristic changes. Bug: chromium:865098 Bug: chromium:866868 Change-Id: Ib3974ebe6d28dadb8421e75fd13801e0d916de24 Reviewed-on: https://chromium-review.googlesource.com/1238435Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#593444}
-
Thomas Tangl authored
When the account image is updated in the background, settings is now notified to make changes accordingly. Bug: 882384 Change-Id: I05000533de1205fc5b9d9a9500b4c05f088e8923 Reviewed-on: https://chromium-review.googlesource.com/1238501Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#593443}
-
David Tseng authored
At runtime, the actual list of available attributes on an AutomationNode can be found at: chrome/renderer/resources/extensions/automation/automation_node.js 'scrollable' was previously missing from automation.idl. Its inclusion in the idl correctly matches what is available at runtime and makes it included in externs. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1b78d883cd256d8bbe48272baec5f8fa8ff88423 Reviewed-on: https://chromium-review.googlesource.com/1238821 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593442}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/738aa56a10f9..fe48d54568d2 Created with: gclient setdep -r src-internal@fe48d54568d2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I915347fc46e4c24779b4e2ba852c20ea36ac43b7 Reviewed-on: https://chromium-review.googlesource.com/1239893Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593441}
-
Ned Nguyen authored
This reverts commit c2747b15. Reason for revert: breaking many loading perf tests BUG:888222 Original change's description: > Perfetto: Fix trace buffer memory size > > Some unnoticed debug sizing caused the host-side tracing buffer > to be a bit larger than necessary. > > R=ssid@chromium.org > > Bug: 886685 > Change-Id: I56f3ed15952d7f0d6382b6e939c5386169f672b8 > Reviewed-on: https://chromium-review.googlesource.com/1236663 > Reviewed-by: Siddhartha S <ssid@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593257} TBR=oysteine@chromium.org,ssid@chromium.org Change-Id: I6a19cad20042d06bc6ac8406cb1f8ac9d3fa79ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 886685 Reviewed-on: https://chromium-review.googlesource.com/1239077Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de8b7f52c072..738aa56a10f9 Created with: gclient setdep -r src-internal@738aa56a10f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie370693d9e1f4689c7b9892c54d4debc5ffb5ba8 Reviewed-on: https://chromium-review.googlesource.com/1238991Reviewed-by:
-
Fredrik Söderquist authored
This changes the _interface_ to these properties in ComputedStyle (and SVGComputedStyle) to use StyleColor - storage is changed to a <Color, bool> (separated) pair. Usage is updated accordingly. This is needed in order to support "better" tainting on 'feFlood' and other filter primitive elements to which these properties apply. The actual tainting functions will be updated in a follow-up CL. Bug: 792518 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I705ee38219615c4c691e4a5fbc73799a72b604da Reviewed-on: https://chromium-review.googlesource.com/797271 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#593438}
-
Fredrik Söderquist authored
This reverts commit 1f654b07. Reason for revert: This test was reverted by https://chromium-review.googlesource.com/c/chromium/src/+/1239773 causing presubmits to fail. Original change's description: > [Sherrif] Disable worklet-animation-responsive-to-zoom.html > > It wasn't included in TestExpectations by > > https://chromium-review.googlesource.com/c/chromium/src/+/1237235 > > but it looks like it failed all the same. > > NOTRY=true > TBR=majidvp@chromium.org > > Bug: 887659 > Change-Id: Iabb8204a4b4b05515838cf20378e61d07062ea51 > Reviewed-on: https://chromium-review.googlesource.com/1239446 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593345} TBR=majidvp@chromium.org,liberato@chromium.org Change-Id: I6bb03b3d8d78f3c7c66132656f00f32ee36e9a21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887659 Reviewed-on: https://chromium-review.googlesource.com/1238916Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#593437}
-
Simon Zünd authored
R=mmenke@chromium.org Bug: v8:7283, v8:8015 Change-Id: I8f97518eba7a6cc07c91ae4c7763d24b907a6120 Reviewed-on: https://chromium-review.googlesource.com/1238533Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#593436}
-
Simon Zünd authored
Bug: v8:7283, v8:8015 Change-Id: I21d6e81d273fb6f321788a6f3e7122d7d63dbf28 Reviewed-on: https://chromium-review.googlesource.com/1238434Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#593435}
-
Lei Zhang authored
Make PDFiumPrint::PrintPagesAsRasterPdf() and PrintPagesAsPdf() consistent. Now they both call CreatePrintPdf() to generate a PDF for printing. The only difference is PrintPagesAsPdf() does an extra rasterization step. BUG=887825 Change-Id: I1f02f6acfa5833d33bf999933fa681c10b67ccf9 Reviewed-on: https://chromium-review.googlesource.com/1238077 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593434}
-
Lei Zhang authored
Split most of the code in PDFiumPrint::PrintPagesAsPdf() into a separate method. CreatePrintPdf() will be reused in an upcoming CL. BUG=887825 Change-Id: I0e6fee3a6908cee038a45e5a7f62182559f33df4 Reviewed-on: https://chromium-review.googlesource.com/1238076 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Lei Zhang authored
Reorganize: - Move NupPdfToPdf() into the anonymous namespace. - Make NupPdfToPdf() return a PDF instead of the PDF data. - Return earlier in PrintPagesAsRasterPDF(). - Make CreateSinglePageRasterPdf() return a ScopedFPDFDocument. - Put |scale_factor| in the smallest possible scope. - Group static methods together in the header. - Use "Pdf" consistently in method names. - Mark some methods const. Nits: Change-Id: I25ac995d2041990eab42391915a6736044ad6b63 Reviewed-on: https://chromium-review.googlesource.com/1238075 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Ella Ge authored
remove expectations for rebaseline Bug: 737777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If1ba264a039086ca91a4872519e5f34e1fae9591 Reviewed-on: https://chromium-review.googlesource.com/1234996Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#593431}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc4ede78306c..de8b7f52c072 Created with: gclient setdep -r src-internal@de8b7f52c072 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia51e7b833c254edc7e4ca5150e2b0097805ed765 Reviewed-on: https://chromium-review.googlesource.com/1239739Reviewed-by:
-
Tao Bai authored
To understand the usage of autocomplete, add metrics for - if the autocomplete is disabled in WebView by application. - if the query is triggered for the field. - if the suggestion exists for the query. Bug: 873795 Change-Id: If58836c02a78a3fe85b5d264f29417d9a7509969 Reviewed-on: https://chromium-review.googlesource.com/1187824Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#593429}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/799da6d18c5a..55e57f96fbf8 git log 799da6d18c5a..55e57f96fbf8 --date=short --no-merges --format='%ad %ae %s' 2018-09-22 jmadill@chromium.org Remove some redundant dirty bits notifications. 2018-09-21 bryan.bernhart@intel.com ES31: Support atomic functions on D3D11 - Part III Created with: gclient setdep -r src/third_party/angle@55e57f96fbf8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ifbb4d1e192b68d3761a69e7cf6632ca04eda7570 Reviewed-on: https://chromium-review.googlesource.com/1239735Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593428}
-
Ella Ge authored
missed Pixel_WebGLTransparentGreenTriangle_NoAlpha_ImplicitClear when rebaselining pixel tests for zoom-for-dsf TBR=kbr@chromium.org Change-Id: I439e2e3d389735e2add7a993a4b5a67df517c1a1 Reviewed-on: https://chromium-review.googlesource.com/1239476Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#593427}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/575af7ecfc21..90a12b3d4d1d git log 575af7ecfc21..90a12b3d4d1d --date=short --no-merges --format='%ad %ae %s' 2018-09-22 alanbaker@google.com Decoration validation for Vulkan memory model 2018-09-22 alanbaker@google.com Validate vulkan mem model capabilty Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@90a12b3d4d1d The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ida46ddd3a867db7a96ad07046f0a9937f34ecca1 Reviewed-on: https://chromium-review.googlesource.com/1238990Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0dc1fa046374..baf09271514c git log 0dc1fa046374..baf09271514c --date=short --no-merges --format='%ad %ae %s' 2018-09-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@baf09271514c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I21a9cc3df3f0b41b8ca7939e203dd6661fef7ac5 Reviewed-on: https://chromium-review.googlesource.com/1239655Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8994403e..2f22d111 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33f96a3637ec00461294c67acb3a34a06ef7c3bb Reviewed-on: https://chromium-review.googlesource.com/1239723Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80aef02c3e0f..dc4ede78306c Created with: gclient setdep -r src-internal@dc4ede78306c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:888064 TBR=mmoss@chromium.org Change-Id: I90a010aa42ca43fcd267d8ba6aa516e18f2a66da Reviewed-on: https://chromium-review.googlesource.com/1239738Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I5dbd53b4addb170c9971034bb125363e0be6e678 Reviewed-on: https://chromium-review.googlesource.com/1239754Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#593422}
-
Peter Kotwicz authored
This CL: - Makes code in MainActivity.java more modular. - Splits HostBrowserLauncher into: - a part for selecting the host browser - a part for launching the host browser This CL is in preparation for: - Introducing a version of MainActivity.java for NewSplashWebApk.apk - Implementing the logic to determine whether to show the splash screen inside of the WebAPK or inside of Chrome. The host browser must be known in order to make this decision. BUG=817263 Change-Id: I024e390c57b4da09fe0e4e2fcbaf616c6bad2e8b Reviewed-on: https://chromium-review.googlesource.com/1220054 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593421}
-
David Tseng authored
The Chrome channel was once used by ChromeVox to disable ChromeVox Classic (use ChromeVox Next) when in dev channel. Since ChromeVox/ChromeVox Next now ships by default everywhere, this is no longer necessary. Original change https://codereview.chromium.org/2640503002 TBR=dcheng@chromium.org Change-Id: I0b9b4f844ec5d3b40171027da5e04e0fb248eb49 Reviewed-on: https://chromium-review.googlesource.com/1239439Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Matt Menke authored
The only previous way to get it was to disable cert verification. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic14d5273a803cb53e92bbc370a16f045c86bdcca Reviewed-on: https://chromium-review.googlesource.com/1235173 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#593419}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/32261ee689fe..218f46686f2f git log 32261ee689fe..218f46686f2f --date=short --no-merges --format='%ad %ae %s' 2018-09-21 benjhayden@chromium.org Fix a bug in v2spa's setImmutable() Created with: gclient setdep -r src/third_party/catapult@218f46686f2f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia6435354eb716e7ec8d26a3324c9f77d6b33cd87 Reviewed-on: https://chromium-review.googlesource.com/1238872Reviewed-by:
-
Yuki Shiino authored
Crash issue 887661 is happening because an iframe is detached, but the iframe is still invoking FrameRequestCallback without performing wrapper-tracing. In the repro case, callback function's realm = the parent's one, and the incumbent realm = the parent's one, however, the callback is registered on the iframe that will be detached. Thus, any check against callback function's realm and the incumbent realm does not work well in this case. This patch fixes the crash issue by checking the execution context on the call sites. Bug: 887661 Change-Id: I1fa784add95424c9ff2c2b27ed3d2edbb920068e Reviewed-on: https://chromium-review.googlesource.com/1237839Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#593417}
-
Peter Kotwicz authored
This CL changes the manifest_processor GN build rule to treat 'false' as a boolean value instead of as a string literal. This change is needed for the manifest_processor build rule to omit the 'section_name' section for the following input: BUILD.gn: manifest_processor_template(_manifest_target_name) { ... extra_variables = [ "section_name=false" ] } AndroidManifest.xml: {{#section_name}} Never shown! {{/section_name}} BUG=1220054 Change-Id: I9bf0740e0cfb8115788ec3bf8d6d0640d2c495c7 Reviewed-on: https://chromium-review.googlesource.com/1238354 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593416}
-
Matt Menke authored
Previously it would just fail. Also fix a bug in the ERR_NOT_IMPLEMENTED failure when trying to upgrade accepted client sockets to TLS. Add tests for both cases. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia908a7da077a14c69ae990afe19339dfa440b9a5 Reviewed-on: https://chromium-review.googlesource.com/1234226 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Matt Menke authored
This reverts commit dec72e86. Reason for revert: virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html seems to be failing most of the time on all platforms. Sample failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/91172 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/146546 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/193114 Original change's description: > [animation-worklet] Transfrom related worklet animations should respond to zoom > > Worklet animation compositing state should be updated when a zoom or viewport > resize changes css pixel to dip ratio. > > The fix is to simply match what we already do for regular animations for worklet > animations. > > TEST=virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html > > Bug: 879107 > Change-Id: I0b74bd8297e83b18afd087247f09339aedcc618b > Reviewed-on: https://chromium-review.googlesource.com/1237133 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593171} TBR=majidvp@chromium.org,smcgruer@chromium.org Change-Id: I9eaf621c931ad9003fd7413aeea9f2ec3a7824a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879107 Reviewed-on: https://chromium-review.googlesource.com/1239773Reviewed-by:
-
