- 22 Jan, 2021 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/49fd77f3..fbab010f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic89f7c3bb413d25c2a72a2fcdf978be3e394da9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644560Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846091}
-
Christian Dullweber authored
This reverts commit 8e10fb2a. Reason for revert: Reenable the test to check if failure still exists Original change's description: > [sheriff] Disable SiteDataCountingHelperTest.SameHostDifferentScheme > > TBR=eirage@chromium.org > NOTRY=true > > Bug: 1168198 > Change-Id: I3196ad66bace95157d110f840babd269d394df32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637963 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844891} TBR=xidachen@chromium.org,eirage@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1168198 Change-Id: I67f5a97d8e82513e13025c37639ea3fdeede022b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642630Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#846090}
-
Yunke Zhou authored
Bug: 1157195 Change-Id: Ic4daf299819b3854a7aef924268c8e698271de69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643380 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846089}
-
Omer Katz authored
Initializing a bucket is non-atomic because the hash table is not yet visible to the GC during initialization. When trying to recycle a deleted bucket, the bucket is reinitialized. This introduces data races with concurrent marking. To resolve the data races, we should initialize atomically. For hash table where the empty value is zero, we can atomically memset the bucket to zero. For other cases, atomically initializing is more complicated. Instead, in such cases, we prohibit reusing deleted bucket while marking is in progress. Bug: 1166985 Change-Id: I42d03371388e7cd702d2aec6c5bdfd02e2a38d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643716 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#846088}
-
Aaron Leventhal authored
When an AXInlineTextBox::NextOnLine()/PrevOnLine() is used, the parent of any newly created AXInlineTextBox is not necessarily going to be the same one. Compute the correct parent in all cases. Addresses DCHECKs that are triggered in text-overflow:ellipsis cases. Bug: 1168643 Change-Id: Ib41bc4617bee4761ccad35ad94ab33fb8be4ab43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639167Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846087}
-
Jérôme Lebel authored
Adds signout confirmation dialog for Mice based on this design: https://docs.google.com/presentation/d/1mfVdeJXk2hLXjyzOp9TBIx0E7-7jmuoN1-4oB6dYd5I/edit#slide=id.gaea85d524f_2_0 iPad: https://drive.google.com/file/d/1UAS0L-ANTaIDEN2FFh2mgAiwKe-ksQ5U https://drive.google.com/file/d/1kQJoi6Vqe-xEsbLokmePAlAWU5kNl99T https://drive.google.com/file/d/1DUou8tJ1UR54lQtI2Zzi5smJ3aoUbyXX iPhone: https://drive.google.com/file/d/13TPquf7Z8HbdkCDmQhXnyqwP0VQGxwTp https://drive.google.com/file/d/1UjLwwkEk4RKnkDfX-7BSLmfqo6Lj1Ewd https://drive.google.com/file/d/1aykwVlgT3npD3DQkMCPWJm3hYiMeJfLx Bug: 1166148 Change-Id: Ica58a513ee216d79f4994d155a4941ea5fdbe3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627401 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846086}
-
Renato Silva authored
The login screen in ChromeOS currently only performs one authentication attempt. Either against the user's PIN or password depending on a flag passed by the UI. When the combined 'PIN or password' input field is used, any input consisting of only digits is treated as a PIN. If the user's password is composed of only digits (The minimum is 8 digits.), trying to use the password on the login screen fails. This issue does not exist on the lock screen, where two authentication attempts are made when the input is composed of only digits. It first tries to authenticate against the PIN, and, in case of failure, it tries again against the password. Since the introduction of PIN 'automatic unlock' / 'auto submit', the default UI has been separated into dedicated PIN and password fields with a button to toggle between both. This CL fixes an issue that caused the input from the dedicated password field to be treated as a PIN instead of a password. It also improves tests on LoginAuthUserView. Note that the issue still exists for the combined 'PIN or password' field and it should be addressed in the near future. Bug: 1122939 Change-Id: I719c441d023e9b2c37b901d101e4939732061a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512916Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
-
Ben Mason authored
Change-Id: I392b7783b1252cf4844f11fa301df6b8f7b74856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643545 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846084}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ad73a7a4eb1f..0e20ed5f01b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC snijhara@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: snijhara@google.com Change-Id: I8b4e17bb1169489eac3eee16e5877dc49cc19dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644702Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846083}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 89d93205. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I735ebb34f47c5c5ec8bdd174523d778f24db4f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643544Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846082}
-
Richard Townsend authored
* HTMLDocumentParser::Finish no longer blocks (parsing continues asynchronously) * Now yields for parser-blocking scripts in the Document body. Both of these measures should improve TTFCP. Bug: 901056 Change-Id: Ib0aae3f4f07d047c7e83ca29ae3ad17608c2821c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622116 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#846081}
-
Clemens Arbesser authored
Bug: b/178098376 Change-Id: I10c80db6d54dc10c6b49d2ca48996c2271ef3d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642626Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#846080}
-
Sreeja Kamishetty authored
Currently, WebContentsObserver::RenderFrameHostChanged callback is being dispatched before WebContentsObserver::RenderFrameCreated callback for child frames. This is problematic as embedders use WebContentsObserver::RenderFrameCreated callback to initialize per-RenderFrameHost state. This CL fixes this ordering. BUG=1097143 Change-Id: Iced632ee3369b3dbf3822dd57620b687ed47cb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614467 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#846079}
-
Viktor Semeniuk authored
This change accepts remote changes when passwords are identical but compromised credentials are different during sync merge. Bug: 1169171 Change-Id: I3efb237d4c2c208ea1c97792e4332dead3620cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642357 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#846078}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6e28b60dec0..dbb39ce0d2ed 2021-01-22 jacktfranklin@chromium.org Avoid rendering hidden DOM in data-grid and batch scrolls 2021-01-22 pfaffe@chromium.org Rename and document EvalNodes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1169021 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib9e87d831228469ef2b684ff2825abc55d106856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846077}
-
Sergei Glazunov authored
It's common for C++ code to have pointers right past the end of an allocation, i.e. of the form |allocation_start + allocation_size|. When |PartitionAllocGetSlotStart| receives such a pointer and the size of the allocation equals the size of its bucket, the function returns the address of the next slot (or even the area outside the slot span). Subsequent |PartitionRefCount| operations may then modify the reference count of an unrelated object or corrupt the slot's free list pointer (if it is in the "freed" state). Instead of adding more fields to the CheckedPtr ignore list, we modify |PartitionAllocGetSlotStart| to support past-the-end pointers. In addition, remove the workaround for a bug that has been caused by the past-the-end pointer in |base::BigEndianWriter::ptr_|. Bug: 1073933, 1164636 Change-Id: Ia582680d9d6c83357f45123416a86a52661fa71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636354 Commit-Queue: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Aaron Tagliaboschi authored
Bring tokens inline with Section 3.1 of the Client Hints spec, which recommends tokens be the same as the header name they're associated with. Also fixing the *copious* tests associated with this change... Intent to Remove: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/t-S9nnos9qU Bug: 1153688 Change-Id: I2bfe038abe887713d56ef835e8f9d61246001040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595089Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#846075}
-
Carlos Caballero authored
Removed GetFrameTree method from Render{View|Widget}HostDelegate and made FrameTree* a member of Render{View|Widget}HostImpl instead This will make delegate implementations easier once we have multiple FrameTrees per WebContents. Bug: 1164280 Change-Id: Ie0adb40eb60e696ab018194d1fe9b71650814c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623291Reviewed-by: -
Victor Hugo Vianna Silva authored
The functionality of this class is specific to errors: notifying the user about them and providing a way to resolve them. This is now properly reflected in the name of the class. The name is also picked so as to match its ChromeOS counterpart in sync_error_notifier_ash.h. Bug: None Change-Id: I5fef45fa33df8d92a53e327f1c61d38a07fb54ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642333 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#846073}
-
Mihai Sardarescu authored
This CL changes the DICE account reconcilor to use the Gaia OAuthmultilogin endpoint by default. Bug: 1122988 Change-Id: Ib120979037d850f3100b618721cf51755f6f2376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640380Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#846072}
-
Adrienne Walker authored
This patch adds a CacheStorageControl remote to StoragePartitionImpl. BackgroundFetch and CodeCacheHost now use mojo instead of direct access to CacheStorageContextImpl. Followups to this patch will be to convert other CacheStorageContext users in StoragePartition to use the mojo interface and eventually remove the GetCacheStorageContext accessor. Bug: 1147642 Change-Id: I5c286be77c41bc189084a6a4d89f3f2c06b50fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628049 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#846071}
-
Sylvain Defresne authored
Requiring the BrowserState's path to be passed as a NSString* forces all callers to convert the base::FilePath to NSString* making the API harder to use (as the conversion is non trivial). Instead change the API of both classes to use base::FilePath directly and to do the conversion internally where it can be centralized in a few location makes the API easier to use. Bug: 1165798 Change-Id: Ida8294210f83875fcbeffa88a3e7f5ae78a2316f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635668 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846070}
-
Sreeja Kamishetty authored
This CL disables BackForwardCache for WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored test which assumes no interaction with the back-forward cache by performing a commit on a stored BFCached entry directly. Bug: 1163106 Change-Id: Id21e363950e71db70e7db302b57b8e02958ebb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633441 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
The API comment for PermissionPrompt::Delegate::Requests forbids clients from storing the pointers to PermissionRequest objects, which is violated by PermissionPromptBubbleView::visible_requests_. This patch removes that field and recalculates the visible requests in the two places it's required. This also happens to be convenient for further refactoring plans. Bug: 1110905 Change-Id: I018b7d9fc00445b05268db9e005377a64bfe138e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577497 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#846068}
-
Sylvain Defresne authored
Using global static non-POD object is against the style guide when they have a destructor (which std::string does) as the destructors are called in an order that is not controllable and they can cause issue during shutdown. Bug: none Change-Id: I8967d86d029004bc66912ae6b28f2be59633dd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640535 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#846067}
-
arthursonzogni authored
This patch does not introduce any functional changes. [Previous patch]: https://chromium-review.googlesource.com/c/chromium/src/+/2631271 [Next patch]: https://chromium-review.googlesource.com/c/chromium/src/+/2450093 For OutOfBlinkSandbox, I am going to provide sandbox flags in WebNavigationParams. Filling this object correctly is key. It holds many security properties: DocumentPolicy, FeaturePolicy, CSP, ... As of today, there are many constructors. It is not easy to know when not filling every params isn't a security issue. Some constructors are used only for test, and it's fine only for them. This patch mark some constructors to be used only in tests. This makes it easy to review all the others, which are critical. After this patch, we can exhaustively list all of them: 1. The initial empty document. 2. The synchronous navigation to about:blank that happens immediately after creating an initial empty document in <iframe> with no explicit src. 3. Navigations (regular and error documents) 4. Pseudo new document with same properties (XSLT, javascript). 5. WebViewPlugin (placeholder data URL) 6. Print selected HTML. 7. Test. TBR=tommycli@chromium.org (said LGTM, but didn't click on +1) Bug: 1151340,1041376 Change-Id: Idb3aea723a5da8e349b760a4587bc7609bffbc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635142Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4384.0-1610966529-benchmark-89.0.4389.10-r1 to 89-4384.0-1610966529-benchmark-89.0.4389.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I258f84b42350d15ce40f06bd7d7530836128223f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644699Reviewed-by:
-
Takashi Toyoshima authored
This patch introduces `is_prerendering` flag into CommitNavigationParams so that we can bring the prerendering state information to the renderer processes without any extra effort. This also removes NavigationRequest.is_prerendering as whenever we need it, commit_params->is_prerendering is available. Also, current approach does not intend to capture all cases as mentioned in the comment around SendCommitNavigation. We'd rely on MPArch in the near future to introduce precised implementation. Bug: 1169032 Change-Id: Ic1c12a77cf3cd6ca175235fd65d0ff1d7f0a968c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640514Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4384.0-1610969724-benchmark-89.0.4389.10-r1 to 89-4384.0-1610969724-benchmark-89.0.4389.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I81e620111330e6600f4040747cc8e80e3d26c925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644701Reviewed-by:
-
Kuo Jen Wei authored
Bug: 172340545 Test: tast -verbose run <DUT> "camera.CCA*" Change-Id: I41dac406e805e66036be6c141f2d5fdeafb6d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639994 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#846062}
-
Varun Khaneja authored
https://github.com/aawc/unrar/pull/25 for the corresponding change on Github BUG=1166496, 1166497, 1166498, 1166499, 1166500, 1166501, 1166502, 1166503 Change-Id: Idece6bd531d55f1b379d0a38fad5f74f64323749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634824Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#846061}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611284384-7c6617d93ef1b9fc70abe71fb9acc556bc65d8e5.profdata to chrome-win64-master-1611294737-17c8474f67761118ef8f2490ffa8a435d02d7f3f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4b3e269583880d4a1d817f8837f6016502f493e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644697Reviewed-by:
-
Michael Lippautz authored
Add the proper HashTrait to use the sentinel value for the library version. Bug: 1056170 Change-Id: I62e09904f46a7bb0f3f89d5687e8767d0b936b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643281 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846059}
-
Jason Lin authored
There is a long description about why we need this and how the algorithm work just above class VmInfo in vm_camera_mic_manager.cc. Bug: b/167491603 Change-Id: I7894609dd7d19ae1e69097508e942fca5792cfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643417 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#846058}
-
Alice Wang authored
This CL makes AccountPickerDelegateImpl independent of incognito package by moving the incognito mode policy check to SigninBridge. Bug: 1149857 Change-Id: Ib5ae49f71ea84a08131c70ecd3998eaefe5ac66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640654Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#846057}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a1550b6e356..ad73a7a4eb1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC snijhara@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: snijhara@google.com Change-Id: Ic927d195e863589b90b5d748dd59fa37ae653540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644520Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I771a733d07ae63b455da6fdffae070a6bb0d64e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644636Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846055}
-
Viktor Semeniuk authored
Bug: 1110293 Change-Id: If9e2de7acc4e788136af52f46880151988c2e0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642149Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#846054}
-
Chong Gu authored
Bug: 1054240,1054545,1058255 Change-Id: I945f5de761168432078ecd9c1787289e9608f92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542304 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#846053}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ff5f715e5c4a..c827ccbb58b8 2021-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 67fb6a84 to 318dff18 (435 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I737455704f768501e19108da8ccf11d58ce4fa3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643183Reviewed-by:
-
