GitLab

When an object on Mac is focusable but has no value or name, we compute its accessible description
from its inner text.
Unfortunately, we were adding a space between the concatenation of each piece of text coming from each child object
which creates a mismatch between the text offsets returned by AXPosition and text markers vs. the actual text contents.
If extra spaces are needed, they should be added by Blink, not by the browser.
This patch removes the code that computes the inner text completely since
no other screen reader announces focusable items unless they have an accessible name,
and it is not proper to add an accessible name if there is none.

AX-Relnotes: On Mac and same as on all other platforms, navigating by tab now does not announce
the text contained in a large container such as a table row if that container is focusable.

R=dmazzoni@chromium.org

Change-Id: Iac5f321113595a2372df03bb119ab1c7a6f1bbf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308649
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794574}

This fixes the referenced performance regression in which some such
videos stopped being composited.

Bug: 1108972

Change-Id: Ia77d33c1c50cf25427d825ae3969a120a8cde640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335648Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794573}

Bug: 1112031
Test: fast/media/readystate-update-in-detached-context.html
Change-Id: Id3c865021b1331d83004b371bdf5b9b23d879e84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335484Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794572}

https://skia.googlesource.com/skia.git/+log/1e4158db1ce7..3000d6b8c25c

2020-08-04 brianosman@google.com Validate function return and parameter types in IR generator
2020-08-04 nifong@google.com Add ParagraphBuilder.pushPaintStyle to allow text to be colors with paints.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: herb@google.com
Change-Id: Iae91a5dc69f81364e66165ac561ba3f71e83a69e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336768Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#794571}

Otherwise the function fails to do any copying in compiles which doesn't
hit the cases above.

Bug: 1103818
Change-Id: I18b99488df6852e3713c6b2dc7ae268eceedee52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336075
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794570}

Otherwise, they don't compile for use_x11 && use_ozone case

Bug: 1085700
Change-Id: I56a2afd959a694cb6a80422f440f85419d35f1f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333200Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#794569}

This will measure how often we fail to report FCP to UKM due to the tab
becoming hidden during the flushing window (go/plm-flushing).

Bug: 1010643
Change-Id: I0922f2d461407efb12bb9d02267a4620178a7dbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329915Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794568}

This reverts commit 84b0d040.

Reason for revert: Caused crbug.com/1112642.

Original change's description:
> Reland "Use border box or layout overflow rect for layout shift tracking"
> 
> This reverts commit 491b5a9c.
> 
> The original CL was reverted because it caused failure on MSAN bots
> due to use of uninitialized value.
> 
> The reason was that PaintInvalidatorContext::tree_builder_context_
> pointed into an PrePaintTreeWalkContext entry in a vector, and the
> vector could be reallocated when we added new entries, causing the
> pointer in the parent PaintInvalidatorContext to point to an invalid
> address.
> 
> Now remove PaintInvalidatorContext::tree_builder_context_ and add
> PaintInvalidatorContext::transform_ (which was the only used information
> from the parent PaintInvalidatorContext) to avoid the problem.
> 
> Original change's description:
> > Revert "Use border box or layout overflow rect for layout shift tracking"
> >
> > This reverts commit 0933392f.
> >
> > Reason for revert: ASAN/MSAN failures due to "use of uninitialized value"; see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8873209606965810848/+/steps/browser_tests/0/logs/Deterministic_failure:_AllForms__x2f_FormStructureBrowserTest.DataDrivenHeuristics__x2f_148__status_FAILURE_/0
> >
> > Original change's description:
> > > Use border box or layout overflow rect for layout shift tracking
> > >
> > > This CL addresses the following issues of layout shift tracking:
> > > - Changed visual overflows triggered layout shift report
> > >   (originally filed as crbug.com/1090763).
> > > - Descendant layout overflows were not included in ancestor's layout
> > >   shift report.
> > > - Unnecessary descendant layout shift report.
> > > - Slow visual rect calculation for LayoutInline and LayoutText.
> > >
> > > It includes the following changes
> > > - Track LayoutBoxes and LayoutTexts only.
> > > - Track both old and new starting points and visual representations
> > >   instead of using location of visual rects as starting points.
> > > - For a LayoutBox, the local visual representation is the layout
> > >   overflow rect if the LayoutBox has layout overflow and doesn't clip
> > >   overflow. Otherwise use the border box rect.
> > > - For a LayoutText, suppose its shift causes shift of all contents
> > >   in containing block logically below the LayoutText, and use that
> > >   part of visual representation of the containing block as the visual
> > >   representation of the shift.
> > > - Map both local starting points and local visual representations to
> > >   the initial containing block and viewport.
> > >
> > > This has the following benefits:
> > > - More accurate starting points and visual representations, conforming
> > >   to the specs;
> > > - Better performance by
> > >   * avoiding unnecessary layout shift reports of descendants
> > >   * avoiding slow LayoutInline and LayoutText visual rect calculation.
> > > - sizeof(LayoutObject) is reduced by 16 bytes because now we use the
> > >   previous geometry data in LayoutBoxes for paint invalidation.
> > >
> > > Bug: 1108622
> > > Change-Id: I7ebb4e250e7ca2a03b4dadea50034e300e55ad84
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319538
> > > Reviewed-by: Steve Kobes <skobes@chromium.org>
> > > Reviewed-by: Koji Ishii <kojii@chromium.org>
> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#793806}
> >
> > TBR=wangxianzhu@chromium.org,skobes@chromium.org,kojii@chromium.org
> >
> > Change-Id: I590f2abc4a48ba65bdfe7a948ffce00b299f9e06
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1108622
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333578
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Commit-Queue: Peter Kasting <pkasting@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#793874}
> 
> # Not skipping CQ checks because this is a reland.
> 
> Bug: 1108622
> Change-Id: I253a24799b6d2a3af346d4f65e3889217064b035
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333648
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#794218}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: I06c05f8cab6b2cc2ecd3cf3febf930e6eb95f777
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1108622, 1112642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336782Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794567}

The primary goal of this CL, is being able to add the following DCHECKs:
    DCHECK(loader_factories_);
    DCHECK(loader_factories_->HasBoundDefaultFactory());
to RenderFrameImpl::DidCommitNavigation.  If these DCHECKs hold, then
ChildURLLoaderFactoryBundle::GetFactory should always get the
|base_result| from the base class and therefore shouldn't ever need to
fall back ot the |direct_network_factory_| fallback (which wraps the
deprecated, process-wide / frame-agnostic factory).

One scenario where the new DCHECKs didn't hold before this CL is
RenderFrameImpl::LoadHTMLString which is mostly used from tests, but
also has a call in the product from
MimeHandlerViewContainerManager::LoadEmptyPage which is used by
MimeHandlerViewEmbedder::CheckSandboxFlags to load an empty page when
security checks fail.  Another scenario is unit tests like
RenderViewImplTest going through TestRenderFrame (where tests drive the
simulated commit).  All of these cases don't actually use the factory
bundle and therefore can just use the NotImplementedURLLoaderFactory.

The CL splits GetLoaderFactoryBundleFallback from
GetLoaderFactoryBundleFromCreator to make it more obvious when the
fallback is actually needed.  In particular, this allows the new DCHECKs
in RenderFrameImpl::DidCommitNavigation to explicitly avoid the
fallback.

To facilitate reuse of NotImplementedURLLoaderFactory from
//content/renderer the CL moves this class from //content/test into
//services/network/public/cpp.  The CL also adds NOTREACHED to
NotImplementedURLLoaderFactory::CreateLoaderAndStart to ensure that
future callers don't accidentally start using the factory.

NOTREACHED is also added to the non-opaque-origin/DwoC case in
ChildURLLoaderFactoryBundle::GetFactory (this probably should have been
part of r792963 which added a test that would have hit this NOTREACHED
before the fix).

Bug: 1098938, 1105794
Change-Id: Ifaedf40be35871b0a30797c09a236ea131b24447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321346Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794566}

This CL doesn't change the behavior.

Bug: 1111134
Change-Id: Icf1bba68f665b44864614f724072719bac9b3b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331418Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794565}

This CL adds support for MacOS ARM64 Widevine CDM so that it will
be registered as a component.

Currently the CDM is not available on the server for component
update, not will it be bundled to Chrome. These will be resolved
later, as tracked by crbug/1111381.

Bug: 1110364,1111381
Change-Id: I4fa28d524f21bebdc13fbfb47ecdf8ece7b811ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333997Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794564}

Adds action for enabling virtual authenticator environment.

Used as metric to track use of WebAuthn DevTools front-end.

Related CL that implements metric: https://crrev.com/c/2333990

Design doc: https://docs.google.com/document/d/1A-cn0rxuHHAyGhywayk7xcTqSsR2X7va6H4kSMThOoY

Bug: 1034663
Change-Id: I2e4145e3bb1951968770971a3f0bace8a8403f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332995Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Fawaz Mohammad <fawazm@google.com>
Cr-Commit-Position: refs/heads/master@{#794563}

This Can hopefully prevent confusion / wasted time when running
TestSuite instead of TestSuite.*, Test instead of Test/0, etc.

Bug: 999246
Change-Id: I26ecf8d641c6a3e72c5fbc29fedb881eb2622c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808728
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#794562}

Painted scrollbars are used for overlay scrollbars on MacOS. Thumb
movement would cause a commit on every scroll change because the update
rect (set via Layer::SetNeedsDisplay) would change. This patch ignores
the update rect in PaintedScrollbarLayer::Update and uses part
invalidation for causing commits. With this change, scroll offset
changes do not cause commits.

This is a reland of https://crrev.com/745544.

Bug: 1048384f
Change-Id: Ic7cb0eed729536dd39e87913324e89c01fa27094
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333866Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794561}

Also add a presubmit check that all unsupported policies have been
marked as deprecated and fix all cases in policy_templates.json where
that hadn't been done.

Bug: 1018841
Change-Id: I8e7e69330746ec9c174ccbd1ed9ac66790c4a5af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329674
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794560}

Specifically if the url is the same as the last page and the
navigation is a same-document navigation, then FaviconHandler need
not do anything. This scenario happens when using
history.replaceState() and the like (which is used on the SRP).

BUG=none
TEST=covered by test

Change-Id: Ida3aabeefb1cef033b68b667049fa724efe7b4f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335024Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794559}

This CL doesn't change the behavior.

Bug: 1111134
Change-Id: I35fabb6b626d8763b37ce71e6bd01505cf5b74ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331417
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794558}

Currently, feature initialization looks like this:

1. The pref store is initialized (which contains saved flag states)
2. A FlagsState instance is initialized from that prefs store
  a. FlagsState computes which switches and features should be in what
     states based on flags
  b. FlagsState excludes switches and features from flags that are
     currently expired
3. A FeatureList is initialized from that FlagsState

Unfortunately, deciding whether a flag is expired or not requires
knowing the state of the various TemporaryUnexpireFlagsM$M features,
which aren't initialized until step 3, so step 2b doesn't actually work
properly. During step 2b, every unexpiry feature is treated as if it was
in its default state (i.e. disabled), which means that every flag whose
expiration has passed is treated as expired, regardless of the state of
the unexpiry flag. As a result of *that*, when the FeatureList is
initialized at step 3, any such flag's configured value gets ignored.

The fix for this is deeply unfortunate: at step 2b, add a special case
in checking whether a flag should be considered expired or not.
Specifically, consider not just the state of the unexpiry feature (which
may not have been initialized yet) but also the state of the backing
unexpiry *flag*. To enable this, pass a FlagsStorage into the
FlagsState::Delegate.

Change-Id: Ia2b6423357d24318baaeb3ca34208d1a2f1c36aa
Bug: 1101828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302925Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794557}

https://android.googlesource.com/platform/external/perfetto.git/+log/d14d99cd75b8..46b0d8780f66

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I583f21fe009238abe16fd7454c6b90ea4aa0f62e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336505Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#794556}

https://android.googlesource.com/platform/external/perfetto.git/+log/46b0d8780f66..7176f54720e6

2020-08-04 hjd@google.com Merge "Support armv7l in system_probes_parser"
2020-08-04 lalitm@google.com Merge "tp: switch from dict to list of pairs in descriptor generation script"
2020-08-04 hjd@google.com Merge "Call sendfile in a loop to handle short writes"
2020-08-04 lalitm@google.com Merge "ui: fix searching for data bounds on tracks"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I36af41efbcb71eba7c1b942c3c89e1fc9d2712e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336765Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#794555}

This CL doesn't change the behavior.

Bug: 1111134
Change-Id: Id709ff4a489dd156ef6dd1daed24292eae0c9dac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331439
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794554}

This CL doesn't change the behavior.

Bug: 1111134
Change-Id: I5a0fb2249ccea2f240ba6031859fdcd8736b44d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331381
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794553}

This CL doesn't change the behavior.

Bug: 1111134
Change-Id: Ia2d55b24d2b9fd458d01ae2a44471f6a0eebe340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331380
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794552}

1. Adds junit test --
CustomTabIntentDataProviderTest#defaultOrientationIsSet.
2. Adds new instrumentation test --
TrustedWebActivityOrientationTest.

Bug: 812797, 989606
Change-Id: If7ee74c1d65bb3300132696dc4a78063579a7dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327611
Commit-Queue: Sicheng Li <scli@google.com>
Auto-Submit: Sicheng Li <scli@google.com>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794551}

Change-Id: Ifd4c7d4a9ffe6f3f763f7ee458c6f04523f3350c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333679Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794550}

The fuzzer found a test case that causes the BackoffEntry deserializer
to discard the absolute timeout and fall back on the relative timeout.

BackoffEntry::GetReleaseTime() is actually not guaranteed to equal the
original release time (before serialization). However, it is guaranteed
to be less than or equal to the original release time.

This CL weakens the fuzzer's property check accordingly.

Bug: 1085995
Change-Id: I1dafb08575e73b0548f973565145c8ba7890a33e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324111Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794549}

This CL just flips the newly-introduced parameter to default to enabled
when left unspecified.

Keeping it default-enabled makes it much easier to test manually, and
for now I'd like to maintain the manual testing. It'll be explicitly
disabled via finch when not wanted.

Bug: 1111731
Change-Id: I0502f6eecf51c7a6f44fc544f0797dbc98b4c3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332520Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794548}

This moves ParseAddress() and CanonicalizeAddress() to
//device/bluetooth/public/cpp. These functions are not specific to
BluetoothDevice and are utility functions which more naturally fit in
the public directory.

This CL is a precursor to adding a Bluetooth address field for Phone Hub.

Bug: 1106937
Change-Id: I5b321136a10715a50767b0d2c8536a96cadc4f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335676
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794547}

This CL updates all the UI callsites to use the new
AutocompleteResult::IsSuggestionGroupIdHidden() method, which respects
the server-provided hint as to which groups should default-hidden.

This CL also deletes the deprecated omnibox::IsSuggestionGroupIdHidden()
method, which is no longer used after this CL.

This CL also deletes the deprecated
omnibox::ToggleSuggestionGroupIdVisibility() method, and migrates all
callsites to the omnibox::SetSuggestionGroupVisbility() method.

Bug: 1106096
Change-Id: I00a6248a65a4b2567fae204438534d1735020fd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330320Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794546}

Fix introduced earlier doesn't solve the issue fully. The crash is
caused by calling reconfigureCellsForItems from loadModel. By removing
that the problem should be gone.

Bug: 1112344
Change-Id: I798b909182a5d59c653dc0c212c31225d59b9919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336077
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794545}

Design mocks: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8e7b42d005_0_56

Bug: 1110309

Change-Id: Id0e4316e71d57b80271c0a596cd4de505dc1e54b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332164Reviewed-by: Marian Fechete <marianfe@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Milica Selakovic <selakovic@google.com>
Cr-Commit-Position: refs/heads/master@{#794544}

Mark self.started as NO in stopAnimated: before calling
dismissal callbacks in the Infobar Overlay Coordinators
will prevent successive calls to stop from executing. This is
bad because the request will be destroyed in the first callback
sequence, and then a DCHECK will fail in a successive sequence.

Bug: 1112482
Change-Id: I13f487ebe99f593e253a70af8f26a79375210fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335408
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794543}

This was a feature of Messages, and was neglected in the Overlay
implementation.

Bug: 1112421
Change-Id: I5fdc5cf993ed50f48ae6b0f14c167051891c8c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335553
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794542}

During the sync of the protos on client side and server side, it
was requested to change UNKNOWN field to FAILURE_REASON_UNKNOWN to
avoid confusion in the future and to be in sync with the
guidelines.

Bug: 1106343
Change-Id: I40c6a3e4a0299dfa7a8360dcc44bb09292ee57b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336079Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Cr-Commit-Position: refs/heads/master@{#794541}

This reverts commit 55c54eed.

Reason for revert: Introduced flickering and weird artifacts in ARC P and ARCVM.

http://b/162704898
https://crbug.com/1112017


Original change's description:
> exo: Set the gfx::NativePixmapHandle modifier
> 
> This will forward the modifier all the way to the eventual EGLImage or
> gbm bo import such that GLES or KMS will properly understand the
> buffer layout.
> 
> BUG=b:145579089, b:79682290
> TEST=wayland_rects_client --use-drm=msm and verify modifiers get passed
> 
> Change-Id: Ia422c3713f1a9384aa737c3d1cccb1dd76709e18
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314984
> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#793405}

TBR=frkoenig@chromium.org,lpique@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:145579089
Bug: b:79682290
Change-Id: I15f20a639d9fe532cf03022f566dfa539100eeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335817Reviewed-by: Ricardo Quesada <ricardoq@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794540}

Screenshot:
https://screenshot.googleplex.com/UaY0XVo8r6B.png
With dark background:
https://screenshot.googleplex.com/zkCm5YkgnpS.png

Bug: 1076880, 1099286
Change-Id: I5255ce9f25d88c19b7d24cb684f574cc544cb63f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328854Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Auto-Submit: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794539}

https://android.googlesource.com/platform/external/perfetto.git/+log/9a482652ab18..d14d99cd75b8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ib10c82a69060d54ebcf128d55aa4bf1dc34f9766
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336503Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#794538}

Roll Chrome Win32 PGO profile from chrome-win32-master-1596523951-c381c0b70edf8b236c69b708afa84878f43cb61f.profdata to chrome-win32-master-1596527967-453034edae7748ca30b46c873b3303e5191c764d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Id3f0754b6aa20193f3887acbf121aa0f18592cec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336761Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#794537}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/16150ea24b1e..965b1ffc561e

2020-08-04 sigurds@chromium.org Revert "Migrate browser_debugger to devtools_entrypoint"
2020-08-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-08-04 aerotwist@chromium.org Migrate browser_debugger to devtools_entrypoint

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1101738
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I2faca9462e134f7f0241991625b1195b914962ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336763Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#794536}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fbfa898df70..a79b9fd7235f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sinhak@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: sinhak@google.com
Change-Id: I55c8774dd72677c6822c58c62a5e2cd82f01ed00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336760Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#794535}