- 22 Jun, 2020 40 commits
-
-
Anatoliy Potapchuk authored
This test has been flakily failing. Example failure: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel TBR=ulan@chromium.org Change-Id: Ib822a468b0eb9ff4799034b527e69bb9f3d0a97e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257198Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#780691}
-
Clemens Arbesser authored
I added GetUserModel() a while ago, which supercedes this method. Bug: b/145043394 Change-Id: I5d22394e8282906d61c40ce3958b4dcf33f38a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252343Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#780690}
-
Alex Rudenko authored
DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253898 Bug: 946975 Change-Id: I6080f0b0c912b825024e710f68a0ac4f80de43fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256199Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780689}
-
Bugs Nash authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/hHNzH9agD69T1E_LZpIZVzqyspiBI3MkAir2tP-KXtIC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202006210800_RC00.html Bug: b/154069736, b/158702282, b/156201188, b/158703476, b/158263742, b/144966889, b/158263707, b/158794019, b/155448625, b/156556242 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I3e14df1923ac71dc4c1718fcc47369f8411ef347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255948Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#780688}
-
Takashi Sakamoto authored
Bug: 1086388, 1096952 Change-Id: Id8307aa3b21b46a237766ae1dd75664a8c804da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256920Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#780687}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592794775-3ca8972fd43e2dafcf6b1d386a5259b1a453c9cc.profdata to chrome-win32-master-1592798309-f2bcf0f33aab857d8bcffdd4e0dd372aeeedf408.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7bca20aa5b6cb0937f914824c9531addd3377a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780686}
-
Alexey Baskakov authored
Observers should be able to detect if a field they are interested in is changing from sync and react accordingly. This API allows observers to detect changes/diff on a: 1) per web app basis (new_web_app_state->app_id()) 2) per field basis (new_web_app_state->field() != old_web_app_state->field()) Another use case: user_display_mode is shown in App Management UI v2 and we need to update the UI if user_display_mode gets changed from other device. This is a preparation CL to implement AppSorting (a user's UI) in the new web apps system: https://chromium-review.googlesource.com/c/chromium/src/+/2243603 Example: void ChromeAppSorting:: OnWebAppsWillBeUpdatedFromSync( const std::vector<const WebApp*>& new_apps_state) { ... for (const WebApp* new_web_app_state : new_apps_state) { const WebApp* old_web_app_state = registrar_->GetAppById(new_web_app_state->app_id()); DCHECK(old_web_app_state); if (old_web_app_state->user_page_ordial() != new_web_app_state->user_page_ordial()) { // Do the minimal UI/NTP update only for app_id() and knowing the next and the previous // values for the field we are interested in (user_page_ordial is this case) } } } Bug: 1061586 Change-Id: If7993216a3acd80f5211f98cc70bf855d87429d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255932Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#780685}
-
Jérôme Lebel authored
When sign-in starts, all other windows should be blocked. Fixed: 1086383 Change-Id: I7e1214016c2e6c93f13d596bf38ba0aec635ebad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248686Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#780684}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad20226ea8b8..a061b4a78240 2020-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4a914f21 to 5964c496 (498 revisions) 2020-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from eb6824408d08 to ae1007957f09 (3 revisions) 2020-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 581c407cd20b to 92379bff49c2 (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I8ba0be918ee3adec739b837416226cc6838ea52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256689Reviewed-by:
-
Jia authored
Bug: 1096834 Change-Id: I598097278f38d3f832b0c242c1852dcd2c5e050f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251611 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#780682}
-
Hans Wennborg authored
Ran `./tools/clang/scripts/upload_revision.py 7f0d7f32631648acf48bc23047635ab5e2058a1a`. Bug: 1094943 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Change-Id: Ie5f06745147ec69033616b4ef8a7ee2dc8ca8d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252882Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780681}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592782588-22df9ed37f1e7bef27e6e30c2d3156d67070dcf4.profdata to chrome-mac-master-1592804634-613f5d333e880097e41ea0ea654d3b24558f2504.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If46262036d0f27c8b5582e500093e83866a82a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256691Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bcc295d28b7..ea3fc18261ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071344,chromium:1094753 Tbr: fergal@google.com Change-Id: If0a2e4a6680fa511806eb47a1842c2e56d29e3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256687Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780679}
-
tby authored
We're DCHECKing on a call to FileTasksNotifier::QueryFileAvailability, which needs to be called on the UI thread rather than a task runner. The method offloads its IO work to another sequence on its own. Bug: 1097166 Change-Id: I1b0e0bef2f2b64f5ddd09d35ebe2340ef133645b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255732Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#780678}
-
Yutaka Hirano authored
Define Agent::IsCrossOriginIsolated() [static] which represents Agent cluster's "cross-origin isolated" concept. We are planning to ensure that a renderer process host only cross-origin isolated agents or only non-cross-origin isolated agents, not both, so the boolean is renderer process global. The value comes from content::RenderProcessHostImpl::cross_origin_isolated_. It is set to false now, so Agent::IsCrossOriginIsolated() returns always false now. We are planning to set RPHI::cross_origin_isolated_ in the future. Design doc: https://docs.google.com/document/d/1QyAGuwxoX1MrrPqOpAr84zhX0_YB7kOD2w8azvq45ME/edit Bug: 1018680 Change-Id: If6b5a6ee5df100ecd997c4c047afc40208102f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247463 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
-
Marc Treib authored
This CL fixes PasswordManagerTest.* and HttpAuthManagerTest.* with the feature EnablePasswordsAccountStorage enabled. I fixed these previously (in crrev.com/c/2246172 and crrev.com/c/2237976), but then broke them again (in crrev.com/c/2249898). The fix now is to call OnGetPasswordStoreResultsFrom() (and pass the originating store) instead of plain OnGetPasswordStoreResults(), since the MultiStoreFormFetcher relies on the former. Bug: 1093310 Change-Id: I97c6e41000ec5114268c33910cdb6437ac40dbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254120Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#780676}
-
Yoichi Osato authored
This feature counts the feature usage for origin trial. Bug: 688906 Change-Id: I7563aac1ba0ed96cd668e82d3f8e5d4c45f5e2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256098Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#780675}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Id7da3b287e4b3ad2aa0f46f59b75b905dcd5a7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254602 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#780674}
-
Dominic Farolino authored
R=yhirano@chromium.org Bug: N/A Change-Id: I7fa860d4b017cd8858ecb5f56d9ae273eda295e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255137Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592791037-61d3597a6914c6758ea9d71b339128d21bdc1553.profdata to chrome-win32-master-1592794775-3ca8972fd43e2dafcf6b1d386a5259b1a453c9cc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2a43112bd827b88c2b16ff9901339c5412180af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256685Reviewed-by:
-
Leo Lai authored
This CL implements a way to set the enrollment preparations to the fake client so we can use it in the unittests of the consumer in the child CLs. To test this CL, the consumer code in the child CL is needed, and it is passed with the same test coverage after the API replacement. BUG=b:158955123 Change-Id: Ia98c05cac0de58e6153a206322733921135f5b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249274 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#780671}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/50daeddf396f..ad20226ea8b8 2020-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c81f0b7b921f to b772a955e70c (18 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1094869,chromium:1096577,chromium:1097082 Tbr: lovisolo@google.com Test: Test: Test: CopyTexImage*Vulkan:Texture3DCopy*Vulkan:Texture2DArrayCopy*VulkanTest: Test: angle_perftestsTest: Test: angle_perftests --gtest_filter="*Trace*"Test: Test: dEQP.KHR_GLES3/copy_tex_image_conversions_required_cubemap*cubemap*Test: Test: run_tests_with_framecapture.py Change-Id: I9e3ad08b01a17f05295e4bc5f08745b2df4de290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256686Reviewed-by:
-
Ramin Halavati authored
Wrongly used "Incognito" term in media router is replaced with "OffTheRecord" to clearly represent all OffTheRecord profile types. This CL does NOT result in any behavioral change and is just to improve readability. Bug: 1074201, 968028 Change-Id: I25aab1c417ab7d7a420b7cf948b6933923da6496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212208 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#780669}
-
Jia authored
This cl uses Daily Event observer to log daily search requests to UMA. Bug: 1096834 Change-Id: Idd9c8663390f248605774ac762d0d7acf2a838c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251564 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Weiliang Chen authored
This reverts commit 65cdf4dc. Reason for revert: crash w/ GLRendererCopier Bug: 1096487 Original change's description: > viz: Make GpuTaskSchedulerHelper a unique_ptr with Single Ownership > > |gpu::GpuTaskSchedulerHelper| is the interface to post tasks to the gpu > thread that is shared by the output surface and the overlay processor. > The ownership used to be managered by a scopred_refptr. Since > viz::Display owns both the output surface and the overlay processor, > move the shared gpu task scheduler to be owned by display as well. > This will make |viz::Display| the single owner of this class, and > this will make the lifetime of this class easier to understand. > > > R=rjkroege > TBR=kylechar > > Bug: 1093440 > Change-Id: Ie5f3760ca6c7ee61e9adf6ce56eb3904f1b8d1c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237996 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779176} TBR=rjkroege@chromium.org,boliu@chromium.org,weiliangc@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093440 Change-Id: I4eb125e9f75ef38336a395a8c288d3f3ed94f911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256005Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#780667}
-
John Palmer authored
Suggested by a reviewer in https://crrev.com/c/2245163 Bug: 1095879 Change-Id: Ibc2bcb2cecef7c207f9dc77349972239fc10e160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253263Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#780666}
-
Joel Hockey authored
Bug: 1097596 Change-Id: Ia792220a5daa29f7d855117162193468c5a5a29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256107 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#780665}
-
Fergus Dall authored
CrostiniManager::OnAbortRestartCrostini gets an iterator into |restarters_by_id_| but dereferences it before checking if it is the past-the-end iterator, potentially causing a crash. Change this method to bail out early if the restarter being aborted has already stopped. This was not caught by the test for this case (CrostiniManagerRestartTest.DoubleAbortIsSafe) because it incorrectly terminates as soon as the first abort finishes, instead of waiting for the second. Fixing this causes the original code to crash under MSAN, and passes with the new code. Bug: 1096979 Change-Id: I67322c5a8823dea4e517ba04d5fbf110b200e8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251644Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#780664}
-
Leo Lai authored
Change-Id: I62e307e35fd70b90697f52c2d823faf49b1c40a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249275 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#780663}
-
Christopher Lam authored
This CL hides unnecessary page action icons from System Web App titlebars. All page actions except Zoom and Find have been removed. Bug: 1090169 Change-Id: Ib73371c055d545533c2315f98b04dc3420ee37f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245999 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#780662}
-
My Nguyen authored
Added support for kAutocorrect text type in blink based on design doc at http://go/e14s-autocorrect-marker. Bug: 1096212 Change-Id: I89b4bcc407c8598de16af78bbd8eec18239b1e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249405 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780661}
-
Fergal Daly authored
This reverts commit e44abb7d. Reason for revert: Fails on Win DBG builder. Original change's description: > bluetooth/winrt: Observe discovery failures > > Change BluetoothAdapterWinrt to subscribe to > BluetoothLEAdvertisementWatcher::Stopped events. The event fires if > scanning for LE advertisements has been cancelled by the application or > due to an error. Once the event is received, mark all active > BluetoothDiscoverySession instances inactive, which will cause > BluetoothAdapter::IsDiscovering() to return false. > > Also make BluetoothAdapterWinrt call Observer::DiscoveringChanged(). > > Change-Id: If4abf65f09b4d20b89b53adb63dad89939ddcceb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255549 > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780539} TBR=reillyg@chromium.org,martinkr@chromium.org BUG: 1097635 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I5b2e012bee60c94d735f95aa49cf90db2adff016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255946Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#780660}
-
Hirokazu Honda authored
kVaapiH264AMDEncoder is removed because the feature is enabled. Furthermore, the new feature about Low power encoding is introduced recently. This CL removes and adds the features to be enabled during the test. Bug: None Test: None Change-Id: Icb71079a884c42eb5ac1734245a9d3f250e17cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248393Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#780659}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592779386-d10fa35c75ce463022fded9cb8371e7e46e4c833.profdata to chrome-win32-master-1592791037-61d3597a6914c6758ea9d71b339128d21bdc1553.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I454f45807871c8ae0a9017361529088db7f42f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256684Reviewed-by:
-
Bartek Nowierski authored
This is needed when Chrome codebase is automatically rewritten to use CheckedPtr (see go/miracleptr for project description). Bug: 1080832 Change-Id: Ic9f023651f991fd9d559d6be827e12498c57748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255940Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#780657}
-
Fergal Daly authored
This reverts commit ec355e1b. Reason for revert: This has caused several of the mac builders to start failing consistently Original change's description: > [Profile menu] Streamline ProfileMenuClickTests > > This CL removes behavior of profile menu in tests that is not checked by > the click tests (i.e. the various actions that happen after clicking the > menu items). > > This CL is a speculative fix for high flakiness of > ProfileMenuClickTests. The flakiness has multiple root causes, none of > which seems specific to profile menu / the test code. The hope is based > on the fact that many of the actions in the user menu are expensive > (loading guest mode and opening another browser) and thus increase the > risk of flakiness. > > Bug: 1021930 > Change-Id: I0f24a1f18ce8d3029daef44e2bc96b95eef81ac9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247642 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780296} TBR=droger@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1021930,1097627 Change-Id: If18ad3b4f7a9155a67fd5f7a3b2c71b7b175769f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256109Reviewed-by:
-
Nate Chapin authored
* Document doesn't need to be a FeaturePolicyParserDelegate, go to ExecutionContext instead. Leave it as FeatureContext so it still can be passed to RuntimeEnabledFeatures, with the goal of removing that, too, in a later CL. * SecurityContextInit does still need to be a FeaturePolicyParserDelegate, because while the SecurityContextInit is in use, the ExecutionContext isn't fully initialized and doesn't have access to the OriginTrialContext. It can, however, use the ExecutionContext for most things and doesn't need to store so much state to be applied later, so it can be substantially simplified. Bug: 1029822 Change-Id: I13ceec01c91ffa97c53dd943f4ae0c498547437d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255030 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Nate Chapin authored
Bug: 1029822 Change-Id: Idb92d7f4dfa0f1567a4bca993e3e10905e92df0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255359 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Leo Lai authored
This CL enables the communication between the browser and the attestation service daemon (attestationd). This will be used to replace all attestation-related APIs that go to cryptohome client at this point. To test the further setup is correct, we use dbus-monitor to see if sender is not cryptohomed after the switch in the child CLs. BUG=b:158955123 Change-Id: I48706f287853ef19465ac92e7e6054ed64c9337a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249273Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#780653}
-
Yoshifumi Inoue authored
This patch changes "svg-is-part-of-same-line.html" to remove redundnat spaces to hide white space collapsing differences between legacy layout and LayoutNG for ease of enabling EditingNG. In legacy, "<img>\n ab" yields <img> " " " ab", LayoutNG yields <img>" " ab". Bug: 707656 Change-Id: I2177fbfdbcad9483f4d13c21c13ee1a3b36ca458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255933 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#780652}
-
