- 03 May, 2019 40 commits
-
-
Alexander Alekseev authored
This CL adds OfflineGaiaLogin mixin. Bug: 950236 Change-Id: I704795a7877375f150aabe8a872b4e6c9c5530df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590898 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#656295}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c57ec6f0af33..10f7befc49a7 git log c57ec6f0af33..10f7befc49a7 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 capn@google.com Fix overwriting of filter factor Created with: gclient setdep -r src/third_party/swiftshader@10f7befc49a7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I8d76225ad3694719ec9ca0eb8254b83b1491ec00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594243Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656294}
-
David Bokan authored
To understand why this is needed, note that the size of the layout viewport is calculated based on the minimum scale factor of the page. That is, we size the layout viewport to the size of the visual viewport when it's at the minimum allowable scale factor. |position: fixed| elements are sized relative to the layout viewport; therefore, their size depends on the minimum scale factor. When we override the minimum scale of a page, this can cause the layout viewport, and thus |position: fixed| elements, to increase in size. If we respect the initial-scale, this can cause fixed elements to appear cut-off by the viewport without a good visual indication to the user that zoom-out or horizontal scrolling is available. This is especially bad since the typical case here is a banner with a close [X] button at its far right. This causes those buttons to get cut out of view. Bug: 929709 Change-Id: Iacb6f6e92a5db11037710380e736f1f429575262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591888 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#656293}
-
Jeevan Shikaram authored
The app list in App Management would not render when navigating to it via a back button. This was caused by an onDomChange not being triggered by the page change while navigating within App Management. Bug: 948444 Change-Id: I9567a3baa6512550fdee221dfc062b5042925ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560878Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#656292}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9046c85c3ce..d22de7578813 Created with: gclient setdep -r src-internal@d22de7578813 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I28250c5688b85ac0d7ff4804b4e10edaf119372b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594242Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656291}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I589470df2c015be520f0a229b9434dd64dc2ca35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594334Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#656290}
-
Nico Weber authored
It's identical to gnuwin-9.zip but additonally contains tr.exe from UnxUpdates.zip. TBR=hans Bug: 958969 Change-Id: I6c2b49f57af8d85925750c03282ff6ae9dfd21b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593366Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#656289}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Ibd1e392c80d1d9786ccc0c300085a085f2d0f864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594254 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#656288}
-
Evan Stade authored
TBR=tsepez@chromium.org Bug: 958154 Change-Id: I0d7773c19c5ebb10b18946d68d916af17f3553bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592694Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#656287}
-
Kyle Milka authored
Previously requests for promos and the OGB were not sent until the NTP had almost finished loading. Instead start these requests when the request for the main HTML page is received. With this change promos and the OBG will appear along with search suggestions and the most visited tiles if they're available (which is now fairly likely). Otherwise they will appear once ready. Also removes a console error when the OGB failed to load. Bug: 770640 Change-Id: If041fd825dcc763a81b93337b85d4e939be7c7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518058 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#656286}
-
Giovanni Panaro authored
In file manager, when the select all command was issued in a directory where there is only one file and the file was selected, checkSelect mode would not enable. CheckSelect mode now correctly enables. Bug: 938273 Change-Id: Ia44814582f5bf2c5e8e8028e77c35b6fdaf88ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576434 Commit-Queue: Giovanni Panaro <tsrwebgl@gmail.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#656285}
-
Peter Kasting authored
* In-declaration initializers * =default * base::ClampToRange() * Use a default value to reduce to a single Reset() function * Call Stop() after resetting internal vars, not before, since it calls callbacks which could read these vars * Reduce redundancy * No || on function names * Shorten code * Rename ResetForSlide() to StopThrobbing() for parallel structure Bug: none Change-Id: I794e219401be3b7bcc5d09be65fe10daf072d537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594061 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#656284}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/719163224a6f..b9046c85c3ce Created with: gclient setdep -r src-internal@b9046c85c3ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I37eb66aec3647614af550fe3d783b40428368271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594236Reviewed-by:
-
Jamie Walch authored
This CL renames LocalMouseInputMonitor to LocalPointerInputMonitor, plumbs the event type (ET_MOUSE_MOVED or ET_TOUCH_MOVED) through to the RemoteInputFilter, and adds touch input detection to ChromeOS. Change-Id: I1adb94df5d56ec3194e7ccd81b870d2c8e73efa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590449 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#656282}
-
Jimmy Gong authored
- Adds new max width constant for cr-searchable-down to shared_vars_css. - Update SmbShare page to use this new max width constant. - This constant will be used in other dialogs in future CL's. Bug: 955173 Test: End to End manual Change-Id: Icc68ca995c1bf0d8df81f16c954e2ae5a202a5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584845 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#656281}
-
James Cook authored
Use pageVisibility to hide: * internet * bluetooth * device Bug: 950007 Change-Id: I5fdfb525a33b19176d99bc6528bd060758fb2171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590604 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#656280}
-
Yuwei Huang authored
Change-Id: I20db073d1b987abf5e4e4c43267f2cbae9e7a70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592619 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Ensures that the wrapper script for the XR browser tests properly exits with the browser tests' return code. Previously, it was doing nothing with the returncode, causing the tests to appear to always exit with 0. Bug: 954581 Change-Id: Iede65178478980a7e1770df9c4b20a38f2efa3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592616 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#656278}
-
Evan Stade authored
ImmersiveContext remains as an interface in //ash/public. Bug: 958248 Change-Id: Ie32c248e2683cf6957448b33436808394b551176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593836Reviewed-by:
-
Daniel Cheng authored
Bug: 841899 Tbr: thestig@chromium.org Change-Id: I972785b8f6c189039c56049a8c132b7bf4c69876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584531 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#656276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7fde8e172810..666a9f9f8bb9 git log 7fde8e172810..666a9f9f8bb9 --date=short --no-merges --format='%ad %ae %s' 2019-05-02 bungeman@google.com Update includes for Wuffs. 2019-05-02 bungeman@google.com IWYU for SkTLogic.h 2019-05-02 ethannicholas@google.com Child fragment processors are now written as separate functions 2019-05-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 668026c511f3..853f66269c16 (2 commits) 2019-05-02 halcanary@google.com GMs: re-sort gni, script to regenerate gni, file name convention 2019-05-02 halcanary@google.com SkPaint: new constructor 2019-05-02 herb@google.com SkShaper JSON output with cluster visualization Created with: gclient setdep -r src/third_party/skia@666a9f9f8bb9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I420e09c36a614796d854398a1c7b319ad5194215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593596Reviewed-by:
-
Evan Stade authored
The part of the AshWindowManager mojom which was being used to preview and perform snaps (click on restore button and drag to left or right) is moved to a pure virtual interface in //ash/public/cpp, and implemented in //ash/frame. Bug: 958154 Change-Id: I1cb107784dfffe2209e27860d6735342913cc5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592871 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Evan Stade authored
This is mostly a revert of ddb9a768 and 08ebee42. It also deletes the tap visualizer app. You can test with --ash-touch-hud and ctrl-alt-i, or --show-taps. Bug: 958074 Change-Id: I7282603e02588ad4d92fb51181565e203ee12f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589830Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#656273}
-
Rakib M. Hasan authored
All GPU test suites have been moved onto the new expectations format. This CL also removes the generate_test_expectations.py script which was used to generate test expectations file for a test suite using the old test expectation python scripts. This CL also removes the --also-run-disabled-tests command line argument. This argument depended on the old format of expectations. The --all command line argument can be used instead to run disabled tests. It either by ignores the Skip expectation in the new format or the --skip command line globs. Bug: chromium:698902 Bug: chromium:937516 Change-Id: I5d866f0e2f21f2ada0ac94db45bf656ec11a9029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594057 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#656272}
-
John Williams authored
Bug: 954797 Change-Id: Ibc4db91c4ea76b109a6361aa6c269e99cce8480d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577674 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#656271}
-
Dale Curtis authored
Since we allow duration to be infinite, a seek to 2**64 (kInfiniteDuration) and a subsequent currentTime retrieval will yield kInfiniteDuration. BUG=958324 Change-Id: Ia7e2beead415cb3cfca91672f9399d6fd09a0d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592614Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#656270}
-
Aleks Totic authored
Inline containing block dimensions were computed incorrectly if: - inline OOF container was split - OOF Element was inside non-root continuation This happened because container dimensions were computed by finding all fragments whose layout object root matched inline_container. If inline container was not a root, no fragments were found. Actual fix is simple: ensure that NGOutOfFlowPositionedDescendant always points to the root. While fixing this, I also did a little bit of cleanup. Main change was - change NGOutOfFlowPositionedDescendant.inline_container to LayoutInline* from LayoutObject* Bug: 931867 Change-Id: Ibd3c0e9fdeffaf2c63d3f59386bc2ea223ec726b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592528 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#656269}
-
Raphael Kubo da Costa authored
This was removed in the spec in 2016 (commit 16cd4c74, "Spec update"), and there is no reason to keep it around at this point. Bug: 257511, 957953 Change-Id: I3d0d6400ec529891266633fba0f86d7df67a32c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588637Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#656268}
-
Etienne Bergeron authored
The fallback fonts logic in VR was used to detect that every glyphs will exists when rendering. see: https://bugs.chromium.org/p/chromium/issues/detail?id=722861 This is roughly a revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1345419 The Android fallback fonts is implemented here: https://chromium-review.googlesource.com/c/chromium/src/+/1589274 R=billorr@chromium.org BUG: 952963, 770893, 944227 Change-Id: Ia370f666369127f19bd7c950cbd32529e8927411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573652Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#656267}
-
Pedro Amaral authored
Bug: 958769 Change-Id: I6001ac7307215bd947c21022d3cabc9bfbf37667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594082Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#656266}
-
Ehsan Karamad authored
The tests started failing a while back; trying them locally they pass 100% of the time. Re-enabling the tests and monitoring dashboard. TBR=wjmaclean@chromium.org Bug: 949683 Change-Id: Ib96a0562492372e2bc66e52fb2c65465beec84ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593641Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#656265}
-
Matt Reynolds authored
When PlatformEventController is initialized, it takes a handle to the current Document. In some navigation scenarios, the Document used to initialize the PlatformEventController is short-lived and may be shut down by the time the page has fully loaded. Attempting to use the shut down Document can lead to errors. NavigatorGamepad is a subclass of PlatformEventController. When NavigatorGamepad is constructed with a short-lived Document, it fails to properly initialize the PlatformEventDispatcher (GamepadDispatcher) if it passes the (null) LocalFrame associated with the shut down document. This CL modifies PlatformEventController::AddController to take a LocalFrame parameter to use instead of the frame associated with the possibly-stale Document. NavigatorGamepad is modified to pass the LocalFrame associated with the DOMWindow, which is not stale. BUG=949320 Change-Id: Ied380362eb26add5ef0c23195a9ba93bebb5f348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552410 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2f2fee059f6..e207b5651204 git log e2f2fee059f6..e207b5651204 --date=short --no-merges --format='%ad %ae %s' 2019-05-02 manojgupta@google.com cros_fuzz: Update tool to handle msan. Created with: gclient setdep -r src/third_party/chromite@e207b5651204 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2e344312c761b14c411dedc119f76433986663a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594092Reviewed-by:
-
Lukasz Anforowicz authored
History navigations might have |CommonNavigationParams::initiator_origin| that doesn't match spec expectations (i.e. they might use an opaque origin, rather than the original initiator origin). This issue causes https://crbug.com/946503 and now apparently also causes https://crbug.com/958421. This CL makes the following changes: - It adds a regression test for the CORB issue caused by |request_initiator_site_lock| calculated based on the incorrect |CommonNavigationParams::initiator_origin| - It fixes the CORB issue by reverting r635124, so that |request_initiator_site_lock| is based on the site URL (rather than on |CommonNavigationParams::initiator_origin|) for about:blank frames. Bug: 958421, 918967, 888079 Change-Id: Ibec66ac8cf6d4fddf2ebe0e911e3b5922131a90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593793Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#656262}
-
Daniel Murphy authored
In the current ScopesLockManager design, locks that were granted by the release of other locks (the async use-case) were temporarily owned by the task queue. This meant that even if you destructed all objects that held locks, the lock system could still have locks being held by SequencedTaskManager queue. This change splits up the lock granting into two pieces, a lock receiver and a closure which is called on lock granting. This allows the lock to always be held by the client, and makes the interaction between the lock system and system shutdowns / object destructions much more predictable. Doc: https://docs.google.com/document/d/1jX6OOQJ0aLrWAeqYLtARXPFawUlJPbHNIKAK-0vmFHU/edit?pli=1#heading=h.upsvliozchjx Bug: 862456 Change-Id: I0953c5f2025a3851750f7cdae621c4bf9326e645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590595 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#656261}
-
Matt Menke authored
new_tab.js was calling EncodeURIComponent on a full URL, only to have CoreAppLauncherHandler call UnescapeURLComponent() on the URL, to get the original result back. This is unnecessary, and not really correct, since UnescapeURLComponent() leaves certain unsafe characters escaped. This CL is part of an issue to clean up uses of UnescapeURLComponent(), as it's been used for wildly disparate uses, and much of its logic is only suitable for cases where we want to format a URL for safe display to the user. We also want to make it leave more weird characters escaped, but need to eliminate usage of it in other contexts before we can do that. Bug: 849998 Change-Id: I9c1aadecff32b1f5a592a6deb1ae73997a523b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593453Reviewed-by:
-
James Cook authored
This removes the client of the mojom::AXHost interface. Future CLs will remove the implementation. This must land after the shortcut viewer moves back in-process, otherwise it will break accessibility for that dialog. Bug: 958187 Change-Id: Ib993fd7eb76e33fa4b93657e0ae280c123282eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589669 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
Ryan Hamilton authored
Change-Id: Ic32a954422a0825392f76fa039dcff3e2c41890b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594063 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#656258}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71ee4b946e64..719163224a6f Created with: gclient setdep -r src-internal@719163224a6f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:920315 TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: Ib0a674f8fc964ae7e73dff09d305ba25776a4943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594094Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for ImageViewBase::Alignment enum class is more type safety. Bug: 940736 Change-Id: Ia5f7b5e8cb0d49ae070c85a861b878ce82e84c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587578Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
