- 12 Oct, 2018 40 commits
-
-
Xiaocheng Hu authored
This reverts commit 90115af8. Reason for revert: caused layout test failures on Android: * compositing/geometry/bounds-ignores-hidden.html * compositing/images/clip-on-directly-composited-image.html * crypto/random-values.html * crypto/subtle/importKey-badParameters.html Original change's description: > Layout test text dump rebaseline using Element.innerText part 1 > > This patch changes tests in the following directories to use > Element.innerText for text dump: > > accessibility/ > animations/ > battery-status/ > bindings/ > clipboard/ > compositing/ > crypto/ > > Most of this patch is mechanical rebaseline, except: > - Some LayoutNG-specific baselines become redundant and are > removed > - One test is turned into failure with LayoutNG flag due to > LayoutNG innerText bug with ellipsis (crbug.com/873957). > > Bug: 887148 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Idf28a2696b4824f3fd845c7392b588544e8de1d3 > Reviewed-on: https://chromium-review.googlesource.com/c/1239165 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599052} TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org Change-Id: I0018e928bd9789c95c2d923b35296f1f82fd41c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887148, 894841 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1278931 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599255}
-
Moe Ahmadi authored
Bug: 892220 Change-Id: I0aa186011149b4c53697fcfa0a62d3ee60dbe956 Reviewed-on: https://chromium-review.googlesource.com/c/1278885 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#599254}
-
François Beaufort authored
Change-Id: I0186fd20fc1d1e763208f5488917b65d24fa3e00 Reviewed-on: https://chromium-review.googlesource.com/c/1278786Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#599253}
-
Ulan Degenbaev authored
Original change's description: > [perf] Add browse:media:tumblr:2018 system health story > > This also add a login helper for tumblr and updates credentials.json > > Bug: 878390 > Change-Id: Iba56faf550cb638692899326b217347e04be9932 > Reviewed-on: https://chromium-review.googlesource.com/c/1256883 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596763} Change-Id: I45d738bf10b7fcc72a1d032785d4eba2727b5363 Reviewed-on: https://chromium-review.googlesource.com/c/1277789Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599252}
-
Katie D authored
This cleans up Autoclick code, resolving a TODO, by refactoring AutoclickControllerCommon into AutoclickController and eliminating the need for the delegate. Also makes AutoclickController into a concrete class, removing the need for AutoclickControllerImpl and improving readability. Bug: 876115 Change-Id: Id38917adc38aafcb4f4602e8827f0ad43d1f1dba Reviewed-on: https://chromium-review.googlesource.com/c/1277961 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#599251}
-
Tim Volodine authored
Add InterceptedRequest class, which represents an in-progress network request and allows to receive callbacks at certain points in the process and control the flow. This patch also adds code for the OnReceivedHttpError callback, which fixes the following tests: - org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testAfterRedirect - org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testForMainResource - org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testForSubresource - org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testNotCalledIfNoHttpError This patch in more detail: - add IntercepedRequest internal class - add code necessary for AwContentsClientBridge lookup - detect http errors and code for the onReceivedHttpError callback - update tests filter BUG=891722 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2123a30b0c9ea8c3f07c34adc0fedb6bc69ca8f3 Reviewed-on: https://chromium-review.googlesource.com/c/1259019 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#599250}
-
Xianzhu Wang authored
Bug: 703899 Change-Id: I3b19b91c5e74401e7ba576112d68f0adc9893aca Reviewed-on: https://chromium-review.googlesource.com/c/1277286Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599249}
-
Greg Kerr authored
This reverts commit 4173f201. Reason for revert: The dependent CL was reverted so this has to be reverted. https://chromium-review.googlesource.com/c/chromium/src/+/1278162 Original change's description: > Reland "macOS V2 Sandbox: Remove the feature flags." > > This is a reland of 5c4908e8 > > Original change's description: > > macOS V2 Sandbox: Remove the feature flags. > > > > The V2 sandbox is now default for all but the network and GPU processes > > on macOS. This CL deletes the feature flag. A new experiment will be > > introduced for the GPU process. The default case for the sandbox profile > > switch is removed, because previous CHECK() failures were confusing to > > diagnose. All profiles must now be handled explicitly, so Chrome won't > > build if a new profile type isn't handled. > > > > Bug: 749839 > > CQ-Depend: 1268671 > > Change-Id: I0860d3a5148b0085be6a99dc01c4971602ee5582 > > Reviewed-on: https://chromium-review.googlesource.com/c/1269996 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Mark Pearson <mpearson@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#598128} > > CQ-DEPEND=CL:1268671 > > Bug: 749839 > Change-Id: I91544907b640c572823f3aae3e29c0cfa003da51 > Reviewed-on: https://chromium-review.googlesource.com/c/1274888 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598822} TBR=avi@chromium.org,mpearson@chromium.org,kerrnel@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: I301c95634bd447d35ef19948cf0488c0bf847e58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749839 Reviewed-on: https://chromium-review.googlesource.com/c/1278861Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599248}
-
Owen Min authored
Bug: 894212 Change-Id: Icd4c7d9f8a79a9b57900366d4677b0e7023b8ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1274196 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#599247}
-
Sergey Poromov authored
PrintingAllowedColorModes - Launch in M70 (remove 'Future' flag) PrintingAllowedDuplexModes - Launch in M71 (remove 'Future' flag) PrintingAllowedPageSizes - M72 PrintingColorDefault - M72 PrintingDuplexDefault - M72 PrintingSizeDefault - M72 Bug: 853877 Change-Id: Ibda00ef02efc4dfc1f5b04079bb776f8b3e10f05 Reviewed-on: https://chromium-review.googlesource.com/c/1235675 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#599246}
-
Min Chen authored
The kAppType of browser based custom apps are set based on the |app_name|, which is not set for the internal apps like Settings and Discover. Rewrite it for these two apps in corresponding window manager to make sure both of them can have the correct app type now. calamity@ is doing a refactoring of the system apps here (https://docs.google.com/document/d/16CRTWFjU8Ohrn9aSTPuDJcbqh1z7E4wKwyEWstInRh0/edit#), which will fix all these related issues in long term. Bug: 877723 Change-Id: Iaaf9fb4998a1416bae4a8c6fa5582d1ff2235326 Reviewed-on: https://chromium-review.googlesource.com/c/1258090Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#599245}
-
Marc Treib authored
A small step on the journey to making sync-internals useful for investigating auth-related issues. Bug: 889844 Change-Id: Ifa84cdb4e0f418e89b5207d4ea3cb1cb7d31b382 Reviewed-on: https://chromium-review.googlesource.com/c/1278628 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#599244}
-
W. James MacLean authored
This suite of tests has been flakey for a *long* time on Windows, it's time to disable them until they are fixed. TBR=nyquist@chromium.org TBR=sky@chromium.org Bug: 882937 Change-Id: I383a959faeb2798a15ee0fe9c32a06c58af20573 Reviewed-on: https://chromium-review.googlesource.com/c/1278543Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599243}
-
Marc Treib authored
It's always set to the same value, and it's never actually read (apart from some DCHECKs). This also uncovered lots of IWYU violations which this CL fixes. Bug: none Change-Id: Idf98478d8fcf81f65ab42b7b9561de0ceff701dc Reviewed-on: https://chromium-review.googlesource.com/c/1276505 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#599242}
-
Daniel Bratell authored
When a different static char broke the build (for unrelated reasons), I looked through the tree for other static chars without const. This was the only other one outside third_party and tests. It's possible the generated machine code is the same, or it might become better this way. Depends on the compiler/linker/OS. Change-Id: I11a75cda4de25d468357f36e1afb23c79460ace8 Reviewed-on: https://chromium-review.googlesource.com/c/1278730 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#599241}
-
Morten Stenshorne authored
Remove some special-code to resolve the logical height of percent-based replaced content whose containing block was an out-of-flow object with auto height and non-auto top/bottom. This caused problems for LayoutNG, which typically hasn't stored the new heights on the containing blocks at the time of calculating the height of some child (so attempting to calculate anything based on the ancestor layout objects during layout won't work in NG). If we just remove the special-code, and fall back to calling ContainingBlockLogicalHeightForContent() further down, that method will honor the containing block logical height override (which NG has calculated and set before entering the legacy replaced content object). For legacy layout, we'll eventually bump into more or less identical (to what I'm removing here) special-code in AvailableLogicalHeightUsing() anyway. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I78636cce88bd66e625925b79e19183d4653f32fe Reviewed-on: https://chromium-review.googlesource.com/c/1278865 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#599240}
-
Jialiu Lin authored
SignInManager considers incognito profile as not signed-in. As a result, when user reuses their sync password in incognito profile, the reuse password type is mis-identified as OTHER_GAIA_PASSWORD. This CL makes incognito profile aware of its original profile's sync username such that sync password reuse detection can work correctly in incognito mode. This CL also makes it more explicit that Chrome does NOT save any password hashes if the user is in incognito mode to prevent leaking any browsing history to original profile. Change-Id: Ie4398a85e4a13045f418cebd38313bb32c4bb6fd Bug: 893715 Reviewed-on: https://chromium-review.googlesource.com/c/1273993 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#599239}
-
Ehsan Chiniforooshan authored
Bug: 894622 Change-Id: I89647c29faccb5654000a98cebabea92d9511618 Reviewed-on: https://chromium-review.googlesource.com/c/1278850Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599238}
-
Jonathan Freed authored
Change-Id: I1a5cca85ac14fcec14a6536b57d8bfa5db211fd6 Reviewed-on: https://chromium-review.googlesource.com/c/1277525 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#599237}
-
Tom Anderson authored
BUG=892351 R=jani.hautakangas@lge.com,msisov@igalia.com Change-Id: I422141bae3e10339cb38490a2a7acd1e3c66d339 Reviewed-on: https://chromium-review.googlesource.com/c/1269337Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599236}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e5455648879b..5bc30788fd8a git log e5455648879b..5bc30788fd8a --date=short --no-merges --format='%ad %ae %s' 2018-10-12 nsubtil@nvidia.com Fix gtest.h include in test/opt/pass_utils.h 2018-10-12 dneto@google.com Validator: TaskNV can use LocalSize or LocalSizeId (#1970) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5bc30788fd8a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I39e5edd7e673225b30bf060fa507f6fe8b2ab40c Reviewed-on: https://chromium-review.googlesource.com/c/1278722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599235}
-
Troy Hildebrandt authored
Certain ProtoDBPerfTests still consistently fail on Windows or are flaky because they take too long. This CL re-enables the disabled tests on Windows but they should now take 10% of the time they used to. Tested locally on Linux, the disabled tests that each took ~20s to finish now take under 2. The total running time of the entire suite locally was reduced from 390s to 49s. Bug: 879922 Change-Id: I620e5329c1ffef53b311f3a04524bafa8b749381 Reviewed-on: https://chromium-review.googlesource.com/c/1276772Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#599234}
-
Mohamed Amir Yosef authored
Lazy sunbscription information were stored in the default SharedPreferences file. However, the plan now is to store the queued FCM messages in SharedPrefernces as well. Therefore, it makes sense to use their own SharedPrefences file for that. Bug: 882887 Change-Id: Id78642f5c849c1458db04fdae8b85ceaf328fff6 Reviewed-on: https://chromium-review.googlesource.com/c/1264206Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#599233}
-
David Bokan authored
This patch adds methods to SimCompositor to allow ticking some basic impl-side animations. In particular, this is used in https://crrev.com/c/1205797 to play a browser controls animation from impl-side code. Despite the fact that SimCompositor supports only single-threaded mode, an impl animation can still be initiated. Though there is no "impl thread" on which the animation can be serviced, we can tick it by producing main frames using BeginFrame (the commit calls LayerTreeHostImpl::Animate). BeginFrame checks that a new frame is actually needed so this adds a plumbing to make this check work with changes coming from the "impl-side". Another wrinkle is that the browser controls animation was based on TimeTicks::Now; the start and end times are set from Now() and the incoming frame_time is used to interpolate a value between the two. This CL updates BrowserControlsOffsetManager to get the start time from the first frame time, allowing tests to use a mock clock. This works more like scrollbar and other animations but requires fixing tests that assumed the first tick would produce delta. We also add plumbing to pass viewport changes to Blink to allow the impl side changes to propagate to Blink through ApplyViewportChanges, since things can now change outside of the "main thread" side. The ScrollSnapTest change was necessary in a previous iteration of this CL when I made a change to the last_frame_time in SimCompositor. Though that change was undone in favor of fixing the animation start time in BrowserControlsOffsetManager, the changes in ScrollSnapTest are still desirable since they make dispatched events use timestamps that explicitly correspond to the frame times we use in BeginFrame. Bug: 861618 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I069268d1b3ae25003f62f3e9b9c2ad54245e402c Reviewed-on: https://chromium-review.googlesource.com/c/1270344Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599232}
-
Gyuyoung Kim authored
AccessibilityTreeFormatter::Create has been returning a raw pointer even though it's a factory function. Like other factory functions, it would be good if it also returns a smart pointer. Bug: None. Change-Id: I35fc4aa6fcf3d0f7adbeacd916e00efaff517f4d Reviewed-on: https://chromium-review.googlesource.com/c/1273177Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599231}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c12ec9ee. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25975 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Iacc4a934ed55a03a6fa514f65852e07165f4417c Reviewed-on: https://chromium-review.googlesource.com/c/1277604 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599230}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c34cf71d6017..62b1345c850d git log c34cf71d6017..62b1345c850d --date=short --no-merges --format='%ad %ae %s' 2018-10-12 kthelgason@webrtc.org Get rid of thread_darwin file. Created with: gclient setdep -r src/third_party/webrtc@62b1345c850d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2f00dbafda8810f87003f9f01763accd5d4d46d5 Reviewed-on: https://chromium-review.googlesource.com/c/1278716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599229}
-
Jordan Demeulenaere authored
Before this change, ElementExists was failing if more than one element matched the selector. After this change, ElementExists succeeds even if more than one element matched the selector. Bug: 806868 Change-Id: Icedb29c5c51a949fc6086211693723aa071689c1 Reviewed-on: https://chromium-review.googlesource.com/c/1275946 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#599228}
-
Matthew Jones authored
This patch is attempting to fix an issue that is causing the overflow menu to appear offscreen on certain HTC devices on Android N by increasing the margin between the bottom of the menu and the bottom of the screen. The thought is that the menu is originally positioned slightly offscreen and Android tries to reposition the menu; on some devices this is broken and positions the menu so it is mostly invisible. Bug: 894555 Change-Id: Idbb0b4b96e20586a4e15a876f485208504ce72c4 Reviewed-on: https://chromium-review.googlesource.com/c/1278289Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#599227}
-
Kevin McNee authored
Currently, a web page receives synthetic wheel events for touchpad pinch so that it may prevent the browser from changing the page scale and instead implement custom zoom behaviour. On Mac, in addition to the pinch gesture, a double-tap with two fingers on a touchpad causes a scale change. There is currently no way for a page to prevent this. Now, before applying a scale change from a touchpad double-tap, we offer a synthetic wheel to the page which it may cancel. Bug: 802369 Change-Id: Idc68c7d0992fa7bd2bdf29bf3357085276821434 Reviewed-on: https://chromium-review.googlesource.com/c/1237234Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#599226}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2cecd6e79600..9f8930395748 Created with: gclient setdep -r src-internal@9f8930395748 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I40083f597c320371c0bb843de2bf70c57d1f42ae Reviewed-on: https://chromium-review.googlesource.com/c/1278719Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599225}
-
Fady Samuel authored
With SurfaceRanges, clients will soon no longer need FirstSurfaceActivation messages in order to update fallbacks. The ultimate end state of this work is to save an IPC on scroll on Android when showing/hiding top bar controls. This should allow for a smoother scroll experience (yay!). This CL introduces a new parameter to RegisterFrameSinkId that allows the client to decide whether or not it's interested in FirstSurfaceActivation. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6a085f4ed910ef6997af67f63e47e85a05b41dd6 Bug: 893850 Reviewed-on: https://chromium-review.googlesource.com/c/1277375Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599224}
-
Kyle Horimoto authored
This CL enables several multi-device flags by default. This resulted in lots of broken tests, so this CL also fixes those broken tests. Instant Tethering is enabled via Finch flags; however, Finch does not immediately enable/disable features. Instead, when a user logs in, a Finch configuration is downloaded and is applied the next time the user logs in. Thus, to ensure that these features are available during OOBE, this CL overrides multi-device feature experiments during the first run. On subsequent logins, the Finch feature list will be applied. Bug: 884066 Change-Id: Ie12f3c62e766457456fd8a35e13168e6b35331ec Reviewed-on: https://chromium-review.googlesource.com/c/1260491 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#599223}
-
Mugdha Lakhani authored
exposed only to ServiceWorker context. Bug: 894448 Change-Id: Iebc55a247b519d573d8cd8c9bdc384b496614fb9 Reviewed-on: https://chromium-review.googlesource.com/c/1276848Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#599222}
-
Jordan Demeulenaere authored
Before this patch, we unsuccessfully converted the date as a timestamp in native before transfering it to Java side. This patch directly pass the different values of the date instead. Bug: 806868 Change-Id: I99b4aa6903bc36168a68a41d641ed0d0000f4ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1277655 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#599221}
-
Michael Giuffrida authored
Adds a new policy, AllowWakeLocks, that can be used to disable wake locks entirely. The existing AllowScreenWakeLocks policy merely demotes screen wake locks to system wake locks. If AllowWakeLocks is set to false, all wake locks should be disabled. Note that AllowScreenWakeLocks will now be ignored when AllowWakeLocks is set to false. Bug: 894645 Change-Id: I3d153801dcd9ed1f6fbf7339cdd4e7173552338c Reviewed-on: https://chromium-review.googlesource.com/c/1278347Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#599220}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: I1dd426d03ac459c627299b6a301c64f9e58002c3 Reviewed-on: https://chromium-review.googlesource.com/c/1274448Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#599219}
-
Cezary Kulakowski authored
Bug: 893616 Change-Id: I09d5d906c3cb2e075e142a36b3ebe9b6532eb11f Reviewed-on: https://chromium-review.googlesource.com/c/1271001Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#599218}
-
Eric Robinson authored
This replaces the specialized AfterStartupTask paradigm with a BEST_EFFORT task on the UI thread for the RulesetService, adjusting tests as necessary. Bug: 887407 Change-Id: Id93a5b77e1433281b5cdd49a3599463a61b41703 Reviewed-on: https://chromium-review.googlesource.com/c/1255343Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599217}
-
A Olsen authored
Network is by far the largest subdirectory of chromeos. This gives it its own BUILD.gn file. Also added a ":chromeos_implementation" config. Better to use a single config than a define each time, less chance for undetected spelling errors. Bug: 446937 Change-Id: I2f26cf3f9f15c4b4db364d7d2bc6cf5cc7e57887 Reviewed-on: https://chromium-review.googlesource.com/c/1276568 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#599216}
-