GitLab

In order to avoid a RecentTabsTableVC update everytime a tab is closed after
Closed All Tabs has been triggered, RecentTabs mediator stops forwarding
any update signals to its consumer (RecentTabsTableVC) while all close tabs
is taking place. Once this operation is complete it will tell its consumer
to update, thus only refreshing once per Close All Tabs operation.

Bug: 994229
Change-Id: I9eec07fada9863fbaae600ed1dc9675527c24681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860526
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707242}

Currently we assume search result score are in [0,1], which is not the
case for Drive files. This changes LogZeroStateReceivedScore to take
lower and upper bounds, and re-ranges them into [0,100].

While here, I've changed two calls to UMA_HISTOGRAM_COUNTS into
UMA_HISTOGRAM_EXACT_LINEAR, which is more aligned with what we want.

Bug: 1011221
Change-Id: If70fd8a184d24bd73ee29f580088c3a3c7de4df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858063
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707241}

Looks like ServiceWorkerStorage doesn't implement
ServiceWorkerVersion::Observer anymore.

Bug: N/A
Change-Id: I39852d7a41686863f5c1a48b6eb058362982a85f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866224Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707240}

I manually tested that 1013972 was fixed.

Bug: 1013972
Change-Id: If93c5a8e0486599060efb0b8d6b116f7082c4e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864565
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707239}

The h264 and vpx software encoder implementations the MediaRecorder uses
only support I420 as the input pixel format, so we need to explicitly
convert the GpuMemoryBuffer video frame for them.  The software encoders
mainly serve as a fallback mechanism and in most cases the hardware
encoders would be used instead.

Bug: 982201
Test: blink_unittests
Test: Disables hardware video encoder in chrome://flags and verify that
      the recorded videos in Chrome camera app are correct.

Change-Id: I76942d2681f9e3ab30c2502a24c2332f3c236bfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846423
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707238}

This reverts commit 23fa6714.

Reason for revert: Caused a regression around the port forwarding in Android due to wrong conversion. Let me revert this first to unblock beta release.

Original change's description:
> Convert base::Bind to base::Bind{Once,Repeating} in content/browser
> 
> This CL converts base::Bind to BindOnce or BindRepeating, and also changes
> relevant base::Callbacks or base::Closures to appropriate types.
> 
> This CL is split from https://crrev.com/1831621.
> 
> This CL was uploaded by git cl split.
> 
> R=​yangguo@chromium.org
> 
> Bug: 1007760
> Change-Id: Id6da42c61527457fcb365f49ce3561bc0fce3399
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849542
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705069}

TBR=yangguo@chromium.org,shimazu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1007760, 1014376
Change-Id: Iadb6008679b5ccfc6df8591f8bda3c9eb922d739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866339Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707237}

The current histogram buckets (http://shortn/_CI2Q9eMaXS) are too wide
to be helpful. This makes them exponential, with the success metric
being 50 buckets over 30 seconds and failure 50 buckets over 60
seconds.

Change-Id: Iae667ff36dca5ce402bf87447166174ba9e31a3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867293
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707236}

https://webrtc.googlesource.com/src.git/+log/86d053c2db6e..7bf8699dd1ce

git log 86d053c2db6e..7bf8699dd1ce --date=short --no-merges --format='%ad %ae %s'
2019-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1d5b803f..8a67b116 (707010:707122)

Created with:
  gclient setdep -r src/third_party/webrtc@7bf8699dd1ce

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I4f1e77a89b2d4afcdc88247782862da5b12a82f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868110Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707235}

This change improves the metrics for IPP Printer queries.

The result is broken up in to two separate boolean enums:
- Printing.CUPS.IppAttributesQueryResult captures whether we were able to
successfully query the printer.
- Printing.CUPS.IppAttributesSuccess captures whether the request for
attributes was successful, given that we were able to reach the printer


Bug: 1012437
Change-Id: If11ae1b03c3f2f76618d91eef8f49f1aefdb75d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864022Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707234}

When BrowserRootView is being destroyed, we shouldn't call callbacks from
DropTarget. It might be already destroyed.

Bug: 1001942
Change-Id: Id4a0550e1266e40822c6b77d6848e73432d07e2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849749
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707233}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org

Change-Id: I10fa95860e79cb9b7690cdde94bdc4dc39206173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868330Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707232}

Bug: 1013808
Change-Id: I3b16f6dc8d4cc6499c9eb596942f8c28c199a602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867851Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707231}

This PR makes the ImageToggleButton class fire a kCheckedStateChanged
event on state changes instead of kAriaAttributeChanged. This fixes an
issue where NVDA was not announcing the state change.

The kCheckedStateChanged event is also handled in
AXPlatformNodeWin::MojoEventToUIAProperty. We map it to
UIA_ToggleToggleStatePropertyId, which makes Narrator announce the
state changes as well.

Tested locally:

* Narrator works with --enable-experimental-ui-automation.
* NVDA works both with and without the experimental flag.
* MacOS VoiceOver works.

Bug: 1013835
Change-Id: I925aad65925aadc34468651198bed39c2ba8776a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861915Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sumit Sahrawat <Sumit.Sahrawat@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707230}

To record CORS related errors in both CORS modes, this patch
renames the CheckAccess to CheckAccessInternal, moves it inside
an anonymous space, then calls it from the new CheckAccess and
CheckPreflightAccess.

Bug: 1008693
Change-Id: Ib1a02e52470de89d082002213665464389b70ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864756
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707229}

This change add a fuzzer for the following methods:
* EncodeIndexedDBKey()
* EncodeIndexedDBKeyPath()
* DecodeIndexedDBKey()
* DecodeIndexedDBKeyPath()

Bug: 654810
Change-Id: Iadc850bdc750f0f1b80b7d70b90deed298ece808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857605
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707228}

[android] Report the highest private memory footprint of a renderer process after the first navigation start.

Also report the number of web pages (ie. Page::OrdinaryPages().size()) and the peak RSS when the highest private memory footprint is observed.

Design doc: https://docs.google.com/document/d/1TPL2DBEWP6goZJBYKmRyU-hP73etQ5nigjBbVx71kik/edit?usp=sharing

Change-Id: I0f732fb812ca9772745d273985d411e61d251817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687391Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#707227}

This change removes all the remaining "easy" cases in cbui. ~All of these are
simply static strings, or static strings returned by a
controller/model/delegate/etc. As such they aren't individually listed below.

Bug: 1011446
Change-Id: I7a004d84bb78cd3f1dc3458a6b80416f540bc94e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865401
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707226}

These histograms are extended
PasswordManager.LinuxBackendMigration.TimeIntoEncrypted
PasswordManager.LinuxBackendMigration.AttemptResult
PasswordManager.LinuxBackendMigration.Adoption
We are seen occasional failures, which may be related to the migration,
therefore we are keeping the metrics until we determine the cause.

These histograms are no longer being used
PasswordManager.LinuxBackendMigration.TimeIntoNative

Bug: 1006983
Change-Id: Ie9c98f0ae5bdbaa04ac1e2382e9b3c2986b16a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831812
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Auto-Submit: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707225}

Bug: 995543
Change-Id: Iabbb018ed0b2d2bcaab4e42436b9feae2c15fa31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855379
Auto-Submit: Bo <boliu@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707224}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/16af35606f4d..fcde3ba0a657

git log 16af35606f4d..fcde3ba0a657 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 erikchen@chromium.org Store up to 30000 packet log lines for git fetch.

Created with:
  gclient setdep -r src/third_party/depot_tools@fcde3ba0a657

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: Ic392c5fa823224b0fbf3ba4557402064836934f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867989Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707223}

This CL fixes a bug when scrolling from outside the root scroller
hierarchy. The root scroller is the "main" scroller on a page. On
Android, this can be designated on an element other than the document.
However, it's still possible to scroll a chain of elements outside of
the root scroller subtree. For example, from a sibling of the root
scroller or from a |position: fixed| element. In these cases, when the
scroll chains to the root, we still want to scroll the visual viewport
so that we support panning around if the user is zoomed in. We don't do
this on the main thread prior to this CL.

Typically, the VisualViewport is scrolled by using the RootFrameViewport
class. However, in this case we can't use it since that would cause
scrolling in the root scroller (and thus change behavior based on
whether the page is viewed using a UA that supports root scroller). This
CL adds a special case to Node::NativeApplyScroll. When we construct a
chain that doesn't end at the root scroller, we'll always add the root
LayoutView to the scroll chain. When scrolling it, we'll attempt to
scroll the visual viewport if the document itself can no longer scroll.

Note: we have an equivalent special case in
LayerTreeHostImpl::ApplyScroll where we can pass a bool to
viewport()->ScrollBy() to specify that we should scroll only the visual
viewport. This behavior is somewhat more natural in CC since the scroll
chain walks the ScrollTree which contains the visual viewport. Blink's
scrolling code assumes all scrollable nodes are DOM nodes which isn't
true of the visual viewport; hence the need to make this a special case
of the root document node.

This was implemented in CC in https://crrev.com/c/1752866. At the time,
it was assumed this case would be exceedingly rare on the main thread so
it was left unimplemented. However, fixing bug 1011866 will result in
this case becoming more common.

Bug: 977954, 1011866
Change-Id: I7d2d9cb70b66b54a8c972af4bdc6d69978fe690b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859940Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707222}

This CL adds metrics to records error type when doing inference.

Bug: 1006133
Change-Id: I30d1956cf409c5d13506d262678469c42ddd70f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851371Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707221}

This change marks obsolete UMA histograms for the SMS Receiver API.
Because the API no longer accepts timeout values,these histograms
are no longer needed. The code using these histograms have been
removed here [1] and are not expected to be used in the future.

[1]https://crrev.com/c/1783227

Change-Id: I492f26b4a4bc6a76c5901ab8b0082c791cd2638a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829565Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707220}

This patch removes ScrollingCoordinator::IsForRootLayer as well as the
declaration for ComputeShouldHandleScrollGestureOnMainThreadRegion. This
patch also fixes some minor typos and removes some unnecessary includes.

Change-Id: I500d77e657fcc0bf86d029ed4a50b5d3b4628ad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866872
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707219}

Fixed: 1015685
Change-Id: Ie5241e62ccf06c854a578634cda968a55c21ea80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867850
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707218}

- Add |alertStates| as property on |TabData|, sent from C++
- Move fade in and fade out animations out from CSS to JS to allow
wrapping them within Promises, so that TabElement can reliably tell
when there are AlertIndicator elements in the DOM.
- Fix tests such that SVGs load from chrome://tab-strip instead of
chrome://test.

Screencast in attached bug.

Bug: 1004983
Change-Id: I32cb6c91169646c244070826875a8317b8c9b296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861124Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707217}

https://chromium.googlesource.com/angle/angle.git/+log/5fcfcea4a937..6dee176c8d7d

git log 5fcfcea4a937..6dee176c8d7d --date=short --no-merges --format='%ad %ae %s'
2019-10-17 tobine@google.com Vulkan:Roll vulkan layers and headers

Created with:
  gclient setdep -r src/third_party/angle@6dee176c8d7d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@google.com

Bug: chromium:1011068
Change-Id: I27c4be48ff43a7fd293989e6c5fa4ac11870c517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867771Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707216}

Reading the directory-tree.js I see the following in a few tree item
classes derived from cr.ui.TreeItem:

 // Get the original label id defined by TreeItem before overwriting
 // prototype.

followed by identical code to label the derived cr.ui.TreeItem

By the time I'd read that 3 times I imagine we could improve the our
code health by ditching this clearly duplicated code.

Begin with a simple idea class TreeItem: a TreeItem that has a label
and createRowElementContent() helpers, used to provide the innerHTML
row content depending on mode FILES_NG_ENABLED or not.

In subsequent patches, we will use this class to label all tree item
classes derived from cr.ui.TreeItem, and shave off code lines.

Bug: 992819
Change-Id: I30867c20c80e000f7175aaaaf1bc3bf212ae6bfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866122Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707215}

Ensure that we don't cache pages which have in-progress navigations
in one of the subframes.

Together with already existing check for whether the frame is active
during navigation start this ensures that we never commit navigation
in an inactive frame.

R=arthursonzogni@chromium.org,lowell@chromium.org,alexmos@chromium.org
CC=nasko@chromium.org

Change-Id: I71e0b325dfefb9269af85b50c2617b7ab9a306af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860338
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707214}

Records the number of days since any origin in the redirect chain was
last visited according to the HistoryService.

Bug: 995437
Change-Id: Id044f4845e353187c01eb5464173836296d5eff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850419Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707213}

https://webrtc.googlesource.com/src.git/+log/e8b962bd3c97..86d053c2db6e

git log e8b962bd3c97..86d053c2db6e --date=short --no-merges --format='%ad %ae %s'
2019-10-17 mbonadei@webrtc.org Use source_sets in component builds and static_library in release builds.

Created with:
  gclient setdep -r src/third_party/webrtc@86d053c2db6e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: Ic7b919efcdac5840b2a0d5ebc782409d9c5b1bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867262Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707212}

Expand saved password protection experiment to add a flag
on whether or not to show a list of domains in the modal
warning and include a button to route the user to the first
domain that the password was saved on.

Bug: 1015671
Change-Id: I5e5343ea19258ff7fe54044cbdc17e85033edf23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867095Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707211}

In the previous patch, renderers are changed to take a command line
flag for deciding OutOfBlinkCors mode. But since the flag is passed
by chrome/ code, content_browsertests run without the required flag
even when the OOR-CORS is enabled. This potentially affects other
chromium content embedders and may cause confusing situations.
To solve this problem, I changed to use the combination of a flag
and the base::Feature. Fortunately, there are only two call sites
in the renderer processes, and it won't be so bothering.

This fix failed content_browsertests at linux-oor-cors-rel bot.

Bug: 1015289
Change-Id: I8835b0c328e23656114b4dfcb87286f6cd1d5455
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866372
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707210}

This method takes ownership of a View to use for the dialog's extra view
slot. This change also has the default implementation of
DialogDelegate::CreateExtraView return the view provided by
SetExtraView. It then migrates some users of CreateExtraView to use
SetExtraView, from their constructors if possible, by:

1) Moving their Foo::CreateExtraView method to a free function inside an
   anonymous namespace
2) Invoking it from their constructor, and storing a weak raw pointer to
   the created View if needed

Further CLs will remove other uses of CreateExtraView and eventually
remove it in favor of DialogDelegate pushing the extra view to
DialogClientView.

Bug: 1011446
Change-Id: If3a9f3ebe086122dc28b76c233193e7cfb4c0152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865597Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707209}

This CL adds UX for a few more WebProtect final states, as well as the
logic to trigger them. It modifies the shelf to show UX for deep scanned
files that were found safe, deep scanned files that were found unsafe,
and both kinds of DLP violations.

Screenshots:
https://screenshot.googleplex.com/3QZGfkEGXOK.png
https://screenshot.googleplex.com/eDfjOVJOzOw.png
https://screenshot.googleplex.com/nnsGgnS6E0z.png
https://screenshot.googleplex.com/cK1DzQjQ1wg.png

Mocks:
https://docs.google.com/presentation/d/1MH7zM5YiuCZr3jYsqkTJRC0cqtdo8wuWZOOQ66jptVk/edit#slide=id.g5d9bcde872_0_0

Bug: 980777
Change-Id: I1372fdd0395918a1352a1ecb22e01b6b301b8696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864876
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707208}

Do not cache a page if the main resource of its main document had
cache-control: no-store header.

Note that it's the only set of conditions that disabled bfcache.
Back-forward cache is still enabled in the following scenarios:
- no-cache directive
- no-store on a non-main resource (e.g. image)
- no-store on a main resource of a subframe.

This matches Safari's implementation of back-forward cache:
https://bugs.webkit.org/show_bug.cgi?id=140302

R=arthursonzogni@chromium.org,lowell@chromium.org
BUG=1014925

Change-Id: Ie1185462dc0420dc2a4b1b16f93b22a649bb67ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865337
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707207}

This componentizes the low-memory histogram provided by
AndroidMetricsProvider, leaving the rest in the chrome-layer class. This
renames the Chrome-layer class to ChromeAndroidMetricsProvider to
distinguish from metrics::AndroidMetricsProvider.

This registers the metrics provider with WebView. This does not add
integration tests because https://crbug.com/1011991 is still unresolved.

Bug: 1008534
Test: Manual - observe the MetricsProvider logic is called in AW
Test: out/Desktop/metrics_unittests --gtest_filter=*AndroidMetricsProviderTest.*
Change-Id: Ia8fed61c071f649032f40c6945c97a53e6544c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866270
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707206}

Currently, adding the synced user's birth year and gender to the
UKM report is only allowed for unittests. The feature isn't allowed for
browser builds that use the UkmService base class.

TBR=treib@chromium.org,eugenebutt@chromium.org,

Bug: 1010936
Change-Id: Icf81cfd3468cd53ce1fbe9e8f0ae252b59a21f3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835689
Commit-Queue: Vincent Boisselle <vincb@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707205}

Bug: 987646, 1015113
Change-Id: If62dfade0113e2502529339aef967304bd66f726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865423
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707204}

Bug: 829689
Change-Id: I525854254fd2e9fc2bad57c87ffdaa9175e452a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865740Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707203}