- 05 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a8b4e1acbd6..51916083e752 git log 0a8b4e1acbd6..51916083e752 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-05 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@51916083e752 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Id7d6b2a118f8616356a7e9dc2baad02cdb98730b Reviewed-on: https://chromium-review.googlesource.com/c/1317174Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605272}
-
Yuta Kitamura authored
This CL replaces the occurrences of "Platform::Current() ->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()" which has the same meaning. Also, this CL simplifies the code that assumes Thread::Scheduler() can be null, which is no longer true. Bug: 826203 Change-Id: I994db5b3be6e5e0f29cfe346dac15b49ca40394e Reviewed-on: https://chromium-review.googlesource.com/c/1314079Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#605271}
-
Anand K. Mistry authored
BUG=791396,855197 Change-Id: I4e4602e3748247c6bd0d1973c368467e1dc057fc Reviewed-on: https://chromium-review.googlesource.com/c/1309387 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605270}
-
BUG=762641 TBR=oshima@chromium.org Change-Id: Ia19d30eb1b996d3dfda03d8f12e3c227f6f46c60 Reviewed-on: https://chromium-review.googlesource.com/c/1317347Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605269}
-
Kunihiko Sakamoto authored
This reverts commit aa69df1c. Reason for revert: culprit for flakes of - SystemDisplayApiTest.SetDisplay (crbug.com/901586) and - HeadlessBrowserTest.CreateAndDestroyBrowserContext (crbug.com/901637) Original change's description: > Perfetto: Unify TraceEventAgent classes > > This unifies the Perfetto and non-Perfetto TraceEventAgent classes, so > that it's possible to use Perfetto directly even when it's not enabled > as the default TraceLog backend. > > Also moved the Mojo bindings of ProducerHost into a StrongBindingSet of PerfettoService > so they get cleaned up if the service gets shut down. > > Already reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541 > > Change-Id: I3070d69e92778de8e3b5e33957ab4f4694b782af > Reviewed-on: https://chromium-review.googlesource.com/c/1307998 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605060} TBR=oysteine@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901586,901637 Change-Id: I45f18d58e6355722c124ee753de5021e1d965da5 Reviewed-on: https://chromium-review.googlesource.com/c/1317298Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605268}
-
Kouhei Ueno authored
Bug: 803774 Change-Id: I259e29f1fc0423e87983d89ac50794cfb1fb3fca Reviewed-on: https://chromium-review.googlesource.com/c/1317218 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605267}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ad24595..fad38646 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I91b549d0c276abe50b547c96d814f768f35c237a Reviewed-on: https://chromium-review.googlesource.com/c/1317345Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605266}
-
Leon Han authored
This CL removes the typemapping of (blink.mojom.Referrer, blink::Referrer), a follow-up CL will remove the typemapping of (blink.mojom.Referrer, content::Referrer), after that we can move blink/public/platform/referrer.mojom into blink/public/mojom/. BUG=789854 Change-Id: I9acb000e5f64939cd5898954e85f4288e2a88678 Reviewed-on: https://chromium-review.googlesource.com/c/1317344Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#605265}
-
David Tseng authored
List items in Android settings are: 1. clickable 2. have no content description 3. contain text nodes (possibly multiple) Fixes: 1. never consider clickables as containers. ChromeVox has logic to descend into containers. For ordinary list items on the web, we usually want to treat them as containers because list items have arbitrarily nested complex structures (e.g. links, headings inside). 2. fix the computation of list item name. Previously, we only computed the name based on a tree walker that visits and stops descent into leafs or static text. Since clickables themselves are leaves, this stopped the walker from descending into the children of the list item. Bug: b:118842617 Test: manually on ARC++ settings. Regression coverage provided by browser_tests --gtest_filter=ChromeVox*.* Change-Id: I916c2a4187502c19d489e7c78e965523c05f6074 Reviewed-on: https://chromium-review.googlesource.com/c/1316095 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#605264}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. CircleFunctions => circle_functions EllipseFunctions => ellipse_functions InsetFunctions => inset_functions PolygonFunctions => polygon_functions BasicShapeInterpolationFunctions => basic_shape_interpolation_functions FilterInterpolationFunctions => filter_interpolation_functions This CL has no behavior changes. Bug: 889726 Change-Id: Ia5e4075c8d48b87a1a536f1d6715be999891a771 Reviewed-on: https://chromium-review.googlesource.com/c/1317416Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#605263}
-
Xiaocheng Hu authored
In some cases, we create anonymous block flow wrappers for float pseudo elements. Such wrappers should be skipped by TextOffsetMapping. Bug: 900906 Change-Id: I7f9ce5906ed8b2daaff3b0c9310e639d932ae5d0 Reviewed-on: https://chromium-review.googlesource.com/c/1315701 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605262}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34b7d6a21843..8cd3016c5e3b Created with: gclient setdep -r src-internal@8cd3016c5e3b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I773875d2b7d7fc4978101646917f6b70255df645 Reviewed-on: https://chromium-review.googlesource.com/c/1317357Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605261}
-
Yoshisato Yanagisawa authored
This CL fixes the following warning: W: 133, 2: Unused variable 'version' (unused-variable) Change-Id: I73a3eb3fe40b46196a2fbf014c398bd90e693ced Reviewed-on: https://chromium-review.googlesource.com/c/1317009Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#605260}
-
Takashi Toyoshima authored
This patch factors out allow/block list calculation logic into cors_util so that browser side list management code can reuse the same logic. Also this patch fixes some wrong tests, and refines access list management APIs among network::OriginAccessList, and blink::(Web)SecurityPolicy so that developers are not confused. Bug: 870172 Change-Id: I781b258e2f0ec7ad70065beda0f6eb96923cc690 Reviewed-on: https://chromium-review.googlesource.com/c/1309389Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#605259}
-
Anand K. Mistry authored
BUG=889703 Change-Id: I4482aa852393f4bdc67eaf8b5732f0b58e1974cf Reviewed-on: https://chromium-review.googlesource.com/c/1317211Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605258}
-
Tetsui Ohkubo authored
This CL removes all remaining old SystemTray related code. This is the part 3 of removing old System Tray code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray It's the last CL for this cleanup. TBR=oshima@chromium.org TEST=trybot pass BUG=898419 Change-Id: Ib64a3c31f0d63221f4289b8fe66e39c05ed2d83a Reviewed-on: https://chromium-review.googlesource.com/c/1307354 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#605257}
-
Wenzhao Zang authored
Bug: 871412 Change-Id: I5bf054ed6ef4c927253fbad4fe09ec674cc58d39 Reviewed-on: https://chromium-review.googlesource.com/c/1310559Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605256}
-
Matt Falkenhagen authored
All subclasses define their own RequestStillValid() already, so we can make it a pure virtual method. Change-Id: Ic5bf5deb40eb52e6f93733a5770b1e3f1761b91f Reviewed-on: https://chromium-review.googlesource.com/c/1317418Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605255}
-
sangseok.jang authored
InkDrop is handled before View::OnMouseEvent() in OnMouseEvent(). So, If I want to override the functions associated with InkDrop(ex : CreateInkDropHighlight()), there is a problem with not getting the something appropriate(ex. Button::STATE) Bug: none Change-Id: I8543a1354197a42478075b941671e5c0e59fc0b7 Reviewed-on: https://chromium-review.googlesource.com/c/1309561Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605254}
-
yoshiki iguchi authored
This CL adds the code to open the message center after unlocking if user clicks the inline reply button on the lock screen. We also need to focus the target notification but let me leave it to the separate CL. Bug: b/79951342 Test: manual Change-Id: I7d47e4064d0a85dc144d2895ae34c85789acf9d9 Reviewed-on: https://chromium-review.googlesource.com/c/1314022Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605253}
-
Leo Zhang authored
Bug: 888885 Change-Id: Ic5b8f4decbfb5508cc52bb7d3f4540d41bcdb185 Reviewed-on: https://chromium-review.googlesource.com/c/1312145 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605252}
-
Kouhei Ueno authored
Bug: 803774 Change-Id: I4ec00babc22db0d0efb96f8481d724e78ee73cca Reviewed-on: https://chromium-review.googlesource.com/c/1313712 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#605251}
-
Jia authored
We split user adjustments into two types: with or without prior model adjustments. Bug: 881215 Change-Id: I34c6084ef96cfcf81f97c0825951a340934c4557 Reviewed-on: https://chromium-review.googlesource.com/c/1312179 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#605250}
-
Xiaocheng Hu authored
This patch changes SelectionModifier to use non-canonical versions of Previous/NextWordPosition() to reduce usage of VisiblePosition(). Now that the canonical versions are no longer used, they are also removed by this patch. Bug: 657237 Change-Id: Ifa908bfb6bda948e78d4afc8171be55343eaa0ea Reviewed-on: https://chromium-review.googlesource.com/c/1315930Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605249}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5d6dd803..4ad24595 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9b81c05a56030eec85121d869479c10486204f73 Reviewed-on: https://chromium-review.googlesource.com/c/1317342Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605248}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46e156a4422d..34b7d6a21843 Created with: gclient setdep -r src-internal@34b7d6a21843 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6c720423a2bbbfe3ab424c8521b330f2d41df63b Reviewed-on: https://chromium-review.googlesource.com/c/1317356Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605247}
-
Kunihiko Sakamoto authored
TBR=hbos@chromium.org,hta@chromium.org Bug: 901711 Change-Id: I4ed1826e728cc777924ce4ab54050308db0bff31 Reviewed-on: https://chromium-review.googlesource.com/c/1316977Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605246}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b21e88ed6dd..0a8b4e1acbd6 git log 2b21e88ed6dd..0a8b4e1acbd6 --date=short --no-merges --format='%ad %ae %s' 2018-11-04 fmalita@chromium.org [skottie] Add support for explicit text line breaks 2018-11-04 reed@google.com remove empty devKern from SkPaint 2018-11-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@0a8b4e1acbd6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I0eb084784270bb0e79100a55f94c424ae9a89cc8 Reviewed-on: https://chromium-review.googlesource.com/c/1317170Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605245}
-
Hayato Ito authored
This is a kind of follow-up CL of https://crrev.com/c/1270596. It would be better to fix the root cause, instead of early return in JSBasedEventListener::handleEvent. Accessibility folks might want to look further to decide what we should do if event's target can't be set there. Bug: 892970 Change-Id: Ic2a14242c611133df68cfc3ec6e24cb9d20bf214 Reviewed-on: https://chromium-review.googlesource.com/c/1272937Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#605244}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib690418ad7f66fab003f7ddc8ca44e33faa2ae2d Reviewed-on: https://chromium-review.googlesource.com/c/1316599Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#605243}
-
Kunihiko Sakamoto authored
This reverts commit ea1a3ea1. Reason for revert: broke fast/canvas/canvas-composite-shadow.html on Win10. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/43023 Original change's description: > rebaseline SK_LEGACY_OP_COLOR_AS_BYTES > > This flag was repurposed... the real thing we're rebaselining > is https://skia-review.googlesource.com/c/skia/+/167264, which > affects situations with solid colors and unusual blend modes. > > Change-Id: I1da6486ca54d5f6c60bb0b04db05f6dc92487039 > Reviewed-on: https://chromium-review.googlesource.com/c/1316754 > Commit-Queue: Florin Malita <fmalita@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605216} TBR=fmalita@chromium.org,mtklein@chromium.org Change-Id: I1592f49dd54abd4da3f9abbd3d85cce40cddc5d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1317071Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605242}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: fast/files fast/filesystem fast/forms fast/frames Most of this patch is mechanical rebaseline, except that: - Some LayoutNG-specific baselines become redundant and are removed - Two LayoutNG-specific baselines are added due to LayoutNG doesn't include \u000C in Element.innerText while legacy does. Bug: 887148 Change-Id: Ie92bfd289ee494930896365f81efb54ebbb02424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1308253Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605241}
-
Kunihiko Sakamoto authored
This reverts commit 14c0b604. Reason for revert: Following tests are timing out - MojoCoreTest.SanityCheck - MojoCoreTest.BasicMultiprocess on MSAN bots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/12687 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9416 Original change's description: > [mojo] Add IPC support to core shared library > > Updates the mojo_core shared library so that it is actually suitable > for production IPC use. Namely: > > - MojoInitialize now spins up a background thread for I/O and gives > it to the core impl. > - A flag is added to Initialize(), allowing shared library consumers > to initialize themselves as a broker process. > - The thunks helper correctly loads the mojo_core library with > RTLD_DEEPBIND set, avoiding heap crossover within the core impl > due to e.g. malloc and free lazy-binding to different heaps > - Fixes the thunks header to compile as C once again, as it was > missing some struct keywords. > - Adds MojoShutdown to the core ABI as a necessary call for shared > library consumers who want clean shutdown. > > This also adds a new multiprocess test consuming the shared library > to tie together and validate all of the above changes. > > Bug: 809320 > Change-Id: Ic1c56d99c86fd4a2dc7f812ee152994ced35ece6 > Reviewed-on: https://chromium-review.googlesource.com/c/1306347 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605109} TBR=rockot@google.com,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 809320 Change-Id: I19816cf592bacd58dbb452cd32bea4df7a8077be Reviewed-on: https://chromium-review.googlesource.com/c/1317297Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605240}
-
S. Ganesh authored
Bug: 833687 Change-Id: I60ca6e5ef75a8dabbf9e15d5a10e2738fa83d303 Reviewed-on: https://chromium-review.googlesource.com/c/1295732 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#605239}
-
Luciano Pacheco authored
These 2 tests are flaky on MSAN and ASAN, disabling it them until they get fixed. Bug: 899664 Change-Id: I0ee7b0fd58731f47b03637f21a55f27254ae576b Reviewed-on: https://chromium-review.googlesource.com/c/1317210Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605238}
-
Zhuoyu Qian authored
Move: build/scripts/{ => core/css}/make_css_value_id_mappings.py build/scripts/{ => core/css}/templates/css_value_id_mappings_generated.h.tmpl This CL has no behavior changes. Bug: 732657 Change-Id: Ia914f52ca9b78d802d3994cc88f2731e66a2017e Reviewed-on: https://chromium-review.googlesource.com/c/1314015 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605237}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I95717738ae95c2cee3caa3ff75e43be068e02bc0 Reviewed-on: https://chromium-review.googlesource.com/c/1314075Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#605236}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d88f2e88..5d6dd803 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52658fe329b887822e7938e94d9c55fd170d544b Reviewed-on: https://chromium-review.googlesource.com/c/1316710Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605235}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ie763396344fb7b76a698636353e8a54c0bab3898 Reviewed-on: https://chromium-review.googlesource.com/c/1317296Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605234}
-
Sergei Datsenko authored
As now we have keepalives being sent from drivefs we don't need such a long timeout to detect stuck service. BUG=chromium:889732 Change-Id: I828c1e59fb889aba223f45d327cf68c4e5eaf37f Reviewed-on: https://chromium-review.googlesource.com/c/1309373Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#605233}
-