GitLab

Provide a "Enable tracing" option in the menu of the SystemWebViewShell,
to demo/test the new Tracing API functionality. This requires Android P
SDK which has been dropped upstream recently.

When "Enable tracing" is selected the tracing is started. The following
configuration is used:
- trace web-developer categories
- use continuous tracing i.e. a ring buffer

When the user un-checks "Enable tracing" in the menu the tracing is stopped
and the trace data is written to webview_tracing.json in the application
file directory. An alert dialog showing the number of bytes written is
shown upon completion.

Note:
The trace file can be pulled from the device using "adb pull" using the
relevant local directory, e.g.
$ adb pull /data/user/0/org.chromium.webview_shell/files/webview_tracing.json .

BUG=798101

Change-Id: I2a22fbf5f07f12e9c3eadfe9fb027c05b892c092
Reviewed-on: https://chromium-review.googlesource.com/1143820
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578633}

This reverts commit 453eba23.

Reason for revert: Failing Linux ASAN/LSAN bot: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939853423518476256/+/steps/chromeos_unittests/0/logs/ServiceConnectionTest.BindModelProvider/0

Original change's description:
> Add basic ServiceConnection unit test
> 
> The is just testing that ServiceConnection::BindModelProvider returns
> successfully. The Mojo invitation won't go anywhere beyond the no-op
> FakeMachineLearningClient D-Bus client.
> 
> To make this test compile, I had to fix an #include from an
> overlooked file rename in an earlier CL ...
> 
> Bug: 863794
> 
> Change-Id: Ifd31fea950145561cd5954ae16e930b801bfe49b
> Reviewed-on: https://chromium-review.googlesource.com/1139942
> Commit-Queue: Andrew Moylan <amoylan@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578329}

TBR=derat@chromium.org,rockot@chromium.org,amoylan@chromium.org

Change-Id: I9878dee8885c78f88c0af50e70e921861ab87663
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863794
Reviewed-on: https://chromium-review.googlesource.com/1152371Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578632}

This implements the discovery of BluetoothRemoteGattCharacteristics for
WinRT.

Bug: 821766
Change-Id: Iba0cbe9f7bae4d5a4403bd12193077ad57358387
Reviewed-on: https://chromium-review.googlesource.com/1136310
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578631}

Since it's been a week after pages in top_real_world_mobile were
refreshed, delete the old pages and their corresponding expectations.

Bug: 852530
Change-Id: Ic4d9cb9503fa22dd2b73735404a60c69e2a8a2ba
Reviewed-on: https://chromium-review.googlesource.com/1151104
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#578630}

Record the results of the task UKM recording to ensure that we are not
dropping tasks anymore (we used to do so for OOPIFs).

R=eseckler@chromium.org,holte@chromium.org
BUG=866169

Change-Id: I814bd8f71e9e2c0ba6de75f861cb46ca1119aa31
Reviewed-on: https://chromium-review.googlesource.com/1150226
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578629}

This reverts commit f3f5b838.

Reason for revert: Breaks official build: https://crbug.com/868258

Original change's description:
> Reland "[ar] Do not refer to ARCore shim in APK merger"
> 
> This is a reland of 58e4a081
> 
> Original change's description:
> > [ar] Do not refer to ARCore shim in APK merger
> > 
> > This hard-coding should no longer be required.
> > 
> > Bug: 839191
> > Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843
> > Reviewed-on: https://chromium-review.googlesource.com/1147706
> > Commit-Queue: Ian Vollick <vollick@chromium.org>
> > Reviewed-by: Richard Coles <torne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577662}
> 
> Bug: 839191
> Change-Id: I42c3d31c0cbe49c1fe2d68c55d0db18dcdc3381d
> Reviewed-on: https://chromium-review.googlesource.com/1151567
> Reviewed-by: Richard Coles <torne@chromium.org>
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578347}

TBR=vollick@chromium.org,torne@chromium.org

Change-Id: I1383b1330cb21619fe040ed420487fe33003101f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839191, 868258
Reviewed-on: https://chromium-review.googlesource.com/1152274Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578628}

ModelAssociationManager used to DCHECK that all DataTypeControllers are
in a NOT_RUNNING state. This apparently assumes that it receives freshly
created DTCs, which isn't actually the case: ModelAssociationManager
gets destroyed during Sync shutdown, but the DTCs don't, so if Sync later
starts up again, there's no guarantee that the DTCs are NOT_RUNNING.

While we're here, also replace some iterator-based loops with range-based
loops.

Bug: 856179
Change-Id: I6a14cbe1955df11aea1c8796ae44b637ff777e58
Reviewed-on: https://chromium-review.googlesource.com/1152922Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578627}

TBR=dpranke@chromium.org

Bug: 868180
Change-Id: Ic9cb48f82954f102f60dd3e1b9c29bcca209f3bb
Reviewed-on: https://chromium-review.googlesource.com/1152566Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578626}

Bug: 866899
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I9083c01776240859d0802ce0c09786a3d748daea
Reviewed-on: https://chromium-review.googlesource.com/1152485Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#578625}

Always submit a CompositorFrame on OnFirstSurfaceActivation even if
the fallback doesn't change.

Bug: 827242
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I560b5251a188eae2a83db384367e2201ffcce83b
Reviewed-on: https://chromium-review.googlesource.com/1152209
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578624}

Omnibox width was 10 characters (plus some extra for page actions and location bar bubbles), and is now 20 characters.

Bug: 849784
Change-Id: Iaacab5244b5f1c21156151f49e0405e844f09451
Reviewed-on: https://chromium-review.googlesource.com/1135147Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578623}

Change-Id: If91c0fe7a5aec868cca22a132c32e1b2344e5440
Reviewed-on: https://chromium-review.googlesource.com/1152921Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578622}

Replaces the custom backlink from V8->Blink that was using a v8::External with a
GC-aware backpointer that is encapsulated in the CustomWrappableAdapter
interface.

CustomWrappableAdapter establishes a link from a given JavaScript object to the
Blink object inheriting from CustomWrappableAdapter. The link is known to
garbage collectors and thus the Blink object will be kept alive as long as the
JavaScript object is alive. The adapter can be used to model liveness across V8
and Blink component boundaries. In contrast to ScriptWrappable, there is no IDL
definitions required and the JavaScript object must not escape to user-visible
JavaScript.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id9b6a046fd5e3f4c31ddf15894a9968701831e90
Bug: chromium:843903
Reviewed-on: https://chromium-review.googlesource.com/1145262
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578621}

When a tab is closed using a gesture (i.e. overscroll action or long
press on the TabGrid button), the non-incognito BVC was selected even
if it has no Tab.

This leads to an issue as the BVC is very briefly presented during this
time, before being dismissed. But the -viewDidAppear: call is executed,
which leads to a situation where the BVC is marked as "active" even if
it is not presented on screen. The -viewWillDisappear: call is never
made.

This CL fixes it by setting the main BVC as active only if it contains
tabs.

Bug: 849937
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I88f9a36247a7b5fc9ea34b686cc17850aca1615d
Reviewed-on: https://chromium-review.googlesource.com/1150533Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578620}

Instead of the deprecated argumentless Int32Value and BooleanValue
functions, it now uses the Context versions which return MaybeLocals.
Since this is for testing, we just force the results to their respective
types and crash if not possible.

Change-Id: I4a1b83640bdd64e3d7b81c5e21e1c8e0e89eb900
Reviewed-on: https://chromium-review.googlesource.com/1151987Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578619}

https://chromium.googlesource.com/catapult.git/+log/a1e31db3c6b7..787a378926fb


git log a1e31db3c6b7..787a378926fb --date=short --no-merges --format='%ad %ae %s'
2018-07-27 sadrul@chromium.org rendering: Add pipeline metrics.


Created with:
  gclient setdep -r src/third_party/catapult@787a378926fb

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855328
TBR=sullivan@chromium.org

Change-Id: Ia559efe708fe4426cdbdc09ac7b244abf21dba74
Reviewed-on: https://chromium-review.googlesource.com/1152616Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578618}

Since the titles of the infobars have been shortened, the information
about where passwords are saved for syncing users is now added to the
body of the save and update passwords infobars.

Bug: 866461, 862269
Change-Id: Ic1231b1d8daaaa4a7f53730540b79439121b3ab1
Reviewed-on: https://chromium-review.googlesource.com/1146759
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578617}

A change in when Skia calls glGenMipMaps() causes imperceptible image
diffs.

Bug: skia:8155
Change-Id: I176f6e68f6ff961f979311dbb9873ef1e7057283
Reviewed-on: https://chromium-review.googlesource.com/1152073Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#578616}

Various test APIs around IdentityManager currently DCHECK preconditions
when invoked (e.g., clearing the primary account DCHECKs that there is
a primary account). However, unittests for GCM that will shortly be
converted intentionally stress-test the system in various exceptional
ways, e.g., invoking the flow that the primary account was cleared when
there is no primary account. To accomodate porting those unittests
without having to reduce their coverage, this CL relaxes the constraints
on the relevant IdentityManager test APIs.

Bug: 798699, 809923
Change-Id: Ibe2db519d0e231ea707ad09b329d6abc6ad7a9d2
Reviewed-on: https://chromium-review.googlesource.com/1149864
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578615}

BUG=835860

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ide83ee27d1a888a08787b8726c0e5cc80fe80f03
Reviewed-on: https://chromium-review.googlesource.com/1148018Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578614}

Using wpt-import in Chromium 8d361113.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."
408f60ca "Remove Shared Worker WPT for WebUSB"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21781

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
meade@chromium.org:
  external/wpt/web-animations

TBR=robertma

No-Export: true
Change-Id: I52462748674d7db6eefa708e280ccf67bc5d99eb
Reviewed-on: https://chromium-review.googlesource.com/1152706
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578613}

Adds channel information ("stable", "beta", "dev", 'cannary") next to
the browser version.

BUG=chromium:849803
TEST=browser_tests --gtest_filter=*DeviceStatusCollector*

Change-Id: I30c4b78950ad1540169835bc4e295bc9ba0ea483
Reviewed-on: https://chromium-review.googlesource.com/1124162Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578612}

BUG=836871

Change-Id: I278b34cb305a13a029e84eaaeec57144e2858678
Reviewed-on: https://chromium-review.googlesource.com/1149364Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#578611}

https://pdfium.googlesource.com/pdfium.git/+log/aa418e541589..b3bab6ce43ca


git log aa418e541589..b3bab6ce43ca --date=short --no-merges --format='%ad %ae %s'
2018-07-27 art-snake@yandex-team.ru Parse obj nums range within Hint tables for shared groups.


Created with:
  gclient setdep -r src/third_party/pdfium@b3bab6ce43ca

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7ceedf4be65097d8869c4dac59137cbffb9fccf8
Reviewed-on: https://chromium-review.googlesource.com/1152615Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578610}

Building //media takes around 23 CPU minutes. A experimental
branch showed that this could be reduced, by using jumbo,
to around 9 CPU minutes. media/cast is the fourth largest part
of media and takes around 2 CPU minutes to compile without
jumbo.

This commit enables jumbo for media/cast.

Bug: 867350
Change-Id: Iaefb6e7ac95c1c7fab78478f879a8ba542f329d9
Reviewed-on: https://chromium-review.googlesource.com/1152807Reviewed-by: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578609}

Building //media takes around 23 CPU minutes. A experimental
branch showed that this could be reduced, by using jumbo,
to around 9 CPU minutes. media/filters is the third largest part
of media and takes around 2 CPU minutes to compile without
jumbo.

This commit enables jumbo for media/filters.

Bug: 867350
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I01fe34fb39b35bf1a95e893916c2fc49e59a6d9e
Reviewed-on: https://chromium-review.googlesource.com/1152808Reviewed-by: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578608}

Make sure that GetPacMandatoryFromExtensionPref() sets |*out|
whenever it returns true.

Without this fix, ProxyPrefTransformer::ExtensionToBrowserPref()
would proceed with reading an uninitialized variable.

Change-Id: I62bd8dcf7e173171dadd824787ea725c93a73eb1
Reviewed-on: https://chromium-review.googlesource.com/1151668
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578607}

While work on Android is on going, the remaining Viz failures on other platforms
have been resolved. The filter file is no longer needed.

This change removes it.

TEST=viz_content_browsertests

Bug: 794961
Change-Id: I46f8a7094aa10f72cf383607a8b7a68a19141fc8
Reviewed-on: https://chromium-review.googlesource.com/1150684Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578606}

When clearing the primary account, three behaviors are possible:
1. Explicitly remove all accounts.
2. Explicitly keep all accounts.
3. Let the signin code internally decide between 1 and 2 based on its
own default policy.

The IdentityManager test APIS (IdentityTestEnvironment and
identity_test_utils.h) currently support only 3. However, an upcoming
conversion will require 1 and 2. This CL adds that support in to the
APIS for clearing the primary account.

Bug: 798699, 809923
Change-Id: Idb717836c843a14a5f6d33aab5d60d7e14ff4d1c
Reviewed-on: https://chromium-review.googlesource.com/1149861
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578605}

Change-Id: I63eae05326391dcb2c62f571ac13650a6e2967b0
Reviewed-on: https://chromium-review.googlesource.com/1148210Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578604}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: If9283073cb46cbdb2b123b13695c1b7dc5b2c4a0
Reviewed-on: https://chromium-review.googlesource.com/1152887Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578603}

Bug: 864455
Change-Id: Ia71d2bc2360b3db4100643e62210401c9b6c7a2b
Reviewed-on: https://chromium-review.googlesource.com/1148451
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578602}

We want to decouple the code cache from the HttpCache and
recently added a separate code cache [1]. This cl adds
required support to fetch the generated code from the
code cache. There will be a followup cl that uses this
API and fetches from the code cache.

[1] chromium-review.googlesource.com/c/chromium/src/+/1120179

Bug: chromium:812168
Change-Id: I4972def83f05d2c6d5810f489704ffd9f1d1d536
Reviewed-on: https://chromium-review.googlesource.com/1150239
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578601}

Rebaseline some interfaces/properties that have been exposed in Chrome and
should also be exposed in Android WebView. In particular:
- attribute @@toStringTag
- method @@iterator
- attribute @@unscopables
- CSS* related interfaces/attributes

BUG=867450

Change-Id: Iee23c9f75fb3031826dfe388920a1ae6b3a9722e
Reviewed-on: https://chromium-review.googlesource.com/1150177Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578600}

Resolve errors on Chrome OS with opening Drive files whose file name
contains a valid URL-encoding like "%41.pdf".


Test: unit_tests --gtest_filter=ExternalFileURLUtilTest.*:FileManagerPathUtilConvertUrlTest.*
Bug: 850035
Change-Id: If4768ae07f82d722065601192d557eaea53b3f12
Reviewed-on: https://chromium-review.googlesource.com/1151172
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578599}

This reverts commit bfc33b7c.

Reason for revert: The work for UKM is done in a separate CL, so this is no longer needed.

Original change's description:
> [unified-consent] Add shutdown information for the UrlKeyedDataCollectionConsentHelper.
> 
> This CL adds methods that handle the shutdown state for the
> UrlKeyedDataCollectionConsentHelper. This is set when the dependent sync
> service is shut down.
> 
> Bug: 867388
> 
> Change-Id: Id6f948bc0aa1a55ec2943590a5f77cd179b65e3f
> Reviewed-on: https://chromium-review.googlesource.com/1148564
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578242}

TBR=msarda@chromium.org,bcwhite@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 867388
Change-Id: If3978f977afcb9ea1997bdde1b7220f56a271bbb
Reviewed-on: https://chromium-review.googlesource.com/1152847Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578598}

Rearrange ReceiveMore and SendMore, so that we check MOJO_RESULT_SHOULD_WAIT
before !MOJO_RESULT_OK. This CL adds three unit tests that pass
with or without the change.

Bug: 721401
Change-Id: I6b132b2399f9091374d037d890d7ca98ba358445
Reviewed-on: https://chromium-review.googlesource.com/1150428Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578597}

When building using jumbo, files get merged and functions and
variables with the same name may end up in the same namespace
and conflict. This happens in:
media/cast/net/cast_transport_impl.cc
media/cast/net/udp_transport_impl.cc

Since the functions and variables are identical they are
moved to a common util file.

Bug: 867350
Change-Id: I08747781d56b78e9a8783bfec870c7084183062a
Reviewed-on: https://chromium-review.googlesource.com/1152738
Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578596}

Currently VideoEncodeAccelerator::Initialize() does not take level into account
which is a factor of AVC encoding. Instead, it always set the fixed level in
VEA implementation. For upstream Android CTS, it requires AVC level setting and
checks the level of output encoded stream is within configured one. To satisfy
this we need to pass level on initialization.

Since there is a bunch of parameters we decide to refactor VEA::Initialize() to
use Config struct bundling all parameters as VideoDecodeAccelerator did.

This CL only modifies VEA::Initialize() API to use Config struct as input to
cover original parameters and output_level. Once this is approved to change, we
will implement the utilization of output_level inside VEA.

BUG=b:110811755
BUG=863321
TEST=build and deplot chrome on eve
TEST=build and run video_encoder_accelerator_unittest on eve
TEST=build media_unittests
TEST=build content_unittests

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I002169634a2b2d23a00178eb5015a14f4ddcf5dc
Reviewed-on: https://chromium-review.googlesource.com/1130570
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578595}

When building using jumbo, files get merged and functions
with the same name may end up in the same namespace. This
happens with the functions InProgressFrameEncode defined in:
media/cast/sender/external_video_encoder.cc
media/cast/sender/h264_vt_encoder.cc

This commit solves the issue by renaming the functions
to something more file specific.

Bug: 86750
Change-Id: I8f6fb84783539dcec4aae824bb971e982b4db5c2
Reviewed-on: https://chromium-review.googlesource.com/1152745
Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578594}