- 08 Dec, 2020 40 commits
-
-
Jonah Chin authored
SharedImageRepresentationSkia Local OOPR Canvas tests revealed an issue when uploading YUV video frames to the GPU. When provided a mailbox representing a YUV plane, RasterDecoderImpl::DoWritePixelsINTERNAL() fails because Skia does not allow wrapping these formats in SkSurfaces. To combat this, this CL introduces a new version of SharedImageRepresentationSkia::ScopedWriteAccess that works directly with an SkPromiseImageTexture rather than an SkSurface. Bug: 1115217 Change-Id: I63e3f0e74f6bb42642545516407ede42279e9bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528695Reviewed-by:
Jonah Chin <jochin@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834864}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf980426002..26a24ee9aeb 2020-12-08 primiano@google.com Add PERFETTO_EXPORT to CloseFile fwd declaration 2020-12-08 primiano@google.com Add missing includes for Windows build 2020-12-08 primiano@google.com Fix mismatching signature in base::OpenFile 2020-12-08 primiano@google.com Fix chromium roll 2020-12-08 primiano@google.com base: Move OpenFile to file_utils.h and fix IWYU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174454879 Change-Id: I0eff5233f3419cb5901e509609ea45055d67f5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577783 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#834863}
-
dpapad authored
This minor refactoring of the chrome:extra_resources" target leads to better encapsulation, and more importantly relieves build/OWNERS from having to review trivial/mechanical CLs that could be reviewed by chrome/browser/resources/OWNERS. Bug: None Change-Id: I2eeeb812099a4dfeb88aecda42c0453c9c2993ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578712 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#834862}
-
Patrick Noland authored
This change moves keyboard visibility manipulation to UrlBarCoordinator, shifting setKeyboardVisibility and setSoftInputMode. It also shifts the implementation of AutocompleteDelegate to LBCoordinator, re-ordering some methods as a result. Change-Id: I6465891fe67edbacef87692bce1bfa982023cc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569434 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#834861}
-
John Lee authored
Bug: 1142082 Change-Id: Ibdadd23bb877fdbbe63dd499a80e0969aefbe7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577891Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834860}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4c2c0ae8a65324b022a4dc3a23cfa12b5f47596d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580278Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#834859}
-
Nina Satragno authored
Request handlers were DCHECKing on AuthTokenRequester HavePINUVAuthTokenResultForAuthenticator callbacks that the authenticator had been selected. However, this is not the case for pre-touch errors. This patch moves the DCHECK after handling those, and adds request handler tests. Fixed: 1154859 Change-Id: I8475c597c1bc10666c970626eee14dc55de32d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577868 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#834858}
-
Ben Pastene authored
Adding these to a test's isolate will allow folks to symbolize crash dumps from tests with only the test input & a crash .dmp file. Note that it's not necessary to add these to the test isolate since the test itself won't use them. (These tools could be built locally by hand instead.) It's merely a convenience since the test isolate would have to be downloaded locally anyway to retrieve the outdir symbols. This should have minimal impact on test compile time (since dump_syms and minidump_* binaries are pretty simple) as well as test isolate size since those binaries are also fairly small. Bug: 1155738, 1156772 Change-Id: Iaaa47299edb1c592ba3b143408454fe9c271604a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576076 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#834857}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e05f7b914762..e2c30849a21d 2020-12-08 tsepez@chromium.org Fix longstanding typo in bug_481363.in If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I04cc23562ee6043ab945d4ec7a956cc9acaf1c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834856}
-
Li Lin authored
Migrate to Gaia reauth endpoint for supervised user. Handle message "removeUserByEmail" triggered by the button on the deleted user page: - If the removed user is the device owner, trigger powerwash. - Otherwise, remove the user locally. Bug: 1115203 Test: manual Change-Id: I9ac37359b68acb3038d9b451926af267d584a27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506613 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834855}
-
Rob Clark authored
Needed by mesa, for a similar reason as the amd gpu sandbox BUG=b:174909812 TEST=gpu process does not crash Change-Id: I6c82f4371f354e2bd16625c47a9893fb39bd4a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576942 Auto-Submit: Rob Clark <robdclark@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#834854}
-
Vladimir Levin authored
Since we pass this node as a reference, we need to ensure that it isn't null. This is a speculative fix for the referenced bug. R=aleventhal@chromium.org Bug: 1156599 Change-Id: I117910cd1304c61f7accea1b70fca92c75ece647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579943Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834853}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/61355d416d9c..30805557e651 2020-12-08 enga@chromium.org Enable use_tint_generator w/ test suppressions for SPIR-V based backends 2020-12-08 rharrison@chromium.org Fix issues with roll into Skia 2020-12-08 cwallez@chromium.org Rename TryConvertAspect to better reflect what it does. 2020-12-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from b8a3078bbec9 to 195917c0be32 (17 revisions) 2020-12-08 stha09@googlemail.com use cstring instead of string.h 2020-12-08 stha09@googlemail.com GCC: fix template specialization in ObjectContentHasher If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I36597fcaff5c9fee9f830c70aee55f24652b3a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579765Reviewed-by:
-
Aaron Leventhal authored
DCHECK Occurs when running test in a11y FYI bot, which uses --additional-driver-flags=--force-renderer-accessibility. Bug: None Change-Id: Ia7764492cb1aa171197b0f7e6ac7a6011aa15f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577703Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Yi Gu authored
The verification backend may be unavailable for some reasons. In most cases we will fall back to the user consent backend but occasionally we need to cancel the request. Regardless, we want to measure how often this happens and why. Bug: 1127397, 1141024 Change-Id: I7e8e92878c100d20df012705ef3b944e2ad3ae64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572956Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834850}
-
Josh Nohle authored
When the existing flag CryptAuthV2DeviceActivityStatus is enabled, we receive two piece of information from the server about each device: - the Bond last active time and - a connectivity status (online vs. offline). Previously, when the CryptAuthV2DeviceActivityStatus flag was enabled, the multi-device dropdown list was sorted with all online devices first (sorted by last activity time) then all offline devices (also sorted by last activity time). However, there are two issues with using the connectivity status to sort: (1) The connectivity statuses--as well as the last activity times--are only retrieved at sign-in or when new devices are synced down via a DeviceSync. A mildly stale last activity time is acceptable, but a stale offline status could be very misleading, especially because an "(offline)" label is displayed in the dropdown list. (2) During testing, even when forcing a connectivity status retrieval, we noticed that the connectivity status might not be accurate. In this CL, we put use of the connectivity status behind a flag: CryptAuthV2DeviceActivityStatusUseConnectivity. When enabled, online devices are sorted before offline devices, and offline devices are labeled with "(offline)" in the dropdown list. When disabled, the connectivity status is ignored during sorting, and no connectivity labels are applied in the UI. For example, say the Samsung Galaxy has a more recent Bond last active time than the Pixel, and the Pixel is online whereas the Galaxy is offline. The UI will appear as follows with CryptAuthV2DeviceActivityStatus enabled: CryptAuthV2DeviceActivityStatusUseConnectivity disabled (default): https://screenshot.googleplex.com/4cRYc5UXiAHMSyE.png CryptAuthV2DeviceActivityStatusUseConnectivity enabled: https://screenshot.googleplex.com/AeqyvBcA29meeyN.png This allows us to enable the CryptAuthV2DeviceActivityStatus flag to use the Bond last activity time to sort the dropdown list, while disabling the CryptAuthV2DeviceActivityStatusUseConnectivity flag. This immediately improves the dropdown experience without worrying about stale connectivity statuses. Manually tested with two eligible host phones, adjusting their last activity times and online/offline states, and going through multi-device setup. Bug: 923594 Change-Id: I19d08232d7d0f35b3b430793f22a4aac07d9b5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577632Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#834849}
-
Vincent Boisselle authored
Bug: 1156169 Change-Id: I9e8510b879663354b767e2a2b4c6c38b0f8f1499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576622Reviewed-by:
-
Michael Thiessen authored
Migrates all remaining ActivityTestRule usage to BaseActivityTestRule, which is more flexible and fixes various issues with ActivityTestRule. This change also bans the usage of ActivityTestRule so that more unintentional usage doesn't creep in. Bug: 1146574 Change-Id: I67f9427b8b637d36589f7d06e5cde51c8a50caa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527770 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834847}
-
Moe Ahmadi authored
Fixed: 1078677 Change-Id: I4534a9a2834d8de4d7cb692e0d19ed648d686429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568354 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#834846}
-
Ionel Popescu authored
In order to test multiple input events being fired, the input element should be disabled async. Bug: 1148986 Change-Id: Ia49f78c38ec459e6237a9e6171dcf64239363a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578707Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834845}
-
Rakib M. Hasan authored
Yesterday the refresh-weblayer-skew-tests recipe failed because of of error which was fixed in crrev.com/c/2577952. This CL updates the binaries skew tested. It also removes redundant test suites which skew test an older version of M88. Bug: 1147459, 1099017, 1041619 Change-Id: I1cc49a66ae457a3283bdc3439f4e7d1966ee1bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580441Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#834844}
-
Becca Hughes authored
As part of our security review we were asked to split the KaleidoscopeDataProvider interface into two to reduce the attack surface from the NTP. BUG=1114862 Change-Id: Ie37472dfcda44cbea00b3e5b9b610b485d41d5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577899 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834843}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser. Bug: 1113033 Change-Id: I998057216aba1f64121847848308f07b5b8e1e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578156Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#834842}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1742f98791c9..c1fbb82f9e23 2020-12-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ic6acadb5db5c881d35f924877b900cddfbb0612b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579767Reviewed-by:
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I3f29622a021b2ffd73f91d81fa690553af87594e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577831Reviewed-by:
-
Will Harris authored
This reverts commit 6a60c787. Reason for revert: causing crashes BUG=1132179 Original change's description: > Reland "Add dbghelp.dll to delay load list" > > This is a reland of 4edc0503. With > the fix in clang for the delay load crash previously hit with this > change I am relanding this. > > Bug: 1132179 > > Original change's description: > > Add dbghelp.dll to delay load list > > > > Currently, many of the binaries have a static dependency on dbghelp.dll. > > This results in dbghelp getting loaded in all chrome processes. Upon > > inspection, dbghelp.dll is only necessary for stack sampling and mini > > dump handing in crashpad. Stack sampling is only enabled by default on > > unofficial builds of dev and canary. All other times we are needlessly > > loading this module which brings in 300k of image file refset and 60k > > of Copy on Write costs per process. This change adds it to the delay > > load list. > > > > Change-Id: I13da0ce0735431c5c51cdbc9ba2cfea0cc3cded7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336541 > > Commit-Queue: Chris Davis <chrdavis@microsoft.com> > > Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796707} > > Change-Id: I5f946d76af853c2d277f670b99479e874e784f44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523245 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com> > Commit-Queue: Chris Davis <chrdavis@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#832526} TBR=thakis@chromium.org,brucedawson@chromium.org,cliffsmo@microsoft.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,chrdavis@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132179 Change-Id: I0d340b2853f5d67b8ddc080450a10c1f93e38b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579985Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#834839}
-
Dominique Fauteux-Chapleau authored
TBR=jrw@chromium.org Bug: 1156767 Change-Id: I213f0d5776002d8ef6931ff564ad109e6e0bc052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580299Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#834838}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607428729-5d7fb4cc4f483e4100008e013fc190caf99a5621.profdata to chrome-mac-master-1607450253-216f09df6b61ffe8dbd79a2c1e7354b5e42173e1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia124019516452d74a0afc378f5ddb3691453d5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580301Reviewed-by:
-
Dominic Farolino authored
kMBIMode is a feature that enables Multiple Blink Isolates work, which introduces a new scheduling boundary in the render process: AgentSchedulingGroup. What this CL sets out to solve: For MBI, we'd like to have some include-only bots that we can request to run "all of the tests" that a normal CQ bot would run, but in MBI mode (with our feature enabled). It's basically a substitute for us uploading a dummy CL that enables our feature and running the try bots to see what would fail. After speaking with hypan@ and I think indirectly, fergal@, the suggestion to use what bfcache is doing was made, that is, to set-up a recipe like [1]. However it appears that in order to set this kind of bot up, you would have to manually specify all of the test targets in the config. That might be worth doing, but since MBI makes some pretty fundamental changes, it would be best to run *all* the tests that a normal CQ bot would run on the waterfall. After speaking with hypan@ about this, he mentioned the simplest (only?) way to do this would be to make the feature controllable via gn args, and create an mb_config that applies the gn arg like: https://chromium-review.googlesource.com/c/chromium/src/+/2399129/4/tools/mb/mb_config.pyl#2772 Then we'll be able to reuse the default configs that the other waterfall bots use. For example, [2] uses [3]. [1]: https://source.chromium.org/chromium/chromium/src/+/master:testing/buildbot/chromium.linux.json;l=12199;drc=073d5574fa06b002a5a9754ff24c8e72cac779ea [2]: https://source.chromium.org/chromium/chromium/src/+/master:tools/mb/mb_config.pyl;l=1283-1285;drc=f64c223e2408d61250660c221d3f26ad28ec9060 [3]: https://source.chromium.org/chromium/chromium/src/+/master:tools/mb/mb_config.pyl;l=2792-2798;drc=f64c223e2408d61250660c221d3f26ad28ec9060 R=kinuko@chromium.org Bug: 1154360 Change-Id: I71eb06b9d63699e8774b5d8fc9abc75e89f05a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577593Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tal Pressman <talp@google.com> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#834836}
-
Alexander Surkov authored
File names has to match class names. Also see discussion at goolge accessibility mailing list, https://groups.google.com/u/1/a/chromium.org/g/chromium-accessibility/c/JvecMcj8thw Bug: 1133330 Change-Id: I8c09211b9705f56c3d4d29b6403cbde0e2f10c70 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566633 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Josh Karlin authored
Change-Id: I8d2eccaa5352291b589043a3fcb0575ea82bc242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580319Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834834}
-
Dominic Mazzoni authored
The --pid argument is used for both pids and hwnds now, and the Chromium scripts should look for Chromium in the window name and not Google Chrome. Bug: none Change-Id: I36e41413684d9a93a0f2b7573172bbeef2e46f89 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577925 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Vladimir Levin authored
When we do a EnsureComputedStyle in a display none subtree, we are not in a style recalc but we still call SetRequestedState on a display lock context. This means that we should not dirty style, but rather rely on style adjustment for children to take the dirty bit information. The testcase for this is in https://chromium-review.googlesource.com/c/chromium/src/+/2575815 which DCHECKs without this patch. R=aleventhal@chromium.org Bug: 1147481 Change-Id: Iaa24945f4ad44e73d0bf79ec757ad79b7081af9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579523Reviewed-by:
-
David Bertoni authored
These tests were previously disabled for flakiness, but they passed 3000 iterations on the bots with no flakes. Bug: 1132581 Change-Id: I954734c79a1b46829830257dadc04e7a8177ce2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568897Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#834831}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9d73bd8981e..12b3841881bd 2020-12-08 changhaohan@chromium.org Fix flashing metrics widget when changing nodes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieae68ab5ee6c29945aa143dfa4622015e6a0e4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579025Reviewed-by:
-
Yulun Wu authored
Bug: 1156265 Change-Id: Ie422fd32cf651b6e0524425c7eae7f10f56271e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577894Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834829}
-
Dominique Fauteux-Chapleau authored
TBR=jrw@chromium.org Bug: 1156754 Change-Id: I85af0e5b94b65be15392329d3fc11831530dac67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579724Reviewed-by:
-
Jenny Zhang authored
Bug:1149452 Change-Id: If2defff6b2e1274a22b354e6d1563f77ec1c3004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577996Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834827}
-
arthursonzogni authored
I found something interesting. The initial empty document's javascript windows is reused for same-origin new document. We apply the sandbox flags to the window, instead of documents, which is very weird. My hypothesis: we are enforcing sandbox_flags twice into the same window. The bug might be caused by the remanence of the initial sandbox flags? This turned out to be the case. \o/ This patch adds a WPT test. It triggers a DCHECK in the browser process. Bug: 1041376 Change-Id: Ic7543148b0c2571e95c0c4dfe6df50563254981b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578957 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#834826}
-
Andre Le authored
Add MultiDevice.SecureChannel.Nearby.ConnectionResult Bug: 1106937, 1150634 Change-Id: I24a807a5de0e9322ae9e53ed6bf6290f0fa30861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575516 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
-
