- 27 Aug, 2018 40 commits
-
-
Steven Valdez authored
Bug: boringssl:226 Change-Id: I9541ae612322776a7ccddd8e163ab3025dba1e7a Reviewed-on: https://chromium-review.googlesource.com/1188849Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586260}
-
Stephen McGruer authored
The addition of CSS filter properties as animatable values caused not one, but two Persistent reference cycles (where we went from garbage collected classes to non-garbage collected classes and back again). The two cycles are documented in crbug.com/821547#c24 and crbug.com/821547#c28 This CL fixes the reference cycle by making everything in the above chains GC'd. Bug: 821547 Change-Id: I49133875f8a476da1d45cd715d90b74783b15a4f Reviewed-on: https://chromium-review.googlesource.com/1060693 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586259}
-
Balazs Engedy authored
Previously, it was gated on a command-line option which cannot be controlled via field trials. Also, enable the feature on continous build. Bug: 847985 Change-Id: I07ae0a7ef372b27309017da538f1dd4f85a9e3e3 Reviewed-on: https://chromium-review.googlesource.com/1187157Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#586258}
-
David Davidović authored
Refactor Nigori to better isolate the key derivation implementation. Add a function for scrypt-based key derivation, based on SymmetricKey::DeriveKeyFromPasswordScrypt, but do not expose it externally. Since the new functionality is not yet exposed, no unit tests for it have been added. Bug: 875931 Change-Id: I2bf1649e80fdeec4b44ac64034f246444b4a6d8b Reviewed-on: https://chromium-review.googlesource.com/1181903 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#586257}
-
Sylvain Defresne authored
Pass the PrefRegistry as a PrefRegistrySimple to the static method registering the properties as they are not synced. This allow calling the helper method in the tests instead of manually registering the properties. Fix include what you use in the factories. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaaad21d0a3cfe8278fb08a8c32dd890c0eb29a91 Reviewed-on: https://chromium-review.googlesource.com/1187145 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#586256}
-
Owen Min authored
Platform policy should be in the machine level as it applies to all profiles. Change-Id: Idc5bab84d31cb577299c689ca27e75a68e87441b Reviewed-on: https://chromium-review.googlesource.com/1188892Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586255}
-
Henrik Grunell authored
Removes false positives. Bug: 830624, 826664 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2be987f17cae4200146f565374c63dcb411345c2 Reviewed-on: https://chromium-review.googlesource.com/1188137Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586254}
-
Marc Treib authored
Supervised user creation has been gone for a long time, so these aren't necessary anymore, and were never supplied (outside of some tests). TBRing a whole bunch of trivial call site updates (i.e. not passing an empty string as supervised_user_id). TBR=jochen Bug: 828890 Change-Id: I45bb13111960b5c8b39a13b8368df1749fcfaa6d Reviewed-on: https://chromium-review.googlesource.com/1188570 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, if the only method of payment available was a payment handler that is not yet installed, but is available or installation Just-In-Time (JIT), then PaymentRequest.canMakePayment() would return "false". This prevented JIT installable payment handler usage by merchants that don't call PaymentRequest.show() unless PaymentRequest.canMakePayment() returns true. This patch makes canMakePayment() return "true" for JIT installable payment handlers on both desktop and Android. (iOS does not support payment handlers at this point.) After this patch, if the only method of payment available is a payment handler that is not yet installed, but is available for JIT installation, then PaymentRequest.canMakePayment() would return "true". Bug: 877644 Change-Id: I614a02789b514d5d0e7738ca827178a844e74199 Reviewed-on: https://chromium-review.googlesource.com/1188900 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#586252}
-
Fredrik Söderquist authored
When synchronizing an empty list, the result should be that the attribute is removed. However, since StringBuilder::ToString for an "empty" StringBuilder returns the empty string we end up setting an empty attribute. Add a special case to handle empty lists, and return the null String there instead. The null String will translate to an attribute removal. All the SVG*List types that inherit from SVGListPropertyHelper are changed call a new shared implementation (SerializeList) in that class. Bug: 843901 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9442268196aaa605886fd4d6d31d66ae075f901d Reviewed-on: https://chromium-review.googlesource.com/1189862Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#586251}
-
Michael Lippautz authored
SVGPropertyTearOffBase::context_element_ is already TraceWrapperMember and will thus emit a write barrier for wrapper tracing. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I89d540179dc47792172f75bf769b898f0290c59e Reviewed-on: https://chromium-review.googlesource.com/1190163Reviewed-by:
-
Koji Ishii authored
r583983 (CL:1178441) checks associated InlineBox are cleared when LayoutText and LayoutInline are destructed. This patch checks associated paint fragments are cleared too. https://chromium-review.googlesource.com/c/chromium/src/+/1180828 Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I83e66e44be04366fcb072a2218e674c29be497c8 Reviewed-on: https://chromium-review.googlesource.com/1188407Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586249}
-
Jan Wilken Doerrie authored
This change adds a CanPower() method to BluetoothAdapter. By default it simply delegates to IsPresent(), but it is overriden for WinRT, where we can be in a state where we were able to get accesss to the adapter, but not the underlying radio. Bug: 821766 Change-Id: I46544d542b49a73f7876a10daccb6d78c492b36c Reviewed-on: https://chromium-review.googlesource.com/1189903 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#586248}
-
David Davidović authored
Add a method for key derivation using the scrypt algorithm to crypto::SymmetricKey. Rename the pre-existing method for key derivation (which uses PBKDF2) to clearly disambiguate between the two. TBRing because all the changes to files not under crypto/ are a trivial library method name change. TBR=mnissler@chromium.org,droger@chromium.org,alemate@chromium.org,cfroussios@chromium.org,tbarzic@chromium.org Bug: 875931 Change-Id: Iaa0b2bb0fc3ae2481733072363718cffd8811b97 Reviewed-on: https://chromium-review.googlesource.com/1181881 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
-
Fredrik Söderquist authored
When an SVGAnimatedProperty has its associated attribute updated, we can cancel any pending attribute synchronization. This prevents overwriting the new value with the old in some cases. Bug: 843901 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3654ad616fd6e6ef82a1933ec034bc9cf0097d56 Reviewed-on: https://chromium-review.googlesource.com/1189842Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dcad91db..6e2adae6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7a336e3ccc72865a30f38cb382f61b0dd8f7a8b5 Reviewed-on: https://chromium-review.googlesource.com/1190122Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586245}
-
Scott Wu authored
Bug: 865114 Change-Id: I74a77252b7280f2e85df56f3ce7f4a0fd28b9873 Reviewed-on: https://chromium-review.googlesource.com/1169028 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#586244}
-
Patrik Höglund authored
This adds experimental test suites I can call from my new LUCI bots. Depends on a change which makes variable substitutions available to gtests. Bug: chromium:877018 Change-Id: Iadf529513e5a92a4e731d3adcaff874101356646 Reviewed-on: https://chromium-review.googlesource.com/1186412 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586243}
-
Armando Miraglia authored
Looking at the referenced bug (crbug/338503) it looks like this comment is outdated since the spec was already implemented. This CL removes the comment. BUG=338503 Change-Id: Id986c398ea59ea1d50c0835567a160b900769cd0 Reviewed-on: https://chromium-review.googlesource.com/1188566Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#586242}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/420696961c8c..e00fe30b8fe7 git log 420696961c8c..e00fe30b8fe7 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 reed@google.com remove SkIPoint16 from documentation -- it is private Created with: gclient setdep -r src/third_party/skia@e00fe30b8fe7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I2dc3b8bdcd4944b435980ac6eb01e1ea2565337d Reviewed-on: https://chromium-review.googlesource.com/1190004Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586241}
-
Jinho Bang authored
The following pattern is wrong in browser tests: ResetEventWaiter(...); RetryPaymentRequest(...); WaitForObservedEvent(); The first line in the pattern is unmeaningful because the RetryPaymentRequest(...) helper method has already ResetEventWaiter() and WaitForObservedEvent() internally. So, this patch makes the helper method take DialogEvent and wait for the event internally. Bug: 861704 Change-Id: I94495cb0f0ed2369a08f49d1065571fa02251a00 Reviewed-on: https://chromium-review.googlesource.com/1189662Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586240}
-
Alexander Hendrich authored
This CL adds handles the status code 417 from DMServer on an enrollment request, which occurs when the user has a packaged license and tries to enroll with a consumer account. The new error message hints the user to create an admin console. Bug: 871203 Change-Id: I9ddf696a252809f80104502b6df6744b1620e009 Reviewed-on: https://chromium-review.googlesource.com/1180961Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586239}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifb2bad243924f0260802a3b01cf6813b7dc23ae3 Reviewed-on: https://chromium-review.googlesource.com/1189344 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586238}
-
Eriko Kurimoto authored
This UI allows users to know the type of log (speech, event..) easily. Bug: 874349 Change-Id: Ia525731a02752fbc5fa9a29a6aeeeea55c66d2df Reviewed-on: https://chromium-review.googlesource.com/1179116 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586237}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c02e02c4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23499 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I442cd02cdae8c7c0c525442d6820950976d1c7ef Reviewed-on: https://chromium-review.googlesource.com/1188498 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586236}
-
Jan Wilken Doerrie authored
This CL modifies AddTypedEventHandler to post its tasks instead of running them immediately. This guarantees that events are received on the same thread an event handler was created on, and closer resembles production environments in tests. Bug: 821766 Change-Id: I7859a2566adf304c835b5a3982725bb4069007fc Reviewed-on: https://chromium-review.googlesource.com/1188904Reviewed-by:
-
Scott Wu authored
Note: In order to provide __crWeb.passwords, looks like the password_controller.js file needs to be included in js_compile targets as source file. Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9a2447259247c58a86b36a354737fdd7ab1fa443 Reviewed-on: https://chromium-review.googlesource.com/1168959Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/13f46245..dcad91db Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I35ab516e8a672b3bf0adb85f4bc321f204c74ed8 Reviewed-on: https://chromium-review.googlesource.com/1188499Reviewed-by:
-
Stephan Herhut authored
Changes the v8 binding to propagate the custom v8 deleter for array buffers into blinks internal DataHandle object. Also, always use deleters, regardless of reservation mode. As a follow-up, reservation mode and corresponding data can now be removed. Bug: v8:8073 Change-Id: I6db795d5a4f19ee0cea727a54d9085ff2ba5b5dc Reviewed-on: https://chromium-review.googlesource.com/1186333 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch adds const modifier to member variables in |NGPhysicalFragment| for improving readability. Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I39f838aeb4f61ca4fe262056f22f0e772f1d86a2 Reviewed-on: https://chromium-review.googlesource.com/1186219Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This is part of efforts to replace per-thread task runner usages with per-frame task runners. We tried to replace legacy IPC with Mojo first, but failed due to a message order issue (see https://chromium-review.googlesource.com/c/chromium/src/+/1174341/2/content/common/frame.mojom#65). Until this problem is solved, just replacing the task runner at the accepting side would work. Bug: 856568 Change-Id: I57f067cd34638eba6fd8bcce29e23e79c6ee7490 Reviewed-on: https://chromium-review.googlesource.com/1184739 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |ElementInnerTextCollector::ProcessNode()| to check object type before casting to |LayoutTableCell|. The issue is caused by |LayoutSVGRect|'s computed style of "display" property is "table-cell". This patch is follow-up of the patch[1] to fix the bug found by Cluster Fuzz. [1] http://crrev.com/c/1114673 Implement Element#innerText to conform the spec Bug: 877470 Change-Id: I8bf833c66770f1f0dbace7c45bc22f6a5c0cfa26 Reviewed-on: https://chromium-review.googlesource.com/1189262 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#586229}
-
Alan Cutter authored
This CL fixes color inconsistency between the title and the caption buttons on Windows 10 when theme colors are used in PWA windows. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354609&signed_aid=XZviD7H5PrdO2M-73ui7Tw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354795&signed_aid=Av8_PIND8_gosBPPahgKFw==&inline=1 Bug: 872118 Change-Id: I7dcc27aa480ca43746ca65bb8a60561d99e47e99 Reviewed-on: https://chromium-review.googlesource.com/1186929Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#586228}
-
Elad Alon authored
TBR=grunell@chromium.org Bug: 775415 Change-Id: I272edfe82cdd3ae296251905f3e36b9611d63f44 Reviewed-on: https://chromium-review.googlesource.com/1162325 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586227}
-
Vasilii Sukhanov authored
Bug: 874029 Change-Id: I24d337bb04becf16f8f67d1f143129ccac8624cd Reviewed-on: https://chromium-review.googlesource.com/1186900 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#586226}
-
Tobias Sargeant authored
TBR: jinsukkim@chromium.org Bug: 877918 Change-Id: I73811d10e7c7e3af1ded812178424d69298d40f7 Reviewed-on: https://chromium-review.googlesource.com/1189863 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#586225}
-
Eriko Kurimoto authored
Change-Id: Ia527aeb71f894bfc0e4bac21abd9b951cd8fe568 Reviewed-on: https://chromium-review.googlesource.com/1184802 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
Noel Gordon authored
Most tests herein are promise-based. Having a few tests in StepsRunner is not great. Let promises win in this file. Bug: 877557 Change-Id: Ia063d4218e4e1c27957beac2fa3f850532eb4f64 Reviewed-on: https://chromium-review.googlesource.com/1189586Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586223}
-
Yoshifumi Inoue authored
This patch changes |ElementInnerTextCollector::IsAfterWhiteSpace()| to use |IsInlineTextBox()| instead of |InlineBox::IsText()| to detect |InlineTextBox| type properly. Note: |InlineBox::IsText()| is used for handling <br> in quirk mode, and list marker. This patch is follow-up of the patch[1] to fix the bug found by Cluster Fuzz. [1] http://crrev.com/c/1114673 Implement Element#innerText to conform the spec Bug: 877498 Change-Id: I484a93afba351b74a8b3cae0c6736e3ccdfde45d Reviewed-on: https://chromium-review.googlesource.com/1189242Reviewed-by:
-
Victor Costan authored
This is needed to fix cronet_unittests_android on the android_cronet_tester bot after https://crrev.com/c/1187783. TBR=mef Bug: 877868, 875486 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: If59e993e3e6b19cb54f04c2259014c34d6ad4592 Reviewed-on: https://chromium-review.googlesource.com/1189712Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586221}
-
