- 24 Sep, 2019 40 commits
-
-
Jeevan Shikaram authored
This CL corrects a regression which hides the more settings and permission linkout. Bug: 979531 Change-Id: I468734a201836b23c1d7943f139ff9090af45390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820401Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#699224}
-
John Z Wu authored
This makes it easier to output debug menus. I had to change the private property into a method because C++ things do not seem to work well with valueForKey: Change-Id: I62b08be230b968449a6a002a1c7e62a4c0026a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816288Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#699223}
-
Jeevan Shikaram authored
This CL deletes the Google Play Store section and adds it's children into the new Apps settings section. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413184&signed_aid=VDO2a7j5Bu_Via8i0H_BzA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413183&signed_aid=sQOsHwyPDGWKiaC2zZlgQQ==&inline=1 Bug: 1004583 Change-Id: If9d307de4240ab8246f2b7ebb61e38b2530f792a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815957 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699222}
-
Peter Kasting authored
Bug: 82078 Change-Id: Id6acded56ab6c6e4133a274875db985e963fcf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820539 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699221}
-
François Beaufort authored
This CL adds missing attribute error to GPUUncapturedErrorEvent. It was forgotten in http://crrev.com/1787504 Bug: 877147 Change-Id: Ia135b7b79a4215c0c90a4704516c3b70f3658072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814827 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#699220}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/984536bb45f4..e18bf0acc0be git log 984536bb45f4..e18bf0acc0be --date=short --no-merges --format='%ad %ae %s' 2019-09-24 dberris@chromium.org PinpointScheduler: A Validator Implementation 2019-09-24 dberris@chromium.org Pinpoint: Allow for partial job instance migration Created with: gclient setdep -r src/third_party/catapult@e18bf0acc0be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:988912,chromium:1006658 Change-Id: I6bc3f39f8d0124e31726b702551b7a6142468a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699219}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class, allowing to retrieve the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider. Additionally, this CL also migrates the few usages of the old Mojo types that were still around in the codebase. TBR=clamy@chromium.org Bug: 955171, 978694, 936482 Change-Id: I95d2d9ef39838a09748542c847440b060190e2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819238 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/5327092bb28b..4881f75b7ca0 git log 5327092bb28b..4881f75b7ca0 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 apodtele@gmail.com * src/base/ftstroke.c (ft_stroke_border_arcto): Speed up calculations. Created with: gclient setdep -r src/third_party/freetype/src@4881f75b7ca0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I010c59395b4b818f5ecd45d26cf5230010a5f727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816426Reviewed-by:
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider. TBR=clamy@chromium.org Bug: 955171, 978694, 936482 Change-Id: I38672e3a40864aef9a179afc5463ab241491d096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816552 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the blink::mojom::DevToolsAgent[Host] and blink::mojom::DevToolsSession[Host] interfaces. Also, rename blink::DevToolsAgent's BindRequest() methods to BindReceiver, to make them consistent with the usual pattern followed on this migration. Bug: 955171, 978694 Change-Id: Ide73670eb7d3d3fafe30f09a4d94a0e98d63b552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819309Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media_router.mojom.MediaRouterTraitsTestService interface, and adapt unit tests. Bug: 955171 Change-Id: I4856427d46032c66a0dec395cd0711e93ba93700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816539Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts SpellCheckHost and SpellChecker to new Mojo types using Remote, PendingRemote, PendingReceiver, Receiver, and ReceiverSet. It introduces a new template for GetInterface from LocalInterfaceProvider. Bug: 955171 Change-Id: I459d2ffc50242f8f2159c31212fd2346e571544f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813125 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#699213}
-
Julie Jeongeun Kim authored
This CL converts apps::mojom::PublisherPtr to new Mojo types using PendingRemote or Remote, PendingReceiver, ReceiverSet, and Receiver. It also updates RegisterPublisher from app_service.mojom Bug: 955171 Change-Id: Ic4001997764a9872a0df5f4931368312c263d27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818886 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Roman Sorokin authored
I've left it a separate polymer element to make the CL as simple as possible Before: https://screenshot.googleplex.com/O4r365FLMzJ.png After: https://screenshot.googleplex.com/2uf0mVpH5ck.png Bug: 999090 Test: manual Change-Id: If815a9b5e45334cde63b615d60d72be32f9d9021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819299Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699211}
-
Marina Sakai authored
V8_PRIVATE_PROPERTY_GETTER_NAME: a macro-generated function can be cleaned by using the new API which was created in CL1810511. Two macros variable can be removed with this CL. Bug: 715418, 1005601 Change-Id: I1da3aa583d95700ce305c237e4a4ee4ce2aa01ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813117Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
This CL follows up crrev.com/c/1784238 with few naming and console error fixes. Bug: 999896 Change-Id: Ic053db94e250aebd38105ace7e895c468d3d30c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798255Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#699209}
-
Ricky Liang authored
In crrev.com/c/1687018 we added a local call site to RegisterClient, so we can no longer assume the method is always called through Mojo IPC. enabled. Bug: 1000842 Test: Make sure Chrome debug build starts on Nocturne with ARC++ Change-Id: Ibe546396646bab01c7caec02ff72f8122ac80181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817875Reviewed-by:Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699208}
-
Alex Keng authored
This change updates forced_color.css to enable <select multiple> to render high contrast color. Bug: 994219 Change-Id: If9814a11544232cfe8ee4de219f0ddaa83f70204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816448 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#699207}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4b1005d485f..c096654fa7c6 git log b4b1005d485f..c096654fa7c6 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 csmartdalton@google.com ccpr: Don't assign inverse fill types to fan tessellations Created with: gclient setdep -r src/third_party/skia@c096654fa7c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: Ida0d7f3e7aa6a2e18927c488f476f1e705b06bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820012Reviewed-by:
-
Xiaocheng Hu authored
The current parser allows `/ <bg-size>` as long as there's a <bg-position> in the current or previous layers, which is wrong. This patch ensures that it's allowed only after a <bg-position> in the same layer as per spec: https://drafts.csswg.org/css-backgrounds-3/#the-background Bug: 1002568 Change-Id: I79630a1331d880248d27205788a65cd5b4032a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819562 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#699205}
-
Chih-Yu Huang authored
Originally we assume that VD::CreateSurface() will be called after AVD::SetStream() is called, and the returned surface is used for the current bitstream buffer. However, the description of AVD doesn't guarantee this fact. This CL changes to set the timestamp that is mapped from bitstream id passed from SurfaceReady(). This timestamp is actually reliable value. BUG=b:140842667 TEST=run video_decode_accelerator_tests on Kevin and Eve Change-Id: I255870c6220a4bd771e1f23b54c309fe8ca42246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810452Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699204}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. - WebLocalizedString::kAXMillisecondFieldText - WebLocalizedString::kAXMinuteFieldText - WebLocalizedString::kAXMonthFieldText - WebLocalizedString::kAXSecondFieldText - WebLocalizedString::kAXWeekOfYearFieldText - WebLocalizedString::kAXYearFieldText Bug: 995644 Change-Id: I09495c8f2737a398e1b553b2b006f44e424f6686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820398Reviewed-by:
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Presubmit disabled due to an unrelated error in find_runtime_symbols/find_runtime_symbols.py. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. NOPRESUBMIT=true Bug: 941669 Change-Id: I3174ed0eb7005d493c6bc44751353b8fae18a1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818478 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699202}
-
Kenichi Ishibashi authored
We should terminate a service worker thread when the top-level script fetch fails. Otherwise the thread would stay running and leak a V8 isolate. WorkerGlobalScope::close() schedules thread termination. I manually confirmed that this CL fixes the leak. I'll add a test for this fix in a follow-up CL. Bug: 1005650 Change-Id: If3fd2f7f0f746c4e240b9fdebd4cf242d87a0943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819282 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#699201}
-
Wei Lee authored
This CL changes the behavior to let CCA open back camera as the default one when the device is under tablet mode. Bug: b/140273786 Test: Tested on Soraka and it open front camera as default under clamshell mode and open back camera as default under tablet mode. Change-Id: I1fa8f16265e9021ab0093cba506e0b652cb27af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815927Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699200}
-
Alexis Savery authored
Since the host is reading/writing in power of 2 units to the device, and lifetime_writes is originally reported in KiB, the amount of writes reported in the histogram should be in GiB. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1779603 Bug: None Test: ran validate_format.py Change-Id: I481c31730e66fe1f677ff52280fa8bfef97ca7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818607Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699199}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3da5033009ec..e712395b0e52 Created with: gclient setdep -r src-internal@e712395b0e52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4bd645f7b2ab42668d6044b70d3d41b1af57b21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819846Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699198}
-
Alan Cutter authored
This test is failing on just Windows 7 after getting deflaked. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Fcss%2Fcss-scroll-snap%2Fscroll-margin.html TBR=alsan@google.com Bug: 964239 Change-Id: I9e63ab319955f70138f529585ac8ce51efd58bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820399Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9650d22d16e..984536bb45f4 git log b9650d22d16e..984536bb45f4 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 ntfschr@chromium.org Docs: add devil to navbar.md Created with: gclient setdep -r src/third_party/catapult@984536bb45f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: I1e16eb8a35d1289fa26bb0f262f8369ffe71c834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820294Reviewed-by:
-
Jay Harris authored
Bug: 1007063 Change-Id: Ife944e1e1784037c442e260df7d02e65454606cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818890 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
-
Maggie Cai authored
This CL updates the App Service intent filter condition value to an array and create a intent_filter_util file to handle the creation of the condition values. Bug: 853604 Change-Id: Ib43f1efd4cde468379f25d6aaf9dd3ae54a6a142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816000 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d0581808..017e8357 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d91dde62095dffb25df97bd6a6b656a36ebbb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820307Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699193}
-
jongdeok.kim authored
This CL adds a link to Korean version for how_cc_works.md. Change-Id: Iaf09c30d2c43304a85bd4416def6a5c742787c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819278Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699192}
-
Alan Cutter authored
This reverts commit de35a097. Reason for revert: Failing on all platforms. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WelcomeA11y.WelcomeFlow_color_contrast https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/27248 [18374:18374:0923/204432.097393:ERROR:CONSOLE(49)] "Mocha test failed: WelcomeFlow_color_contrast Landing Page Error: the string "Found 1 accessibility violations." was thrown, throw an Error :) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) [18374:18374:0923/204432.101101:ERROR:web_ui_test_handler.cc(72)] Test Errors: 1/1 tests had failed assertions. [18374:18374:0923/204432.101355:ERROR:web_ui_browser_test.cc(546)] CONDITION FAILURE: encountered javascript console error(s): [18374:18374:0923/204432.101376:ERROR:web_ui_browser_test.cc(548)] JS ERROR: '[18374:18374:0923/204432.097393:ERROR:CONSOLE(49)] "Mocha test failed: WelcomeFlow_color_contrast Landing Page Error: the string "Found 1 accessibility violations." was thrown, throw an Error :) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) ' [18374:18374:0923/204432.101390:ERROR:web_ui_browser_test.cc(550)] JS call assumed failed, because JS console error(s) found. gen/chrome/test/data/webui/welcome/a11y_tests-gen.cc:285: Failure Value of: RunJavascriptTestF( true, "WelcomeA11y", "WelcomeFlow_color_contrast") Actual: false Expected: true Stack trace: #0 0x55ebe3920b5f StackTraceGetter::CurrentStackTrace() #1 0x55ebe392955c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x55ebe3928ea9 testing::internal::AssertHelper::operator=() #3 0x55ebe36c24dd WelcomeA11y_WelcomeFlow_color_contrast_Test::RunTestOnMainThread() #4 0x55ebe60b131e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x55ebe5cae39c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #6 0x55ebe5cad1ad ChromeBrowserMainParts::PreMainMessageLoopRun() #7 0x55ebe438318f content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x55ebe4779607 content::StartupTaskRunner::RunAllTasksNow() #9 0x55ebe4381e42 content::BrowserMainLoop::CreateStartupTasks() #10 0x55ebe4384bf2 content::BrowserMainRunnerImpl::Initialize() #11 0x55ebe438041f content::BrowserMain() #12 0x55ebe5873245 content::ContentMainRunnerImpl::RunServiceManager() #13 0x55ebe5872d76 content::ContentMainRunnerImpl::Run() #14 0x55ebe7a2e8dd service_manager::Main() #15 0x55ebe4c9c511 content::ContentMain() #16 0x55ebe60b0dc6 content::BrowserTestBase::SetUp() Original change's description: > Reland Update axe-core to v3.3.2 > > This change updates the version of axe-core to the latest released > version. As part of picking up the latest version, the following > additional changes were made: > > 1) axe-core removed the 'href-no-hash' rule, so that been removed > from the test list. > > 2) Several 'link-in-text-block' tests started failing with > axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but > are disabled as part of this change. > - CrManagementA11yTest.SimpleTest_link_in_text_block > - CrManagementA11yTestWithExtension. > ExtensionSection_link_in_text_block > - CrostiniAccessibilityTest.CROSTINI_link_in_text_block > - CrExtensionsA11yTest.NoExtensions_link_in_text_block > - MultideviceA11yTest.MULTIDEVICE_link_in_text_block > - MultideviceFeaturesA11yTest. > MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block > > 3) One 'heading-order' test started failing in v3.0.0 (and later). > This tests does pass in V2.4.2, but is disabled as part of this > change. > - CrExtensionsA11yTestWithMultipleExensions. > WithExtensions_heading_order > > 4) Several DevTools a11y tests were failing. This change either > updates the baseline or excludes the rule depending upon the > test/rule itself. > - http/tests/devtools/a11y-axe-core/basic-a11y-test.js > - http/tests/devtools/a11y-axe-core/console-a11y-test.js > - http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js > - http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js > > I spent some time investigating the test failures, and it looks > like axe-core is highlighting legitimate product issues. > > Change-Id: I0ef08cdace91250936f83705fb3cd0fbb35bed4b > Bug: 984817 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809407 > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699166} TBR=aboxhall@chromium.org,hcarmona@chromium.org,yangguo@chromium.org,mjackson@microsoft.com,tvanderlippe@chromium.org Change-Id: I6e74d1ddeec80407fc057dd07c95c492d7e6679f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819284Reviewed-by:
-
Manu Cornet authored
Add some tests. Bug: 982512 Change-Id: Ifcf6574fae9dc258c60ce4990109c6c5d2c3a12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820092Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#699190}
-
Alexey Baskakov authored
TestWebAppRegistryController contains TestWebAppDatabaseFactory (the input and the output for tests), WebAppRegistrar, WebAppSyncBridge and ChangeProcessor. Bug: 860583 Change-Id: I1e0ed5e75fb5effd8f69bd2a7d9f819b56df0be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818893 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Raul Tambre authored
Converted other regex strings to raw strings to prevent this being reintroduced in the future. ../../build/toolchain/win/midl.py:56: SyntaxWarning: invalid escape sequence \. 'Created by MIDL version 8\.\d\d\.\d{4} at ... Jan 1. ..:..:.. 2038\n', ../../build/toolchain/win/midl.py:72: SyntaxWarning: invalid escape sequence \. 'File created by MIDL compiler version 8\.\d\d\.\d{4} \*/\r\n' ../../build/toolchain/win/midl.py:73: SyntaxWarning: invalid escape sequence \* '/\* at ... Jan 1. ..:..:.. 2038', ../../build/toolchain/win/midl.py:78: SyntaxWarning: invalid escape sequence \( ' Oicf, W1, Zp8, env=(.....) \(32b run\), ' ../../build/toolchain/win/midl.py:79: SyntaxWarning: invalid escape sequence \. 'target_arch=(AMD64|X86) 8\.\d\d\.\d{4}', ../../build/toolchain/win/midl.py:97: SyntaxWarning: invalid escape sequence \( contents = re.sub('class DECLSPEC_UUID\("[^"]*"\)', ../../build/toolchain/win/midl.py:231: SyntaxWarning: invalid escape sequence \* print(' copy /y %s\* %s' % (tmp_dir, source)) Bug: 958138 Change-Id: I171f8d30540aa5ef15126b568d313a928b89c3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816412Reviewed-by:Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699188}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idc52d4fe3180ea595870b9965ca743838de94632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819849Reviewed-by:
-
Alan Cutter authored
Flaking on all platforms. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fintersection-observer%2Fv2%2Fdelay-test.html TBR=szager@chromium.org Bug: 1007134 Change-Id: Iff33f55d6fea6ea94a1ff8398de3208100c6dc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818009Reviewed-by:
-
Dan Beam authored
R=rbpotter@chromium.org Bug: 1003508 Change-Id: Ibad7ce62a2aeee2e40a911e6ebdff853a87cbfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818466 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#699185}
-
