- 14 Jun, 2018 40 commits
-
-
Ryan Hansberry authored
This implementation is a port of tether::BleServiceDataHelperImpl, but correctly uses its provided DevicePair arguments, and uses a RemoteDeviceCache for device storage. This CL also fixes a small bug in tether::BleServiceDataHelperImpl that caused it to attempt to identify *all* known Tether hosts, instead of the requested hosts. Bug: 824568, 752273 Change-Id: Ib8ab47dfcb2889392b6ec5f519aed706ffc513d9 Reviewed-on: https://chromium-review.googlesource.com/1098146 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#567121}
-
Carlos Knippschild authored
TBR=johnchen@chromium.org Bug: 852616 Change-Id: I8046cc162d1cb39d9809bd2bcd3a09b3a29212b8 Reviewed-on: https://chromium-review.googlesource.com/1100125Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#567120}
-
John Budorick authored
TBR=ellyjones@chromium.org Bug: 767397 Change-Id: I88764b5dad273ec9dbea975cc6e97ce799ce6fe1 Reviewed-on: https://chromium-review.googlesource.com/1100296Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567119}
-
Luke Bjerring authored
Upstream re-attempt at https://github.com/web-platform-tests/wpt/pull/9854. Adds more untested IDL deps. Change-Id: Icf7bda0f264ec66f4980e0742485eb406e334c19 Reviewed-on: https://chromium-review.googlesource.com/1089862 Commit-Queue: Luke Bj <lukebjerring@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567118}
-
Sarah Hu authored
Bug: 837577 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I709b737af4e8b77de40be4f2798681ffa45532b4 Reviewed-on: https://chromium-review.googlesource.com/1097948Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#567117}
-
Christopher Lam authored
This CL updates Chromium Closure Compilation docs to use GN-based compilation. Bug: 632206 Change-Id: Ie3aef4b7f81744e04051489731acf4e7aa80da15 Reviewed-on: https://chromium-review.googlesource.com/1098749Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#567116}
-
Vikas Soni authored
Add Media.CodecImage.SurfaceTextureGLOwner.WaitTimeForFrame and Media.CodecImage.ImageReaderGLOwner.WaitTimeForFrame to histograms.xml. These were added in the source code by CL 561988 but was not added to histograms.xml. Bug: 849218 Change-Id: I417e19816398aad194e534379e4cbe3dca3e4383 Reviewed-on: https://chromium-review.googlesource.com/1093540Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#567115}
-
Sebastien Marchand authored
Bug: 773383 Change-Id: Ibf4bb5fe5881248489d01bf52fc6100f31c9266c Reviewed-on: https://chromium-review.googlesource.com/1099681 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#567114}
-
Takumi Fujimoto authored
This is the view that is shown when there are no devices found. For the first three seconds, it will show a throbber. After that, it will show a help icon that links to a help center article. Whenever the dialog receives a model update containing sinks, the "no devices" view is replaced with the sink list view. Video: https://drive.google.com/open?id=18zr2x3B30HsRc0j9hYry8_dZWXAlW5e_ Bug: 846164 Change-Id: I203197b5300c604a062deb303c18d5c98631c761 Reviewed-on: https://chromium-review.googlesource.com/1089580 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567113}
-
Sky Malice authored
This incremental change adds the pref dependency and starts to register feed preferences. Bug: 831648 Change-Id: Ifb5ed97ac1de87a6319539839f9c57be46fb89b1 Reviewed-on: https://chromium-review.googlesource.com/1093982Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#567112}
-
Ahmed Fakhry authored
Don't delete feedback reports files on disk on the report destruction. This leads to losing pending reports on sign out or reboot. Instead explicitly delete the files once successfully uploaded, or when a no-retry failure occurs. BUG=851687 TEST=Added new test. Change-Id: I64caf16f63ea73c1888d8b097543e9eacabc1d9e Reviewed-on: https://chromium-review.googlesource.com/1099758 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567111}
-
Fabio Tirelo authored
In the new dialog proposal, expiration date is aligned on the right for LTR language, and on the left for RTL languages. Bug: 852094 Change-Id: I255ad02c270bca3fc7f2fa548d54a4ec889d278b Reviewed-on: https://chromium-review.googlesource.com/1097938 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#567110}
-
Pedro Amaral authored
Bug: 852118 Change-Id: I8069787fda1a3e26086e16fe3839cbc30e3c5f7c Reviewed-on: https://chromium-review.googlesource.com/1094488 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567109}
-
Tetsui Ohkubo authored
This adds DefaultView.VisibleRows metrics to UnifiedSystemTray. It was previously implemented in old SystemTray. PatchSet 1: Moving SystemTrayItem::UmaType to SystemTrayItemUmaType PatchSet 2: Implement the metrics in UnifiedSystemTray TEST=manual BUG=842079 Change-Id: Ied65e288147c59b6df0a8312a86e30a35fa4b953 Reviewed-on: https://chromium-review.googlesource.com/1094821 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567108}
-
Sergey Ulanov authored
Fuchsia packages were not generated with is_chromecast=true. The problem with library loading has been fixed, so there is no reason not to generate packages anymore. TBR=dpranke@chromium.org Bug: 810069 Change-Id: I5ab66414bab4c6e9eab8c5dd12360656ba5e7d44 Reviewed-on: https://chromium-review.googlesource.com/1099995 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#567107}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/31d539486159..41ff7a035785 git log 31d539486159..41ff7a035785 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@41ff7a035785 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0fadd83cdcff0d1551d3e6a76967c83d67626280 Reviewed-on: https://chromium-review.googlesource.com/1100118Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567106}
-
John Rummell authored
Update navigator.requestMediaKeySystemAccess() to support querying for encryption scheme support. This is based on https://github.com/WICG/encrypted-media-encryption-scheme/blob/master/explainer.md. BUG=657957 TEST=new layout and browser tests pass Change-Id: I5ba39861bab673a61dd65c12fe82d6ba3bd63ddb Reviewed-on: https://chromium-review.googlesource.com/959459Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#567105}
-
Andrey Lushnikov authored
Method injects a binding object to the target's main frame that allows communication with browser target. R=pfeldman, dgozman Change-Id: Ic36a058c2cba41fccb9419318676a4fdc04a8454 Reviewed-on: https://chromium-review.googlesource.com/1066289 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567104}
-
cathiechen authored
In order to update counter-reset correctly, MoveNonResetSiblingsToChildOf is called, so the non-reset sibling will become the child of this reset CounterNode. If this reset node is nested inside another CounterNode, the sibling's nested layer won't be correct. So we should skip calling MoveNonResetSiblingsToChildOf() in the nested case. Bug: 849107 Change-Id: I8c59e18785dfec18c4bc2053e9c01041c23e4183 Reviewed-on: https://chromium-review.googlesource.com/1098867Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#567103}
-
Xing Liu authored
The file size is very useful for the user and it's in the UI design. This CL adds the pipeline to show the file size in download location dialog. Bug: 846222 Change-Id: I972955571a6dd8b781c784167a4aee697b98d486 Reviewed-on: https://chromium-review.googlesource.com/1097713 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#567102}
-
Tetsui Ohkubo authored
This CL changes the back button of a detailed view to have custom shape following the UX spec. To do this, this CL splits CustomShapeButton from CollapseButton, and derives CollapseButton and BackButton from CustomShapeButton. Screenshot: http://screen/Lkuj2DJCYHP UX spec: http://shortn/_N5oGsw6QZ0 TEST=manual BUG=850396 Change-Id: I08554db7e78e710e96dd670917d612dbadee5ccb Reviewed-on: https://chromium-review.googlesource.com/1096813Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#567101}
-
Sara Kato authored
Related CL https://chromium-review.googlesource.com/c/chromium/src/+/1065964 see testing/buildbot/filters/mash.ash_unittests.filter Bug: None Change-Id: Ia2f278b23ff20ed6084a9482e2e47c6206489be0 Reviewed-on: https://chromium-review.googlesource.com/1098415 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567100}
-
Lukasz Anforowicz authored
This CL is desirable today, to avoid the memory leaks associated with queueing of IPCs that are sent to RenderProcessHosts that are constructed, but not yet initialized - such RenderProcessHosts accumulate IPC messages and flush them only after renderer process is actually launched at a later point / after a call to RPH::Init. This aspect of the CL is very similar to r562797 which landed earlier. This CL is desirable for the future - a tentative long-term plan for https://crbug.com/813045 is to avoid creating an IPC channel before RPH::Init is called. This means that in the long-term RPH::GetChildIdentity will crash (dereferencing a nullptr |RenderProcessHostImpl::child_connection_|) if called on an uninitialized RPH. This CL ensures that this crash won't happen in ClientSideDetectionService::SendModelToProcess and SpellcheckService::OnCustomDictionaryChanged by ensuring that these methods only work with already initialized RPHs. The changes under //chrome/browser/spellchecker and //chrome/browser/safe_browsing skip uninitialized RPHs for 2 specific IPCs/subsystems. The changes under //content/browser/renderer_host prevent future IPCs/subsystems from using uninitialized RPHs, by adding a DCHECK to RenderProcessHostImpl::GetChildIdentity. The new DCHECK necessitates setting |is_initialized_ = true| much earlier in RenderProcessHostImpl::Init (because ChromeContentBrowserClient::RenderProcessWillLaunch needs to call RPH::GetChildIdentity). Bug: 813045 Change-Id: I4783de85cb7c199ab360f8361acd54c63287e1df Reviewed-on: https://chromium-review.googlesource.com/1095433Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#567099}
-
Bret Sepulveda authored
Refresh changes the amount of extra padding added to the left of the favicon. But when the tab is too small to accommodate this extra padding, Refresh was failing to remove this padding and calculate icon visibility correctly. This also fixes TabTest.LayoutAndVisibilityOfElements when Refresh is enabled. Bug: 846410, 822061 Change-Id: I2b77b976d55e314da3e6b5193403eb2a102dd426 Reviewed-on: https://chromium-review.googlesource.com/1098148Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567098}
-
Ian Clelland authored
Existing code was multiplying ints in a context where an intermediate result could overflow the 32-bit container. Change to explicitly use a 64-bit long long for the intermediate product to avoid undefined behaviour. Found by UBSan / clusterfuzz Bug: 852435 Change-Id: I683eee6eda51f40e7f165c0a55111fba623c2ec9 Reviewed-on: https://chromium-review.googlesource.com/1099756Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#567097}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/571053a44f87..8e631772e342 git log 571053a44f87..8e631772e342 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 tsepez@chromium.org Collapse some more xfa/non-xfa code in cpdfsdk annots. Created with: gclient setdep -r src/third_party/pdfium@8e631772e342 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I88fc81f18e1b1dd8967c22005c72aac1bbaf81dc Reviewed-on: https://chromium-review.googlesource.com/1100117Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567096}
-
sczs@chromium.org authored
- Creates TableViewLoadingView, which is added as a backgroundView of ChromeTableVC. - HistoryTableVC adds this TableViewLoadingView instead of implementing its own. - Re-adds searching property to HistoryTableVC. Screenshot: https://drive.google.com/open?id=1gXnkLADyKrv3hqtijU7Su9t8gW0hR7el Bug: 838577 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id494826f4bd522062f7d30bf4c6e7e81ceba6370 Reviewed-on: https://chromium-review.googlesource.com/1041187 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567095}
-
John Budorick authored
This reverts commit 4a2a5c4a. Reason for revert: seems to be a bit too new of a flag for the xcode version of clang: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-xcode-clang/51865 Original change's description: > build: Pass -fcomplete-member-pointers when building with clang. > > This prevents member pointers of incomplete base type from being used in > cases where they might cause problems under the Microsoft ABI. > > Specifically, the Microsoft ABI has different kinds of member pointers with > different sizes, and the choice of member pointer representation depends on > the inheritance hierarchy of the member pointer's base type. C++ allows a > member pointer's base type to be incomplete, so if it is incomplete at the > point where a variable of that member pointer type is declared, that forces > the compiler to pick the most general (i.e. largest) one. That can lead to > ODR violations since the most general representation wouldn't necessarily > be the one that would be chosen if the base type happened to be complete at > the point where the variable was declared. It can also be less size efficient > because the compiler will generally be able to choose a smaller representation > than the most general one if it were complete at the point where it is needed. > > This flag also enables additional semantic analysis that we'll need in order > to correctly implement -fsanitize=cfi for member function pointer calls. This > is because the inheritance hierarchy of the base type must be available in > order to make the CFI checks as precise as possible. > > Note that the flag is a -f flag rather than a -W flag. This is because > requiring member pointer base types to be complete is technically a > non-conforming language extension, as it may, for example, cause templates > to be instantiated which would otherwise not be, which may be observable > after code generation in conforming programs that were crafted to observe > it. However, the effects of this language extension should not be observable > in most ordinary programs. > > Bug: 847724 > Change-Id: I8d823fd4a6f21dfcadba55eefc0a69ef2e0c3479 > Reviewed-on: https://chromium-review.googlesource.com/1098217 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567086} TBR=thakis@chromium.org,pcc@chromium.org Change-Id: Ieb56b1bb4236a874ecc4846eb3ad73a87d9bdf82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847724 Reviewed-on: https://chromium-review.googlesource.com/1100516Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567094}
-
Chris Blume authored
Shaderc currently does not build and is used in a Vulkan test. The upstream version of Shaderc has fixed the issue preventing the build. However, we may not actually want Shaderc. Currently, Shaderc is only being used in a unit test. It is possible that in the future we will want to compiler GLSL at runtime. But there are no plans for that right now. BUG=852620 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4edc119b6fe36851901a0b03924613c161db7c7e Reviewed-on: https://chromium-review.googlesource.com/1100298Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#567093}
-
Koji Ishii authored
Following CL:1074989 that fixed inline-level baseline for flipped-lines (vertical-lr), this patch fixes block-level baselines. When NGBlockLayoutAlgorithm propagates baselines from its child line boxes, line boxes and font metrics are in the [line-relative] coordinates. This needs to be converted to [flow-relative] coordinates when adding to box fragments. [flow-relative]: https://drafts.csswg.org/css-writing-modes-3/#logical-directions [line-relative]: https://drafts.csswg.org/css-writing-modes-3/#line-directions Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If4ddc2374cc0351120ae672614a32f38bb1f3bc8 Reviewed-on: https://chromium-review.googlesource.com/1087192Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567092}
-
Oksana Zhuravlova authored
This change prepares GamepadSharedMemoryReader for the move to blink by removing its inheritance from RendererGamepadProvider and moving listener-related logic to GamepadSharedMemeoryReader. Since the GamepadSharedMemoryReader instance can no longer be stored in RendererBlinkPlatformImpl::platform_event_observers_, a separate variable has been added temporarily that will be moved to GamepadDispatcher along with the logic when the GamepadSharedMemoryReader class is moved to blink. Bug: 612330 Change-Id: I4a6e2dd1af5afb52f7f6a980eb8aace7642426ac Reviewed-on: https://chromium-review.googlesource.com/1096349 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567091}
-
Kenichi Ishibashi authored
When a controller doesn't have fetch event handlers we should not route requests to ServiceWorkerSubresourceLoader for no fetch optimization. Bypass ServiceWorkerSubresourceLoader when there is no ControllerServiceWorker. This works because ControllerServiceWorker is set only when the controller has fetch event handlers. Bug: 847322 Change-Id: I6e76a415b5b3c9156bce8676a79312c09307595c Reviewed-on: https://chromium-review.googlesource.com/1096584 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567090}
-
Charles Zhao authored
Bug: 843891 Change-Id: I7fba61c7a46a8d0b6a3dabdc37b9209510c9cb15 Reviewed-on: https://chromium-review.googlesource.com/1064651Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567089}
-
Kevin McNee authored
Now that we no longer send gesture pinch events to OOPIF renderers, we can remove the check for the InnerViewportScrollNode before the snap-to-min page scale animation and have it be a DCHECK instead. Bug: 787924, 791885 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I834a40ed6df46fa48abb3662a0331cc7bc1365c0 Reviewed-on: https://chromium-review.googlesource.com/1087399 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567088}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9327981248e7..4cc753e01054 git log 9327981248e7..4cc753e01054 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 jmadill@chromium.org Vulkan: Implement sampler arrays. 2018-06-13 jmadill@chromium.org Vulkan: Fix qualifier replacement for sampler arrays. 2018-06-13 jmadill@chromium.org Vulkan: Store Pipeline/DS Layouts in ProgramVk. 2018-06-13 jmadill@chromium.org Vulkan: Add PipelineLayout and DescriptorSetLayout caches. 2018-06-13 tobine@google.com Migrating ANGLE to split LVL repos 2018-06-13 lucferron@chromium.org Vulkan: Clamp the point size range to have a min value of 1.0 Created with: gclient setdep -r src/third_party/angle@4cc753e01054 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie11e85e6485cbb6dd28fd95bcf19c95e5086746e Reviewed-on: https://chromium-review.googlesource.com/1100115Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567087}
-
Peter Collingbourne authored
This prevents member pointers of incomplete base type from being used in cases where they might cause problems under the Microsoft ABI. Specifically, the Microsoft ABI has different kinds of member pointers with different sizes, and the choice of member pointer representation depends on the inheritance hierarchy of the member pointer's base type. C++ allows a member pointer's base type to be incomplete, so if it is incomplete at the point where a variable of that member pointer type is declared, that forces the compiler to pick the most general (i.e. largest) one. That can lead to ODR violations since the most general representation wouldn't necessarily be the one that would be chosen if the base type happened to be complete at the point where the variable was declared. It can also be less size efficient because the compiler will generally be able to choose a smaller representation than the most general one if it were complete at the point where it is needed. This flag also enables additional semantic analysis that we'll need in order to correctly implement -fsanitize=cfi for member function pointer calls. This is because the inheritance hierarchy of the base type must be available in order to make the CFI checks as precise as possible. Note that the flag is a -f flag rather than a -W flag. This is because requiring member pointer base types to be complete is technically a non-conforming language extension, as it may, for example, cause templates to be instantiated which would otherwise not be, which may be observable after code generation in conforming programs that were crafted to observe it. However, the effects of this language extension should not be observable in most ordinary programs. Bug: 847724 Change-Id: I8d823fd4a6f21dfcadba55eefc0a69ef2e0c3479 Reviewed-on: https://chromium-review.googlesource.com/1098217 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567086}
-
Mike Frysinger authored
Since Chrome is the only thing that loads these files, there's no need to force them to use JSON escapes for non-ASCII Unicode codepoints. Just use native UTF-8 encoding everywhere (especially since all the files already have Unicode BOM's in them!). It shouldn't make the readability of the files worse. If anything, it should improve it greatly, especially relative to the source grd files (which use UTF-8), and for native readers. Example delta for Arabic: CHROMEVOX_COLUMN_GRANULARITY - "\u0639\u0645\u0648\u062f" + "عمود" On a Pixelbook, converting all the messages.json files in this way shaves off ~1.4MiB. Bug: 852585 Change-Id: I1978141717bbd69aec5a72c9d6769c6998419c1b Reviewed-on: https://chromium-review.googlesource.com/1099881Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#567085}
-
Yuke Liao authored
I just realized luci.chromium.ci sets the default value of cores to 8, however, the mac-code-coverage-generation builder has 24 cores: https://chromium-swarm.appspot.com/bot?id=build227-m9 Bug: 825362 Change-Id: If017fca1c47b798c2573f50d37e1a7823595181c Reviewed-on: https://chromium-review.googlesource.com/1098645Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567084}
-
Allen Vicencio authored
Implements share discovery for SmbHandler and SmbService using SmbShareFinder Bug: 757625 Change-Id: Ib3baa0b307ab95c17f38b47339f264231831752e Reviewed-on: https://chromium-review.googlesource.com/1089855 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#567083}
-
Hongchan Choi authored
This CL splits the Autoplay-related code from BAC to AC. It simply changes the code location without changing logic. Note that the code around resume() promise resolvers has not been modified in this CL. The code is not directly related to the auto play and it needs a bit of rewriting. Bug: 851608 Test: AudioContextAutoplayTest Change-Id: I2e0b2b10fc56e86e4724635aba0fe452c73c54da Reviewed-on: https://chromium-review.googlesource.com/1097988Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567082}
-