- 18 Nov, 2020 40 commits
-
-
Daniel Cheng authored
Change-Id: I1116d41985a070cc00056205edb5aa7fcf0a9713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547629Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828878}
-
Friedrich Horschig authored
Bug: None Change-Id: Ia849b221bae0d3ad316f3c7c9e0b4f27cdd1cb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547681Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#828877}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: Iece38e6a64fe06e058bdece48ece4f6428e42fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544863Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#828876}
-
Andrew Grieve authored
Reworks several things: * method_count.py now exposes a DexStatsCollector and can take an .aab as an input. * DFMs now report normalized size * DexCache metric now diffs based on min_sdk_version to account for it being smaller on Oreo+. * Trichrome's "Combined_unique methods" no longer double-counts methods that exist in the various APKs. * Fixed a couple files being treated as unrecognized: * assets/icudtl_extra.dat * assets/webapk_dex_version.txt Tested by running //tools/binary_size/diagnose_bloat.py locally with a flag flip for enable_chrome_module=true. Result: +330,788 bytes other lib size +568,824 bytes main dex size +992,148 bytes normalized apk size These results look correct to me. Chrome module does increase size currently. Binary-Size: Changed metric (not a real regression) Bug: 1143687 Change-Id: I8a073d2492b3ff675dc6636cbded5f501763c3aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542803Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#828875}
-
Mason Freed authored
The [1] CL moved many flaky-timeout WPT (and non-WPT layout) tests over to SlowTests, with the expectation that many of them just needed more time. The WPT tests within this set should now be marked via the <meta name=timeout content=long> to benefit other implementations. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2538144 Bug: 1095379 Change-Id: I50a26ebf6dbf5903bdec4ebba5b7b9cc5c5379db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547627 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#828874}
-
Nektarios Paisios authored
This patch is the first, (not user visible), fix for a bug with the reading of lines in NVDA. When the screen reader focus is in the accessibility tree for Views, such as in a context menu, a toolbar or the main application's menu, the "Read Line" command (NVDAKey+Up) doesn't always read the currently focused item. We were exposing ignored views in the accessibility tree that was exposed to platform APIs. As a result, platform specific code under ui/accessibility was building IA2 and ATK hypertext for ignored nodes, while text navigation code in the same component was trying to locate non-existent line boundaries in that hypertext. A followup patch will ensure that the names of Views that come from their contents are clearly marked as such. R=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: n/a. Change-Id: I5fdae5714b10b10db3dc5b5dcf22d118f322e9e7 Bug: 1098528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435645 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828873}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/309eb9b67205..6e44bd85f3a3 2020-11-18 heiserya@google.com Implement support for Lacros in Telemetry. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1148485 Tbr: nuskos@google.com Change-Id: I8173d8285bafab16efd206d0729413c222e6f59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547387Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828872}
-
Majid Valipour authored
We are planning to start the devtrial for the new backend in the next two milestones so updating the flag expiry to reflect this. Bug: 1101050 Change-Id: Ife0ad995225169ec0e3705dfa66d1d5e3706880c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546992Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#828871}
-
David Tseng authored
This change makes it explicitly clear that chromeos::test::SpeechMonitor is meant to be used in test code only. R=dmazzoni@chromium.org Change-Id: If2ae2d9c5cc49b33e8e580ac82298477650f2b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547761Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828870}
-
Nina Satragno authored
Mark http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.js as flaky on all platforms. No-Try: true Tbr: yigu@chromium.org Bug: 1046784 Change-Id: I6b838ff0103d7df2f4dd2fd838a5995a55614a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547881 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828869}
-
Stephen McGruer authored
This rolls up to sha 79331586050ac939313f48167a7a26d9c2332382 Bug: None Change-Id: I37b635ad21cb9ed751209dd09d1b3fae910ebb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545065 Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828868}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If26c9fd5a55e58d960d843a395ba20b2a31931e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546968Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#828867}
-
Matthew Mourgos authored
Crash can be triggered from login screen when any paste is performed and ClipboardNudgeController::OnClipboardDataRead is called. So add a check to see that the clipboard history is enabled in the current mode. Also possible is that ClipboardNudgeController::ShouldShowNudge() is passed a null PrefService*. So add a check for this being null, as well as some checks for null dictionaries. Bug: 1150168 Change-Id: I79e407f3896408af7a44aacf31f15d290c2629c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546085 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828866}
-
Brian Ho authored
As part of the UseRealBuffersForPageFlipTest experiment, OverlayProcessorOzone now uses the primary plane's buffer directly for page flip tests [1]. This buffer is obtained via OutputSurface::GetOverlayMailbox [2] which is unfortunately only implemented for GL-based OutputSurfaces. With SkiaRenderer enabled, OverlayProcessorOzone can't extract the primary plane mailbox and skips promoting overlays at all [3]. This CL implements GetOverlayMailbox for SkiaOutputSurface by threading the corresponding mailbox from the GPU main thread back to the compositor thread via the SwapBuffers callback. Note that since GetOverlayMailbox corresponds to the *last* submitted buffer, we need to skip the primary plane in the event of a reshape because the page flip test result is meaningless. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/overlay_processor_ozone.cc;l=139;drc=a44fcb321ea308b8f8d2227190a99c6cca2b79e6 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/direct_renderer.cc;l=356;drc=a44fcb321ea308b8f8d2227190a99c6cca2b79e6 [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/overlay_processor_ozone.cc;l=210;drc=a44fcb321ea308b8f8d2227190a99c6cca2b79e6 Change-Id: I88d10746ede9bdc8afa565e8a42aef27d5572e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533416 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#828865}
-
Xi Han authored
This reverts commit 661d737a. Reason for revert: this CL didn't fix the issue, and in favour of https://chromium-review.googlesource.com/c/chromium/src/+/2547200. Original change's description: > [Instant Start] Shows identity disc button on Start Surface. > > When Instant Start is enabled, the calculateButtonData() is called > pre-native and early exits without calling the > IdentityDiscController#ensureProfileDataCache(). As a result, the > IdentityDiscController misses the event of the onProfileDataUpdated() > and thus doesn't notify its observer StartSurfaceToolbarMediator to > update the visibility of the identity disc button. > > To fix the issue, we cache the call of calculateButtonData() from the > Start surface if it is called pre-native. When a new Profile is set, we > check if a cached request exists, and call the calculateButtonData() if > yes. Thus, it guarantees to update the button data if Profile has > updated, as well as to notify Start Surface to update the visibility of > the button. > > Bug: 1137535 > Change-Id: I3aca4434ecc74850ee226affd3c3425931cf02a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533522 > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Commit-Queue: Xi Han <hanxi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828362} TBR=pavely@chromium.org,hanxi@chromium.org Change-Id: I942ac76741e193705c757e739a14d4cfca827ae4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546972Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828864}
-
Peter Kasting authored
This is primarily to address the case of "inf / inf", which in terms of doubles is 1, but in terms of TimeDeltas is a checkfailure. Bug: 1148774 Change-Id: Iee4d80a721915ab2251535585153d9f6e2eb7f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545026Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828863}
-
John Lee authored
Fixed: 1145715 Change-Id: I2b5a6660b2dd09a05c24e252df384f01fe3ee49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541746 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#828862}
-
Renato Silva authored
Fix compile error: comparison of integers of different signs: 'const unsigned long' and 'const int' in certificate_provider_apitest.cc:658 EXPECT_EQ(GetAllProvidedCertificates().size(), 1); Change-Id: Iddfb3b8b4015b0f99c337e91a11ddcc92fd9e881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547108 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#828861}
-
Nina Satragno authored
Disable PaymentRequestShippingAddressEditorTest.AsyncData. It's Flaky. Change-Id: I468a82a404ebd93b78f6e4160577d3b690d6d5e3 Tbr: danyao@chromium.org Bug: 1150496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547386Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828860}
-
James Forshaw authored
This CL removes support for the SANDBOX_EXPORTS compile option. The feature is not tested or officially supported. It's common practice to removed unused code where possible. Bug: 610499 Change-Id: I357e8a0a531dc0cbbd263baa77441bb7f97c5585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544878 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828859}
-
Xida Chen authored
This CL moves the paint of the background color off the main thread. Here is the design doc: https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit In particular, we follow the infra of paint worklet. When main thread paints, we create a PaintDeferredImage, which is a place holder that does nothing. And then we create a NativePaintWorkletInput that captures necessary info and pass it to the compositor thread. After commit, we ask the compositor thread to use the information from the NativePaintWorkletInput and paint the background color. Once the paint is done, we activate the pending tree. There is no need to add new test, as long as the current test are passing because this CL should not cause any behavior change. Bug: 1139004 Change-Id: Id487ca3c8511e620bcc652e75199f893227a50e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466140 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#828858}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d14436f82285..2e4ad365f6e4 2020-11-18 tvanderlippe@chromium.org Remove bridge files from inline_editor 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in inline_editor/ 2020-11-18 tvanderlippe@chromium.org Typecheck inline_editor/Swatches.js with TypeScript 2020-11-18 tvanderlippe@chromium.org Remove bridge files in elements/ 2020-11-18 bmeurer@chromium.org [bindings] Fix breakpoint not hit upon first reload. 2020-11-18 jacktfranklin@chromium.org Fix heuristic for determining external bundles in Release If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1150259 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc477a04776447848d11ecef8bd23af00f2f0639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828857}
-
Chris Sharp authored
Users can change it, so it isn't always 3 Change-Id: I71b9cb834ba79414b7590a07601b58d2edb49f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547305Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#828856}
-
Steven Bingler authored
The ordering of columns in the SQL access statements was different from the initial schema. This CL reorders them to match. While it is possible to omit the column names and only reference them by number the code is easier to read/confirm correct by using the names. Fixed: 1149659 Change-Id: Ia60848f5d3b5940b5f283448911ce426271c7328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542943 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#828855}
-
Moe Ahmadi authored
crrev.com/c/2531654 made deletion of queries from the in-memory URL DB asynchronous by posting the deletion task to a sequenced task runner on the UI thread. The said CL was later reverted in crrev.com/c/2532543 for making RepeatableQueriesServiceTest.SignedOut_Deletion flaky. This CL fixes the flakiness by providing a way for the tests to flush the scheduled tasks after deletion from the in-memory URL DB and TearDown() Bug: 1148612 Change-Id: I3f5c7b598a5d6907794b9d6ca1598626156516c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536355Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828854}
-
Omar Morsi authored
This CL handles cases when TPM initialization fails and system token certificate database was requested. It handles this case by introducing a five-minutes-timeout for the database request. Bug: 1068548, 844022 Change-Id: If738218f7816aa9af931fa23c85da39012b86b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410377Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828853}
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //content. R=danakj@chromium.org, jochen@chromium.org, majidvp@chromium.org Bug: 1113033 Change-Id: I819cce1cfa2d16cafb61b963b26e54647eee61ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543696 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828852}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/262a64839ac8..b61a10d6bd1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dmazzoni@google.com,nsatragno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142932 Tbr: dmazzoni@google.com,nsatragno@google.com Change-Id: I6c05680e05728254120c517ed5dd1ccae04543cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547560Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828851}
-
Mark Yacoub authored
Remove useless modesetting tracing from HDC that don't mean much. Add tracing to Screen Manager where modeset test and commit are being orchestrated. BUG: N/A TEST: modeset and unplug connectors while recording on chrome://tracing Change-Id: If6e30326551a47bf22d2acfd530678cc73396cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544444 Auto-Submit: Mark Yacoub <markyacoub@google.com> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#828850}
-
James Cook authored
Lacros does not support multi-signin (aka "Chrome OS multi-profile"). Don't add the Lacros icon to the shelf for secondary accounts in multi-signin session. Likewise, don't add LacrosApps to AppServiceProxy for secondary accounts, which prevents the Lacros icon from appearing in the app launcher. Update the related unit tests so they create a primary user, which is needed for ProfileHelper::IsPrimaryProfile() to return true in tests. Bug: 1142507 Test: unit_tests Change-Id: I8e11b6834500f7da3d2642c087aac31b1e4b2f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542678 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828849}
-
Vasilii Sukhanov authored
The foreign key is gonna be used for the table of compromised passwords. The CL just - activates the feature for the database file (no migration is happening) - Makes SQLTableBuilder aware of it for proper version migrations. Bug: 1137775 Change-Id: Ia891184575094bb6eef4e699db2b5dc2737af994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543155 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#828848}
-
Dirk Pranke authored
Apparently the test() template had a special-case branch for a linux-chromeos build that was not generating bin/run_* wrappers like every other build configuration was. This CL fixes that omission. Bug: 816629 Change-Id: I30852d040675efc62159120b0d2396f2e22ea3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545777Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#828847}
-
Patrick Brosset authored
In the DevTools flex tooling project, we want to be able to control how the empty space (created by justify-content, align-content and gap properties) look. We want to do so in a way that allows to highlight just one, or several of them. So this CL simply adds the required properties to the corresponding CDP types as well as handling of this data so it goes to the overlay frontend. Bug: 1139949 Change-Id: Ibfbd33531f3f2018447d113807f3878b823cfd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539742 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#828846}
-
Kevin Marshall authored
Handles the crasher in which the metrics recorder channel is disconnected while additional metrics are being gathered. Test: cr_fuchsia_base_unittests Bug: 1147146 Change-Id: Iff987933233bd1565ed052b1ca1e1225b30e782d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538331 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#828845}
-
Wez authored
Publishing the fuchsia.web.FrameHost introduces the possibility that it causes the main web.Context to be created before the list of CORS- exempt headers has been fetched. This can prevent headers being applied based on UrlRequestRewriteRules, breaking later users of that Context. StartComponent() is split into the public API which verifies arguments and triggers fetch of the CORS exempt headers list, if necessary, and a separate internal part called when the headers are available, which actually creates the FrameHostComponent, or PendingCastComponent. Bug: 1150488 Bug: b/173386485 Change-Id: I2f294e9f0acbf43c971004882461c0f38a4c37b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547580 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#828844}
-
Stephen McGruer authored
The lack of __init__.py was failing the import in resource-timing/SyntheticResponse.py, which then caused external/wpt/resource-timing/resource-timing-level1.sub.html to timeout. Bug: None Change-Id: I8dc2c9f9d439c7c2c1cbaad9225f24563eb0e99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546993 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#828843}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dda9c164cb3b..d361e6028c27 2020-11-18 primiano@google.com Merge "test data: Add chrome_memory_snapshot.pftrace" 2020-11-18 treehugger-gerrit@google.com Merge "metrics: Add camel-case mapping for modified RAIL mode names" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icdc6cf1da231cde2786ac9462c92f581a934ab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828842}
-
David Tseng authored
It is generally bad practice to send the tts engine an empty string. This change will try to identify all call sites or scenarios where this occurs. If many such instances occur, a allow list (for now) with bugs filed against owners should be added. R=dmazzoni@chromium.org Change-Id: Ie08dd07e07bf43419aadde83786e5724dd196f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538035 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828841}
-
Nina Satragno authored
It's flaky. Tbr: masonfreed@chromium.org Bug: 1150475 Change-Id: I772bf0577ba5d2772340731e7384779238e6734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547383 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828840}
-
Robbie McElrath authored
This reverts commit d5f58580. Reason for revert: A CL this depends on got reverted Original change's description: > [WebLayer] Create FragmentHostingRemoteFragmentImpl > > This CL removes the fake FragmentActivity from SiteSettingsFragmentImpl > and MediaRouteDialogFragmentImpl, replacing them with a Context that > hosts the fragments instead. This is possible now that we've landed > the bytecode rewriting that changes the return type of > Fragment.getActivity() from FragmentActivity to Activity. > > Bug: 1123216 > Change-Id: I98c2c07eb348d6833ca2e5d976110f7f29b5359e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523751 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828649} TBR=sky@chromium.org,finnur@chromium.org,estade@chromium.org,rmcelrath@chromium.org Change-Id: I2b83becfef2a92bd878bf32ae3aa5b750853a752 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1123216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547783Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#828839}
-