GitLab

It makes lock/unlock of AudioSourceProviderClient easier.
This class holds a strong reference to AudioSourceProviderClient. So we
don't need MediaElementAudioSourceNode::m_keepAliveWhileLocking.

BUG=395940

Review URL: https://codereview.chromium.org/416333002

git-svn-id: svn://svn.chromium.org/blink/trunk@178999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, calc values in cubic-bezier functions
weren't being read correctly since they were handled as
simple floats.

R=rob.buis@samsung.com,timloh@chromium.org,alancutter@chromium.org
BUG=388332

Review URL: https://codereview.chromium.org/369313002

git-svn-id: svn://svn.chromium.org/blink/trunk@178998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Disallow new/delete operations for HitTestResult.
HitTestResult was used
-- with new/delete operators
-- as part objects of ContextMenuController and MouseEventWithHitTestResult.
-- as stack allocated objects

We'd like to avoid to make such classes in Oilpan.
So, this CL disallows new/delete, and WebHitTestResult owns another
class to hold only required data copied from a HitTestResult.

- Move ContextMenuController to Oilpan heap, and trace HitTestResult member.

- Mark MouseEventWithHitTestResults STACK_ALLOCATED.

- We can't get HitTestResult from a WebHitTestResult. So we need to
introduce new function to WebViewImpl for WebSubstringUtil.mm.

Difference from r176393:
Always calling HitTestResult member functions was bad. Some of them are
expensive. So WebHitTestResultPrivate contains a HitTestResult copy, and
WebHitTestResultPrivate is RefCountedWillBeGarbageCollectedFinalized in order to
trace HitTestResult.

BUG=357163

Review URL: https://codereview.chromium.org/413903004

git-svn-id: svn://svn.chromium.org/blink/trunk@178997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, the document held by ServiceWorker registered by
the LayoutTests were detected as leaks. The service worker is designed to live
longer than registerer document. The service worker implementation,
|WebEmbeddedWorkerImpl| carries a |WebFrame| to hold a resource loader.
The frame has its associating document, and it confused WebLeakDetector.

This patch work arounds the issue by terminating all |WebEmbeddedWorkerImpl|
instances before counting number of documents.

BUG=396493

Review URL: https://codereview.chromium.org/413993002

git-svn-id: svn://svn.chromium.org/blink/trunk@178996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397892
TBR=hajimehoshi
NOTRY=true

Review URL: https://codereview.chromium.org/415403003

git-svn-id: svn://svn.chromium.org/blink/trunk@178995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chrome does not handle large numbers of layers well and the flakiness
dashboard was creating thousands of them (one for each interpolated
result.) This patch switches to manually calculating the opacity value
and baking it into the css. This is less maintainable but avoids
expensive non-zero opacity layers.

http://hex2rgba.devoth.com is a simple tool I used to calculate the
20% opacity version of the test result colors.

NOTRY=true
TEST=manual. With this patch applied, the flakiness dashboard scrolls smoothly.
BUG=397886

Review URL: https://codereview.chromium.org/421853002

git-svn-id: svn://svn.chromium.org/blink/trunk@178994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/iWDqDWQ8mhs

BUG=243354
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/418133011

git-svn-id: svn://svn.chromium.org/blink/trunk@178992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Minimize RenderObject* casting to RenderText* by providing renderer() methods
on Text and InlineTextBox that return a RenderText. This hides the more generic
renderer() methods in their parent that return a RenderObject.

This is inspired by WebKit r157373 by antti@apple.com:
https://trac.webkit.org/r157373

R=esprehn@chromium.org, pdr@chromium.org

Review URL: https://codereview.chromium.org/414863002

git-svn-id: svn://svn.chromium.org/blink/trunk@178991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=374343

Review URL: https://codereview.chromium.org/421043002

git-svn-id: svn://svn.chromium.org/blink/trunk@178990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing to increase code readability. This CL focuses on
Editor and EditorCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/426433002

git-svn-id: svn://svn.chromium.org/blink/trunk@178988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Of the 2 callers one doesn't really need the conversion and  the other can get
the same results with a local flag.

BUG=

Review URL: https://codereview.chromium.org/412353003

git-svn-id: svn://svn.chromium.org/blink/trunk@178987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing to increase code readability. This CL
focuses on CompositeEditCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/424493003

git-svn-id: svn://svn.chromium.org/blink/trunk@178986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing/ to increase code readability and avoid
unnecessary type checks. This CL focuses on BreakBlockquoteCommand and
Caret.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/419313002

git-svn-id: svn://svn.chromium.org/blink/trunk@178985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178888

BUG=259547
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/419683011

git-svn-id: svn://svn.chromium.org/blink/trunk@178984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178873

BUG=108833,178745,248065
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/420613007

git-svn-id: svn://svn.chromium.org/blink/trunk@178983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178796

BUG=23476,243732,243248
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/414113006

git-svn-id: svn://svn.chromium.org/blink/trunk@178982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178901

BUG=388780,377445
TBR=h.joshi@samsung.com

Review URL: https://codereview.chromium.org/420713010

git-svn-id: svn://svn.chromium.org/blink/trunk@178981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current reparenting logic for overlay scrollbars for compositor-
driven scrollable areas does not account for ancestor clips. The result
is that the scrollbars can escape clips that need to affect them.

Consider the following stacking tree. (The '-' characters in the
following trees should be ignored. I've only added them so that
my indenting doesn't get stripped).

+ stacking-context
- + overflow-hidden-clipper
- + overflow-scroller
- + fixed-positioned-descendant-of-the-scroller
- + relative-positioned-descendant-of-the-scroller

Where, in tree order, these are arranged like this
+ stacking-context
- + overflow-hidden-clipper
--- + overflow-scroller
----- + fixed-positioned-descendant-of-the-scroller
----- + relative-positioned-descendant-of-the-scroller

Since overflow-scroller is clipped by overflow-hidden-clipper, a layer
that is not an ancestor in the stacking tree, it gets an ancestor
clipping layer. If the overflow controls are parented under
overflow-scroller's m_graphicsLayer, everything works fine: the
controls inherit the clip from the ancestor clipping layer.

Unfortunately, if we are using overlay scrollbars, we can't hang
the scrollbars under m_graphicsLayer because they'd stack behind
fixed-positioned-descendant-of-the-scroller and
relative-positioned-descendant-of-the-scroller. In order to get things
stacking correctly, we have to reparent the overflow controls like
this:

+ stacking-context
- + overflow-hidden-clipper
- + overflow-scroller
- + fixed-positioned-descendant-of-the-scroller
- + relative-positioned-descendant-of-the-scroller
- + <overflow controls for overflow-scroller>

If we reparent the controls like this in the graphics layer tree,
the overflow controls will no longer be a descendant of the
ancestor clipping layer that applies the clip for m_graphicsLayer,
unfortunately. In order to get the overflow controls clipped
correctly, we need to ensure that they have a clipping layer
above them. This CL adds m_overflowControlsClippingLayer for this
purpose.

BUG=393926

Review URL: https://codereview.chromium.org/397713004

git-svn-id: svn://svn.chromium.org/blink/trunk@178980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These test cases should have been enabled when Blob support landed, but
were missed.

BUG=108012
R=cmumford@chromium.org,dgrogan@chromium.org

Review URL: https://codereview.chromium.org/414223008

git-svn-id: svn://svn.chromium.org/blink/trunk@178979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that the spec specifies that data should be passed using
ArrayBuffer/ArrayBufferView, change the IDL to match.

BUG=358271
TEST=Updated EME layouts tests pass

Review URL: https://codereview.chromium.org/397463005

git-svn-id: svn://svn.chromium.org/blink/trunk@178978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178952

BUG=394833
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/416403010

git-svn-id: svn://svn.chromium.org/blink/trunk@178977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We must notify nodes that they were removed before calling childrenChanged
because childrenChanged could run script. If don't then the script can remove
the parent and then Element::removedFrom doesn't think the parent is
inTreeScope or inDocument so it'll fail to clean up the TreeScope hash maps
like the id map.

I tried this once before for a different reason in:
https://src.chromium.org/viewvc/blink?revision=175732&view=revision
but that got rolled out because it caused crashes http://crbug.com/382160

By looking at the code it appears that the reason for this is that
m_element in the WebPluginContainerImpl is a raw ptr, and so nothing is
keeping the element alive inside the UpdateSuspendScope. In this patch
I didn't remove the NodeVector, a future patch will attempt to do that.

Unfortunately even when I did remove the NodeVector I couldn't reproduce
the crashes mentioned in the bug, but by code inspection and the crash
stacks it appears to be the situation I described.

BUG=387389

Review URL: https://codereview.chromium.org/418133003

git-svn-id: svn://svn.chromium.org/blink/trunk@178976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the final part of the core infrastructure of Blink-in-JS. This CL implements internal APIs exposed only to private scripts. They are not visible from user's JavaScript. They are needed for moving XSLT and editing/ to Blink-in-JS.

Here is a summary of the IDL extended attributes around private scripts:

interface X {
  aaa();
  [ImplementedInPrivateScript] bbb();
  [OnlyExposedToPrivateScript] ccc();
  [ImplementedInPrivateScript, OnlyExposedToPrivateScript] ddd();
};

- aaa() is a normal DOM method implemented in C++. aaa() is exposed to both user's JavaScript and private scripts.

- bbb() is implemented in a private script. bbb() is exposed to both user's JavaScript and private scripts.

- ccc() is implemented in C++. ccc() is exposed only to private scripts.

- ddd() is implemented in a private script. ddd() is not exposed to user's JavaScript nor private scripts. V8X::ddd() is exposed to C++ so that Blink can invoke ddd() from C++.

In other words, we essentially need the following four kinds of APIs, and the two IDL attributes control the kind of each API.

- user's JS & private scripts => C++ (e.g., aaa())
- user's JS & private scripts => private scripts (e.g., bbb())
- private scripts => C++ (e.g., ccc())
- C++ => private scripts (e.g., ddd())

This design might be a bit confusing but this is the least confusing design we can come up with at the moment.

BUG=341031
TEST=fast/dom/private-script-unittest.html

Review URL: https://codereview.chromium.org/413393003

git-svn-id: svn://svn.chromium.org/blink/trunk@178974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dpranke@chromium.org
BUG=397678

Review URL: https://codereview.chromium.org/421623005

git-svn-id: svn://svn.chromium.org/blink/trunk@178973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178711

BUG=395103,390587
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/422603002

git-svn-id: svn://svn.chromium.org/blink/trunk@178972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178853

BUG=389594
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/419803004

git-svn-id: svn://svn.chromium.org/blink/trunk@178971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178752

BUG=360308
TBR=costan@gmail.com

Review URL: https://codereview.chromium.org/425463003

git-svn-id: svn://svn.chromium.org/blink/trunk@178970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178893

BUG=331119
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/425463002

git-svn-id: svn://svn.chromium.org/blink/trunk@178969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178474

TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/420723009

git-svn-id: svn://svn.chromium.org/blink/trunk@178968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397678
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/420723008

git-svn-id: svn://svn.chromium.org/blink/trunk@178967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178719

BUG=385169
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/419673008

git-svn-id: svn://svn.chromium.org/blink/trunk@178966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hit testing which lands on a pseudo element (eg. :before/:after) is
normally modified (in HitTestResult.setInnerNode) to return the
parent element.  This CL makes touch adjustment consistent with this.
We still adjust towards any pseudo elements, but the final node will
be the pseudo element's parent.

This fixes an issues where checkboxes covered by a pseudo element
(as for chrome://settings custom checkboxes) weren't being activated
on tap.  CheckboxInputType::willDispatchClick is invoked only when
the click event is targetted directly at the <input> element, not
when it bubbles up from a descendant such as this pseudo element.

Prior to 
http://src.chromium.org/viewvc/blink?revision=178098&view=revision
this issue was masked because we did a redundant non-rect hit test
 for the mouseup event using the adjusted position.  Now that we
share the original hit test results the difference of behavior was
exposed to mouse event handlers.

BUG=395942

Review URL: https://codereview.chromium.org/418133010

git-svn-id: svn://svn.chromium.org/blink/trunk@178965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is testing a theory that maybe we are not reliably computing
the pid the apache server is running as on win7, and we are getting
confused over whether the server is running. If this theory is correct,
we should either see the hangs go away, or get some sort of different errors
that might help to debug things.

TBR=eseidel@chromium.org
BUG=378444

Review URL: https://codereview.chromium.org/416243006

git-svn-id: svn://svn.chromium.org/blink/trunk@178964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding the code to extract the raw YUV channels from the JPEGImageDedcoder and the plumbing to go from the skia derived classes all the way down to the decoder.

BUG=

Review URL: https://codereview.chromium.org/418653002

git-svn-id: svn://svn.chromium.org/blink/trunk@178963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397678
TEST=BaselineOptimizerTest.test_virtual_root_redundant_with_ancestors_skip_scm_commands_with_file_not_in_scm
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/423553004

git-svn-id: svn://svn.chromium.org/blink/trunk@178961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the spec, drawing an animated image to a canvas should only
draw the first frame.

BUG=286673

Review URL: https://codereview.chromium.org/388253004

git-svn-id: svn://svn.chromium.org/blink/trunk@178959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When DEBUG_AUDIONODE_REFERENCES is set, a message for the destruction
of an AudioContext is printed, but there's no matching message for the
creation of an AudioContext. Add one to make it symmetric and so we
can see how many contexts are created.

BUG=

Review URL: https://codereview.chromium.org/421603002

git-svn-id: svn://svn.chromium.org/blink/trunk@178958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/422553002

git-svn-id: svn://svn.chromium.org/blink/trunk@178956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing/ to increase code readability. This CL focuses
on ApplyStyleCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/418223004

git-svn-id: svn://svn.chromium.org/blink/trunk@178955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We show console message when they are used.

Intent to deprecate: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2SWnbXAL7Wg

BUG=397429

Review URL: https://codereview.chromium.org/417103002

git-svn-id: svn://svn.chromium.org/blink/trunk@178954 bbb929c8-8fbe-4397-9dbb-9b2b20218538