GitLab

This CL is a follow-up to 776093004 and 811033002 and wires up the UI (WebUI only!) to the disallow shutdown policy.

BUG=312541
TEST=Full browser- and unit-test coverage

WebUI

BUG=

Review URL: https://codereview.chromium.org/871483003

Cr-Commit-Position: refs/heads/master@{#313017}

This moves the functions
 - NormalizeAlgorithm from enterprise_platform_keys_natives to platform_keys_natives
 - sign from enterprise.platformKeysInternal to platformKeysInternal .

Both will be reused by the new platformKeys API.
platformKeysInternal will then be extended about the internal selectClientCertificates function that is needed for platformKeys.

No functional changes.

TBR=arv@chromium.org
BUG=450167
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/847333004

Cr-Commit-Position: refs/heads/master@{#313016}

Replaced all EXPECT_EQ for booleans with EXPECT_TRUE/FALSE

TBR=mnissler@chromium.org

Review URL: https://codereview.chromium.org/874833002

Cr-Commit-Position: refs/heads/master@{#313015}

BUG=451029

Review URL: https://codereview.chromium.org/866753002

Cr-Commit-Position: refs/heads/master@{#313014}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/90acb8e..070eaee

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/874613005

Cr-Commit-Position: refs/heads/master@{#313013}

Cr-Commit-Position: refs/heads/master@{#313012}

Previously, calling print() on the window object for a plugin document
resulted in printing a blank page. This adds an OverridePrint method to
PrintWebViewHelper::Delegate so MimeHandlerViewContainers can replace
the default print behavior with posting a print message to the mime
handler.

BUG=448720

Review URL: https://codereview.chromium.org/858363002

Cr-Commit-Position: refs/heads/master@{#313011}

There's no need for this flag to be sent from ppb_nacl_private_impl.cc
to plugin.cc and back again.  It can stay within
ppb_nacl_private_impl.cc.

This merges two error-handling checks in LaunchSelLdr().

BUG=239656
TEST=browser_tests

Review URL: https://codereview.chromium.org/874603002

Cr-Commit-Position: refs/heads/master@{#313010}

The copies in src/chrome/ were left over from a previous attempt to
put them on the GPU try servers.

These tests are still running on the chromium.gpu.fyi waterfall. The
isolate's build target will be picked up from src/gpu/gpu.gyp.

BUG=451180

Review URL: https://codereview.chromium.org/871813002

Cr-Commit-Position: refs/heads/master@{#313009}

BUG=146464
NOTRY=true
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/874693004

Cr-Commit-Position: refs/heads/master@{#313008}

Suppresses some debugging output unless the test fails. Updates some tests.

BUG=451017

Review URL: https://codereview.chromium.org/866243003

Cr-Commit-Position: refs/heads/master@{#313007}

BUG=417463
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/873943002

Cr-Commit-Position: refs/heads/master@{#313006}

It still partly a controller, but it mostly have view logic.

TEST=Tested manually with to show a Drive banner.
BUG=451658

Review URL: https://codereview.chromium.org/867033003

Cr-Commit-Position: refs/heads/master@{#313005}

This cl:
* Merges in new strings needed by AppRemoting
* Updates some shared strings to make them generic (to
  remove the need for a separate AppRemoting resources target)
* Fixes incorrectly annotated i18n-content strings so that our
  verify_resources script can detect them properly.

Strings that were genericized:
* IDS_DESCRIPTION_AUTHORIZE
* IDS_ERROR_BAD_PLUGIN_VERSION
* IDS_ERROR_INCOMPATIBLE_PROTOCOL
* IDS_ERROR_MISSING_PLUGIN

General strings that were added:
* IDS_ERROR_NOT_AUTHORIZED - Will soon be used by fromHttpStatus

New strings:
* IDS_ERROR_APP_NOT_AUTHORIZED - Used by AppRemoting instead
  of the generic string to provide more info to the user.
* IDS_PRODUCT_NAME_APP_STREAMING - Used instead of IDS_PRODUCT_NAME
  so that we don't need a separate resources target for AppRemoting.
* ...many more, including those that will be used by the host
  code when it is merged...

BUG=

Review URL: https://codereview.chromium.org/873883002

Cr-Commit-Position: refs/heads/master@{#313004}

Otherwise, pixels on the edge of wallpaper may be blended with the pixel outside of the boundary.

BUG=368591
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/871773004

Cr-Commit-Position: refs/heads/master@{#313003}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6a14434..90acb8e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/867383003

Cr-Commit-Position: refs/heads/master@{#313002}

BUG=417463
TBR=yukawa@chromium.org

Review URL: https://codereview.chromium.org/872713006

Cr-Commit-Position: refs/heads/master@{#313001}

BUG=417463
TBR=gwilson@chromium.org

Review URL: https://codereview.chromium.org/871123002

Cr-Commit-Position: refs/heads/master@{#313000}

Concurrently writing with multiple FileWriters causes broken files. This patch
wraps both reading a writing with a queue made of chained promises.

TEST=browser_tests: *ImportHistoryTest*
BUG=None

Review URL: https://codereview.chromium.org/868133004

Cr-Commit-Position: refs/heads/master@{#312999}

Note: ui/ozone/BUILD.gn file (for common ozone), and
      ui/ozone/platform/dri/dri.gypi already have dependency,
      and that's why it wasn't caught by bot.

BUG=None
TBR=spang@chromium.org, gunsch@chromium.org

Review URL: https://codereview.chromium.org/869743005

Cr-Commit-Position: refs/heads/master@{#312998}

BUG=442738

Review URL: https://codereview.chromium.org/799543006

Cr-Commit-Position: refs/heads/master@{#312997}

BUG=417463

Review URL: https://codereview.chromium.org/873883003

Cr-Commit-Position: refs/heads/master@{#312996}

BUG=451286

Review URL: https://codereview.chromium.org/869003003

Cr-Commit-Position: refs/heads/master@{#312995}

Removal of FakePolicyWatcher means that PolicyServiceWatcher is now the only
class derived from PolicyWatcher.  A next check-in should merge PolicyWatcher
and PolicyServiceWatcher into a single class.

Testing via FakeAsyncPolicyLoader rather than FakePolicyWatcher means that
tests cover more of PolicyServiceWatcher code.

I chose to introduce FakeAsyncPolicyLoader, rather than going via an already
existing MockConfigurationPolicyProvier, because 1) this way I can cover more
of PolicyServiceWatcher code and 2) this simplifies the test code (by a) keeping
PolicySchema manipulation within the product code and b) not requiring mocking
of IsInitializationComplete and c) being able to directly call into unmodified
CreateFromPolicyLoader method in the product code).

BUG=368321

Review URL: https://codereview.chromium.org/858303003

Cr-Commit-Position: refs/heads/master@{#312994}

R=maruel@chromium.org, yoz@chromium.org
TBR=jam@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/869783004

Cr-Commit-Position: refs/heads/master@{#312993}

Locking can now succeed even when the range of pages has been
purged. This avoids unnecessary IPC as it reduces the need to
create new DiscardableSharedMemory instances when backed by ashmem.

BUG=429416
TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest*

Review URL: https://codereview.chromium.org/871043003

Cr-Commit-Position: refs/heads/master@{#312992}

Because ImageSkia is not thread-safe, we should restrict
the caller thread of GetImageSkiaNamed() to the UI thread only.

BUG=449277
R=oshima@chromium.org, xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/874483007

Cr-Commit-Position: refs/heads/master@{#312991}

BUG=420680
TEST=NONE

Review URL: https://codereview.chromium.org/869783005

Cr-Commit-Position: refs/heads/master@{#312990}

BUG=450831

Committed: https://crrev.com/d1f7bbc03afac5ff0cc3e7fcca73ff92d1b955e7
Cr-Commit-Position: refs/heads/master@{#312652}

Review URL: https://codereview.chromium.org/823113005

Cr-Commit-Position: refs/heads/master@{#312989}

Revert of Disable Mojo on RenderThreadImplBrowserTest on Android (patchset #1 id:1 of https://codereview.chromium.org/866973004/)

Reason for revert:
This doesn't work in some tests.

Original issue's description:
> Disable Mojo on RenderThreadImplBrowserTest on Android
>
> It hasn't worked from the beginning and it blocks ChannelMojo from
> being enabled.
>
> BUG=451221
> R=jcivelli@chromium.org, sky@chromium.org
>
> Committed: https://crrev.com/b5a99f2c1652471236c5d07403faa42bf53420df
> Cr-Commit-Position: refs/heads/master@{#312875}

TBR=jcivelli@chromium.org,sky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451221

Review URL: https://codereview.chromium.org/873913002

Cr-Commit-Position: refs/heads/master@{#312988}

Fix top crasher with ipc fuzzer. Convert hard checks on |is_started| in Gamepad into dchecks and bailout conditions.

R=bajones, jam
TBR=sadrul@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/873453003

Cr-Commit-Position: refs/heads/master@{#312987}

jam: please review the changes under //src/chrome/browser

blundell: please review the changes under //src/components

waffles: please review the component updater and the update client changes.

The intention here is to move most of the component updater dependencies to update_client, with the goal of creating an update_client Chrome component that encapsulates the details of talking with the update servers, downloading, and invoking installers of CRXs for both extensions and components.

The dependencies should be: component_updater->update_client.

This change just lays down some of the code that will be further used by update_client. No functionality is provided in this change. Also consider the overall goal as WIP; therefore, some of the naming and dependencies are not final. We want to have most of the code in place for future work, but want to minimize the changes to the existing production code and keep the refactoring mechanical for this change.

BUG=450337

Review URL: https://codereview.chromium.org/808773005

Cr-Commit-Position: refs/heads/master@{#312986}

Review URL: https://codereview.chromium.org/696033002

Cr-Commit-Position: refs/heads/master@{#312985}

Pixels around a changed pixel may be affected because of filters applied
by libvpx to reduce block edge artefacts. Our use of active map resulted
in these side-effects being missed from the active map and updated
region, and thereby (ironically) introduced edge artefacts.

BUG=448265

Review URL: https://codereview.chromium.org/869133004

Cr-Commit-Position: refs/heads/master@{#312984}

build/ios/coverage.gypi is conditionaly included into build/common.gypi
for iOS platform.

BUG=441961

Review URL: https://codereview.chromium.org/867323003

Cr-Commit-Position: refs/heads/master@{#312983}

Previously, the coordinate sent for adjusting the text selection was
offset from the line by half the line height. The side effect is that
dragging up/down from large lines, particularly to smaller lines, was
difficult, and sometimes even impossible.

Resolve this by using the smaller of fixed size offset and half the
line height. This eases dragging the selection bounds between lines
that differ greatly in size.

BUG=450640

Review URL: https://codereview.chromium.org/872083002

Cr-Commit-Position: refs/heads/master@{#312982}

Review URL: https://codereview.chromium.org/869363002

Cr-Commit-Position: refs/heads/master@{#312981}

Helper extension/app could have hidden windows created. Kiosk
app session should only be bound with the kiosk app's window and
not affected by them.

BUG=449313

Review URL: https://codereview.chromium.org/873873002

Cr-Commit-Position: refs/heads/master@{#312980}

Ozone-surfaceless renders the scene flipped, so the texture contents are
inverted from what they should be. This fixes the mirroring logic to
un-flip the texture when needed, and also to send the right sub-buffer
update rect.

BUG=434115

Review URL: https://codereview.chromium.org/846063002

Cr-Commit-Position: refs/heads/master@{#312979}

The method is not a simple accessor.

BUG=417532

TBR=satorux@chromium.org (chromeos)
TBR=siggi@chromium.org (browser_watcher)
TBR=mseaborn@chromium.org (nacl)
TBR=davidben@chromium.org (content)
TBR=rsesek@chromium.org (sandbox)
TBR=sadrul@chromium.org (ui)

Review URL: https://codereview.chromium.org/864163003

Cr-Commit-Position: refs/heads/master@{#312978}