- 18 Jun, 2018 40 commits
-
-
Ryan Sturm authored
This UKM is recorded at the same time as the PageLoad UKM so that the data can be tied together. This does not record on pages that did not show the InfoBar. Otherwise, it records 3 states: (a) InfoBar shown, but page not paused (b) page paused (c) page paused then resumed. Bug: 852824 Change-Id: I912774c3c9651e342bfa7435e6adf33bd194fb87 Reviewed-on: https://chromium-review.googlesource.com/1101831 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#568146}
-
Tommy Martino authored
This CL adds the missing scroll functionality to the Views Autofill implementation. Previously, dropdowns that were too tall for their window would extend beyond its boundaries (Win + Mac) or even be cut off entirely (Linux). The major changes include: - Changes to PopupViewCommon to use window bounds, rather than display bounds - The creation of a mock version of PVC for contexts where we cannot safely get the needed window object - Exposing the x and y portions of the calculation logic in PVC - Changes to the dropdown, including the addition of a scroll view, and new logic which determines the needed size. The new size logic first uses the new PVC function to determine the height, then adjusts for the scroll bar if present, then applies existing rules (rounding, minimum, etc.), and finally uses the other new PVC function to get the final width. Change-Id: I4434fa045bfe010d51d582272fbc011b813d3ab0 Reviewed-on: https://chromium-review.googlesource.com/1072427 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568145}
-
Matthew Jones authored
Bug: 852406 Change-Id: Iab6fc1125a0af2feed0c2c3d9918591f9b0bd332 Reviewed-on: https://chromium-review.googlesource.com/1099861 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568144}
-
Luke Bjerring authored
Case was revealed by https://github.com/web-platform-tests/wpt/pull/9794 Specifically, Navigator implements NavigatorUserMedia; Navigator was not being added as a depenedency, and thus was not being imported. Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b Reviewed-on: https://chromium-review.googlesource.com/1104707Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Bj <lukebjerring@chromium.org> Cr-Commit-Position: refs/heads/master@{#568143}
-
Becca Hughes authored
Add a feature for media controls to recognise a gesture and expand into the display cutout. BUG=849790 Change-Id: Ice6de82f4fb94e366fca68338a55236fa1f05c8a Reviewed-on: https://chromium-review.googlesource.com/1087710Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#568142}
-
Jordy Greenblatt authored
Change-Id: I0389ed2168472e524a126d263bd30a52602cdb7e Reviewed-on: https://chromium-review.googlesource.com/1102880 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#568141}
-
Steven Holte authored
BUG=852888 TBR=perezju@chromium.org Change-Id: I773594071fb0e9357af63d3024dd71125cad9723 Reviewed-on: https://chromium-review.googlesource.com/1104880Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568140}
-
Ryan Hansberry authored
This change only plumbs SecureChannelClient into the necessary locations in Tether; it does not actually use it. A subsequent CL will utilize SecureChannelClient, instead of BleConnectionManager, inside MessageTransferOperation. Bug: 824568, 752273 Change-Id: I85adef9c17caf63ce9bea34621fb7a1c4666a3d9 Reviewed-on: https://chromium-review.googlesource.com/1104952Reviewed-by:
-
Bret Sepulveda authored
SetPermissionInfo and SetPermissionInfoForUsbGuard were checking whether Harmony was enabled by checking the feature flag instead of calling MaterialDesignController::IsSecondaryUiMaterial. The latter will return true under Refresh when the former does not. Also deletes some obsolete Mac-only code. Bug: 846410 Change-Id: I9cdf5ec0dee8fb2fcc519fa3c09702014d7342fe Reviewed-on: https://chromium-review.googlesource.com/1103583 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#568138}
-
Sonny Sasaka authored
In https://crrev.com/c/997098, params_ was changed to a local variable, but it needs to last longer than that since net::WrappedIOBuffer may use the data after the local variable goes out of scope. This CL changed it back to be an instance variable. Bug: 851799 Change-Id: I392f8acaef4c6473d6ea4fbee7209445aa09112e Reviewed-on: https://chromium-review.googlesource.com/1103676Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#568137}
-
Quentin Fiard authored
Flag-protected by the EmitGoogleSearchDomainMixingMetrics feature which guards the ServiceIsCreatedWithBrowserContext() method of the factory. The service is never explicitly requested, so this is sufficient to guard the creation of the service. Bug: 825255 Change-Id: Ia62b157ae56edc2806fda0feb214d64be43c0750 Reviewed-on: https://chromium-review.googlesource.com/1087454 Commit-Queue: Quentin Fiard <qfiard@google.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568136}
-
Sarah Hu authored
This CL supports alt+shift+i to open the feedback dialog in views login screen. TBR=tsepez@chromium.org Bug: 852242 Change-Id: I5d124422ade0f1b8f2698520c2cafd7cd7d27382 Reviewed-on: https://chromium-review.googlesource.com/1102035Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#567829} Reviewed-on: https://chromium-review.googlesource.com/1104895 Cr-Commit-Position: refs/heads/master@{#568135}
-
Clark DuVall authored
Bug: 853256 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibb5641a86c89739ef67d9ff8df86bff3f81c3ec0 Reviewed-on: https://chromium-review.googlesource.com/1104950Reviewed-by:
-
Varun Khaneja authored
Also, add kSuspiciousSiteTriggerQuotaFeature to list. Change-Id: Ifa1876d1cf931a217fadb10bb1b9bd5a423a882c Reviewed-on: https://chromium-review.googlesource.com/1103443Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568133}
-
Chris Morin authored
These types and methods are no longer used. Bug: none Test: Ensure OOM scores of android apps are set correctly. Change-Id: Ieef435e504c101ebfeea534b7566dbf4b114c9df Reviewed-on: https://chromium-review.googlesource.com/1093892Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Christopher Morin <cmtm@google.com> Cr-Commit-Position: refs/heads/master@{#568132}
-
Roberto Carrillo authored
The component mapping updater needs the mastername property to be defined. This mixin takes care of that. R=hinoka Bug: 803310 Change-Id: I579375231325cbc89ce31edef16e505eb16c0ccd Reviewed-on: https://chromium-review.googlesource.com/1104796Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#568131}
-
Ryan Sturm authored
This CL starts to refactor the PreviewsBlacklist. The goal is to split Blacklist into it's own component and implement a PreviewsBlackList as a derived class. This CL creates core methods and Previews specific methods that can easily be moved into seperate classes. Further, this cleans the Blacklist <-> OptOutStore API to pass a single object that supports various blacklisting rules. This allows consumers to write their own OptOutStore (or Blacklist) implementation, while getting all of the functionality of the Blacklist. There are TODO's identifying functionality in PreviewsBlackList that will move to a seperate class (base class) or stay in PreviewsBlackList (derived class). Bug: 852593 Change-Id: I684ccb6b1a1b9d0838d34e2db36a8f870aa76fd9 Reviewed-on: https://chromium-review.googlesource.com/1100085 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Change-Id: I3c2237bf6cba439236c951af4859f382211c5785 Reviewed-on: https://chromium-review.googlesource.com/1104899Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#568129}
-
Luis Hector Chavez authored
This change makes it possible to allow interfaces to globally handle unhandled RuntimeExceptions, in their bindings or in the callbacks. delegate can now forward the unhandled exceptions to the crash server. Bug: 810087 Test: Android-on-Chrome OS has the same behavior as before Test: Android-on-Chrome OS, when setting the DefaultExceptionHandler's Change-Id: I2b7455a0344a109e1d2416a74ad4a0b98cd007f0 Reviewed-on: https://chromium-review.googlesource.com/1101898Reviewed-by:Ken Rockot <rockot@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568128}
-
Sadrul Habib Chowdhury authored
BUG=778749 Change-Id: I3ff438e53838e3e8c9c387fab837af0a31bcdac2 Reviewed-on: https://chromium-review.googlesource.com/1101643Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568127}
-
danakj authored
These methods are only valid when the Layer is in a Layer tree attached to a LayerTreeHost, making them difficult to use. Also, they don't use any private stuff from Layer so they don't need to be part of its API. Instead have code that knows about the LayerTreeHost get the MutatorHost off that. PropertyTrees code could also but doesn't have the LayerTreeHost/LayerTreeImpl passed in today. HasTickingAnimationForTesting() was being tested to return false when the Layer is not attached to a LayerTreeHost, which is testing test-only code. Remove those cases. Instead have tests query the MutatorHost directly. R=weiliangc@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id384e3cef22d62c65e4c63411bdbfd603993f5ce Reviewed-on: https://chromium-review.googlesource.com/1101416 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568126}
-
Aga Wronska authored
Showing demo mode setup UI is already guarded by the appropriate screen group check. This check is sufficient. Change-Id: I61478bb0e0a4933a2f6869781b7a9b115d926f08 Reviewed-on: https://chromium-review.googlesource.com/1104974Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#568125}
-
Raymond Toy authored
Print a deprecation message when WebAudio Media nodes (MediaElementAudioSourceNode, MediaStreamAudioDestinationNode, MediaStreamAudioSourceNode) are created on an OfflineAudioContext. Doing so is not allowed in the WebAudio spec. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/H29uXnsIN54/BKXDqxoJAQAJ Chrome feature entry: https://www.chromestatus.com/feature/5258622686724096 Bug: 845913 Change-Id: I5247d67456afa11582099f4d52d65a76f788639d Reviewed-on: https://chromium-review.googlesource.com/1091656 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#568124}
-
Aleks Totic authored
Will need help with this one. I think it is a real regression. Offending CL modifed LayoutBox::AvailableLogicalHeight https://chromium-review.googlesource.com/c/chromium/src/+/1093996 LayoutBox::ComputePercentageLogicalHeight gets called 740 times for each layout. I was unable to reproduce this on my Linux box. Uploading so I can run on Android. The test also renders incorrectly in Legacy, correctly in NG. The root cause of incorrect rendering is that LayoutBox::ComputePercentageLogicalHeight for TableCell is incorrect in Legacy when: #target { overflow: auto; height: 100%; } td { height: 100%; } table { } <table> <td> <div id="target"> LayoutBox::ComputePercentageLogicalHeight should in this case return intrinsic_logical_height instead of 0. Bug: 852976 Change-Id: Iaf65c226eb9727877d14e68156d522421af57c87 Reviewed-on: https://chromium-review.googlesource.com/1103289Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568123}
-
Ryan Sturm authored
This fixes a typo in the capping heavy pages flag string and removes the text around Renderer side resource scheduler, since that has already launched. Change-Id: Ic0662f4621d2c7094f2c2ec8b2e3591c61e300cf Reviewed-on: https://chromium-review.googlesource.com/1104888Reviewed-by:
-
rbpotter authored
In normal print preview dialogs, the handler is destroyed with the web contents, but for the special case of chrome://print this does not occur, and old preview requests should be cleared in OnJavascriptDisallowed(). Bug: 853672 Change-Id: I5681680dc64fe020f389c6893d992694e8fcdb95 Reviewed-on: https://chromium-review.googlesource.com/1104877Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568121}
-
danakj authored
With an image theme we use kPlus blending mode so that the alpha of the active and inactive images together adds to 255, and is opaque. Before 8f007b92 we did the same for solid colors as well. But afterward it was lost, only applying to images. This CL restores the kPlus mode for solid colors too. R=oshima@chromium.org Bug: 852612 Change-Id: I6f581d34dea85d98dc602e34a4ad87e4115d2d8c Reviewed-on: https://chromium-review.googlesource.com/1103012Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#568120}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a735a26. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 1db32e09 "OffscreenCanvas Text rendering tests" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" de5c1819 "Do not override kReattach for ::first-letter." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19913 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: I9b054e2564ef14693127be1bc1cfa936a578a774 Reviewed-on: https://chromium-review.googlesource.com/1104784 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568119}
-
Sadrul Habib Chowdhury authored
DidNotSwap() no longer needs to return any value. crrev.com/567297 removed the last instance of a persistent SwapPromise that would return KEEP_ACTIVE. Now that it's gone, the associated code can be removed. BUG=851504 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I12d5af548800ac8674c1ab11f38c9aeb73338941 Reviewed-on: https://chromium-review.googlesource.com/1103944Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568118}
-
Zhongyi Shi authored
Fix QUIC connection migration to cancel migrate back to default if an earlier migration has brought the session to the default network. This change also converts obsolete V1 tests for V2, adding regression test coverage. Bug: 818259, 843299 Change-Id: I8abfdb9af15af132efab62686fb014502e641198 Reviewed-on: https://chromium-review.googlesource.com/1103222 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568117}
-
Daniel Bratell authored
There is both ::extensions::api::storage and ::storage so inside extensions::api, unless you explicitly write ::storage it's unclear what namespace is intended. In jumbo builds, some code ended up in a translation unit where both storage namespaces were known, so this patch adds :: to storage to make the code explicit. There is a code style guideline to not use namespace names that are also top level namespace for this reason, but it's not easy to change all extension api namespaces. Bug: 850484 Change-Id: I1c85fbc9dd3dc8be49d41be25f4886ec98c47926 Reviewed-on: https://chromium-review.googlesource.com/1104678 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Paul Miller authored
BUG=655167 Change-Id: I2b18f52fae92993f1e37852924d8cbaf19872eaf Reviewed-on: https://chromium-review.googlesource.com/1103395Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568115}
-
Balazs Engedy authored
This CL introduces AuthenticatorSheetModelBase, which will serve as a base class for sheets, and implement the shared behavior used on most sheets, as well as maintaining a weak pointer to the dialog model. Also introduce CreateSheetViewForCurrentStepOf, a factory method that constructs the appropriate SheetView subclass, along with the appropriate SheetModel subclass. Bug: 849323 Change-Id: Iaedb3da6aa3f3fdc932b57cc5795143acab7d4c5 Reviewed-on: https://chromium-review.googlesource.com/1104422Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568114}
-
Steven Holte authored
Flakily timing out. BUG=853852 TBR=ekaramad NOTRY=true Change-Id: I894fe217109a63e86ed5aa2b2be2c801b8f91d76 Reviewed-on: https://chromium-review.googlesource.com/1104977Reviewed-by:
-
Fabrice de Gans-Riberi authored
This removes all the remaining disabled tests in the filter file for base tests on Fuchsia and instead filters each of them individually. Bug: 738275, 752368, 753490, 810077, 811881, 851734, 851747, 851759, 851760 Change-Id: I375954138d09ebacc05b2ad37afe1e09901e52e2 Reviewed-on: https://chromium-review.googlesource.com/1096483Reviewed-by:
-
Pedro Amaral authored
The model properties should be agnostic to the view implementation. ANDROID_VIEW_VISIBILITY was an int but that was view specific and really all the mediator needs to interact with is whether or not the Android View is visible. Change-Id: I0daa79cc0d5a4a2a1a5c7b2443eee731525baa66 Reviewed-on: https://chromium-review.googlesource.com/1103545 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
-
Jun Cai authored
Network Service: Add VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromRequestUsingSimpleURLLoader This CL adds variations http headers browser which uses SimpleURLLoader. Bug: 841309 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I16bc257c18b76f0b2ba6b9ba721b87f4e3fb44a7 Reviewed-on: https://chromium-review.googlesource.com/1100106 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568110}
-
Kai Ninomiya authored
Bug: 828135 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9ac4b3d671bee44c574f1a75ca357296a34f1cba Reviewed-on: https://chromium-review.googlesource.com/1098558 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568109}
-
rbpotter authored
Since /deep/ is deprecated in shadow DOM v1, track highlights and search bubbles as they are added to avoid searching recursively to remove them later. Bug: 852098 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iac61a1f340ae4029589556c3ad09e567126a1639 Reviewed-on: https://chromium-review.googlesource.com/1100102 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
Add a BOOT_ANIMATION_OVERLAY type for the initial animation happening at startup. Add a CORNERS_OVERLAY type for window mask around the display corners. BUG=b/110092844 TEST=None Change-Id: Ifde30aeb490171e2f3daf0bb727f9e70e6e6ced4 Reviewed-on: https://chromium-review.googlesource.com/1103301 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#568107}
-
