GitLab

It is possible in case of partial requests for transactions to go from
reading the response body back to reading headers for the next range
and then back to reading the response body.
In some code paths the |io_buf_len_| is set to the headers length and
then used as the length of the read buffer provided by the calling site
which is incorrect. More details in
https://bugs.chromium.org/p/chromium/issues/detail?id=986211#c66

This CL fixes the issue by having a separate member field read_buf_len_
which is only set to length of the read buffer provided by the calling
site in Read().

Manually verified the asan issue reproduced while loading the site
http://mahokubota.com doesn't come after this patch.

Bug: 986211
Change-Id: I223656e7e1eb8906d1e0415fac184faea1042b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747389Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686118}

Add GetCreationTime() function to profile, which returns the date/time the user profile was created.

This is needed for use in the trigger checks for HaTS.

Bug: 807714
Change-Id: I53567f417d5342a6209fc1e838323860085118a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730835
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686117}

A link to a source is now displayed in the element properties panel.
Clicking on the link opens the source panel where the header file is
loaded. Right clicking on the link gives the option to open in new tab,
which opens the header file in Chromium code search.

Change-Id: I0314ff285e727bdcc7a9a58201cb6f9089a4c718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719164
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686116}

There was starting to become a long list of these and it was a little
unclear what each of them were for.  This should help.

Change-Id: I930d1f7d693839501175b3b452f8499dbadca228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747384Reviewed-by: Siyu An <siyua@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#686115}

This CL adds the support of temporary license support to FuchsiaCdm.
FuchsiaCdm maintains a map from session ID to its corresponding
fuchsia::media::drm::LicenseSession. Besides, it simply converts
Chromium data types into fuchsia data types.

Bug: 966191
Test: Shaka player WV content "Dig the Uke". Tested with other CLs.
Change-Id: I21776910158eacb228d940b1747f6fcb1fab494c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743251
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686114}

Bug: none
Change-Id: I8571ec4c3dd7f54de4af133a5aabaa4203d2a5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741972
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686113}

Unlike Web Bluetooth or WebUSB where developers are expected to filter
devices based on model or capability it is common to not be able to
determine the device connected to a serial port and so many applications
will want to match all ports. This change makes the requestPort()
options parameter optional.

Bug: 884928
Change-Id: If3017c7331020fdb4a62c9b195bef8ba0ef0169e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749460Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686112}

This is a reland of 7da07070 and
d77c5029

Compositor and window event target is associated with window's parent.
We call LRWHH UpdateParent when window's parent update, includes
window's parent actually update and window initialize. Recreate
DirectManipulationHelper on every window's parent update helps keep
DirectManipulationHelper lifecycle tracking simpler. We also make
CompositorAnimationObserver owned by DirectManipulationHelper.

With this changes, we start the DirectManipulation event polling when
DirectManipulationHelper created and stop when it destroyed. The issue
should be fix since event polling start no more depends on
DM_POINTERHITTEST.

This CL also includes 3 refactoring changes:

1. Move CompositorAnimationObserver into DirectManipulationHelper.
2. Call ZoomToRect to reset viewport of DirectManipulation when
   viewport is actually transformed in RUNNING - READAY sequence.
3. Pass the viewport size to DMEventHandler and use it to reset viewport
   at gesture end.

The original changes caused a regression that browser UI composition
keeps ticking begin frames. We register DirectManipulationHelperWin
as an AnimationObserver of ui::Compositor. UI compositor will ask for
begin frames as long as it has an AnimationObserver. We should call
OnCompositorShuttingDown() when the compositor is going Idle. Therefore,
I added a IDirectManipulationInteractionEventHandler that adds the
observer when a manipulation begins, and removes it when manipulation
ends. After my fix, we start the DirectManipulation event polling when
DirectManipulation interaction begin and stop when DirectManipulation
interaction end.

Bug: 914914
Change-Id: I9f59381bdcc6e4ed0970003d87b26ac750bfb42d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689922Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Siye Liu <siliu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#686111}

This CL adds a holdback similar to the GWS holdback. Also, it removes
the preconnect from the GWS holdback experiment to more accurately
reflect what would happen if GWS did not send the link rel preload at
all.

Bug: 992542
Change-Id: I9e36103b37490305922443865990fa45475a12e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746797
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686110}

This patch updates enums.xml with the correct data from
use_counter_helper.cc.

It seems that one of the patches (2b9ff484) didn't add the
properties to the enum, and a follow-up patch (d6622944) added
wrong numbering.

The effect of this patch is that overscroll-behavior* use counters will
now correctly track the right properties. The previous values will now
track inherits and initial-value.

R=majidvp@chromium.org, andruud@chromium.org, asvitkine@chromium.org

Change-Id: If196a42d6bfb783200cc4d687efb67eabe5aee1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749548Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686109}

NOPRESUBMIT=true

Bug: 969748
Change-Id: Iff4c144ab4072ff64915c08a02ce61426ddd32f3
Binary-Size: Increase in size occurred because components/supervised_user_error_pages was moved to chrome/browser/supervised_user
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681360
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686108}

This change adds a switch to explicitly enable or disable the YUV
decoding feature for WebP images: decode-webp-images-to-yuv. We target
M81 for flag expiry, by which point we hope the Finch trial will have
ramped up to 100% on Stable and YUV decoding for WebP images will be
the default.

Bug: 900264
Change-Id: I8bc48894b18b9e38fa3b9cfe7e8fdd21828a8c7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749142
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686107}

Prior to this CL, inline elements with backdrop-filter did not
get a PaintLayer, because BackdropFilter wasn't in the list
of attributes in CreatesGroup. That is now fixed. This was not
noticed until recently because the backdrop-filter element did
not create a containing block prior to [1].

[1] https://chromium.googlesource.com/chromium/src/+/4be7920fee20fd21f5c4dc432dc18d2579a487fd

Bug: 992549
Change-Id: I79d8777a178eca488bb76b0909ca815467e34fdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745600
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686106}

https://pdfium.googlesource.com/pdfium.git/+log/f97fd060af46..31fc760897f7

git log f97fd060af46..31fc760897f7 --date=short --no-merges --format='%ad %ae %s'
2019-08-12 tsepez@chromium.org Move more logic from fpdf_save.cpp down into CPDFXFA_Context.
2019-08-12 tsepez@chromium.org Remove dependence of fpdfxfa on fpdfdoc.

Created with:
  gclient setdep -r src/third_party/pdfium@31fc760897f7

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: I0ba828f5a93f8c0787eb42d927030d7ba2125931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749582Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686105}

Bug: 809294
Change-Id: I9d8a6de52f1d861678627a81c3420bf842c0e61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744886
Commit-Queue: Jenna Himawan <jhimawan@google.com>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686104}

Based on discussion at https://github.com/immersive-web/webxr/issues/783 ,
we are confident this will become a requirement in the WebXR spec.

Also update the OpenVR render loop to re-send the input source description
when the profiles array is updated.

Bug: 989244
Change-Id: I77bb2b15d894fe41c532235b062163bdc87a4ea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744663Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686103}

Bug: 913424
Change-Id: Ieda6e90d92875a38912ea8cd8739849013dbe7f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743538
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686102}

This CL creates AppCacheBackend per ApplicationCacheHost, not per renderer
process, to avoid the main thread dependency from ApplicationCacheHost. This is
a preparation for creating ApplicationCacheHost for nested dedicated workers on
worker threads after PlzDedicatedWorker is enabled.

When PlzDedicatedWorker is disabled, dedicated workers depend on their parent
Document's ApplicationCacheHost on the main thread.

Bug: 945673
Change-Id: I7a2cd2c76bcf91771f7ffd22fb4975b411b07748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746508
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686101}

This change adds a helper function which checks the status code of the
JSON validation functions in order to log a more descriptive error
message.

Bug: 811931
Test: tested manually on asuka device
Change-Id: Ib972567ae710526bee8df18eaf9cecdb2180a374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745430
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686100}

https://chromium.googlesource.com/angle/angle.git/+log/d7500aa800b6..3b3fe83788c5

git log d7500aa800b6..3b3fe83788c5 --date=short --no-merges --format='%ad %ae %s'
2019-08-12 jmadill@chromium.org Use BufferID in place of GLuint handles.

Created with:
  gclient setdep -r src/third_party/angle@3b3fe83788c5

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Bug: None
Change-Id: I00ca315fdddd0e510f6761b2900ec0a061c72b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749001Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686099}

This reverts commit 6b30d4e5.

Reason for revert: Affected test is Gtest-based, not Telemetry.

Original change's description:
> Switch GPU Angle perf to histograms
> 
> Switches the GPU Angle perf tests to use histograms instead of the
> default ChartJSON format. The use of ChartJSON was causing the uploader
> script to try to upload to the perf dashboard via the IP whitelisted
> endpoint instead of using a service account, which was causing the
> upload to fail.
> 
> TBR=kbr@chromium.org
> 
> Bug: 924618
> Change-Id: I7238ff3fe188e3983e91e6391e52fb417caedfd4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749455
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686089}

TBR=kbr@chromium.org,bsheedy@chromium.org

Change-Id: I19476a505cc3178a343987407fe0cd63fe017111
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 924618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749706Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686098}

Add a comparison for did_device_registry_change_.

Also, simplified the function by extracting the ClientDirective
comparison and simplifying that logic.

Bug: 951969
Change-Id: I61809ed953e711502c3a058c51cc1315888e8e20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747376
Commit-Queue: Josh Nohle <nohle@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686097}

This was requested in the bug, but it didn't make it into the previous
CL.

Bug: 985961
Change-Id: I94946912d4984d052475eaf6584e459c684b1ebd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745131Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#686096}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bcb0bef6093..44d77e47f726


Created with:
  gclient setdep -r src-internal@44d77e47f726

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I769c2109f864d16ef9fc80865b0cf14ebd954816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748998Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686095}

Bug: 951969
Change-Id: I02fec9c2da5c0ceacc369ee4cd0a4d1b5ddf5d88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747374
Commit-Queue: Josh Nohle <nohle@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686094}

Bug: 991971
Change-Id: I409166eceee48f43e589bded02bb0938e01349fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748947Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686093}

Bug: 983721
Change-Id: I15043932968a789bf7f38090ebe78436e32831f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744789Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686092}

https://android.googlesource.com/platform/external/perfetto.git/+log/4a4990f4c78c..703b48c36369

git log 4a4990f4c78c..703b48c36369 --date=short --no-merges --format='%ad %ae %s'
2019-08-12 nicomazz@google.com Merge "Add event_tokenizer_errors stat for interning errors"
2019-08-12 lalitm@google.com Merge "trace_processor: change diff test script to output final JSON format"

Created with:
  gclient setdep -r src/third_party/perfetto@703b48c36369

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I3aaf0c5aac1f68d5bcbbcb886844d2ec09533a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748999Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686091}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

Bug: 968047
Change-Id: I2d71d797e509699f21e328b99c89543f34afe831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748896
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686090}

Switches the GPU Angle perf tests to use histograms instead of the
default ChartJSON format. The use of ChartJSON was causing the uploader
script to try to upload to the perf dashboard via the IP whitelisted
endpoint instead of using a service account, which was causing the
upload to fail.

TBR=kbr@chromium.org

Bug: 924618
Change-Id: I7238ff3fe188e3983e91e6391e52fb417caedfd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749455Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686089}

Both MSE_ExternalClearKey and SRC_ExternalClearKey have began failing more
consistently. However each failure appears to be the test suite verifying state
too early. We've seen similar patterns in other tests, where SkiaRenderer
changes the timings enough that races within the tests are exposed.

This change updates the filters to skip the affect test suites until we can look
into giving them an appropriate startup synchronization.

TBR=cblume@chromium.org
TEST=vulkan_content_browsertests

Bug: 963266
Change-Id: I2bce1c75d59f49cc8797ba00889d1be435333f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748005Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686088}

Change-Id: I94b3b294a915410cb1451007679d4bfcbb983805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748075
Auto-Submit: Scott Haseley <shaseley@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686087}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

TBR=eladalon@chromium.org, sergeyu@chromium.org

Bug: 968047
Change-Id: I48c2cec9df44fe4f2a27bed84163e459d4a39b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729156Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686086}

The template was deleted in 212f516e

Change-Id: I47d1888d00bbb00b183e6ee24383bf50c4932a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748001Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686085}

This param is not necessary, since glue layer will figure out the
WebView instance.

In prepare of http://crrev/c/1745462.

Bug: 918065
Change-Id: I7f64f37943d008f3160a5201a7d34d77f97db9ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747247
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686084}

Update the LocalizedControlType of <output> to "output" per
https://w3c.github.io/html-aam/#el-output

The DumpAccessibilityTreeTest.AccessibilityOutput was disabled without a bug
link, so I re-enabled it and updated the stale baselines.

For <input type='color'>, update the ControlType to "button" and
LocalizedControlType of "color picker" per
https://w3c.github.io/html-aam/#el-input-color

Bug: 991746
Change-Id: Ibe4908e1195d25048ceb2ed6716e3bbad2f1515b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743195Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#686083}

The cellular setup flow relies on a utility script which loads a
<webview> using a POST instead of a GET.

This script previously was only part of the old setup flow, but the new
flow also requires use of this script. Thus, I moved the script to be a
shared resource, renamed it from mobile_setup_util.js to
webview_post_util.js, and updated from the "mobile" naming scheme to
"cellular" instead.

Bug: 991826
Change-Id: I5cad54c9b37cd6404abc37e0cf93b0d23a82949e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743269Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686082}

This simply add the necessary plumbing to get the total Chrome RSS from
SystemMonitor, the part that computes this metric hasn't been
implemented yet but having this will allow working on the components
that will eventually need this (in parallel to the work being done to
implement this metric).

Bug: 992959
TBR: chrisha@chromium.org
Change-Id: I3faec2f5092ece2d56f7483e118ab0d7c0de6946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741637
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686081}

New Fields:
  - DeviceFeatureStatus.FeatureStatus.last_modified_time_millis
  - DeviceFeatureStatus.FeatureStatus.enable_exclusively
  - ClientAppMetadata.droid_guard_response
  - ApplicationSpecificMetadata.bluetooth_enabled

Deprecated Fields:
  - BatchSetFeatureStatusesRequest.enable_exclusively

Note: No changes to cryptauth_proto_to_query_parameters_util.{h,cc}
were needed; none of the new or deprecated fields are converted to
query parameters as part of GET requests.

Also added and revised some comments.

Bug: 899080, 951969
Change-Id: I4fbc6a68a268261ea8debdb5fe9a2150d1e96442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746553
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686080}

There is a bug which sometimes can occur where a AXMenuList is marked
as needing to update its children when it does not have children
yet. When the children are created the NeedsToUpdateChildren flag is
not cleared.

During created of the AXMenuListOptions (part of AXMenuListPopup's
AddChildren) they call to check if AXMenuListPopup needs update it's
children and runs through the adding children, not realizing we're in
the middle of an AddChildren call. When it returns the child vector is
actually populated and it re-adds the very same AXMenuListOption to
the vector. This creates the duplicate children.

This resolves the problem by simply ensuring regardless of child
status, the NeedsToUpdateChildren is always cleared before re-adding
children.

Bug: 987702
Change-Id: Ifc24681123f2b2bfeb4e9ecc23a897e669bb5b51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735456Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Jessica Tallon <jtallon@igalia.com>
Cr-Commit-Position: refs/heads/master@{#686079}