GitLab

R=mark@chromium.org
BUG=93548
TEST=

Review URL: http://codereview.chromium.org/7740030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98326 0039d316-1c4b-4281-b951-d872f2087c98

case the navigator changes while a menu is showing (as could happen if
a tab closes).

BUG=92994
TEST=make sure bookmark menus still work; covered by tests too.
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7749011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98324 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94219
TEST=manual

Review URL: http://codereview.chromium.org/7745032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19082
TEST=manual testing

Review URL: http://codereview.chromium.org/7745031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98321 0039d316-1c4b-4281-b951-d872f2087c98

FAILED  ] ExternalTabUITest.FLAKY_HostNetworkStack (90498 ms)
FAILED  ] ExternalTabUITest.FLAKY_HostNetworkStackAbortRequest (90681 ms)
FAILED  ] ExternalTabUITestPopupEnabled.FLAKY_UserGestureTargetBlank (46071 ms)
FAILED  ] ExternalTabUITestPopupEnabled.FLAKY_WindowDotOpen (45892 ms)

BUG=61023,42545
Review URL: http://codereview.chromium.org/7749018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98320 0039d316-1c4b-4281-b951-d872f2087c98

Our previous PreRead experiment involved flipping a coin on every launch, but we wish to persist the coin-toss between launches. Additionally, this version of the field trial includes an expiry date and limits it to the canary and dev channels.

We are unable to use the FieldTrial mechanism due to PreRead occuring prior to chrome.dll being loaded. As such, we use the registry for persisting the coin-toss and environment variables for communicating between chrome.exe and chrome.dll.

Review URL: http://codereview.chromium.org/7712014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98319 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=tree green
Review URL: http://codereview.chromium.org/7722001

TBR=zmo@google.com
Review URL: http://codereview.chromium.org/7749022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98317 0039d316-1c4b-4281-b951-d872f2087c98

- Added testing for drag and drop involving multiple panels.
- Refactored the code to make it clear what's being tested.
- Refactored to simplify the test code so we don't worry about bugs in
  test code. Comes with some loss of compactness but is the right
  trade-off for test code.

TEST=none
BUG=none

modified:   chrome/browser/ui/panels/panel_browsertest.cc
modified:   chrome/browser/ui/panels/panel_manager.cc
modified:   chrome/browser/ui/panels/panel_manager.h

Review URL: http://codereview.chromium.org/7706027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=print preview works after code changes.

Review URL: http://codereview.chromium.org/7740025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98313 0039d316-1c4b-4281-b951-d872f2087c98

Get views::Widget rendering working against an aura::Window NativeWidget.

http://crbug.com/93944
TEST=none
Review URL: http://codereview.chromium.org/7741027

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7749020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93777

Review URL: http://codereview.chromium.org/7753012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98308 0039d316-1c4b-4281-b951-d872f2087c98

The code is now a lot simpler, and unit tested.
The dlopen hack and the timeout hack are now gone.

BUG=90036
TEST=confirm that the geolocation works on maps.google.com on a device with wifi network

Review URL: http://codereview.chromium.org/7725001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98307 0039d316-1c4b-4281-b951-d872f2087c98

Get views::Widget rendering working against an aura::Window NativeWidget.

http://crbug.com/93944
TEST=none
Review URL: http://codereview.chromium.org/7741027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98306 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98305 0039d316-1c4b-4281-b951-d872f2087c98

```---------------------------------------------------------------------
r826 | mark@chromium.org | 2011-08-25 17:19:29 -0400 (Thu, 25 Aug 2011) | 14 lines

Fix CalculateStackSize to behave properly when the main thread's stack is
split up into multiple regions.

An older workaround relyied on known fixed stack locations and only filled in
the initial page of the stack if it was in a distinct region. The new approach
looks upwards for additional regions that appear to be part of the same stack.

With PIE on Lion, the stack no longer begins at a fixed address, so the older
workaround became ineffective.

BUG=247, chromium:94107
TEST=Stacks should run through to _main/start and then stop when examining
     Chrome on Lion with PIE and "slid" stacks.
Review URL: http://breakpad.appspot.com/300001
```

---------------------------------------------------------------------

BUG=94107
TEST=Stacks should run through to _main/start and then stop when examining
     Chrome on Lion with PIE and "slid" stacks.
Review URL: http://codereview.chromium.org/7744038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98304 0039d316-1c4b-4281-b951-d872f2087c98

Always create InputMethod object instead of being lazy.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7744029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=tree green
Review URL: http://codereview.chromium.org/7722001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98302 0039d316-1c4b-4281-b951-d872f2087c98

Moving from NaCl repo to Chrome repo requires us to add an
OWNERS file.

BUG= none
TEST= none
Review URL: http://codereview.chromium.org/7749009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98299 0039d316-1c4b-4281-b951-d872f2087c98

Add member to Node to return a set of unique releases for that node.
Updates DefineStruct to iterate across all unique releases for the
struct, generating first the most recent release as we do today
and other releases without comments, and the version number 
appended to the structure name.

NOTE: This is work in progress. This CL adds support for
Interfaces that change which should be enough for M15.  While this
same CL creates multiple structures when the structures change, 
references to structures will not have mangled names which would 
cause errors.

BUG= http://code.google.com/p/chromium/issues/detail?id=89969
TEST= python generator.py --cgen --test --diff --range=M13,M14
Review URL: http://codereview.chromium.org/7751001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93049
TEST=View bookmarks folder with large number of bookmarks, should quickly display the first 60 items.
Review URL: http://codereview.chromium.org/7701013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles

Review URL: http://codereview.chromium.org/7715020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98294 0039d316-1c4b-4281-b951-d872f2087c98

This static method branches the CreateSelfSigned code to create a self signed certificate that contains an X509v3 extension that indicates the ASCII weborigin that is bound to the generated certificate.

BUG=88782
TEST=


Review URL: http://codereview.chromium.org/7384002

TBR=mdietz@google.com
Review URL: http://codereview.chromium.org/7740034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98293 0039d316-1c4b-4281-b951-d872f2087c98

iWe should use system path of the device that contains partitions block device, instead partitions system path as notifications identification path.

e.g.
/sys/devices/pci0000:00/0000:00:1d.7/usb1/1-6/1-6:1.0/host9/target9:0:0/9:0:0:0
instead of
/sys/devices/pci0000:00/0000:00:1d.7/usb1/1-6/1-6:1.0/host9/target9:0:0/9:0:0:0/block/sdb/sdb9

TEST=Manual on Cr48 (tried multiple-partitioned device with no good partitions, with one good-partition, device with one partition)
BUG=chromium-os:19559


Review URL: http://codereview.chromium.org/7748003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=86361
TEST=None

R=mirandac@chromium.org,erg@chromium.org

Review URL: http://codereview.chromium.org/7715032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98291 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r98287.

BUG=93804

Review URL: http://codereview.chromium.org/7749017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98290 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the webrequest API documentation to state that requests that cannot be associated with a tab are labeled with "tabId = -1" instead of "tabId = null".

I chose to update the documentation rather than the code for two reasons:
- As 0 is a valid value for the tabId, we would need to distinguish between 0 and null.
- For the RequestFilter type, 'tabId' is an optional parameter. I.e. we would need to distinguish between 0, null and undefined.

BUG=93373
TEST=no


Review URL: http://codereview.chromium.org/7741014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98289 0039d316-1c4b-4281-b951-d872f2087c98

This static method branches the CreateSelfSigned code to create a self signed certificate that contains an X509v3 extension that indicates the ASCII weborigin that is bound to the generated certificate.

BUG=88782
TEST=


Review URL: http://codereview.chromium.org/7384002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98288 0039d316-1c4b-4281-b951-d872f2087c98

This yak needs shaving because chunks of gtk using code in chrome/ are being
moved to content/ to build the content_shell, but we can't depend on code in
chrome/. While I'm here, split gtk_util.h into a set of logical chunks: hig
constants, widget factory functions, etc instead of just moving the file.

BUG=93804
TEST=none; code move

Review URL: http://codereview.chromium.org/7737001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98287 0039d316-1c4b-4281-b951-d872f2087c98

Other places which spin a nested loop pin the containing object in
place in case something fires a window close.  There are crashes which
indicate that this is happening here.

BUG=92390
TEST=monitor crash server.


Review URL: http://codereview.chromium.org/7715019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98286 0039d316-1c4b-4281-b951-d872f2087c98

If the window is animating closed when a previously-posted
PerformLayout task is fired, the last reference to the controller may
be released while laying things out.  Pin the controller down until
the task is completed.

BUG=90773
TEST=Monitor crash server for continued zombies.


Review URL: http://codereview.chromium.org/7717027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98285 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verified basic functionality using views_examples.

Review URL: http://codereview.chromium.org/7669028
Patch from Daniel Nicoara <dnicoara@chromium.org>.

TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/7741028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98284 0039d316-1c4b-4281-b951-d872f2087c98

Add missing entry for new content type 'auto-select-certificate' to kContentSettingsTypeGroupNames array of the content_settings_handler.

Fixes chrome crashing when opening an incognito window while the preferences tab is open.


BUG=81825
TEST=chrome not crashing


Review URL: http://codereview.chromium.org/7744007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98283 0039d316-1c4b-4281-b951-d872f2087c98

This is used in code that will be moved for use in content_shell.

BUG=93804
TEST=none; code move

Review URL: http://codereview.chromium.org/7740003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98282 0039d316-1c4b-4281-b951-d872f2087c98

Referenced by browser/bookmarks/bookmark_drop_info.cc, fixes link when in
component and incremental linking on Windows.


BUG=
TEST=Links in Component build mode


Review URL: http://codereview.chromium.org/7741017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98281 0039d316-1c4b-4281-b951-d872f2087c98

The GpuInfoCollector and CompositorGL exist on different threads in the browser process and both use the GL bindings. I've witnessed a race in the binding initialization where one thread thinks that the bindings have been initialized, but the initialization hasn't completed on the other thread, and a NULL function pointer gets dereferenced.

BUG=none
TEST=fixes segfault on TOUCH_UI build

Review URL: http://codereview.chromium.org/7724003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98280 0039d316-1c4b-4281-b951-d872f2087c98

for bug 84426.

But we will only use ssl_host_info_->state().certs if the cached info
extension is enabled.

Do not treat an empty ssl_host_info_->state().certs as failure because
it is normal for us to not have the server's certificates if we have
not visited the site before.

R=agl@chromium.org
BUG=84426
TEST=none

Review URL: http://codereview.chromium.org/7741007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98279 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verified basic functionality using views_examples.

Review URL: http://codereview.chromium.org/7669028
Patch from Daniel Nicoara <dnicoara@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98278 0039d316-1c4b-4281-b951-d872f2087c98

is finished.

R=agl@chromium.org,mattm@chromium.org
BUG=88782
TEST=none

Review URL: http://codereview.chromium.org/7746010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98277 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/7749014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98276 0039d316-1c4b-4281-b951-d872f2087c98