- 25 Jul, 2014 27 commits
-
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285453 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
another attempt at https://codereview.chromium.org/408063002/ to try fixing the iOS Simulator:URLFixerTest failures writing to DIR_TEST_DATA. R=nyquist@chromium.org TBR=brettw@chromium.org, nyquist@chromium.org, sky@chromium.org BUG= Review URL: https://codereview.chromium.org/411253010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285451 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
Chrome OS requires app_locale_strings for font configuration information, so it needs to be part of the .pak file for extensions_unittests. BUG=397245 TEST=build extensions_unittests with chromeos=1, it doesn't crash on start Review URL: https://codereview.chromium.org/418133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285450 0039d316-1c4b-4281-b951-d872f2087c98
-
rmcilroy@chromium.org authored
Add a trace event to MemoryPressureListener::NotifyMemoryPressure to enable tracking of whether any jank is caused by dealing with memory pressure notifications. BUG=397026 Review URL: https://codereview.chromium.org/413233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285449 0039d316-1c4b-4281-b951-d872f2087c98
-
vmpstr@chromium.org authored
This is a fix for the following situation: If we have no skewport, then in operator++ we call advance phase after we process all visible tiles, however because the skewport yields no tiles, we immediately skip to the eventually bin, since the soon iterator construction was in operator++ instead of advance phase. The reason this passed unittests is that there was a second bug in which we would process the eventually rect without ignoring the soon rect, which caused the same tiles to show up. This patch fixes both bugs. The first one is fixed by moving tiling data iterator construction to be in advancephase in all cases. The second bug changes the iterator to iterate around the soon rect instead of the visible rect. R=reveman Review URL: https://codereview.chromium.org/413053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285448 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelpg@chromium.org authored
BUG=219446 R=satorux@chromium.org,dbeam@chromium.org,asvitkine@chromium.org satorux@: c/b/chromeos/preferences.cc dbeam@: c/b/resources/options c/b/ui/webui/options asvitkine@: actions.xml Review URL: https://codereview.chromium.org/393023006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285447 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
Review URL: https://codereview.chromium.org/418723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285446 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
BUG=395354 Review URL: https://codereview.chromium.org/416153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285444 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
BUG=349162 R=cpu@chromium.org Review URL: https://codereview.chromium.org/418943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285441 0039d316-1c4b-4281-b951-d872f2087c98
-
cmumford@chromium.org authored
For IndexedDB files in third_party/leveldatabase: 1. "git cl lint" now runs with no warnings. 2. "git cl format" makes no changes. BUG=381456 Review URL: https://codereview.chromium.org/416633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285440 0039d316-1c4b-4281-b951-d872f2087c98
-
megjablon@chromium.org authored
Adding UMAs to count the number of bytes that did not go through Flywheel as the result of a bypass event. DataReductionProxy.BypassedBytes.NotBypassed DataReductionProxy.BypassedBytes.SSL DataReductionProxy.BypassedBytes.LocalBypassRules DataReductionProxy.BypassedBytes.ShortAll DataReductionProxy.BypassedBytes.ShortTriggeringRequest DataReductionProxy.BypassedBytes.ShortAudioVideo DataReductionProxy.BypassedBytes.MediumAll DataReductionProxy.BypassedBytes.MediumTriggeringRequest DataReductionProxy.BypassedBytes.LongAll DataReductionProxy.BypassedBytes.LongTriggeringRequest DataReductionProxy.BypassedBytes.MissingViaHeader4xx DataReductionProxy.BypassedBytes.MissingViaHeaderOther DataReductionProxy.BypassedBytes.Malformed407 DataReductionProxy.BypassedBytes.Status500HttpInternalServerError DataReductionProxy.BypassedBytes.Status502HttpBadGateway DataReductionProxy.BypassedBytes.ServiceUnavailable DataReductionProxy.BypassedBytes.NetworkErrorOther BUG=381416, 384369 Review URL: https://codereview.chromium.org/390533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285439 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
Review URL: https://codereview.chromium.org/415273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285438 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Block in a loop if we get a specific failure on a particular bot. See environment variables at http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/20713/steps/views_unittests/logs/stdio for reference. Timeout raise attempted at https://codereview.chromium.org/410353004/ so that there will be time to attach a debugger. R=brettw@chromium.org BUG=340422 Review URL: https://codereview.chromium.org/411223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285437 0039d316-1c4b-4281-b951-d872f2087c98
-
vivek.vg@samsung.com authored
Blink should make use of blink_resources.grd for the inline resources of inspector. This removes the dependency upon using xxd.py which embeds these resources as strings. Part 1: https://crrev.com/401233003 Part 3: https://crrev.com/402033002 BUG=312586 Review URL: https://codereview.chromium.org/403273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285436 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
It turns out that recursedeps by itself doesn't really work properly on the bots, and so we need to change things in gclient and the bot scripts before we can use recursedeps for this. Reverting this change in the meantime to avoid confusion. TBR=eseidel@chromium.org, cmp@chromium.org BUG=395862 Review URL: https://codereview.chromium.org/420613005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285435 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Otherwise, [5f88f5f5...]d:\src\cr\src>out\release\gn gen out_gn ERROR at //third_party/boringssl/BUILD.gn:58:7: Undefined variable for +=. defines += [ "OPENSSL_NO_ASM" ] ^------ I don't have something with this name in scope now. on Windows. TBR=brettw@chromium.org BUG=354261 Review URL: https://codereview.chromium.org/412413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285433 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
of this feature. TBR=darin Review URL: https://codereview.chromium.org/356713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285432 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
The frame shouldn't be modified by the aggregator, or else it will be broken if GetEligibleFrame is called again. Also modify ScopedPtrVector::const_iterator to make it const-correct. BUG= Review URL: https://codereview.chromium.org/417843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285431 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Should be okay now, according to my local testing (see crbug.com/389666, etc.; crrev.com/285139 also fixed a use-after-free that would be picked up by this test on Debug builds). > Revert 283562 "Mojo: Enable mojo_shell_tests on Windows (on the ..." > > Blech: Stuff fails. Shockingly. > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/27268/steps/mojo_shell_tests/logs/stdio > > > Mojo: Enable mojo_shell_tests on Windows (on the bots). > > > > R=sky@chromium.org > > > > Review URL: https://codereview.chromium.org/398023002 > > TBR=viettrungluu@chromium.org > > Review URL: https://codereview.chromium.org/398253002 TBR=viettrungluu@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/413263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285430 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
This CL doesn't yet include any emulation of network characteristics (latency, bandwidth, etc.). I'm going to implement it in a separate CL. BUG=394067 R=rmsousa@chromium.org, ttuttle@chromium.org TBR=ttuttle@chromium.org (DEPS on net in remoting/test) Review URL: https://codereview.chromium.org/394883008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285429 0039d316-1c4b-4281-b951-d872f2087c98
-
cmumford@chromium.org authored
LocalWriteClosure only had a raw pointer to a ChainedBlobWriter which was held by a scoped_refptr in IndexedDBBackingStore::Transaction. If the transaction was deleted before writeBlobToFileOnIOThread was called then a crash would ensue. Converted raw ptr to scoped_refptr prevents this. BUG=395650 Review URL: https://codereview.chromium.org/417573004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285428 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=396779 Review URL: https://codereview.chromium.org/417853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285427 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/418993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285426 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
Add a new struct that encapsulates the parameters used to initialize FontRenderParams. Also remove all the existing FontRenderParams functions in favor of a single GetFontRenderParams() function that takes a FontRenderParamsQuery. BUG=395313,396659 TBR=boliu@chromium.org Review URL: https://codereview.chromium.org/413003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285425 0039d316-1c4b-4281-b951-d872f2087c98
-
horo@chromium.org authored
BUG=364243,396970 Review URL: https://codereview.chromium.org/415013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285424 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
During signin, when ChromeOS requests refresh token, get signin scoped device_id from SigninClient and pass it to GaiaAuthFetcher. BUG=382968 R=nkostylev@chromium.org Review URL: https://codereview.chromium.org/382983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285422 0039d316-1c4b-4281-b951-d872f2087c98
-
cmumford@chromium.org authored
Tests use //net so a message loop is required. BUG=395358 Review URL: https://codereview.chromium.org/411393003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285419 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Jul, 2014 13 commits
-
-
teravest@chromium.org authored
This change puts nexe information in the parameters for starting a NaCl plugin instead of sending that information over SRPC. This may remove the need for that IPC round trip entirely; perhaps we could report load failure as part of the RPCs for starting sel_ldr or performing StartModule(). nacl_defines.gypi as added as a dependency in components/components_tests.gyp because nacl_process_host.h now includes "native_client/src/public/nacl_file_info.h", which requires nacl_defines. BUG=333950 R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285028 Review URL: https://codereview.chromium.org/332463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285418 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
This was only used by the background mode manager, and didn't actually do what it needed. Now background mode manager doesn't use this so it can be removed. BUG=361637 Review URL: https://codereview.chromium.org/417843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285417 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
This feature has been available on Windows and Mac for some time, but was never made available on ChromeOS. BUG=371642 Review URL: https://codereview.chromium.org/407073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285416 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
Modifies the sync fake server so it derives the IDs for client-tagged items based on their model type and unique client tag. This fixes a race where two clients could simultaneously commit two client-tagged items with version == 0, and the two committed items would be assigned different IDs. The correct behavior, and that of the real sync server, is to assign the same IDs to items that have the same client tags. BUG=396859 Review URL: https://codereview.chromium.org/414953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285415 0039d316-1c4b-4281-b951-d872f2087c98
-
reillyg@chromium.org authored
This simple HTTP server allows remote management of the USB gadget. The serial number of the device is set to the IP address and port number of the server so that from a device enumeration an application can then control the device over the network. BUG=396682 R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org Review URL: https://codereview.chromium.org/418773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285414 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285413 0039d316-1c4b-4281-b951-d872f2087c98
-
johannkoenig@chromium.org authored
https://codereview.chromium.org/394353005 https://codereview.chromium.org/415333002 R=tomfinegan@chromium.org Review URL: https://codereview.chromium.org/401983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285412 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
This patch moves some code out of //ash into //chromeos so that it can be used in other components (e.g. athena). NetworkListView is introduced for representing the list of available networks to the user. It can query information through the NetworkListDelegate. NetworkInfo is used to contain the necessary information about a network. BUG=387199 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/417793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285411 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
This loads up and destroys applications on their own thread (using BackgroundServiceLoader) so we can test the full in-process application lifecycle. BUG=396300 Review URL: https://codereview.chromium.org/415803005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285410 0039d316-1c4b-4281-b951-d872f2087c98
-
vmpstr@chromium.org authored
This patch ensures that all variables of tile version are initialized to something. BUG=391301 R=danakj, enne Review URL: https://codereview.chromium.org/412143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285409 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285408 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
first two values are the same. R=rsleevi@chromium.org, glider@chromium.org BUG=none Review URL: https://codereview.chromium.org/418533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285407 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/8d84c995319dd4a82e4f2054bbd19f968c671ca6..57493ba62a7ec6a6038e64afa891b3c98a7cc15d CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel TBR=robertphillips@google.com BUG= Review URL: https://codereview.chromium.org/420513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285406 0039d316-1c4b-4281-b951-d872f2087c98
-