- 28 Nov, 2019 40 commits
-
-
Antonio Gomes authored
The CL also changes RTCLegacyStatsMemberIterator similarly. BUG=787254 R=guidou@chormium.org Change-Id: I2ce4dca3316560398e271d0dd2964a7533db3924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940128 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#719932}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4c0786bd310..d2610646af11 git log c4c0786bd310..d2610646af11 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 yangguo@chromium.org Roll protocol changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@d2610646af11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d0cef1be94220862b188156b8fba5b1428370f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719931}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbbafc60ae10..068f95675eec Created with: gclient setdep -r src-internal@068f95675eec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Idfe3fc0dd345a5a24f1f047c85d092758083cfa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941618Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719930}
-
Antonio Gomes authored
Note that this file contains two pure virtual base classes reimplemented in renderer/modules/peerconnection. However, given that the types are still referenced in other renderer/platform APIs/headers, it is not possible to simply remove them at this step. TODO added. Note2 that both classes got renamed, with the "Web" prefix removed. BUG=787254, 919392 R=guidou@chormium.org, haraken@chromium.org Change-Id: Ic24b6ec15d04b9cf4618c384204440311ba96502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939742Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Change command default handler for copy/paste/cut/delete to only set |canExecute| when focusing the element where the default handler was forced. This fixes the infinite recursion on <cr-input> and its clear button, because the handler is forced in the <cr-input> and but the focus event was triggered in its children <cr-button> (clear button). These commands should be noop in buttons, these are forced for inputs to be able to copy/paste/etc the text in the input. Our error counter doesn't capture this error, so our integration test can't detect it. Test: Manually checked. Bug: 1029213 Fixed: 1029213 Change-Id: I4a9f9d0e05dee8eb18a06359f770498011db0487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939999 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719928}
-
Hans Wennborg authored
This is a reland of 0ff2da3a Original change's description: > Disable -Wdeprecated-copy with tip-of-tree Clang > > while we figure out how to handle this new warning. > > TBR=rnk > > Bug: 1028110 > Change-Id: I88be5c763bd0f2fcb40ebecc20990f96853d70c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932804 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718651} TBR=rnk Bug: 1028110 Change-Id: Iaac6251551d0ae5089da8eb465c57111b48bba9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940181 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719927}
-
Mihai Sardarescu authored
This CL makes id a private field of the CoreAccountId structure to ensure as clients of this API are not supposed to use it directly. It also adds comments explaining clearly that the result returned by CoreAccountId::ToString() cannot be used as a persistent key until the migration of CoreAccountId from email to Gaia id is not completed on ChromeOS. Note that this CL allowed to identify risks for the migration that are all tracked as dependencies of bug http://crbug.com/id=1028182. TBR= blundell@chromium.org, khorimoto@chromium.org Bug: 1028182 Change-Id: I57c95a29e9cf24c26c935c229bf6a41e2fbc50b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932445Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#719926}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f31f26f73930..b334829a91d6 git log f31f26f73930..b334829a91d6 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 alanbaker@google.com Validate nested constructs (#3068) 2019-11-27 afdx@google.com spirv-fuzz: Improve debugging facilities (#3074) 2019-11-27 stevenperron@google.com Handle unreachable block when computing register pressure (#3070) 2019-11-27 greg@lunarg.com Improve RegisterSizePasses (#3059) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b334829a91d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Icdd00288d9b8aae1525df0f2089e6ea7ad99913c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941281Reviewed-by:
-
Mikhail Khokhlov authored
We'll need the Perfetto trace processor tool for proto trace conversion and eventually for running TBMv3 metrics. So far it doesn't build on Android, so adding the dependency on desktop platforms only. Bug: 1028612 Change-Id: Id3c3231516ee200f30db60a8f14edda136a257a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939789Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#719924}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc3ec57ddf27..7bb0115cecb6 git log fc3ec57ddf27..7bb0115cecb6 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 8c954d5a413d..61050599ec0f (6 commits) Created with: gclient setdep -r src/third_party/angle@7bb0115cecb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: cwallez@google.com Change-Id: I17c7b5f5b10c4f3a09cb439c95009923368ea981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941617Reviewed-by:
-
Fabian Sommer authored
Add property to pin_keyboard to disable input. Bug: 1027988 Change-Id: Ib715335fc0e9d8c54f440c48361851549b8a0464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936496Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@google.com> Cr-Commit-Position: refs/heads/master@{#719922}
-
Theodore Olsauskas-Warren authored
This is being done in concert with the elevation of the privacy card from the advanced section to the basic section. Certain settings access points were previously duplicated in the people and privacy sections, but will now be in one or the other and the people section renamed to You and Google to better reflect the settings options there. Safe browsing settings are being moved from sync and google services subpage to privacy and security card. Allow chromium sign in is being moved from privacy card to sync and google services subpage. Every change except the rename of the people section is behind the privacySettingsRedesignEnabled finch flag. Bug: 1014143 Change-Id: Id257a770e9d62d21b7174adaf42f6ae6c72b32d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936253 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719921}
-
Peter Marshall authored
Awaiting onceAttachedToTarget() directly after the evaluate() call which creates the new worker is not safe. The event could be fired after the `await evaluate()` is finished but before the AttachedToTarget handler is registered. Listening for the attached event before triggering the creation of the worker is the only safe way to do this. Change-Id: I2e9374d42da5a98b18f3c643b9259818620bb2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940245 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719920}
-
Morten Stenshorne authored
We had this almost right, but failed when there was a break with low appeal inside a child. Bug: 829028 Change-Id: I67c0d07db85b8de6d9ac3f685263fb1d3b490760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940273Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#719919}
-
Carlos Caballero authored
Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: I8bded85ad30d311a6bab530b48251224f1d71b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939411Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#719918}
-
Kenichi Ishibashi authored
Looks like this is a redundant callback because both OnStarted() and OnHttpInfoRead() are called at the same time. Merge OnHttpInfoRead() into OnStarted() to remove an API surface. Bug: N/A Change-Id: I0387d4117b59fa1bfb6b2cb9a440f0e67ae20def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940006 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719917}
-
Luciano Pacheco authored
This has been wrong since this file was created: https://codereview.chromium.org/2109563002 Bug: 1029211 Change-Id: I9e95c0180ef31868a2dfe63a6f723f0d1eb9f422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941649 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Michael Ershov authored
Create certificite via net::CertBuilder to avoid flakiness. Bug: 877416, 787602, 1028183 Change-Id: Ibd62d293ed795a25961b3789ebaa6dc299339b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937071Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#719915}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53493ff38604..cbbafc60ae10 Created with: gclient setdep -r src-internal@cbbafc60ae10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I9ec8d97e58c40140b5b327ee07cdbf1cb44ca7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941616Reviewed-by:
-
Balazs Engedy authored
CrowdDenySafeBrowsingRequest interfaces with Safe Browsing to fetch whether a certain origin is known to show unsolicited notification permission requests to users. Bug: 1028642 Change-Id: I9942350500e88115b0d2f42954222423d0eddd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940253 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719913}
-
Alex Clarke authored
Startup.BrowserMessageLoopStartTimeFromMainEntry3 UMA is needed by androidStartupMetric. This patch wires that up. Bug: 1027736, 1022812 Change-Id: If7c7ef8efcd5557e9cd2a15ebf7950d0a8e46ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932547Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#719912}
-
Hitoshi Yoshida authored
Implements Trace() method. Change-Id: Ib32779b94e16dc824cf075cbb995664f19f5820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941461 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719911}
-
Alex Ilin authored
This CL updates all deprecated methods of base::Value and base::JSONReader in OAuth2MintTokenFlow to use recommended APIs. Bug: 1026237 Change-Id: I4e15970bc6215b74c9d4cea2d96f0923e1c7b878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940177Reviewed-by:
-
Alexandre Courbot authored
The V4L2DevicePoller was silent up to now, but knowing what it does is useful to debug issues. Add a few logs at the relevant places. Bug: None Test: Chromium builds for Kukui. Change-Id: I52494e32a89a24fab5e5cad4937e8bceaa8ed5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939996 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719909}
-
Rune Lillesveen authored
There is no repro for this and I haven't been able to find a shorthand that is not handled in shorthandForProperty(), or has a length > 17, but if there is one, we might end up crashing in CommonShorthandChecks since we both write to a stack array that has a fixed length of 17 and we also access longhands[0] without checking if we have a non-zero length. Bug: 1026569 Change-Id: I86bc71947dbd663be9a96a73404f29b737f49266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939797Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#719908}
-
Andreas Haas authored
Again I added a checked getter of return type unsigned for legacy code. We will replace uses of that getter eventually. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I29176e012f3e56fe60fa41668b4e7791b1f62e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932549Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
These entries are not in NeverFixTests any more, and probably some checks in these tests are failing with OOR-CORS. Let's remove these entries, and see how it goes. Bug: 870173 Change-Id: I33476e255a4c304b0ca98f0bf99b5d512928677c TBR: yhirano@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941463Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#719906}
-
Takashi Toyoshima authored
Update expected failure that is caused by a new virtual test. Change-Id: I824d96591aa4c0752a710a9b1591746ddb6b062a TBR: yhirano@chromium.org NOTRY: tue Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941648 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Christopher Lam authored
This CL plumbs the Chrome OS semantic colors into cr-radio-buttons similar to http://crrev.com/c/1925834. To test, go to chrome://os-settings and type $$('html')[0].style.setProperty( '--cros-default-button-color-rgb', '255, 0, 0') into DevTools which should change the color of all radio buttons on the page. Bug: 1018654 Change-Id: I31bcca35d5b0d21d4f3dcf1adead86314647da12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935569Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#719904}
-
Alexey Baskakov authored
Add proper constness. Change ReadIconCallback signature to return `const SkBitmap&`. These changes are required for the integration with AppService. This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 1029221 Change-Id: I4ec06716014686c607ea86da864efe017b0ad585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941458 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#719903}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8ebb625d7f4..53493ff38604 Created with: gclient setdep -r src-internal@53493ff38604 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I71a271260a6a5f1729a3f8673b9a367c8d11e387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941568Reviewed-by:
-
Fergal Daly authored
These tests are newly added and failing. Bug: 1029248 Change-Id: I5d9860183de06b876d76a87de06badfd31c4179d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941647Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#719901}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I91319a95211eceefbbbf1353f1449094f1ca2640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939162Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#719900}
-
Hayato Ito authored
ServiceWorkerTimeoutTimer is using std::set, which is banned in Blink. See the bug 1028982 for the details. This issue is rising in https://crrev.com/c/1906452/. We are renaming ServiceWorkerTimeoutTimer to ServiceWorkerEventQueue there, however, the renaming triggers presubmit warnings for existing usages of std::set. So I've decided to remove the usage of std::set in this CL. Since there is no std::set equivalent in WTF, we have to compromise. |id_event_map_| and |inflight_events_| are now merged, and the code became simpler. Regarding the performance impact, I think it's okay because UpdateStatus() is not called frequently. BUG: 1028982 Change-Id: I9f1c5a141d755772b5c96acb313a6c5fe3f27374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939161Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#719899}
-
Koji Ishii authored
Following r719562 <crrev.com/c/1937953> that moves the logic for |NodeForHitTest| from |NGPaintFragment| to |NGPhysicalFragment|, this patch removes the function and all references to it. Bug: 982194 Change-Id: Ie43a51a22e829249a9ef21791d42c1e3a702e06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941456Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719898}
-
Yoshifumi Inoue authored
This patch introduces next for same layout object cache in |NGFragmentItem| to make following functions faster: - NGInlineCursor::NextForSameLayoutObject() - ItemsForLayoutObject::Iterator::operator++() Once we utilize |NGInlineCursor| for all |LayoutObject::FirstInlineFragment()| usages[1], following patch will make following functions to utilize cache: - NGInlineCursor::MoveTo(const LayoutObject&) - ItemsForLayoutObject constructr [1] https://bit.ly/2MSgvxN List of FirstInlineFragment() usages Bug: 982194 Change-Id: Id34e08b0b87d9471058ee5899b0fbe6e591883f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930370 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I0579f908410d0c45eab45af9818262a853427e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941086Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719896}
-
Austin Tankiang authored
This mimics how cros-disks does external drive label validation. See http://crrev.com/c/1697542 for the cros-disks change. Bug: 983044 Change-Id: I460523bc7a3856a94328160b992052b700744d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941454 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#719895}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4c5faa87b84..e8c96d8e6116 git log f4c5faa87b84..e8c96d8e6116 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c373dfd84194..fc3ec57ddf27 (13 commits) 2019-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c493edcc..43fc40ae (368 commits) 2019-11-28 herb@google.com Reland "Naive CPU large emoji" Created with: gclient setdep -r src/third_party/skia@e8c96d8e6116 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None Tbr: bungeman@google.com Change-Id: I231dd349af899bab11337895bd1788b4616cede5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941567Reviewed-by:
-
Andreas Haas authored
This reverts commit 22d5de04. Reason for revert: https://crbug.com/1028766 TBR=haraken@chromium.org Original change's description: > [arraybuffer] Allow transfer of empty ArrayBuffer > > With a recent change, ArrayBuffers are allowed to have nullptr as their > `Data` pointer. However, a condition in ArrayBuffer::Transfer bailed out > if Data() was nullptr. I changed the condition now, and added a test. > > R=haraken@chromium.org > > Bug: chromium:1027937 > Change-Id: I2fe466bcfe016d850f11211f2ef8104f1f27d41f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932791 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719113} TBR=haraken@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1027937 Change-Id: Ief03dde1bc2c92264a55aa1082da537fca589047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939982Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#719893}
-
