- 13 Nov, 2018 40 commits
-
-
Nicholas Verne authored
The previous container restart flow would return an error if there was insufficient disk. Free disk size is not relevant if there's an existing disk image. Bug: 891165 Change-Id: I34ed750263182e920ab96befc8b00f1f2b2db89e Reviewed-on: https://chromium-review.googlesource.com/c/1328482Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#607490}
-
yoshiki iguchi authored
This CL adds a way to suppress (and un-suppress) picture-in-picture windows. If it is set, picture-in-picture windows can't be crated. If any picture-in-picture windows exist already, they are closed. This CL suppresses only ARC PIP window. Chrome PIP window will be done separately. Summary of change of this CL: - Makes ArcPipBridge observe spoken-feedback pref change - Sends a newly-added mojo message when the spoken feedback en/disables Related CLs: - crrev.com/c/1285253 (chromium/src) - ag/5287718 (vendor/google_arc) - ag/5287717 (frameworks/base) Bug: b/112060145 Test: manual (see pip window is supppressed correctly) Change-Id: I554d74672e4e5136ae21fc0d2440a4150e5b5608 Reviewed-on: https://chromium-review.googlesource.com/c/1285253Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#607489}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 903991 Test: none Change-Id: I37428a83f128c03d95d4eb16d6b36fc8c9a272a5 Reviewed-on: https://chromium-review.googlesource.com/c/1333110 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607488}
-
Hajime Hoshi authored
V8 should not be executed on per-thread task runner. Use per-frame (per- execution-context) task runner instead. Bug: 870606 Change-Id: Ibaf9e02bb33eacbf0f29b2bb30645ad8d7a19121 Reviewed-on: https://chromium-review.googlesource.com/c/1331291Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607487}
-
Dmitry Gozman authored
This replaces WebLocalFrameClient::DecidePolicyForNavigation with BeginNavigation, where client may decide how to proceed. Typically, the client would just call CommitNavigation to commit the requested navigation. However, for browser-side navigation, we do instead ask browser to proceed, and temporarily call CreatePlaceholderDocumentLoader. After this patch, we can start removing WebLocalFrameClient callbacks, like {Did,Will}StartProvisionalLoad, since the client now controls the navigation flow and doesn't need a callback. Bug: 855189 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic995073e191a238ac46ae6be2114af596e41425f Reviewed-on: https://chromium-review.googlesource.com/c/1271411 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607486}
-
sangwoo.ko authored
When selected tabs were removed, we must notify that even selection model is unchanged. This is because the old selection model and new one would be same when the newly activated tab was right after prviously active tab. Bug: 842194, 903438 Change-Id: I23fd9d8ba9f1ac10b3daf03088a2c2d974f435d8 Reviewed-on: https://chromium-review.googlesource.com/c/1331098 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607485}
-
Alexandre Courbot authored
Right now the VDA and IP devices are tightly coupled: notably, their buffers follow a 1:1 mapping, and the VDA decides which IP processor buffer to use. This seriously restricts the applicability of the IP interface. In order to remove this constraint, the VDA must not make any assumption about which IP buffer it will receive, the number of buffers it will use, or even their memory type. Doing so means that the VDA will see the IP buffers for the first time as the FrameProcessed() callback is called, and thus that it cannot create an EGLImage for them ahead of time as we used to do. This patch thus delays EGLImage assignment to the first time we meet a given buffer in the FrameProcessed() callback. Thanks to the fact that every picture needs to be cleared on the child thread first, we can schedule the EGLImage creation on the same thread before this happens, thus ensuring that no synchronization issue occur. BUG=792790 TEST=Checked that VDA unittest was passing on Hana, in import and non-import mode, with rendering enabled or not. Change-Id: Ia89b7620fe890fcd4bbd6791fd59660d9bd89f46 Reviewed-on: https://chromium-review.googlesource.com/c/1288498 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607484}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Iffc383f46c75817ac1896642c2705e9c6d1c5009 Reviewed-on: https://chromium-review.googlesource.com/c/1333134Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#607483}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d5f26302..24bad97f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic47f6acc920d4ad3402ac528ec0736329e01204b Reviewed-on: https://chromium-review.googlesource.com/c/1332722Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607482}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d56676303ac..1ce66d537f0b Created with: gclient setdep -r src-internal@1ce66d537f0b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I82df27970b49de90c2a2a30ace1c7c2ada9f6e20 Reviewed-on: https://chromium-review.googlesource.com/c/1332828Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607481}
-
Bruce Dawson authored
The cost of iterator debugging is too great so it should be off by default. It increases build times and sometimes increases run times by multiple orders of magnitude. I am not aware of it finding bugs recently. Bug: 904034 Change-Id: If3d1ea04a6213ed189cbfeb35bc0980283123acb Reviewed-on: https://chromium-review.googlesource.com/c/1330892 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd1fd279a353..f04fb3cacbad git log fd1fd279a353..f04fb3cacbad --date=short --no-merges --format='%ad %ae %s' 2018-11-13 brianosman@google.com Change how GPs configure attributes 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 48f63f90f6f3..298436280db3 (6 commits) 2018-11-12 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-12 herb@google.com Clean up in, about, and around GrTextBlob::SubRun Created with: gclient setdep -r src/third_party/skia@f04fb3cacbad The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I10b24855c05c992d917eb012161b22e53152fb60 Reviewed-on: https://chromium-review.googlesource.com/c/1333052Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607479}
-
Hayato Ito authored
They never be nullptr. There are still other places which should be a reference, which can be done in another CL. Bug: 874385 Change-Id: I278e022b40a621115d627ac21cdbb9658f98733e Reviewed-on: https://chromium-review.googlesource.com/c/1333167 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#607478}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/03d1a5ed6cc8..0b18583285cb git log 03d1a5ed6cc8..0b18583285cb --date=short --no-merges --format='%ad %ae %s' 2018-11-12 jmadill@chromium.org Copy configs from infra/config branch. Created with: gclient setdep -r src/third_party/angle@0b18583285cb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:833848 TBR=cwallez@chromium.org Change-Id: If678095e9fb2bd2ece9d49695a4abe5e0b32dd7c Reviewed-on: https://chromium-review.googlesource.com/c/1332349Reviewed-by:
-
Sergey Ulanov authored
In debug builds VulkanInstance::Destroy() was trying to call vkDestroyDebugReportCallbackEXT and it would DCHECK after a failure to find that function. That would happen even if Destroy() is called in after a failed attempt to load Vulkan libs. It doesn't make sense to DCHECK in that case. Also now vkDestroyDebugReportCallbackEXT() is called only if debug callbacks were created successfully. Bug: 861853 Change-Id: I03bbdbb1793ddb74f07352f354d0f70ee739a93a Reviewed-on: https://chromium-review.googlesource.com/c/1332263 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607476}
-
Sam McNally authored
In particular, this fixes Drive virtual folders (Offline, Shared with me) remaining current when Drive is unmounted. Bug: 904298 Change-Id: I54cbb672fdfd6b0538829cd309f9b4425abe8c59 Reviewed-on: https://chromium-review.googlesource.com/c/1333087 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#607475}
-
Devlin Cronin authored
Adjust the chrome.permissions API for use with withheld permissions as a result of the RuntimeHostPermissions feature. This patch allows the permissions API to be used to request withheld or optional host permissions, rather than just optional host permissions. This is important for extensions that want to be able to request permissions at runtime using the chrome.permissions API as a workaround to having required permisssions withheld. Additionally, move requesting optional permissions to looking at the runtime granted permission set, rather than the granted permission set. This greatly simplifies the logic, as now all permission requests are compared to the same permissions set, and we don't need to isolate host permission requests versus API permission requests. This also ensures we avoid granting a permission that was explicitly revoked by the user (as could happen if we just checked granted permissions). As of Chrome 70, all permissions granted through the permissions API are added to the runtime granted set. However, this does mean that optional permissions that were granted prior to M70, and then later removed via permissions.remove(), will re-prompt the user. In practice, this is very rare. This also means that optional permissions will not be granted automatically for permissions that were used by previous versions of the extension (similarly, very rare in practice). This does *not* address the issue of scriptable hosts in requested permissions; that is still an issue. Bug: 889654 Change-Id: I8c20f03ec7b402cd61ae1db04b782447dc39414e Reviewed-on: https://chromium-review.googlesource.com/c/1301851 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607474}
-
Yuichiro Hanada authored
Android IMEs can be disabled in Android side by using 'ime' command. This CL ensures that disabled IMEs are also disabled in Chrome OS's InputMethodManager. Bug: b/119274469 Change-Id: I46c2996a41327221470d69b778da2b7270c73cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1331294Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#607473}
-
Shimi Zhang authored
To avoid PRESUBMIT check for InvocationHandler annotation check. Should be no logic change. Bug: None Change-Id: I91680e54c5b0f0cc692b841a57f7f5b68f724d9b Reviewed-on: https://chromium-review.googlesource.com/c/1323624 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607472}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0cf6ee7f1acb..84f62b6f08e8 git log 0cf6ee7f1acb..84f62b6f08e8 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 cbruni@chromium.org [wprgo] Implement httparchive.go add and addAll command 2018-11-12 erikchen@chromium.org Update computation of load bias to handle CrOS edge cases. Created with: gclient setdep -r src/third_party/catapult@84f62b6f08e8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904492 TBR=sullivan@chromium.org Change-Id: Ic4a8c9f0258bf1183c0f78bb2d996dd2ad94e423 Reviewed-on: https://chromium-review.googlesource.com/c/1333049Reviewed-by:
-
Noel Gordon authored
FilesApp provides the innards of the extension file dialog. Add a test to open the file dialog by clicking on an <input type=file> element in a web page. Bug: 895703 Change-Id: Id6f56e2df4034af66a57f888195bc841a55da2b4 Reviewed-on: https://chromium-review.googlesource.com/c/1331099 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607470}
-
Alexander Alekseev authored
This Cl disables pin input field whan it is displayed in incognito UI. Bug: 900351 Change-Id: I7aae9f08403933f12cae5345075e5e94e775e3a4 Reviewed-on: https://chromium-review.googlesource.com/c/1332929 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#607469}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f1ac04ec34e..f1ff631c9f6c git log 7f1ac04ec34e..f1ff631c9f6c --date=short --no-merges --format='%ad %ae %s' 2018-11-12 weidongg@chromium.org Mark four pfq boards as important 2018-11-12 dgarrett@google.com chromeos_config: Adjust postsubmit configs. Created with: gclient setdep -r src/third_party/chromite@f1ff631c9f6c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If4b876c7a0b6136dc6a1fd1b682bee26972e4627 Reviewed-on: https://chromium-review.googlesource.com/c/1333048Reviewed-by:
-
about://newtabJustin Cohen authored
Rather than load chrome://newtab internally and eventually load an error page, internally track the NTP with about://newtab (which is a blank page). Bug: 826369 Change-Id: I2af53f90088ce4f376a4d0d0107eb667d5aa5d48 Reviewed-on: https://chromium-review.googlesource.com/c/1328185 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607467}
-
Bo Liu authored
This CL moves onPageStarted to page commit for browser navigations. However the old code path is not removed since we still do not want to enable this for old versions of GMSCore. Add a kill switch feature that's disabled by default and a test finch config to enable it for testing. Bug: 896022 Change-Id: I7cd0777687ca4be096209a3a0cfed8dba4e5bd13 Reviewed-on: https://chromium-review.googlesource.com/c/1327170Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607466}
-
Fergus Dall authored
We want to know when during the installation process users are canceling This CL adds a new bucket to the histogram for each cancelable state of the installation process. Currently, it maps from install state to reporting bucket by doing arithmetic on enum values. I'm not sure this is the best way to do this, since it's vulnerable to us changing the numbering of install states in the future. The alternative would be to add a static map to the class from State to SetupResult. Bug: 703927 Change-Id: I7ac2fd19b3370f2c46a7cd4bfe9be78b63f31612 Reviewed-on: https://chromium-review.googlesource.com/c/1331094Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#607465}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/332c9ff5a98e..ef71a5f047da git log 332c9ff5a98e..ef71a5f047da --date=short --no-merges --format='%ad %ae %s' 2018-11-12 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ef71a5f047da The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0d5a1624b7358f39f5379281d803758d40cc297f Reviewed-on: https://chromium-review.googlesource.com/c/1333051Reviewed-by:
-
Martin Kreichgauer authored
This changes the return values of FidoAuthenticator::AuthenticatorTransport() and AuthenticatorMakeCredentialResponse::transport_used() to base::Optional<FidoTransportProtocol>. This accommodates the Windows API integration use case where (a) the FidoAuthenticator subclass cannot guarantee any particular transport type and (b) the response we receive from the API contains no hints about which transports were used. Bug: 898718 Change-Id: Iadb83310f03d5f54ad50babb73e0963bdd21e3c2 Reviewed-on: https://chromium-review.googlesource.com/c/1325220Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607463}
-
Dave Tapuska authored
In order to setup origin trial need to make the feature & origin trial dependent on a new runtime enabled feature that is dynamically set if the translation service is available. BUG=872777 Change-Id: Ic6fc5947a50c4e2a5ac659c83d75a972c31b0c12 Reviewed-on: https://chromium-review.googlesource.com/c/1332780Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#607462}
-
Jordy Greenblatt authored
As we try to add new e2e tethering tests, we need a way to make the host scan occur normally even when there is an ethernet connection because there's always an ethernet connection to deploy the test. This CL creates the infrastructure necessary to create a flag to override the prohibition against searching for a tethering host with an ethernet connection by gating it on booleans called ignore_wired_networks_ ----- Testing: I manually tested that this change causes the tethering notification to appear when the user logs in with an ethernet connection but no wifi connection. For comparison, I also tested that logging in with a wifi network does not cause the notification to appear. Bug: 904609 Change-Id: I7406274cd159ae2b18ad6a22ca90cba76b98dbad Reviewed-on: https://chromium-review.googlesource.com/c/1332693 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#607461}
-
Kyle Horimoto authored
This CL adds a metric which measures the time it takes to create a secure connection to a remote device, from the moment a SecureChannelService client asks for a new connection (start scanning), to the moment that an authenticated channel is established with the remote device. Note that this CL creates latency_metrics_util.h/cc files to fine-tune the bucket size for this metric. It's created as standalone files because the same buckets will be used for future metrics. Bug: 870139 Change-Id: I62600f9ef0cb1888c9fd4643c89221c5736bfaee Reviewed-on: https://chromium-review.googlesource.com/c/1327466Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607460}
-
Eric Roman authored
Change-Id: Ia96ee91c0097b2f5dac45c7a83d10643481f9ed5 Reviewed-on: https://chromium-review.googlesource.com/c/1332188Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607459}
-
Mustafa Emre Acer authored
The metrics recording was previously enabled via Finch. It's now ready to be enabled for everyone. This CL enables it by default for all clients. However, the UI is still not ready to be enabled for everyone. Guard the UI behind a new feature name, so as to avoid confusion from past Finch configs. In short, - Old clients which receive the Finch config for LookalikeUrlNavigationSuggestions will record metrics. - All new clients will record metrics. Bug: 878153 Change-Id: Ief99afec48d879431ec33e4e74e8722478b45ddd Reviewed-on: https://chromium-review.googlesource.com/c/1317926 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Chris Morin authored
This is a reland of 756ebd67 Original change's description: > Start arc data removal directly from Chrome > > Chrome had to proxy through session_manager to start the arc-remove-data > Upstart job, but now it calls it directly. > > BUG=b:115779632 > TEST=Disable ARC++ and ensure arc data removal occurs > > Change-Id: I0f30570c665efc85538b9de4bcd63bb158b37417 > Reviewed-on: https://chromium-review.googlesource.com/c/1311124 > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Commit-Queue: Christopher Morin <cmtm@google.com> > Cr-Commit-Position: refs/heads/master@{#604724} Bug: b:115779632 Change-Id: I8ce85de68c88bea372ce7c864a741546bd6695f8 Reviewed-on: https://chromium-review.googlesource.com/c/1330749Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607457}
-
Joe DeBlasio authored
This CL simplifies the logic that determines what text is displayed in the HTTPS UI indicator. It explicitly merges the logic for determining what text is visually displayed with that of the accessibility label into one function. Bug: 812447 Change-Id: I72125b81003223ecd00d290a6900533dfb424d10 Reviewed-on: https://chromium-review.googlesource.com/c/1331569 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
-
Joshua Bell authored
Origins set to "clear on exit" need to get wiped when the storage partition is shutting down. This was wired into the context's destructor, but needed to be triggered earlier. Introduce an explicit Shutdown() call invoked by the storage partition, similar to other storage backends. Bug: 750452, 824533 Change-Id: I353c183f842da0016fa35f7d48c462c5e85b67ab Reviewed-on: https://chromium-review.googlesource.com/c/1289435Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#607455}
-
Antoine Labour authored
Bug: 882513 Change-Id: I7643ae90356a4a98f57cb5e14691af4362ad9b83 Reviewed-on: https://chromium-review.googlesource.com/c/1323719 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607454}
-
Theresa authored
NavigationBarColorController#updateNavigationBarColor is only called on newer versions of Android so the lint warning can be safely suppressed. BUG= Change-Id: I98a6063e53b4976c82e04fb376fea58b84d10b51 Reviewed-on: https://chromium-review.googlesource.com/c/1332292Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#607453}
-
Devlin Cronin authored
Fix a bug where clicking "edit" on a host permission directly after switching to "on specific sites" would fail. This was because we weren't clearing the oldHostAccess_ bit in runtime_host_permissions.js, which then transferred through to the runtime_hosts_dialog. When this is set, editing is forbidden. Properly clear the bit on dialog close, and add a test for the same. Bug: 903082 Change-Id: I2c5c610fe9c9819f749cf4bd112266bd537c0f31 Reviewed-on: https://chromium-review.googlesource.com/c/1327467Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607452}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6374fa323c0e..3d56676303ac Created with: gclient setdep -r src-internal@3d56676303ac The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ice5623fcd1939b65d42d150bf1f9217fcc98b918 Reviewed-on: https://chromium-review.googlesource.com/c/1333047Reviewed-by:
-
