GitLab

base::Callback has been deprecated in favor of base::OnceCallback and
base::RepeatingCallback. In the case of SysLogsSourceCallback it turns
out that it is sufficient to always use base::OnceCallback.
For this reason, all base::Bind calls are replaced with base::BindOnce.
As base::OnceCallback does not have a copy-constructor to protect the
single-call semantics, the value is std::move()ed in a couple of places.
This also means that callbacks need to be passed by value instead
of const-reference. See docs/callback.md for more details.

TBR=rdevlin.cronin@chromium.org

Bug: 787554, 714018
Change-Id: I557c4600b2d927d74345dceb6946b82b711c1cbc
Reviewed-on: https://chromium-review.googlesource.com/808706
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523848}

1. Updated the max limit on number for entries in link map when
   reporting a stack trace from 64 to 512. 64 is not enough, e.g.
   component builds of content_unittests load 158 libs.
2. Fixed the code to handle the case when the limit is reached
   Previously that code was using sizeof() to get array size.
3. Update regex in runner_common.py to handle the case when pc_offset
   part is missing.

Bug: 706592
Change-Id: Iededea88c86206b247948c789043c4f4dfd8a8d9
Reviewed-on: https://chromium-review.googlesource.com/815155
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523847}

This change:
1) Adds NativeTheme::UsesHighContrastColors(), which returns whether special
   high contrast colors should be used, based on system settings;
2) Adds a new --force-high-contrast switch to override the system settings;
3) Adds overrides for certain colors to use black or GoogleBlue900 as needed;
4) Adds gfx::kGoogleBlue900 from the Polymer color specs

Bug: 565996
Change-Id: Ie63f4d965a62bcfdb092660673b52534ce4507dd
Reviewed-on: https://chromium-review.googlesource.com/761316Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523846}

GetStreamForKeyBuffer keeps incrementing offset in GrowableIOBuffer when
it collects things, so at the end data() actually points past the end
(like offset does), and one needs StartOfBuffer() to get to the beginning.

The other implementation of ReturnBuffer already did this.

With this, one can do something like:
 out/Default/cachetool ~/.cache/google-chrome-beta/Default/Cache/ simple get_stream https://www.chromium.org/ 1  > /tmp/file.txt
to see what's in the cache --- and in chromium.org's case, I needed zcat to view it, since it was gzipped.
(passing 0 instead of 1 would demarshal the HttpResponseInfo that goes with the body).

Change-Id: Id3b5608e2845f9404c2c3c21d53e7ce723f13320
Reviewed-on: https://chromium-review.googlesource.com/825102Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523845}

Creates / destroys TabLifecycleUnits and notifies observers as tabs are
created / destroyed.

Bug: 775644
Change-Id: I8042e656c2672dbc71ad0187c151140a098f1356
Reviewed-on: https://chromium-review.googlesource.com/789410
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523844}

The benchmark has been failing since around November 27 and, even though
altimin@ was successful in fixing some failures that were reproducible
locally, the benchmark still seems to be failing on the waterfall and
mythria@ doesn't think that it's likely that we'll be able to debug it
before the holiday vacation.

TBR=altimin@chromium.org,mythria@chromium.org,nednguyen@google.com

Bug: 788797
Change-Id: Ib1b245524afd11400792250f34f0fae6cd952d85
Reviewed-on: https://chromium-review.googlesource.com/824942Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523843}

This CL implements remote-shell APIs that enable ARC to use a relative
surface hierarchy for consistency with upstream Wayland. For newer ARC
clients, the surface origin does not depend on the geometry in global
coordinates, and the client uses local coordinates for shadow bounds.

The relative surface hierarchy fixes a regression where windows outside
quadrant IV were clipped in multi-display and overview mode. It also
fixes notifications in multi-display mode for certain display layouts.

Bug: b:67384524
Test: --ui-show-composited-layer-borders=surface
Test: No clipping in multi-display and overview mode.
Test: No rendering/input issues for notifications in multi-display mode.
Change-Id: Ic506665c4c3074e13c72d0ad3f66d556b560cb2b
Reviewed-on: https://chromium-review.googlesource.com/821415
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523842}

Bug: 656123
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0951d27cf4095d103bbf5a6aa154bdf8493066c2
Reviewed-on: https://chromium-review.googlesource.com/823290Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523841}

Bug: b/69387812
Test: build & run
Change-Id: Ibb30cf0ebcdea39c9087c6730ddeb4dc549c1c4a
Reviewed-on: https://chromium-review.googlesource.com/780451Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Benjamin Shaya <bshaya@google.com>
Cr-Commit-Position: refs/heads/master@{#523840}

This commit fixes the "error: expected expression." error.
It looks like ICECC+Clang resolves the " wrongly and, thus,
fails to compile.

The warning before the actual error is
"warning: missing terminating '"' character". It also shows
how the R script portion is resolved, and shows missing ".

Bug: 
Change-Id: Ia4eac8ce8cb47c6b0163ce5f4043dd2be960d6f8
Reviewed-on: https://chromium-review.googlesource.com/822436Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#523839}

https://chromium.googlesource.com/angle/angle.git/+log/e30edd6fcb96..8225e73bb30f

$ git log e30edd6fc..8225e73bb --date=short --no-merges --format='%ad %ae %s'
2017-11-14 jie.a.chen Support struct varying for transform feedback
2017-12-11 oetuaho Remove SH_TRANSLATE_VIEWID_OVR_TO_UNIFORM

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I8e3d7b9b10b30014ca3c2ce3d3dfa32bb4570068
Reviewed-on: https://chromium-review.googlesource.com/824944Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523838}

Change SmbProviderClient to expect mount_id to start at 0.

CQ-DEPEND=CL:823086

Bug: chromium:757625
Change-Id: I55a13a0e15bf887176825e60c7297827fb45a017
Reviewed-on: https://chromium-review.googlesource.com/823270Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523837}

Bug: 598854
Change-Id: Id79de5ef8f24b0dced2ac17cfd5bc1fbe196121e
Reviewed-on: https://chromium-review.googlesource.com/820894Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523836}

Using NavigationThrottle for this. Since during throttling
the navigation has not committed yet, we have to create
agent host for soon-to-be-committed frame in advance.

Bug: 750901
Change-Id: I88dbd982481b88eeec36209b6bf3ad7f74863200
Reviewed-on: https://chromium-review.googlesource.com/818076Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523835}

Bug: 791884
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaa1ccb566116b80d902f0ccd893d3dac08d3258c
Reviewed-on: https://chromium-review.googlesource.com/818190Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523834}

https://skia.googlesource.com/skia.git/+log/526c39f41f62..c25db637532c

$ git log 526c39f41..c25db6375 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 robertphillips Update SkImage::MakeFromYUVTexturesCopy to GrBackendTexture
2017-12-13 reed Revert "impl SkSerial picture procs"
2017-12-13 jvanverth Ensure we flush TextBlobCache message queue.
2017-12-12 csmartdalton CCPR: Optimize Hull geometry
2017-12-12 brianosman Fix red/blue swap with backend textures on fiddle
2017-12-13 reed impl SkSerial picture procs

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I7d72518161427e809aa00f617f0e2945d3cb54f1
Reviewed-on: https://chromium-review.googlesource.com/824429Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523833}

The original change removed ImageData usage from toBlob/toDataURL code path
from HTMLCanvasElement calls down to the CanvasAsyncBlobCreator. It was
reverted after crashing on canvases with more than 16M pixels.

This change relands the CL. The problem with big canvases was that there
is a logic in WebGLRenderingContextBase that down scales the DrawingBuffer
if it has more than 16M pixles, The previous code was using the size asked
by user instead of the size adjusted in WebGLRenderingContextBase, leading
to a crash down the path while encoding ImageDataBuffer.

Patch set 1 is the reverted CL (chromium-review.googlesource.com/c/chromium/src/+/809097)

TBR=kbr@chromium.org

Bug: 792110, 657870
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7ab2d6fa8359e3adb3bfa13cc24783a1072eece6
Reviewed-on: https://chromium-review.googlesource.com/822910
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523832}

Add knobs to enable the draft22 variant on Chromium, in preparation
of Finch experiments with draft22 side-by-side with experiment2.

Bug: 
Change-Id: Ia897cd2cbfdb2ced740f5bebe3a6e346852c2aec
Reviewed-on: https://chromium-review.googlesource.com/806574Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523831}

This reverts commit e763ffcb.

Reason for revert: The problem for reverting https://crrev.com/c/806689
has been fixed by https://crrev.com/c/824434.

Original change's description:
> Revert "Fix exo for IsMusHostingVis() == false"
> 
> This reverts commit fe678147.
> 
> Reason for revert: Breaks several tests in ash_unittests-mus on Builder Linux Chromium OS ASan LSan Tests
> See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25187
> 
> Original change's description:
> > Fix exo for IsMusHostingVis() == false
> > 
> > Bug: 792479, 793924
> > Test: Test on device with android apps
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> > Change-Id: I8c9beb8f835c294b6e2eb1dec4654a8d501c0952
> > Reviewed-on: https://chromium-review.googlesource.com/806689
> > Commit-Queue: Peng Huang <penghuang@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#523647}
> 
> TBR=penghuang@chromium.org,sadrul@chromium.org,sky@chromium.org,piman@chromium.org
> 
> Change-Id: If258d1188a54f4406b6f0edf0c37ead6c89379b4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 792479, 793924
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/823925
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523764}

TBR=penghuang@chromium.org,sadrul@chromium.org,sky@chromium.org,piman@chromium.org,cfroussios@chromium.org

Change-Id: I5ec6e8befda01fbbd320ee048aab998623e2b830
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792479, 793924
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/825282Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523830}

Bug: 792479
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I8144cc1ebaa73900237e4accd69d4e50891a1d80
Reviewed-on: https://chromium-review.googlesource.com/824434Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523829}

The Mojo Windows bot cannot find the test filter. This change updates the path
to be more specific. Like that of the Cast Linux testing filter

TEST=viz_content_browsertest

Bug: 760181
Change-Id: Ib2516b5c0dd5513b4acf56f8083e5bd47fe7719f
Reviewed-on: https://chromium-review.googlesource.com/822659Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523828}

Some paint code has special DCHECK paths. Some CL may pass with DCHECK
but fail without DCHECK. We need a CQ bot to ensure the non-DCHECK path
is not broken.

Bug: 794424
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I184efbd8e07a14bd6f4d4767d42c2d14007b957a
Reviewed-on: https://chromium-review.googlesource.com/823762Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523827}

Skia's default serialization behavior is to encode "bare" images via PNG.
For these utilities, we can just rely on that (except in the case of the
command-line option).

Bug: 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I439786209a59d5604a53d362e64703af430a8056
Reviewed-on: https://chromium-review.googlesource.com/824443Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Mike Reed <reed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523826}

This alerts the user about exporting passwords and allows them to confirm the action or cancel it.

Bug: 789122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I84af89eae3c5b7004d197826abf1a1f5eccc3bb6
Reviewed-on: https://chromium-review.googlesource.com/817418Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523825}

This makes it so aura::Env is configured for mus if --mus is specified
on the command line.

BUG=776514
TEST=test only change

Change-Id: Iaeb80b571e274f5bae9af7688d6b55b79e43b3d2
Reviewed-on: https://chromium-review.googlesource.com/823568Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523824}

The parametrized tests are needed until the export feature will be fully enabled.

Bug: 789122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I27aa0ec4582913e61dc4116fa6e8fc96f625ad14
Reviewed-on: https://chromium-review.googlesource.com/822250Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523823}

This essentially reverts the following revert:
a599a458.

This reworks the software cache to simplify it and add ability to reuse
larger decoded images instead of always decoding the original image.

R=khushalsagar@chromium.org, ericrk@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I60d0a6aeb46c136cb8230aa7e1d106ef0386462b
Reviewed-on: https://chromium-review.googlesource.com/783636
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523822}

Historically, findMediaFile() helped choose the right extension based
on what the browser could play. Chromium cannot play some proprietary
formats (h264, aac, etc), so this check would choose the .ogv format
in that case.

But things have gotten crufty.
1) A long time ago we started running layout tests on builds that *do*
   include proprietary codecs
2) But we lie about that to the tests via
     media::RemoveProprietaryMediaTypesAndCodecsForTests()
   This makes debugging tests a pain because manual execution doesn't
   call this method and its easy to forget that the test wrapper does.
3) Lots of tests never bothered to call findMediaFile anway and just
   hardcoded the use of an mp4 with proprietary codecs, which worked
   because the method in #2 above only changes canPlayType responses,
   it doesn't remove the actual support for proprietary codecs.
4) findMediaFile is about to be busted anyway because it only queries the
   file mime type without supplying codec info. eg
      canPlayType("video/mp4") == "maybe" -> lets use the mp4!
   and even chromium will now "maybe" for this now that we no longer
   consider mp4 proprietary (though codecs like h264 still are!)

So this patch does the following:

1) Deletes findMediaFile() and instead hardcode use of the ogg file. This
   maintains the existing behavior and avoids a massive rebaseline.
2) Delete media::RemoveProprietaryMediaTypesAndCodecsForTests(). Tests
   and manual runs now behave the same.
3) Delete ancient media-can-play-* LayoutTests that just call canPlayType
   with various codecs and are duplicated by content and chrome browser
   tests (which is a better place for these checks)
4) Updates mediasource-config-change-mp4-* expectations to expect that
   they should run and pass on *all* platforms (previously just android)

There are still many tests that hard code the use of mp4 files. If we
later desire to see LayoutTests run without proprietary codecs, someone
can transition those tests. No one seems to mind at the moment.

It is also not a goal to make LayoutTests try all the supported codecs.
That is covered by unit/integration tests.

Due to #2 above, a handful of tests in external/wpt/media-source now fail
because they use mp4. Fixing these failures is tracked in Issue 794338.

Change-Id: Ie357ae075c880b78d5ee9e95c1b7cc69d9d8a328
BUG: 327115,746579,787575,568704,794338
Reviewed-on: https://chromium-review.googlesource.com/807604Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523821}

Bug: 780984
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4004bd0ed43330dfca8a73133db4a5aec8a423f9
Reviewed-on: https://chromium-review.googlesource.com/802957Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523820}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/05591bb..1a8ed15

BUG=794335,794339,794340,794341,794613
TEST=bots
TBR=kbr@chromium.org
NOTRY=true

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.angle:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3d5567031523d5c1a8558b967d40835b9c1da77b
Reviewed-on: https://chromium-review.googlesource.com/822914
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523819}

I'm logging contents of FakeServer before the call to UpdateCookieJarAccountsAndWait
to ensure that later call to NavigateTab will indeed trigger commit.

I'm adding logging of last commit message to ensure that navigation to kURL2
triggered sync cycle.

R=pnoland@chromium.org
BUG=789129

Change-Id: I7adb3750f5aa2c5e4611fc32b37df461dc744d49
Reviewed-on: https://chromium-review.googlesource.com/823562Reviewed-by: Patrick Noland <pnoland@google.com>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523818}

TBR=dgozman@chromium.org

Bug: chromium:697334
Change-Id: Ic3007ca377343820beff72631480f3e49c7ffe0f
Reviewed-on: https://chromium-review.googlesource.com/824943Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523817}

The content::InterstitialPage hierarchy makes sure that blocking page's Show()
method is called when the interstitial is shown, and OnProceed/OnDontProceed
(from InterstitialPageDelegate) when the interstitial is hidden. However, with
committed interstitials, the content::InterstitialPage hierachy is no longer
used, so we can no longer rely on Show(), OnProceed(), and OnDontProceed() to be
called to trigger metrics set up, recording, and cert reporting.

This CL makes the following changes to account for this:
- Introduce a new SSLBlockingPageBase superclass that handles cert reporting and
  metrics collection when an interstitial is closing. In the old code path, this
  is all triggered from OnProceed/OnDontProceed. In the new code path, it's
  triggered when SSLErrorTabHelper cleans up a blocking page, which happens when
  we navigate away or (newly in this CL) when the tab is closed. We can later
  move more shared code from the various SSL-related blocking pages into
  SSLBlockingPageBase.
- Adjust how a blocking page's HTML is generated in the committed interstitials
  code path: instead of calling GetHTMLContents() directly, we now call a
  wrapper method that does the Show() metrics setup.
- Deprecates an old metric that isn't actively used and was going to be a
  pain to adapt to the new code path.

I've also enabled certificate-reporting-related browser tests for committed
interstitials.

Bug: 792319,792324,792324
Change-Id: I1fcbdc18085434e6c65139350f159fc8c06419c9
Reviewed-on: https://chromium-review.googlesource.com/811604
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523816}

Bug: 781644
Change-Id: I450b4b3472fa024b753a512058ddf0668b280307
Reviewed-on: https://chromium-review.googlesource.com/821051
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523815}

This is 99.9% work by Gavin Peters, at https://codereview.chromium.org/2501353002,
with me just tweaking some parameters and applying the tiny things I suggested
on that review.

Bug: 611464, 722885
Change-Id: I5bdc7d60ec4bc54e1099f408ea09e0573c176fca
Reviewed-on: https://chromium-review.googlesource.com/800972
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523814}

TabUsageRecorder::ShouldIgnoreWebState() is meant to filter out tabs
that are currently loading a chrome:// URL and not record page load
stats for them. However, it treats pending item and last committed item
inconsistently and looks at the URL for one and virtual URL for the
other. This causes a problem when switching to WKBasedNavigationManager
because switching to an evicted tab will load restore_session.html in
the web state. This results in a pending item with a file:/// URL and
a virtual URL that is whatever the page that is being restored, which
may be a chrome:// URL.

Not using virtual URL for pending item seems to be a bug introduced in
https://codereview.chromium.org/2820763002. It replaces [tab url] with
pending_item->GetURL. At the time, [tab url] was implemented using
virtual URL (see https://codereview.chromium.org/2919983002).

Added a unit test to cover this case.

Bug: 789993
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0861ee94ca0d3c5612d3e1ad7680f18bfd7368f0
Reviewed-on: https://chromium-review.googlesource.com/817356Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523813}

Tbr: haraken@chromium.org
Bug: chromium:757440, chromium:790691
Change-Id: I1a660cc40c1f79713dd98948c0efd4477eff958b
Reviewed-on: https://chromium-review.googlesource.com/823844Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523812}

Next step forward towards sandboxing network service.

Ensures that all FS access goes through the proxy, even if it
is not being subject to any whitelist restrictions yet. All
other syscalls are still allowed.

Bug: 715679
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibe8dd5a09bbf498bc10c9ae289222b8e46b8e4b7
Reviewed-on: https://chromium-review.googlesource.com/817697
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523811}

This patch does not change any web facing logic.
Only private methods are changed, the public API is untouched.

Renamed methods:
  DispatchCPPEvent -> DispatchClipboardEvent
  TryDHTMLCopy     -> DispatchCopyEvent
  TryDHTMLCut      -> DispatchCutEvent
  TryDHTMLPaste    -> DispatchPasteEvent

These methods now return false upon preventDefault() from JavaScript.
Before this change, only the first method followed this convention.

Bug: 755459
Change-Id: I2b9dd77b0c0cd6a2ad29136e1ec2f9dec7d37622
Reviewed-on: https://chromium-review.googlesource.com/810806Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/heads/master@{#523810}

With this cl scroll latching timeout is increased to 500ms and the phase
handler ends a timer-based scroll sequence once the difference between
coordinates of the initial wheel event in the sequence and the current
wheel event exceeds some threshold.

       TimerBasedLatchingBreaksWithMouseMove

Bug: 526463
Test: RenderWidgetHostViewAuraWheelScrollLatchingEnabledTest.
Change-Id: Ie6afbf205c42dfce4f3a3f56937c9cb32b2feebf
Reviewed-on: https://chromium-review.googlesource.com/820334
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523809}