GitLab

        Reviewed by Pavel Feldman.

        Web Inspector: move breakpoints restoring to debugger presentation model.
        https://bugs.webkit.org/show_bug.cgi?id=56123

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
2011-03-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move breakpoints restoring to debugger presentation model.
        https://bugs.webkit.org/show_bug.cgi?id=56123

        DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
        setBreakpoint/removeBreakpoint are now called from DPM only.

        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::disable):
        (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.enableDebugger):
        (WebInspector.DebuggerModel.prototype._debuggerWasEnabled):
        (WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
        (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
        (WebInspector.DebuggerModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerModel.prototype._breakpointResolved):
        (WebInspector.DebuggerModel.prototype.reset):
        (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled):
        (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
        (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
        (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype.reset):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
        (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):

git-svn-id: svn://svn.chromium.org/blink/trunk@81025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, rolling out r81015.
        http://trac.webkit.org/changeset/81015
        https://bugs.webkit.org/show_bug.cgi?id=56308

        A Similar patch landed in r76960 (Requested by philn-tp on
        #webkit).

        * GNUmakefile.am:

git-svn-id: svn://svn.chromium.org/blink/trunk@81024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: don't use innerText, use textContent instead.
        https://bugs.webkit.org/show_bug.cgi?id=56307

        * inspector/elements/edit-dom-actions-expected.txt:
        * inspector/elements/edit-dom-actions.html:
        * inspector/extensions/extensions-audits-expected.txt:
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: don't use innerText, use textContent instead.
        https://bugs.webkit.org/show_bug.cgi?id=56307

        * inspector/front-end/AuditFormatters.js:
        (WebInspector.AuditFormatters.snippet):
        * inspector/front-end/ElementsTreeOutline.js:
        * inspector/front-end/GoToLineDialog.js:
        * inspector/front-end/HelpScreen.js:
        (WebInspector.HelpScreen):
        * inspector/front-end/ShortcutsHelp.js:
        (WebInspector.ShortcutsSection.prototype.renderSection):
        (WebInspector.ShortcutsSection.prototype._renderHeader):

git-svn-id: svn://svn.chromium.org/blink/trunk@81023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Disable live-edit in favor of the text editor
        https://bugs.webkit.org/show_bug.cgi?id=56176

        * inspector/front-end/Settings.js:

git-svn-id: svn://svn.chromium.org/blink/trunk@81022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter
        https://bugs.webkit.org/show_bug.cgi?id=56095

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):

git-svn-id: svn://svn.chromium.org/blink/trunk@81021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: move breakpoints restoring after live edit to debugger presentation model.
        https://bugs.webkit.org/show_bug.cgi?id=56179

        Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel.

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.reset):
        (WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype.get callFrames):
        (WebInspector.DebuggerModel.prototype._pausedScript):
        (WebInspector.DebuggerModel.prototype._resumedScript):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):

git-svn-id: svn://svn.chromium.org/blink/trunk@81020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
        https://bugs.webkit.org/show_bug.cgi?id=56111

        * inspector/styles/styles-new-API.html:
        * inspector/styles/styles-source-offsets.html:
2011-03-10  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
        https://bugs.webkit.org/show_bug.cgi?id=56111

        This change reduces the getStylesForNode() payload more than twice for BODY elements.

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::populateObjectWithStyleProperties):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSProperty.parsePayload):

git-svn-id: svn://svn.chromium.org/blink/trunk@81019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Steve Block.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Ensure that all geolocation permission requests are cancelled
        when the page is detached from its frame.

        Fix fast/dom/Geolocation/window-close-popup.html to ignore position error
        generated on watch when window is closed.

        * fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
        * fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
        * fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
        * fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt-wk2/Skipped:
2011-03-14  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        On Page destruction, any outstanding Geolocation permission
        requests should be cancelled, because the Geolocation can only
        access the client indirectly via m_frame->page().

        Page destruction is signalled by a call to the
        Frame::pageDestroyed() method. This explictly calls
        DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.

        Geolocation::reset() detaches from the GeolocationController,
        cancels requests, watches and single shots, and sets the
        permission state back to Unknown.

        Frame::pageDestroyed() is also called by FrameLoader even though
        the page is not destroyed. We should still cancel permission
        requests, because the GeolocationClient will become inaccessible
        to the Geolocation object after this call.

        Frame::transferChildFrameToNewDocument also indirectly calls
        Geolocation::reset when the frame is reparented between
        pages. Ideally we would like the Geolocation's activities to
        continue after reparenting, see bug
        https://bugs.webkit.org/show_bug.cgi?id=55577

        Since GeolocationController is owned by Page, and all Geolocation
        objects will now unsubscribe from the GeolocationController on
        pageDetached(), we no longer need to call stopUpdating() from the
        GeolocationController's destructor. Instead we can simply assert
        that there should be no no observers. See related bug
        https://bugs.webkit.org/show_bug.cgi?id=52216 .

        Introduced new method 'numberOfPendingPermissionRequests' on
        GeolocationClientMock to count the number of outstanding pending
        permission requests. This provides a reusable implementation for
        client-based implementations of the LayoutTestController's
        numberOfPendingGeolocationPermissionRequests method.

        Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::resetGeolocation):
        * page/DOMWindow.h:
        * page/Frame.cpp:
        (WebCore::Frame::pageDestroyed):
        (WebCore::Frame::transferChildFrameToNewDocument):
        * page/Geolocation.cpp:
        (WebCore::Geolocation::~Geolocation):
        (WebCore::Geolocation::page):
        (WebCore::Geolocation::reset):
        (WebCore::Geolocation::disconnectFrame):
        (WebCore::Geolocation::lastPosition):
        (WebCore::Geolocation::requestPermission):
        (WebCore::Geolocation::startUpdating):
        (WebCore::Geolocation::stopUpdating):
        * page/Geolocation.h:
        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::~GeolocationController):
        * page/Navigator.cpp:
        (WebCore::Navigator::resetGeolocation):
        * page/Navigator.h:
        * platform/mock/GeolocationClientMock.cpp:
        (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
        * platform/mock/GeolocationClientMock.h:
2011-03-14  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Add accessors to the WebGeolocationClientMock to allow the number of
        pending geolocation permission requests to be queried.

        * public/WebGeolocationClientMock.h:
        * src/WebGeolocationClientMock.cpp:
        (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):
2011-03-14  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Extend the layout test controller to expose the number of pending
        geolocation requests, so that we can test that the requests have
        been cancelled on page close.

        * DumpRenderTree/LayoutTestController.cpp:
        (numberOfPendingGeolocationPermissionRequestsCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/mac/UIDelegate.h:
        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):

git-svn-id: svn://svn.chromium.org/blink/trunk@81018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION: Messed up with the tabIndex for text editor
        https://bugs.webkit.org/show_bug.cgi?id=56183

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleKeyDown):
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrame.prototype._handleRevertEditing):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorMainPanel):
        (WebInspector.TextEditorMainPanel.prototype.set readOnly):

git-svn-id: svn://svn.chromium.org/blink/trunk@81017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rebaseline GTK+ tests after r80996.

        * platform/gtk/fast/text/soft-hyphen-2-expected.txt:
        * platform/gtk/fast/text/soft-hyphen-4-expected.checksum: Added.
        * platform/gtk/fast/text/soft-hyphen-4-expected.png: Added.
        * platform/gtk/fast/text/soft-hyphen-4-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@81016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Xan Lopez.

        Add all web audio auto-generated files to GTK make system
        https://bugs.webkit.org/show_bug.cgi?id=50497

        No new tests since these are build-system tweaks.

        * GNUmakefile.am:

git-svn-id: svn://svn.chromium.org/blink/trunk@81015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Steve Block.

        Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=56202

        By testing for geolocation watch errors, the test tests more than
        it should, which can cause a flaky result as demonstrated by
        https://bugs.webkit.org/show_bug.cgi?id=56126 .

        * fast/dom/Geolocation/resources/window-close-popup.html:
        * fast/dom/Geolocation/script-tests/window-close-crash.js:

git-svn-id: svn://svn.chromium.org/blink/trunk@81014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Update more expectations after r80857.

        * platform/gtk/fast/layers/video-layer-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

since that is where the crash occurs.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not reviewed: remove the flaky part of the new inspector test for now.

        * inspector/elements/edit-dom-actions-expected.txt:
        * inspector/elements/edit-dom-actions.html:


git-svn-id: svn://svn.chromium.org/blink/trunk@81011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
        https://bugs.webkit.org/show_bug.cgi?id=56268

        * inspector/elements/elements-panel-search.html:
        * inspector/elements/mutate-unknown-node.html:
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
        https://bugs.webkit.org/show_bug.cgi?id=56268

        * inspector/Inspector.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::reset):
        (WebCore::InspectorDOMAgent::performSearch):
        (WebCore::InspectorDOMAgent::cancelSearch):
        (WebCore::InspectorDOMAgent::onMatchJobsTimer):
        (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.requestDocument.mycallback):
        (WebInspector.DOMAgent.prototype.requestDocument):
        (WebInspector.DOMAgent.prototype._attributesUpdated):
        (WebInspector.DOMAgent.prototype._characterDataModified):
        (WebInspector.DOMAgent.prototype._documentUpdated):
        (WebInspector.DOMAgent.prototype._setDocument):
        (WebInspector.DOMAgent.prototype._childNodeCountUpdated):
        (WebInspector.DOMAgent.prototype._childNodeInserted):
        (WebInspector.DOMAgent.prototype._childNodeRemoved):
        (WebInspector.DOMAgent.prototype._removeBreakpoints):
        (WebInspector.DOMAgent.prototype.performSearch):
        (WebInspector.DOMAgent.prototype.cancelSearch):
        (WebInspector.DOMDispatcher.prototype.searchResults):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype._reset):
        (WebInspector.ElementsPanel.prototype._documentUpdated):
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.performSearch):
        (WebInspector.ElementsPanel.prototype._addNodesToSearchResult):
        (WebInspector.ElementsPanel.prototype._attributesUpdated):
        (WebInspector.ElementsPanel.prototype._characterDataModified):
        (WebInspector.ElementsPanel.prototype._nodeInserted):
        (WebInspector.ElementsPanel.prototype._nodeRemoved):
        (WebInspector.ElementsPanel.prototype._childNodeCountUpdated):
        (WebInspector.ElementsPanel.prototype.updateModifiedNodes):

git-svn-id: svn://svn.chromium.org/blink/trunk@81010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: add tests for edit dom operations.
        https://bugs.webkit.org/show_bug.cgi?id=56248

        * inspector/elements/edit-dom-actions-expected.txt: Added.
        * inspector/elements/edit-dom-actions.html: Added.
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add tests for edit dom operations.
        https://bugs.webkit.org/show_bug.cgi?id=56248

        Test: inspector/elements/edit-dom-actions.html

        * inspector/Inspector.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::assertNode):
        (WebCore::InspectorDOMAgent::assertElement):
        (WebCore::InspectorDOMAgent::assertHTMLElement):
        (WebCore::InspectorDOMAgent::nodeToSelectOn):
        (WebCore::InspectorDOMAgent::querySelector):
        (WebCore::InspectorDOMAgent::querySelectorAll):
        (WebCore::InspectorDOMAgent::setAttribute):
        (WebCore::InspectorDOMAgent::removeAttribute):
        (WebCore::InspectorDOMAgent::getOuterHTML):
        (WebCore::InspectorDOMAgent::setOuterHTML):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype.setAttribute):
        (WebInspector.DOMNode.prototype.removeAttribute):
        * inspector/front-end/inspector.js:
        (WebInspector.startEditing.defaultFinishHandler):

git-svn-id: svn://svn.chromium.org/blink/trunk@81009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed. Modify my email address in committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@81008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rearrange some expectations (from IMAGE to IMAGE_TEXT) due to r80996
and add a few bugs which track the other failures.

* platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
* platform/chromium-linux/fast/text/soft-hyphen-4-expected.checksum: Added.
* platform/chromium-linux/fast/text/soft-hyphen-4-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Need WK2 API to view/manage origins with LocalStorage

Reviewed by Dan Bernstein.

../WebCore: 

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread
  before the StorageTracker thread can do it on the background thread.

../WebKit2: 

Hookup the existing API stubs to the WebCore implementations:
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):



git-svn-id: svn://svn.chromium.org/blink/trunk@81005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Move cache_directory api
        https://bugs.webkit.org/show_bug.cgi?id=52139

        Move cache directory related apis from ewk_view to ewk_settings because
        those are not related to ewk_view.

        * ewk/ewk_main.cpp:
        (_ewk_init_body):
        * ewk/ewk_settings.cpp:
        (ewk_settings_cache_directory_path_set):
        (ewk_settings_cache_directory_path_get):
        * ewk/ewk_settings.h:
        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):
        (_ewk_view_priv_del):
        * ewk/ewk_view.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@81004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

removed premature return in syncImportOriginIdentifiers when tracker
db does not exist because that prevented syncFileSystemAndTrackerDatabase()
from running until next LocalStorage db creation, cleaned up
StorageTracker::scheduleTask() code for readability.
        
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=56285
        
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
optionally opened (as in the case when it doesn't exist on disk), don't
exit early and call syncFileSystemAndTrackerDatabase(), which will create
a tracker db if localstorage db files are found on disk by calling setOriginDetails.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask): readability changes.
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
(WebCore::StorageTracker::setClient):
* storage/StorageTracker.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@81003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
https://bugs.webkit.org/show_bug.cgi?id=56240

This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):



git-svn-id: svn://svn.chromium.org/blink/trunk@81002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Dan Bernstein.

Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.

* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):

git-svn-id: svn://svn.chromium.org/blink/trunk@81001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Sam Weinig.

Pass the path along with creation parameters:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:

Add SPI to set the path:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetLocalStorageDirectory):
* UIProcess/API/C/WKContextPrivate.h:

Pass the path along in the process creation parameters:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::localStorageDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setLocalStorageDirectory):

* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Include the path with settings updates, because WebCore needs it set on the Settings object:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::localStorageDirectory):

Sandboxing stuff:
* WebProcess/com.apple.WebProcess.sb:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):



git-svn-id: svn://svn.chromium.org/blink/trunk@81000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Mark Rowe.

        WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
        https://bugs.webkit.org/show_bug.cgi?id=56260

        Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.

        * UIProcess/mac/WKFullScreenWindowController.mm:

git-svn-id: svn://svn.chromium.org/blink/trunk@80999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

above addressing this FIXME.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: svn://svn.chromium.org/blink/trunk@80998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=56287

Reviewed by Sam Weinig.

Source/WebCore: 

(WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
string.

LayoutTests: 

* fast/text/soft-hyphen-4-expected.txt:
* platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
* platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt:
* platform/mac/fast/text/basic/014-expected.txt:
* platform/mac/fast/text/capitalize-boundaries-expected.txt:
* platform/mac/fast/text/hyphenate-character-expected.txt:
* platform/mac/fast/text/hyphenate-first-word-expected.txt:
* platform/mac/fast/text/hyphens-expected.txt:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
* platform/mac/fast/text/soft-hyphen-2-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@80996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=56283
        
Reviewed by Sam Weinig.

ConservativeSet => ConservativeRoots. "Set" was misleading, since items
are not uniqued. Also, "Roots" is more specific about what's in the set.
        
MachineStackMarker => MachineThreads. "Threads" is more descriptive of
the fact that this class maintains a set of all threads using JSC.
"Stack" was misleading, since this class traverses stacks and registers.
"Mark" was misleading, since this class doesn't mark anything anymore.
        
registerThread => addCurrentThread. "Current" is more specific.
unregisterThread => removeCurrentThread. "Current" is more specific.
        
"currentThreadRegistrar" => threadSpecific. The only point of this data
structure is to register a thread-specific destructor with a pointer to
this.
        
"mark...Conservatively" => "gather". "Mark" is not true, since these
functions don't mark anything. "Conservatively" is redundant, since they
take "ConservativeRoots" as an argument.

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
* JavaScriptCore.exp:
* runtime/ConservativeSet.cpp:
(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::add):
* runtime/ConservativeSet.h:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):
* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots):
* runtime/Heap.h:
(JSC::Heap::machineThreads):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::makeUsableFromMultipleThreads):
* runtime/MachineStackMarker.cpp:
(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThreadInternal):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):
* runtime/MachineStackMarker.h:
* runtime/MarkStack.h:
(JSC::MarkStack::append):



git-svn-id: svn://svn.chromium.org/blink/trunk@80995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
<https://bugs.webkit.org/show_bug.cgi?id=56270>

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32): Made void* address argument
const.
(JSC::MacroAssemblerARMv7::store32): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug. :(

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clean up a duplicate test expectation (default-timing-function.html ).
Add a missing test expection for linux debug which was there for linux release (border-image-vertical-lr.html).

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

for Chromium Linux Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@80990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@80988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Try to fix the Mac build.

* JavaScriptCore.xcodeproj/project.pbxproj: Make sure to forward
ConervativeSet.h, since it's now visible when compiling other projects.



git-svn-id: svn://svn.chromium.org/blink/trunk@80987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):
Add missing constructor.



git-svn-id: svn://svn.chromium.org/blink/trunk@80986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Oliver Hunt.

        Removed another case of DeprecatedPtr (ConservativeSet)
        https://bugs.webkit.org/show_bug.cgi?id=56281
        
        The ConservativeSet is an internal data structure used during marking,
        so direct pointers are fine.

        * runtime/ConservativeSet.cpp:
        (JSC::ConservativeSet::grow):
        * runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append.
        (JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated
        the size of the set based on sizeof(DeprecatedPtr<T>*) instead of
        sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not.
        (JSC::ConservativeSet::size):
        (JSC::ConservativeSet::set): Use direct pointers, as stated above. 

        * runtime/Heap.cpp:
        (JSC::Heap::markRoots):
        * runtime/MarkStack.h:
        (JSC::MarkStack::append): Created a special case of append for
        ConservativeSet. I didn't want to add back a generic "append JSCell*"
        function, since other class might start using that wrong. (In the end,
        this function might go away, since the Heap will want to do something
        slightly more interesting with the conservative set, but this is OK for
        now.)


git-svn-id: svn://svn.chromium.org/blink/trunk@80985 bbb929c8-8fbe-4397-9dbb-9b2b20218538