GitLab

The CHECK no longer guards a use of the screen, so can go away.

R=halliwell@chromium.org

Bug: 998273
Change-Id: I24bba7b87d5bbf8fc872eb7bf35c4f78b9c664ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801740Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696158}

The currently committed expected file actually marks the test as failing
while switching to CanvasResourceProviderSharedImage fixes this test.
Temporarily marking this test as failing to allow the skia change which
enables shared images to roll in. After that a new baselines for the
passing test will be committed.

R=fserb@chromium.org

Bug: 900706
Change-Id: Ica8dd394d01e30ce51256ea036f77847d8691730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802018
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696157}

This reverts commit 1102f12d.

Reason for revert: it is breaking stuff on several Mac bots.

[E2019-09-12T12:28:01.848585-07:00 31162 0 annotate.go:241] goroutine 1:
[E2019-09-12T12:28:01.848653-07:00 31162 0 annotate.go:241] #0 go.chromium.org/luci/vpython/python/find.go:93 - python.Find()
[E2019-09-12T12:28:01.848672-07:00 31162 0 annotate.go:241]   annotation #0:
[E2019-09-12T12:28:01.848683-07:00 31162 0 annotate.go:241]     reason: no Python found
[E2019-09-12T12:28:01.848692-07:00 31162 0 annotate.go:241]   annotation #1:
[E2019-09-12T12:28:01.848701-07:00 31162 0 annotate.go:241]     reason: could not find appropriate executable for: "python3.8"
[E2019-09-12T12:28:01.848709-07:00 31162 0 annotate.go:241]   annotation #2:
[E2019-09-12T12:28:01.848725-07:00 31162 0 annotate.go:241]     reason: could not find target in system
[E2019-09-12T12:28:01.848739-07:00 31162 0 annotate.go:241]     internal reason: target(python3.8)/dirs([/b/s/w/ir/.swarming_module /b/s/w/ir/.swarming_module/cpython/bin /b/s/w/ir/.swarming_module/cpython3/bin /b/s/cipd_cache/bin /opt/local/bin /opt/local/sbin /usr/local/sbin /usr/local/git/bin /usr/local/bin /usr/sbin /usr/bin /sbin /bin])
[E2019-09-12T12:28:01.848764-07:00 31162 0 annotate.go:241] 
[E2019-09-12T12:28:01.848774-07:00 31162 0 annotate.go:241] #1 go.chromium.org/luci/vpython/venv/config.go:272 - venv.(*Config).resolvePythonInterpreter()
[E2019-09-12T12:28:01.848785-07:00 31162 0 annotate.go:241]   reason: could not find Python for: 3.8.0
[E2019-09-12T12:28:01.848799-07:00 31162 0 annotate.go:241] 
[E2019-09-12T12:28:01.848808-07:00 31162 0 annotate.go:241] #2 go.chromium.org/luci/vpython/venv/config.go:187 - venv.(*Config).makeEnv()
[E2019-09-12T12:28:01.848822-07:00 31162 0 annotate.go:241]   reason: failed to resolve system Python interpreter
Original change's description:
> Make test_env.py compatible w/ Python 3
> 
> Makes test_env.py compatible with both Python 2 and 3. Also adds a very
> simple test to ensure that it remains compatible until some other test
> switches to Python 3.
> 
> As a side effect of adding the test, also makes
> testing/scripts/common.py compatible with Python 3 since it's
> necessary for running isolated scripts.
> 
> Bug: 898348
> Change-Id: Ib58cf4c4f85df60a432764d7f744bc3fee09ae3a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796525
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#695825}

TBR=dpranke@chromium.org,bsheedy@chromium.org

Change-Id: I80fb04b1a224db48b53865e871f39b6364a785b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802095Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696156}

This is to have the fieldtrial_testing_config.json study name match the
Finch trial name.

Bug: 915910
Change-Id: I994e5cc877c3eed6ddf2c94a58086b209103274a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801270Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696155}

Bug: 986526
Change-Id: Ie564436b2a1b36e2bffccb10f6c909a67e5e34c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800742Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696154}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/60f970aa1987..08fcdc74f15c

git log 60f970aa1987..08fcdc74f15c --date=short --no-merges --format='%ad %ae %s'
2019-09-12 dburger@chromium.org Temporarily disable BinhostTest in master-paladin.

Created with:
  gclient setdep -r src/third_party/chromite@08fcdc74f15c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I86d5594da4ee6a73cb1dcde7f50def2f82b1685f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801465Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#696153}

Make sure that there's an accessible title that is read when the
security token PIN dialog appears during challenge-response user
authentication via SAML (a.k.a. smart card user login).

Implementation details:

1. Provide Aria labels for the <oobe-dialog> that point to the DOM
   elements containing the dialog title and subtitle.

2. Autofocus the PIN input field.
   (For some reason, without that the Aria labels are ignored by
   ChromeVox. Also autofocusing is a UX improvement anyway.)

Bug: 1001612
Test: enable ChromeVox on a test Chromebook, start SAML user sign-in using a smart card, check that when the PIN dialog appears the dialog title is read
Change-Id: If1fa93484965e5db6ef4cbd438a6f1af709bdc82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789148Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696152}

chrome_pdf::InitializeSDK() always returns true. So remove code that
assume otherwise.

Change-Id: I2585e006e87b906795b0b1f201be78106871d9d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801249Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696151}

https://chromium.googlesource.com/angle/angle.git/+log/4fdeb8d28d9c..1439b6d5dc24

git log 4fdeb8d28d9c..1439b6d5dc24 --date=short --no-merges --format='%ad %ae %s'
2019-09-12 laurie.hedge@imgtec.com Vulkan: Fix integer overflow for max per stage and combined uniform buffers.

Created with:
  gclient setdep -r src/third_party/angle@1439b6d5dc24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC syoussefi@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Bug: None
Change-Id: I4fb5ec43206bc7c01c41be2fae8d9d6958f13bc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801794Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#696150}

They are:

conformance/extensions/oes-texture-half-float-with-video.html
conformance/extensions/oes-texture-float-with-video.html

Before they were marked as flaky, now they fail consistently on Nexus 9.

BUG=891456,1003489
TEST=bot
TBR=kbr@chromium.org
NOTRY=true

Change-Id: Idef038977f8a6739f50139da676ea92109e4b086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801501
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696149}

Using wpt-import in Chromium 236a9cdc.
With Chromium commits locally applied on WPT:
20133397 "[sensor] Upstream sensor layout tests to wpt"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I8bd051b5c75952b8d2dbc1ba24a52fad590d58b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801453Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#696148}

The server team is making a couple of changes, reflected here:
* changes path from /sr to /i
* removes t query param

Change-Id: Ia7c79cf2f6b8cec7192566b9ee3d9fc1674efa0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799468Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696147}

MaybeRenderEarlyManager tried to remove images from the wrong codec
group in some cases, leaving the right group with a raw pointer to
the CodecImage, and no way to remove it.

This can be simplified, but this is a small text change to permit
merge back to beta.

Bug: 986783
Change-Id: I3643cd0b847250157b0ce2162c176f0113975bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801330Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696146}

https://dawn.googlesource.com/dawn.git/+log/f35dcfe60a62..785ec66b66a3

$ git log f35dcfe60..785ec66b6 --date=short --no-merges --format='%ad %ae %s'
2019-09-12 cwallez BUILD.gn: Correctly skip GLFW on ChromeOS
2019-09-12 digit [fuchsia]: Fix Fuchsia build.
2019-09-11 natlee Use clear loadop to lazy clear depth stencil attachments
2019-09-11 cwallez BUILD.gn: Only expose the GLFW target on platforms that support it
2019-09-11 hao.x.li Set point size value for vertex shader in OptionalVertexInputTest
2019-09-11 hao.x.li Skip some end2end tests for Vulkan validation layers enable on Windows
2019-09-11 rafael.cintron Cleanup d3d12::Device::ExecuteCommandLists

Created with:
  roll-dep src/third_party/dawn

R=oshima@chromium.org, cwallez@chromium.org, vapier@chromium.org
BUG=1002895

Change-Id: I4f222ae847775d23a90ec5a901fa1345bc34f995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800738Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696145}

This change makes backgrounded WebGL contexts release use of the
high-performance GPU. In particular, the context notifies the
DualGPUState object that it no longer needs a discrete pixelformat
object to ensure that the discrete GPU is active.

Bug: 681341
Change-Id: Ic7978841161a72a2dbc9c3cb01cbe763acb950ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794263Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Daksh Idnani <dakshidnani@google.com>
Cr-Commit-Position: refs/heads/master@{#696144}

Tests flake due to RunLoop().RunUntilIdle() exiting before
preferences are set.

Using TaskEnvironment seems to resolve this issue.

Bug: 1003178
Change-Id: Ifd84dcc2f36e8d7e19c6170aa74046e11c873e28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799127
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696143}

This CL aligns Chrome code with Fuchsia's updated vulkan swapchain
extension that now requires ImagePipe2 interface.

This should land along with
https://fuchsia-review.googlesource.com/c/fuchsia/+/315288.

Bug: 982922
Change-Id: Icbe0fc4d947c5ba52e769136e1f2a7b9605d8f54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789851Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696142}

This is replaced by disbaling them on Linux in:
https://chromium-review.googlesource.com/c/chromium/src/+/1798984

Disabling on Linux is reverted in:
https://chromium-review.googlesource.com/c/chromium/src/+/1801053

However, we still need to add back Linux ASAN

BUG=771119,1003176
TEST=bots
TBR=kbr@chromium.org

Change-Id: I89383f22def3ac234acec68dd046c7d5b148cac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801919Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696141}

TEST:

$ git cl try -B luci.chromium.try -b linux_upload_clang -b mac_upload_clang -b win_upload_clang -r 001fe5f6
Tried jobs on:
Bucket: luci.chromium.try
  linux_upload_clang: []
  mac_upload_clang: []
  win_upload_clang: []
To see results here, run:        git cl try-results
To see results in browser, run:  git cl web

$ git cl try-results
Scheduled:
  linux_upload_clang    id=8902494487098015248
  mac_upload_clang      id=8902494452269498288
  win_upload_clang      id=8902494452269498272


Bug: 1001522
Change-Id: Ifb37d81b883575e8575f6cdc7cb5f8b8c6a0dda7
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801923
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696140}

This is required to support: http://crrev.com/i/1697948.

TEST=In context of that tast test, unit-test added.
BUG=b:139956117

Change-Id: Ief15939ac1b0fcd3bd8617e947d6ab65f7fbea18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773322
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696139}

A caBLE v2 device won't have to scan a QR code _every_ time its used.
Rather, a subsequent change will add a handshake mode based on saved
secrets.

Therefore this change alters the v2 handshake to accommodate this. v2
EIDs are now generated by encrypting an 8-byte nonce with 8 zero bytes
using AES-256. The Noise PSK is generated by deriving a per-handshake
PSK from a PSK generating key using HKDF and that same nonce.

In a non-QR handshake, those generating keys will be known by the
browser. In a QR handshake, they are derived from the secret in the QR
code using HKDF.

Bug: 1002262

Change-Id: Iaddfe0bf16053f53867d20f772d5080e54926793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786004Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696138}

Bug: 23697
Change-Id: I5219d261192b9428aaf93b9994ca865950c3584a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793721
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696137}

Also pass an indicator about whether incognito mode is available and do
not send account name if enabled.

Finally, refactor image sharing to separate out image retrieval from sharing functionality and use callbacks to get cleaner separation between lens and other sharing use cases.

Bug: 1002247
Change-Id: I72f05cf17c8623cc47ac4f35adeab16f70381f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792239
Commit-Queue: Ben Goldberger <benwgold@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696136}

https://android.googlesource.com/platform/external/perfetto.git/+log/2b6c52bb82a0..5bd596e325f5

git log 2b6c52bb82a0..5bd596e325f5 --date=short --no-merges --format='%ad %ae %s'
2019-09-12 tneda@google.com Merge "perfetto-ui: Adding new track for heap profile"
2019-09-12 ilkos@google.com Merge "Profile visitor to use the AppendedData symbol packets"

Created with:
  gclient setdep -r src/third_party/perfetto@5bd596e325f5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I2cd2e4fa8030eb35c6ca2b3414126679c7b240a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801834Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#696135}

This time limit exemption was added as a temporary workaround
for background notifications in Android Messages on ChromeOS
and is no longer needed.

Bug: 869714
Change-Id: Idd25f1cd8c8224621361a5031b389f6f81075123
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789966Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696134}

This was added very early during GN bringup. Nowadays, pdb files
are listed as outputs of the solink, solink_module, and link
tools in build/toolchains/win/BUILD.gn, and data_deps does
the right thing with these outputs.

No intended behavior change.

To make sure this is behavior-preserving, I ran the following
command with and without this patch (which behind the scenes
is what the isolate generation uses):

gn gen out/gn --runtime-deps-list-file=<(echo -e \
//chrome/test:performance_test_suite\\n\
//net:net_unittests\\n\
//content/test:content_browsertests)

I then compared the contents of these 3 files with and without
the patch:

out/gnwin/net_unittests.exe.runtime_deps
out/gnwin/content_browsertests.exe.runtime_deps
out/gnwin/obj/chrome/test/performance_test_suite.stamp.runtime_deps

Without this patch, the pdbs I'm removing are all listed twice.
With it, they're still listed, but only once (which is enough).

Bug: none
Change-Id: I5a992f854e69f0c09f10c6ec993974608b6a8550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801495Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696133}

This feature has launched to 100% now, and we are now just cleaning up
the client side code.

Bug: 958655
Change-Id: I3fa869ac03358a14d947f48b46a6a7a1566f51db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783699Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696132}

Now that CookieStore is launched by default, Remove the flag and
the conditions that depends on it.

Bug: 989554
Change-Id: I4172766b1c9fcf5cbd25e721bd002aba2c1417d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729253
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Auto-Submit: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696131}

Bug: 972621, 954328
Change-Id: I8cad41da4a84ddee529ed8cc55287ed6a8335a65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800522
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696130}

The current logic on passing DownloadEntry to DownloadItemImpl is very
weird. First it is created in InProgressDownloadManager, and cached
there. Later when DownloadItemImpl is created, it will retrieve the
entry from InProgressDownloadManager.
This CL fixes the above behavior by passing DownloadEntry directly to
DownloadItemImpl ctor. So we don't need to expose some interface from
DownloadItemImplDelegate.

No functionality change, just refactoring.

Change-Id: Iba7f0b54877149d1f4681cb161eac62dc5f872d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797700Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696129}

This change:
* Adds a base::Feature "RevokeMediaSourceObjectURLOnAttach", disabled by default.
* Adds logic to auto-revoke the MediaSource object URL immediately on successful
  start of attachment to HTMLMediaElement using that URL. This logic is used only
  if the feature, above, is enabled.
* Updates URLFileAPI to also have a revokeObjectURL method that takes an
  ExecutionContext*, since finding a suitable ScriptState* for the existing
  version of revokeObjectURL is fraught with complexity due to the asynchronous
  selection of, and loading of, various URLs by an HTMLMediaElement.
* Lets HTMLMediaElement find the new base::Feature, which is in media::,
  including relaxing the associated presubmit audit similar to other relaxations.

Since unrevoked MSE Object URLs retain a strong reference to the underlying
MediaSource objects, MSE Object URL autorevocation is hoped to reduce memory
bloat from idle, otherwise unreferenced, attached HTMLMediaElement+MediaSource
object groups by letting them be garbage collected.

With this change, short-term experimentation using Chrome variations of the
new feature can help validate if autorevocation is helping reduce such bloat.

BUG=920044

Change-Id: Ibc15c59d0e8166a0b1d28fcf3e0eb275bb69244d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708897Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696128}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/33a0d4f6d76a..c7a03daa99e7

git log 33a0d4f6d76a..c7a03daa99e7 --date=short --no-merges --format='%ad %ae %s'
2019-09-12 shaindel@google.com Merge pull request #2387 from kuzkry:iff
2019-09-12 hgsilverman@gmail.com Googletest export
2019-09-12 absl-team@google.com Googletest export

Created with:
  gclient setdep -r src/third_party/googletest/src@c7a03daa99e7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/googletest-chromium-autoroll
Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official
TBR=isamsonov@google.com,staphany@google.com

Bug: None
Change-Id: I06162dce47def1cd27a2aff46f5756a000814c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800733Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#696127}

Throw WebLayer specific exeptions instead of AndroidRuntimeException.
Also use a null File for in-memory profile.

Change-Id: I2d72226b5e5b8d08f4734e8467f948b9ac618624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787466
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696126}

Allows Android Smart Text Selection to be enabled along with full
Contextual Search semantics.  Both systems look at page text.

There used to be a bottleneck in getting surrounding text that
only allowed a single request/response, but now that's been moved
to Mojo, so multiple requests are allowed.  The limitation was in
the IPC browser/renderer connection, which Mojo avoids.

This CL removes the logic that limited these systems when they
were both active.

Also annotate all the SelectionEventType ints correctly.

BUG=961114

Change-Id: If588a532ccb3fe46a39528ec725c277ec77e7e0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769532Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696125}

https://skia.googlesource.com/skia.git/+log/032cf12f2b84..de4456f6f23a

git log 032cf12f2b84..de4456f6f23a --date=short --no-merges --format='%ad %ae %s'
2019-09-12 robertphillips@google.com Add bench for SkDDLRecorder detach

Created with:
  gclient setdep -r src/third_party/skia@de4456f6f23a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: None
Change-Id: I1aed5013f4fc3523f2f5f3030c166ab49b0c65cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800734Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#696124}

This is a followup of http://crrev/c/1685837. See more at
https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E/edit

Bug: 955171
Change-Id: Ic526fc11165050fe1a5a4af4995bdc40eb309755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795998Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696123}

The APK when built in this mode is not configured correctly since
system_webview_apk does not exist when !public_android_sdk.

Bug: 1000763
Change-Id: I22490d94f06ef764c6b75490a39c7c11c0bbbb67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790381Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696122}

Bug: 998028
Change-Id: I93e7279cefc0f718e86a34e51c8c81769d8aa740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788511Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696121}

Bug: 1001053
Change-Id: Idb8474645e8a141d1439a64acaf06e6764def1e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790420
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696120}

The enum is no longer being used in net/. However, it's still used by
the WebRequestAPI to indicate how an auth challenge received through
the NetworkService API should be responded to, so rather than remove the
enum, this CL moves it to ExtensionWebRequestEventRouter.

This CL also converts it to an enum class, for better type safety, at
the cost of additional verbosity.

NetworkDelegate::AuthCallback is similarly moved to
ExtensionWebRequestEventRouter.

Bug: 934009
Change-Id: I04dca2c6d66ca52b8cc4c8fa44e7d5af1429646f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799367Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696119}