GitLab

base::WriteClangCoverageProfile() must only be called if the buildflag
|use_clang_coverage| is set to true. This CL enforced that by requiring
that the corresponding header can only be included if CLANG_COVERAGE
is enabled.

Change-Id: I473694c05d8e27206d7f849e3ae4d83ba6fd5d6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640397Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com>
Cr-Commit-Position: refs/heads/master@{#667076}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //net.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

R=eroman@chromium.org

Bug: 970209
Change-Id: I863a80f7f07bd95b09a1d225814a0420ca0a865a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648172
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667075}

Expanded DeviceLoginScreenDefaultScreenMagnifierType and
ScreenMagnifierType policies, removed unnecessary
DockedMagnifierEnabled. Fixes policy escape using hotkeys.

Bug: 953262
Change-Id: Id6c1e0814b914ec8824365023eb77dc0052dea98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611922
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667074}

Similar to
https://chromium-review.googlesource.com/c/chromium/src/+/1621135
this CL implements the same for PasswordStore::UpdateLogin()
PasswordStore::UpdateLogin() can fail for various reasons.
Before this CL:
UpdateLogin() returns an empty change list in case of error.
After this CL:
UpdateLogin() accepts an optional output parameter to report the exact
error. This is required for Sync machinery to understand the reason
of failure.

Follow up patches will consume this output parameter.

Bug:971717

Change-Id: I73568cadb91e8a102181c1ffd871733a48242e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648225Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667073}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f23fb0caa01..22d2d256c5d9


Created with:
  gclient setdep -r src-internal@22d2d256c5d9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com

Change-Id: I75a5cc6d9cc82deb2c9dc6ce7bdb86637e3af66e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649459Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667072}

This CL implements step 3 in the refactoring described by
http://crbug.com/951391, which attempts to port the viz
component and service to use our new shared memory API
(base::SharedMemory is deprecated).

It does the following:

- Modify compositor_frame_sink.mojom to ensure that
  the DidAllocateSharedBitmap() method takes a
  base::UnsafeSharedMemoryRegion instance, instead of
  a handle<buffer>.

- Update all related C++ code (mostly implementation
  of the CompositorFrameSync::DidAllocateSharedBitmap
  method.

- Remove the FromMojoHandle and ToMojoHandle functions
  from viz::bitmap_allocation, since they are no longer
  needed.

Bug=951391,795291
TBR=danakj@chromium.org, liberato@chromium.org, dominickn@chromium.org, chrishtr@chromium.org, alexilin@chromium.org
R=alexilin@chromium.org, enne@chromium.org, danakj@chromium.org, piman@chromium.org, samans@chromium.org, liberato@chromium.org, dominickn@chromium.org, mbarbella@chromium.org, chrishtr@chromium.org

Change-Id: I979944ffaeb0c4a2156942364c2632930a136261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646783
Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667071}

Previously handling a buffer from the network data pipe was wrongly thrown away
and it caused crashes. This CL fixes the timing of handling the |pending_buffer|
to make async read work correctly. Added PendingReadWithErrorStatusShouldNotLeak
as a regression test, and also cleaned up some tests with parameterized testing
to improve the test coverage.

Bug: 968922
Change-Id: Ie04456804fb6c13a250a837efb62f5e25c450d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642614
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667070}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //content.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

R=falken@chromium.org

Bug: 970209
Change-Id: Icbe57df713f3b326c5729cad76348c425d59fb7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648187
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667069}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //extensions.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

R=lazyboy@chromium.org, tbarzic@chromium.org

Bug: 970209
Change-Id: Ieb98ed38010683964cf62feae5da77e3e5c3a946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648188
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667068}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //mojo.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 970209
Change-Id: I39d1a7752172f4fd9493eb63cef0d8a93a07e550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648343
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667067}

https://dawn.googlesource.com/dawn.git/+log/fa7228a1fa63..120f5d906283


git log fa7228a1fa63..120f5d906283 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 enga@chromium.org Return nullptr from MakeErrorMapped if OOM allocating staging data


Created with:
  gclient setdep -r src/third_party/dawn@120f5d906283

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel

BUG=chromium:970305
TBR=cwallez@google.com

Change-Id: Iae093b4be1c80724fb5d50e8ccc25d245399202b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649456Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667066}

tests written in JS, for testing code written in JS.

Markdown is rendered here (in case gerrit doesn't render it):
https://g3doc.corp.google.com/experimental/users/olsen/g3doc/writing_js_unit_test.md?cl=240342366

Change-Id: I996e2fd559e9c637edbf22211c28bb3e54948bad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648158
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667065}

As LayerTreeHostImpl::UIResourceData move constructor is declared
noexcept with default implementation, the move constructor of its
members should also be noexcept. GCC will fail to build otherwise
for mismatching noexcept declaration.

We also set the move assignment operator.

Bug: 819294
Change-Id: Icd663da83b882e15f7d16780c9241972e09bc492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645297
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667064}

https://chromium.googlesource.com/catapult.git/+log/8cb795c23d5c..f4eff3d09256


git log 8cb795c23d5c..f4eff3d09256 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 dberris@chromium.org SheriffRedux: Use short commit ID in version
2019-06-07 dberris@chromium.org SheriffRedux: Add nested dashboard/ directory to config


Created with:
  gclient setdep -r src/third_party/catapult@f4eff3d09256

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Change-Id: I91b964fe8177bc3807b875aafa76508b87d985bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649458Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667063}

Bug: 970150
Change-Id: Iaba850dc87b16d40c4822ad04e95883c0469851b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649157Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667062}

Currently |prefetch_url_loader_called_| is incremented on the IO thread, and
other fetch counters which are passed to RegisterRequestMonitor() are
incremented on the EmbeddedTestServer IO Thread.
But they are checked on the UI thread. This is sometimes causing TSan failure.

To fix this, this CL change the counting logic to guard the counter using
base::AutoLock.

Bug: 935267
Change-Id: Id8d99cfdac1d522f349be6c54a29b07784676632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647987
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667061}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //ios.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

R=kkhorimoto@chromium.org, olivierrobin@chromium.org, sdefresne@chromium.org

Bug: 970209
Change-Id: I681297842bc2f808b73eb762c33ef6f43dbdbe8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648340
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667060}

Change-Id: I8e9a9d7b17368976d6521d4a8891326b8080ec9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646789Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667059}

This reverts commit 79759021.

Reason for revert: causes compile failure on win32-archive-rel
https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/1248

../../base/threading/thread_local_storage_perftest.cc(152,15): error: no matching function for call to 'FlsAlloc'
  DWORD key = FlsAlloc([](void*) {});
              ^~~~~~~~

Original change's description:
> [TLS]: Add native tls perftests
> 
> Change-Id: I08289ef9d8e1cb665393823495e292a9cbc236c1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645220
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#667051}

TBR=fdoray@chromium.org,etiennep@chromium.org

Change-Id: I83d07562c74d69a4585101c4a1649e7da1891b0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647267Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#667058}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //chrome/browser/ui.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 970209
Change-Id: I64f900609c681d5f3b4a1253b8d98a9c83d51177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648185
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667057}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //tools.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

R=rhalavati@chromium.org
TBR=tsepez@chromium.org

Bug: 970209
Change-Id: I53e4f75e0f6218f7e240f0f767a75b7d13e92cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648231Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667056}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //device/bluetooth/bluez.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

R=mcchou@chromium.org

Bug: 970209
Change-Id: I1c5a45e7e13f822afd049090723cb9c1c7dcf9ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648339
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667055}

This change replaces usages of base::ContainsKey() and base::ContainsValue()
with base::Contains() in //ipc.

Reproduction:
 - sed -i 's/\bbase::ContainsKey\b/base::Contains/g'
 - sed -i 's/\bbase::ContainsValue\b/base::Contains/g'
 - git cl format

This CL was uploaded by git cl split.

TBR=tsepez@chromium.org

Bug: 970209
Change-Id: Ic4d52830490eda6fc3aca546f390a2287142c7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648341Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667054}

The context is http://crbug.com/946719. We want to fix a crash, however,
it would be difficult to reproduce it locally. To get an insight on a crash,
it would be better to distinguish an error state of ResourceRecord,
so that we can know who sets "-1" here.

Now an error state has two kinds of values, instead of just -1, and we can
know who sets an error state clearly when WriteResourceRecoredInBatch is
called and DCHECK is hit.

Note that |ResourceRecord::size_bytes| is a public field, so this CL is not
perfect, however, that could be okay for the purpose of debugging.

Bug: 946719

Change-Id: I592e1a4622220f5c7ff4eb5112947100b5562e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645113Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667053}

This reverts commit 2018af5b.

Reason for revert: launch is now approved for beta!

Original change's description:
> Revert "Enable new session sync logic by default"
> 
> This reverts commit cda7826e.
> 
> Reason for revert: launch approvals pending.
> 
> Original change's description:
> > Enable new session sync logic by default
> >
> > The new logic has better privacy and reliability properties, and has
> > been experimented with on dev and canary channels. We now enable it by
> > default to launch with M75.
> >
> > Some unit tests had to be updated to reflect the new behavior, and some
> > additional refactoring is used to improve the accuracy of some function
> > names.
> >
> > Bug: 882489
> > Change-Id: I9eb0816cbec1024581efc227b551781a6fbd6559
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543389
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#645925}
> 
> Bug: 882489,965951
> Change-Id: I04b12de7ab33368fbfe4e5579b2ed974ba78a7c3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624574
> Auto-Submit: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662168}

TBR=treib@chromium.org,mastiz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 882489, 965951
Change-Id: If992df3e164fdfc605964cfc30d0893d726ee99f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649317Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667052}

Change-Id: I08289ef9d8e1cb665393823495e292a9cbc236c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645220Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667051}

Screenshot (google internal)
https://screenshot.googleplex.com/Ho2vcfZ8PHt.png

Bug: 930109
Change-Id: I1eff83104085b1fff498fb4817dda196ee3a7a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640648Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667050}

Both tracing and the sampling profiler need to know when the current
thread's name changes. Make it possible to add multiple thread name
change observers to support this.

Bug: 971642
Change-Id: I824e1fec7c7b59cd85e4aa93b7f5ee1e9875ab68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648239
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667049}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/726acb457e59..8f23fb0caa01


Created with:
  gclient setdep -r src-internal@8f23fb0caa01

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com

Change-Id: I222d0b55834498ac1e24a65958e24028a5118aba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648990Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667048}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ib244691e1ec503a2b62f432aad7f944f53ba51de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667047}

This change replaces usages of base::ContainsKey and base::ContainsValue
with base::Contains in //base.

Bug: 970209
Change-Id: I7457bcfadd8501159d0a44a32b30e45cf4af7aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646778Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667046}

Switching from CreateWebAndAppSettingDetailsController() to
PresentWebAndAppSettingDetailsController(), to open Account Settings
Manager.

Related to:
crrev.com/c/1349969 (Adding new API in ChromeIdentityService)
crrev.com/i/721689 (Implementation in ChromeIdentityServiceImpl)
crrev.com/i/721693 (Removing old implementation in ChromeIdentityServiceImpl)
crrev.com/c/1350185 (Removing old API from ChromeIdentityService)

Bug: 905680
Change-Id: I2d895e5472a44cd61121a6a51295afb823398438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1350630
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667045}

This CL is adding events on potentially expensive calls.
see:
  https://bugs.chromium.org/p/chromium/issues/detail?id=938971#c5

We are adding some trace events to the fonts category. They still belongs
to UI since the global effect on font-cache will affect the UI. We are
proposing to put in "fonts" only category the basic fonts accessors.
Calls that has a global effect should stay in "UI" category.

R=drott@chromium.org
CC=benck@google.com

Bug: 938971
Change-Id: I15b7939e63a9fb27d5ba70f79a851c00628cf94e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646994
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667044}

Bug: 905971
Change-Id: If8e1339831394e9bdaed5d1f28a89a1aacfa9101
Tbr: yhirano@chromium.org
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644892
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667043}

This reverts commit 91948560.

Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/38757, consistent failures on mac of the following tests:
TabDragging/DetachToBrowserTabDragControllerTest.DragToPinEnabled_DragToUnpinInNewWindow/0
TabDragging/DetachToBrowserTabDragControllerTest.DragToPinInNewWindow/0

Original change's description:
> Add ability to drag tabs between pinned and unpinned tabs to modify the
> pinned state.
> 
> Bug: 965681
> Change-Id: I4cebf850839a1fdbee702ab2cd3c2fccbdba811e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637045
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Commit-Queue: Charlene Yan <cyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666796}

TBR=bsep@chromium.org,cyan@chromium.org

Change-Id: I0a68811b31c718fcdccba6058ab6bdf664a1547a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 965681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649316Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667042}

https://skia.googlesource.com/skia.git/+log/0e8362655a66..6faf8d662af8


git log 0e8362655a66..6faf8d662af8 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b91f87b6ce1c..ea49f6f5d4e3 (8 commits)


Created with:
  gclient setdep -r src/third_party/skia@6faf8d662af8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Change-Id: I40e9ecded836a813462e0f5fb35bfa54a3667b26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648986Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667041}

https://swiftshader.googlesource.com/SwiftShader.git/+log/8ac0bd6cc3e5..c2c829bc9a63


git log 8ac0bd6cc3e5..c2c829bc9a63 --date=short --no-merges --format='%ad %ae %s'
2019-06-06 swiftshader.regress@gmail.com Regres: Update test lists @ 5c9e165b


Created with:
  gclient setdep -r src/third_party/swiftshader@c2c829bc9a63

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Change-Id: I31e3d7f44206679845db06f2555521e6a7f49356
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648878Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667040}

This patch adds web platform tests to verify the behavior of the
referrer header and `document.referrer` after flipping the length
limitiation flag to on-by-default.

Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/lckJ5OAkUNo/ooVNdvhLAgAJ

Bug: 959757
Change-Id: I385f8f12f20109c50ededb9018a08cd665cb6868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646784
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667039}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/104f3fc6931f..726acb457e59


Created with:
  gclient setdep -r src-internal@726acb457e59

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com

Change-Id: I75acdcdf66273e2153c209e27346b15108e9a1e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648984Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667038}

ListHashSet is deprecated in favor of LinkedHashSet.

HeapLinkedHashSet's invalidate iterators when the container is
modified.  This does not happen in this usage, so replacement is
simple.

Bug: 614112
Change-Id: Idd46f56d4d5a649799476a84b5ad8cfda8da8973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646292Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#667037}