- 07 Oct, 2019 40 commits
-
-
Hiroshige Hayashizaki authored
This CL implements scoping of import maps: - Parsing in ImportMap::Parse(), and - Resolving in ImportMap::Resolve(). To use ResolveImportsMatch() and MatchPrefix() for resolving using scopes, this CL makes them take |SpecifierMap| arguments instead of using |imports_|. Sorting order of scope keys is fixed by https://github.com/WICG/import-maps/pull/182 and new tests (which will pass after this CL) are added by https://github.com/WICG/import-maps/pull/183 Bug: 927181 Change-Id: I778a74424ad0eded8af8bfcf8443764b52abfbd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838233Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#703402}
-
Erik Chen authored
GpuBenchmarking already has as pointer to a RenderFrame. This CL updates the helper class GpuBenchmarkingContext to use that pointer to fetch the relevant objects. This CL is mostly a refactor with no intended behavior change. The big difference is that it used to use a main frame RenderWidget [which may be undead and nullptr in the future]. Now it fetches the local root render widget. Bug: 912193 Change-Id: I6c5bde608c955dc0c8f9383ae40e5fcbc884a08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838477 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703401}
-
Piotr Bialecki authored
Bug: 997369 Change-Id: Ib094d6c30d58a87ee193741081c0a9f96fbf500d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841659Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#703400}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/37a1d28c0058..40324d671c25 git log 37a1d28c0058..40324d671c25 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 jrosenth@chromium.org chromeos_config: mark veyron_jerry experimental Created with: gclient setdep -r src/third_party/chromite@40324d671c25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I16e87e3bf559182b6d3c77b21ace2f218362ba57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703399}
-
Tommy Li authored
This reverts commit 483903ea. Reason for revert: Fix for at least one of the leaks is here: https://chromium-review.googlesource.com/c/chromium/src/+/1845991 Reverting to re-enable these tests. I'll fix more this week if there are further ASAN omnibox failures. Original change's description: > Disabling flaky Omnibox and KeyProvider tests. > > They sometimes leak on ASAN. > > TBR: tommycli@chromium.org > Bug: 1010691 > Change-Id: I663cb4fa70974b35832edacf77e0fdb094631135 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844958 > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703338} TBR=phoglund@chromium.org,tommycli@chromium.org Change-Id: Ib7ff3431c0b0aabe01f5372ecbc03c9b707131da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846033Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#703398}
-
Tim van der Lippe authored
I saw the following stacktrace while running Chromium locally: [205430:205430:1007/182130.681774:ERROR:CONSOLE(61)] "TypeError: Cannot read property 'originStackTrace' of null TypeError: Cannot read property 'originStackTrace' of null at Function._script (devtools://devtools/bundled/sources/sources_module.js:1469:197) at Sources.ScriptOriginPlugin.rightToolbarItems (devtools://devtools/bundled/sources/sources_module.js:1467:41) at Sources.UISourceCodeFrame.syncToolbarItems (devtools://devtools/bundled/sources/sources_module.js:335:215) at Sources.SourcesView._updateScriptViewToolbarItems (devtools://devtools/bundled/sources/sources_module.js:1215:168) at Sources.SourcesView._editorClosed (devtools://devtools/bundled/sources/sources_module.js:1226:43) at Sources.TabbedEditorContainer.dispatchEventToListeners (devtools://devtools/bundled/common/Object.js:12:173) at Sources.TabbedEditorContainer._tabClosed (devtools://devtools/bundled/sources/sources_module.js:1012:114) at TabbedPane.dispatchEventToListeners (devtools://devtools/bundled/common/Object.js:12:173) at TabbedPane._innerCloseTab (devtools://devtools/bundled/ui/TabbedPane.js:30:73) at TabbedPane.closeTabs (devtools://devtools/bundled/ui/TabbedPane.js:23:93)", source: devtools://devtools/bundled/host/InspectorFrontendHost.js (61) It appears that the code in this file already assumes that script can be undefined, but forgot this particular case. Change-Id: I7b0c0d34b4d16a1d29656cd8d86e3f290f8bb227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845751 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703397}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e94f473753be..6acfca3ad3e3 git log e94f473753be..6acfca3ad3e3 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 cnorthrop@google.com Vulkan: Handle texStorage when base level is set Created with: gclient setdep -r src/third_party/angle@6acfca3ad3e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I1f979e1c8221a26be767c33a251d175420feb7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845333 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Andrew Grieve authored
Two motivations: 1. Allows comparing trichrome (where dex is uncompressed) with Monochrome (where it is compressed). 2. Aligns with SuperSize breakdowns. Change-Id: I86905c52d89a66b52adb05fe8b74df6666c7e485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839432Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#703395}
-
Pavel Yatsuk authored
This CL adjusts logic in TemplateUrlServiceAndroid::SetPlayAPISearchEngine to merge search engine data when search engine with matchiung keyword already exists. Additionally this CL adjusts merging logic during prepopulated list update to preserve Play API search engine data. This is important since search url might contain attribution parameters. We might decide to take different approach with providing attribution info, but before that happens preserving Play API data is the safest approach. BUG=1002271 R=pkasting@chromium.org,wylieb@chromium.org Change-Id: I596a6df724cfc73801663ca7d97074ba69e856c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838534 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#703394}
-
Ryan Daum authored
Upstreams a utility which draws roundy corners on aura windows. (Re-land of chromium/1841573 with fucshia build fix) Bug: internal b/141369549 Test: manual Change-Id: I366f9020632eeae9f3f1f5dad908f8aeb6a910ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845995Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#703393}
-
Fernando Serboncini authored
Otherwise we may lose back information Bug: 1011309 Change-Id: Idabededd27383bca54db237a23fbd245b8c83eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845231 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#703392}
-
Francois Doray authored
This CL reduces the memory associated by a ScopeLock: - Remove ScopeLock::is_locked_: We can check if the release callback is nullptr to know if the lock is held. - Remove level and ScopedLockRange bound to the release callback: The values are already stored in the ScopeLock and can passed when invoking the callback. The goal is to offset the memory that will be used in a subsequent CL to track the frame holding each ScopeLock. Bug: 980533 Change-Id: I9b6852db43c2000ae1b68c31996921bc52a63916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838374 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#703391}
-
Pavel Yatsuk authored
BUG=1002271 R=wylieb@chromium.org Change-Id: I91b95a2cdb8db323248bb9341c85e2a83ec9a15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842673Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#703390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af16026220a0..d16fbbb2686c Created with: gclient setdep -r src-internal@d16fbbb2686c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I725c0d10fd151fadc4c9774bdad4d195b7d653a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844122Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703389}
-
Maksim Sisov authored
At the moment, we have zwp_linux_dmabuf support that we use to create wl_buffers in the browser process based on passed dmabuf prime fds from the GPU process. However, there are plenty of systems that also support EGL_EXT_image_dma_buf_import, but do not provide zwp_linux_dmabuf protocol extension. Instead, instead they use the wl_drm protocol. Thus, import it to third_party protocols and utilize it in the Ozone/Wayland implementation. There are no functionality changes brought with this CL, but rather it adds support for that protocol and uses it if zwp_linux_dmabuf is not available. If non is available, Chromium uses software compositing (Chromium hosts gpu service in a separate process) or Wayland Egl (in-process-gpu is passed and the gpu service is hosted in the browser process). Bug: 1008348 Change-Id: I06eddc68ef0ad0a897aeefa1f31677986e563eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827001Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#703388}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ic2152a5bc8464df9354dcd158a72d6f5168d6030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844338 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#703387}
-
Mathieu Binette authored
Moved in https://crrev.com/c/1841581 and https://crrev.com/c/1841889. Bug: 1011508 Change-Id: I9a582bf09f3c3198e1438e8d41774cee1f5ffabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842560Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#703386}
-
Brandon Wylie authored
When an Android app is killed, C++ destructors aren't guaranteed to be called. When an app is killed within the 5 second delay for CommitQueuedOperations, the operation is skipped completely. The end result is non-Google search engines missing from the settings screen. Bug: 1007070 Change-Id: Icd178a067a2b440ce538b03c4da82e0449306b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837074Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#703385}
-
Vitaly Buka authored
C/C++ for "XEvent = {}" promise to zero initialize only the first member of the union. The tails of larger member can be uninitialized. Detected with -ftrivial-auto-var-init=pattern. XEvent member sizes on x86_64 40 xany 96 xkey 96 xbutton 96 xmotion 104 xcrossing 48 xfocus 64 xexpose 72 xgraphicsexpose 48 xnoexpose 48 xvisibility 72 xcreatewindow 48 xdestroywindow 56 xunmap 56 xmap 48 xmaprequest 72 xreparent 88 xconfigure 56 xgravity 48 xresizerequest 96 xconfigurerequest 56 xcirculate 56 xcirculaterequest 64 xproperty 56 xselectionclear 80 xselectionrequest 72 xselection 56 xcolormap 96 xclient 56 xmapping 40 xerror 72 xkeymap 40 xgeneric 56 xcookie 192 pad Bug: 977230 Change-Id: I7838e5f68b6320e067f9c446222a38fdcd35bdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842505Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#703384}
-
Xiaohui Chen authored
Bug: b:142244324 Test: locally build and able to start voice query Change-Id: I5b3ce11a8b1944b1f6f013e4b39151887bfaf878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845432 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/647c7a97d32d..25f416465e8d git log 647c7a97d32d..25f416465e8d --date=short --no-merges --format='%ad %ae %s' 2019-10-07 brianosman@google.com Add particles gallery to skia.org site 2019-10-07 jlavrova@google.com Adding line/style metrics 2019-10-07 fmalita@chromium.org [skottie] Horizontal-constraint for Shaper *ToFit alignment modes 2019-10-07 borenet@google.com Update go deps Created with: gclient setdep -r src/third_party/skia@25f416465e8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ieb57f56e11f3e7970df0f4855579aad707df1ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844120Reviewed-by:
-
Tim van der Lippe authored
Bug: 1006759 Change-Id: I3f5917ab3f5b3fb823ca460c395301ba19eed2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841792 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/34cccdc65d79..4b97a1108114 git log 34cccdc65d79..4b97a1108114 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 johnkslang@users.noreply.github.com Merge pull request #1919 from dj2/install_spirv 2019-10-03 johnkslang@users.noreply.github.com Merge pull request #1918 from KhronosGroup/format-attributes 2019-09-25 johnkslang@users.noreply.github.com Merge pull request #1906 from ShchchowAMD/master 2019-09-20 johnkslang@users.noreply.github.com Merge pull request #1910 from KhronosGroup/fix-1900-const-nonuniform 2019-09-19 johnkslang@users.noreply.github.com Merge pull request #1907 from kainino0x/separate-web-and-emscripten 2019-09-19 johnkslang@users.noreply.github.com Merge pull request #1905 from KhronosGroup/GL_EXT_buffer_reference_uvec2 2019-09-18 johnkslang@users.noreply.github.com Merge pull request #1908 from digit-google/fuchsia-fixes 2019-09-18 cepheus@frii.com README: Fix WASM typos. 2019-09-18 cepheus@frii.com HLSL: Fix #1903 Catch 0-argument case to constructors. 2019-09-18 johnkslang@users.noreply.github.com Merge pull request #1902 from jeffbolznv/extended_types 2019-09-16 johnkslang@users.noreply.github.com Merge pull request #1899 from KhronosGroup/SPIR-V_1.5 2019-09-16 johnkslang@users.noreply.github.com Merge pull request #1894 from ShchchowAMD/master 2019-09-12 johnkslang@users.noreply.github.com Merge pull request #1897 from dj2/unused 2019-09-11 johnkslang@users.noreply.github.com Merge pull request #1895 from amdrexu/bugfix 2019-09-05 cepheus@frii.com Fix #1879: Check for valid variable before checking for unsized arrays. 2019-09-05 johnkslang@users.noreply.github.com Merge pull request #1892 from greg-lunarg/kg106 2019-09-03 johnkslang@users.noreply.github.com Merge pull request #1889 from Roy-AMD/code-refine 2019-08-30 cepheus@frii.com Placeholder fix for part of #1870. 2019-08-30 cepheus@frii.com Non-functional: Make whitespace/braces consistent for a recent commit. 2019-08-29 johnkslang@users.noreply.github.com Merge pull request #1885 from zoddicus/fixUnInitializedVariableWarnings 2019-08-28 johnkslang@users.noreply.github.com Merge pull request #1876 from jeffbolznv/imma 2019-08-28 cepheus@frii.com ESSL/SPV: Fix #1856: Allow ESSL shaders to compile to OpenGL SPIR-V. 2019-08-28 cepheus@frii.com Documentation: Provide more detail in setting up the environment. 2019-08-27 johnkslang@users.noreply.github.com Merge pull request #1883 from Kangz/fix_gn 2019-08-27 johnkslang@users.noreply.github.com Merge pull request #1881 from baldurk/buffer-array-bind-reflection-fix 2019-08-26 johnkslang@users.noreply.github.com Merge pull request #1882 from Kangz/fix-chrome 2019-08-26 johnkslang@users.noreply.github.com Merge pull request #1878 from dneto0/chrome-fix 2019-08-22 cepheus@frii.com Bump revision. 2019-08-22 johnkslang@users.noreply.github.com Merge pull request #1874 from KhronosGroup/inherit-memory-qualifiers 2019-08-22 johnkslang@users.noreply.github.com Merge pull request #1875 from jonahryandavis/extra-tokens 2019-08-21 cepheus@frii.com Bump version. 2019-08-21 johnkslang@users.noreply.github.com Merge pull request #1855 from KhronosGroup/web Created with: gclient setdep -r src/third_party/glslang/src@4b97a1108114 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: Ia35e07d16f2adfc46bce3b5a581fb4bade2f8315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844121Reviewed-by:
-
Avery Musbach authored
The present CL refactors overview in preparation for the idea that each root window will have its own SplitViewController with its own observers. Each OverviewGrid shall observe the corresponding SplitViewController. OverviewSession shall observe the SplitViewController for the primary root window, for the sole purpose of updating the bounds of the no windows widget. Test: ash_unittests OverviewSessionTest.* OverviewGridTest.* Bug: 970013 Change-Id: Iae96ff34eb7e6c3f0fb48eb38d563e3366f72861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841776 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#703379}
-
Cliff Smolinsky authored
When calling CreateLowBoxToken, the kernel API will throw an error if there is a mismatch between the saved_handles_count and the saved_handles array. If the count is 0, the pointer must be null. This change passes in nullptr to CreateLowBoxToken for saved_handles if saved_handles_count is 0. Bug: 1000447 Change-Id: I2e5706944e5348ae1833eb28562945b7874f6a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845831Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703378}
-
Stephen Nusko authored
Instead of MRUCache which uses a sorted map under the hood. Use two std:arrays, one to store all the keys (very cache friendly when scanning them). And then immediately jump to the value in the other array. This leads to a ~9% speed up (5 to 13% at the 95% confidence). See the "two_arrays tracing/tipOfTreeTracing" sheet in https://docs.google.com/spreadsheets/d/1HIiyUQa7d8eLfMBBBm_7V60kqNABYoFbHpKdpwnYu78/ Total tracing overhead is ~59.8% (52% to 67% at the 95% confidence). See the "two_arrays tracing/tipOfTreeNotTracing" sheet in the doc above. Bug: 1007611 Change-Id: Ie2584e0e3a13e34097021fd128387cfa4fabaeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844822 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#703377}
-
Garrett Beaty authored
These changes simplify migrating to starlark by removing spurious diffs from the semantic diff. The name in the hand-written project.cfg doesn't appear to actually be used. In lucicfg, the parameter that populates the name field in the generated project.cfg is used for creating the fully-qualified names of the form <project>/<bucket>/<builder> where the actual value is only <builder> or <bucket>/<builder>. The repo field in the gitiles field of the trigger field doesn't require the .git suffix and the normalized value when computing the semantic diff omits it. In lucicfg, the parameter that populates the field disallows the .git suffix. Change-Id: Id26647e72cbdb2c7f913ab608273ccc032e14d55 Bug: 1011908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836002 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#703376}
-
Gayane Petrosyan authored
Bug: 1008838 Change-Id: Id8ca2de0720fe6a7254291b18d5969c6174780da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842551Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#703375}
-
Mark Mentovai authored
Our initial remediation instructions for https://crbug.com/1007358, https://web.archive.org/web/20190925230123/https://support.google.com/chrome/thread/15235262, instructed users to remove system Keystone while preserving system tickets. Following these instructions, user Keystone would be installed when Chrome was launched, and a user ticket would have been registered. Chrome's own install script would then find a system ticket and remove the user ticket and cancel the user-driven update. By only respecting a system Keystone ticket when system Keystone actually appears to be installed, based on the presence of GoogleSoftwareUpdate.bundle in the system (root /Library) location, the immediate user ticket removal can be avoided, and the update attempt will not be abandoned. Because a system ticket is present, it's likely that the user will still not have appropriate permission to update the Chrome installation. But in this case, at least the error message will be more accurate. This fix is necessary for users to successfully recover by installing a new copy of Chrome as a user. The "set up automatic updates for all users" button can be used to reinstall system Keystone and get Chrome correctly back on a system ticket. Bug: 1007358 Change-Id: I8a9218cb959e359d6f6033de1d638b99344d8374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834944Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#703374}
-
Maks Orlovich authored
So that cookies get looked up in 1st party, not 3rd party, context. This should keep the tests: IsolatedAppTest.CookieIsolation IsolatedAppTest.SubresourceCookieIsolation PlatformAppBrowserTest.Isolation WebViewTest.CookieIsolation working with upcoming cookie behavior changes. Bug: 1006816 Change-Id: I3d366dcb484efa61045d6d339bb1e7d3c5062a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844712Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b441acf65652..99a209624835 git log b441acf65652..99a209624835 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 ivoc@webrtc.org Added support for skipping get_audio events, adding dummy packets and setting a field trial string. 2019-10-07 srte@webrtc.org Replaces static modifier functions in AudioSendStream. 2019-10-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 35431c51..10156469 (703133:703248) Created with: gclient setdep -r src/third_party/webrtc@99a209624835 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie137c73dcf0b6edf50122787675503be5e7b08f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845090Reviewed-by:
-
Yuwei Huang authored
This CL implements Don't Show Again for the notification UI on iOS client. MDCAlertController doesn't work well if it has too many buttons, (and there is no checkbox UI in iOS either), so I introduced a custom dialog view controller instead that stacks the message and buttons vertically. Screenshots: https://screenshot.googleplex.com/eJk0NEnXGBk https://screenshot.googleplex.com/vQY6nQwB2MN Bug: 1001291 Change-Id: I2a6e94ba5a9162d6144c3a5acb0c0040259d5ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836974Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#703371}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I58eb2f1f250a09221c7a2d3162cd7398e4666e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845572Reviewed-by:
-
Martin Robinson authored
Bug: 866336 Change-Id: I4e59974ee8f11cd789720b587d2954d7e3086168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1309654 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703369}
-
Friedrich Horschig authored
This CL adds a few integration tests. They stop at the bridge since the execution of native code slows the tests down, introduces flakiness and most-likely doesn't work on Kitkat. Bug: 957532 Change-Id: I291c50ef7b8772198c89109bbe3acd885a43d054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845372 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#703368}
-
Lily Chen authored
This adds policy definitions for two policies that allow reverting to "legacy" SameSite cookie behavior, either by default or for a specific list of domains. As the policy implementation is not yet complete, these are tagged with 'future': True for now. Bug: 978172 Change-Id: Ieb95eec87b08b0c44a535ad8b1c7c90431d6a039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837234 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#703367}
-
Andres Calderon Jaramillo authored
This CL modifies the JPEGImageDecoder to detect the YUV subsampling format correctly when not all the components are in the first scan. Prior to this change, the subsampling calculation was based on the information in the first scan. However, for some JPEGs (non-interleaved), this would produce YUV_UNKNOWN. This change makes the computation based on the information in the SOF which is global for the image and includes the information of all the scans. Bug: 900446 Test: Add a test to cover the non-interleaved case. Change-Id: If1d810f0d921cba3603cf82ac9fba19da02e8982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844094Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#703366}
-
Alex Cooper authored
Ensure that newly created sessions get the current XRVisibilityState, even if they were created after that visibility state may have changed. Bug: 1011566 Change-Id: I5eac2aac73f74a7e4b4426be3b5e6603097db39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841246Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#703365}
-
Andrew Grieve authored
Change-Id: Ie638c6f3d05c548056a8f78a83ac7f243bff0472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841751 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#703364}
-
Jinho Bang authored
This is to match the spec change[1]. [1] https://github.com/gpuweb/gpuweb/pull/423/files#diff-599c3a4f36042dec5cdc606f3c30dc38R913 Bug: 877147 Change-Id: I3fcf6505fd69caa6b3932145f937bc1b523b9244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844526Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#703363}
-
