GitLab

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/897803002

Cr-Commit-Position: refs/heads/master@{#314598}

Revert of Mojo+NaCl: Move generated code to mojo/nacl. (patchset #1 id:1 of https://codereview.chromium.org/896243003/)

Reason for revert:
Caused build failures on mac bots. Not sure why it failed there but not on the CQ.

Original issue's description:
> Mojo+NaCl: Move generated code to mojo/nacl.
>
> This change moves generated code for Mojo support in NaCl from mojo/monacl to
> mojo/nacl. This makes the target directory more consistent across GYP and GN
> builds.
>
> An upcoming change for IRT support will generate a header, which will need a
> consistent path (relative to include_dirs) across build systems.
>
> BUG=454466
>
> Committed: https://crrev.com/99cdffdb116cf608630600bbbf66a37fcf16695e
> Cr-Commit-Position: refs/heads/master@{#314591}

TBR=ncbray@chromium.org,jamesr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454466

Review URL: https://codereview.chromium.org/900983002

Cr-Commit-Position: refs/heads/master@{#314597}

Add Rappor metrics for Safe Browsing and SSL interstitials.  This reports the eTLD+1 of URL.  Later we'll add click-through and history state.

BUG=451646

Review URL: https://codereview.chromium.org/872813003

Cr-Commit-Position: refs/heads/master@{#314596}

It is already in the GYP build.

BUG=445627
TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
  ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)

Review URL: https://codereview.chromium.org/899723003

Cr-Commit-Position: refs/heads/master@{#314595}

Because a single gesture (in NSEvent-speak) can contain multiple types
of sub-gestures (e.g, pinch and rotate), we do not get a begin/end
of the magnify-only part of the gesture. Work around this by saving
the NSEvent-gesture's beginning event, sending it (with the right type)
when the magnification begins, and sending an end event when the
gesture ends (only if a magnification event was sent).

BUG=451559

Review URL: https://codereview.chromium.org/886893002

Cr-Commit-Position: refs/heads/master@{#314594}

Clear empty "proxy" dictionary created by bug in data reduction proxy code.

BUG=448172

Review URL: https://codereview.chromium.org/893333002

Cr-Commit-Position: refs/heads/master@{#314593}

omnibox.mojom defines the following interface for javascript to request
omnibox suggestions from C++ code:

interface OmniboxUIHandlerMojo {
  StartOmniboxQuery(string input_string,
      int32 cursor_position,
      bool prevent_inline_autocomplete,
      bool prefer_keyword,
      int32 page_classification);
};

and the corresponding API for sending results back:

interface OmniboxPage {
  HandleNewAutocompleteResult(OmniboxResultMojo result);
};

These were defined as clients of each other so they shared a message
pipe. However, there was no way for the caller of StartOmniboxQuery() to
correlate calls to HandleNewAutocompleteResult() with a particular
invocation of StartOmniboxQuery(). Additionally we're getting rid of the
Client= notion in mojom.

This changes the StartOmniboxQuery API to take an additional parameter
of type OmniboxPage corresponding to a new message pipe that can receive
requests. The caller in omnibox.js allocates a new pipe for each query
(closing the previous one) and gets replies on the new pipe.

(this is a potential use case of a multiple return value syntax in mojom
 but that's just a proposal right now).

R=sky@chromium.org
BUG=451321

Review URL: https://codereview.chromium.org/882883006

Cr-Commit-Position: refs/heads/master@{#314592}

This change moves generated code for Mojo support in NaCl from mojo/monacl to
mojo/nacl. This makes the target directory more consistent across GYP and GN
builds.

An upcoming change for IRT support will generate a header, which will need a
consistent path (relative to include_dirs) across build systems.

BUG=454466

Review URL: https://codereview.chromium.org/896243003

Cr-Commit-Position: refs/heads/master@{#314591}

Using RWH is a pure reflection of what the renderer process knows while
RWHV is linked to the native implementations.

This is fixing the LayoutTest failures created by:
https://codereview.chromium.org/871013003

It might also be the cause of the test flakyness. Another CL will
attempt to re-enable them (can't reproduce locally).

BUG=450634

Review URL: https://codereview.chromium.org/898443003

Cr-Commit-Position: refs/heads/master@{#314590}

Revert of Remove usages of Timeline commands in telemetry (patchset #4 id:60001 of https://codereview.chromium.org/895043002/)

Reason for revert:
Windows telemetry unit tests are failing intermittently after this patch.

Sample failing build:
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/53177

Output:
[1/1] telemetry.core.backends.chrome_inspector.inspector_network_unittest.InspectorNetworkTabTest.testHTTPResponseTimelineRecorder failed unexpectedly:
  Could not find Flash at E:\b\build\slave\Vista_Tests__1_\build\src\third_party\adobe\flash\binaries\ppapi\win\pepflashplayer.dll. Continuing without Flash.
  To run with Flash, check it out via http://go/read-src-internal
  Traceback (most recent call last):
    File "E:\b\build\slave\Vista_Tests__1_\build\src\tools\telemetry\telemetry\decorators.py", line 55, in wrapper
      func(*args, **kwargs)
    File "E:\b\build\slave\Vista_Tests__1_\build\src\tools\telemetry\telemetry\core\backends\chrome_inspector\inspector_network_unittest.py", line 40, in testHTTPResponseTimelineRecorder
      self.assertEqual(test.responses_count, len(events))
  AssertionError: 1 != 2

Original issue's description:
> Remove usages of Timeline commands in telemetry
>
> We are going to remove Timeline domain from the remote debugging protocol soon. This CL fixes remaining usages of timeline commands.
>
> BUG=448318
>
> Committed: https://crrev.com/9ca9eb0c7668c7a7e1f595ea0c4f3bca221e9350
> Cr-Commit-Position: refs/heads/master@{#314522}

TBR=caseq@chromium.org,pfeldman@chromium.org,marja@chromium.org,yurys@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448318

Review URL: https://codereview.chromium.org/903523002

Cr-Commit-Position: refs/heads/master@{#314589}

R=spang@chromium.org
BUG=454455

Review URL: https://codereview.chromium.org/896243002

Cr-Commit-Position: refs/heads/master@{#314588}

BUG=454828
R=maruel@chromium.org,glider@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/895923002

Cr-Commit-Position: refs/heads/master@{#314587}

For developers who have opted in to showing a user-visible UI change on every push (in exchange for showing the user a less scary permission prompt), we currently[1] enforce that each push shows a notification.

This patch relaxes the requirement slightly, so that sites don't need to show user-visible UI if a same-origin-ish[2] tab is currently visible, i.e. is the active tab of a non-minimized window. That's because updating the UI of such a tab instead of showing a notification is a valid way to show user-visible UI.

See also:
- https://crbug.com/437277
- http://lists.w3.org/Archives/Public/public-webapps/2014OctDec/0214.html
- https://github.com/w3c/push-api/pull/87

[1]: (since https://codereview.chromium.org/842233003)

[2]: (see comment in push_messaging_service_impl.cc)

BUG=437277

Review URL: https://codereview.chromium.org/866443003

Cr-Commit-Position: refs/heads/master@{#314586}

Fixed ios unit tests performance for coverage configuration.
Removed testing/platform_test_ios.mm as unnecessary.

BUG=441961

Review URL: https://codereview.chromium.org/899593002

Cr-Commit-Position: refs/heads/master@{#314585}

Rename this asset to a more generic name as it will be used in
the private repository too.

BUG=455020

Review URL: https://codereview.chromium.org/896033003

Cr-Commit-Position: refs/heads/master@{#314584}

This fixes unresolved references in the linux chromiumos ozone
shared_library build.

BUG=445627
TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
  ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)

Review URL: https://codereview.chromium.org/895263002

Cr-Commit-Position: refs/heads/master@{#314583}

Creating a FileRef does not check if the file exists or not.
We had assumed that if a FileRef could be created that
the file or directory in question exists.
Instead look at the result code from Query and possibly
return ENOENT if it turns out the file or diretory does not
exist.

BUG=None
TEST=nacl_io_tests
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/899003002

Cr-Commit-Position: refs/heads/master@{#314582}

BUG=374132

Review URL: https://codereview.chromium.org/895653002

Cr-Commit-Position: refs/heads/master@{#314581}

- Only copy the lib/ dir (i.e. skip usr/ etc),
- Pass --disable-static to configure scripts to avoid
building static libs. Ideally, this flag should be in
target_defaults. However, zlib1g doesn't support it and
fails; I couldn't find a way to exclude the flag for
individual packages. Instead I add it to every other package
expiclitly.

BUG=423343
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/877283005

Cr-Commit-Position: refs/heads/master@{#314580}

BUG=

Review URL: https://codereview.chromium.org/897903003

Cr-Commit-Position: refs/heads/master@{#314579}

InspectorNetworkTabTest.testHTTPResponseTimelineRecorder is flaky on
Win 7 Tests, it fails 11 out of the last 14 runs.  Disabling for now.

BUG=455269
TBR=bolian
NOTRY=true

Review URL: https://codereview.chromium.org/898903003

Cr-Commit-Position: refs/heads/master@{#314578}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4dce32c..1a481fe

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899913002

Cr-Commit-Position: refs/heads/master@{#314577}

Add a class to deal with the streaming/digesting, and hook it up.  File streams are usable in a wider range of scenarios (like over MTP) so this enables hashing in those situations.

BUG=453880

Review URL: https://codereview.chromium.org/875513006

Cr-Commit-Position: refs/heads/master@{#314576}

On Windows, this moves it to chrome_child.dll. Overall binary sizes is 4.5 MB smaller (chrome_child.dll gets 3.6 MB larger while we drop the 8.1 MB pdf.dll). On Mac, the binary is 6.6 MB smaller. On Linux, it's 7MB smaller. This is from official release builds, after stripping on Linux.

The size savings are because we don't ship duplicate versions of V8, and also the PDF plugin uses some of base and net.

This depends on OOP PDF, since otherwise the V8 isolates for the plugin and Blink interact badly. That got turned on a few weeks ago.

BUG=453844

Review URL: https://codereview.chromium.org/799643004

Cr-Commit-Position: refs/heads/master@{#314575}

Add a unit test for DeviceMotionEventPump to ensure that events are not delivered to Blink at a rate faster than 60 Hz.

TEST=DeviceMotionEventPumpTest.PumpThrottlesEventRate
BUG=421691

Review URL: https://codereview.chromium.org/870053009

Cr-Commit-Position: refs/heads/master@{#314574}

Since https://codereview.chromium.org/899663003, child accounts would get both the "supervised user" and the "child" icons. This CL fixes that.

Review URL: https://codereview.chromium.org/897903002

Cr-Commit-Position: refs/heads/master@{#314573}

Review URL: https://codereview.chromium.org/900513005

Cr-Commit-Position: refs/heads/master@{#314572}

This removes plumbing for InstrumentWillBeginFrame(),  InstrumentDidBeginFrame(),
InstrumentDidCancelFrame() and InstrumentWillComposite() between CC and
WebDevToolsAgent and replaces it with trace events emitted directly from CC.
Note all related methods of LayerTreeHostClient still remain, as they're used
in tests.

TBR=jamesr
(for mojo/)
BUG=

Review URL: https://codereview.chromium.org/892203002

Cr-Commit-Position: refs/heads/master@{#314571}

Introduce a local typedef for the DownloadIdCallback type since it
is really simple.

Remove obsolete #includes.

BUG=453790

Review URL: https://codereview.chromium.org/888983003

Cr-Commit-Position: refs/heads/master@{#314570}

Revert of scheduler: Increase work batch size to 4 (patchset #3 id:40001 of https://codereview.chromium.org/873313006/)

Reason for revert:
Reverting because of layout test failure:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/dom/MutationObserver/end-of-task-delivery.html,inspector/sources/debugger/live-edit-no-reveal.html

Original issue's description:
> scheduler: Increase work batch size to 4
>
> BUG=444764
>
> Committed: https://crrev.com/6ef9302baebb894ced09f28741f86bbb626ed82a
> Cr-Commit-Position: refs/heads/master@{#314546}

TBR=rmcilroy@chromium.org,alexclarke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444764

Review URL: https://codereview.chromium.org/877043004

Cr-Commit-Position: refs/heads/master@{#314569}

At present, a change in the default zoom level does not immediately
update the zoom icon in the location bar. E.g. if we change the zoom
level of chrome://settings to 90% (causing the zoom icon to display a
'-' symbol), then change the default zoom level to be 75%, the icon
should switch to show '+'.

This CL adds an event subscription to the ZoomEventManager in order
to receive notifications about default zoom level changes.

BUG=451349

Review URL: https://codereview.chromium.org/897513003

Cr-Commit-Position: refs/heads/master@{#314568}

https://codereview.chromium.org/884993003 broke gdb debugging
on Release buils. This commit makes sure it works to debug
Debug and Release (only on rooted device) builds.

BUG=453379

Review URL: https://codereview.chromium.org/891743003

Cr-Commit-Position: refs/heads/master@{#314567}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d3780c5..4dce32c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/898663004

Cr-Commit-Position: refs/heads/master@{#314566}

ChromeVox uses Google closure-style dependencies (goog.provide and
goog.require) and this script gives a quick view of the dependency tree for
a module.

R=dtseng@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/894853006

Cr-Commit-Position: refs/heads/master@{#314565}

BUG=454800
DIFFBASE=869073006

Review URL: https://codereview.chromium.org/900663002

Cr-Commit-Position: refs/heads/master@{#314564}

BUG=

Review URL: https://codereview.chromium.org/886613002

Cr-Commit-Position: refs/heads/master@{#314563}

This CL implements policy pushing for device-local accounts. The
Tango connection comes from AffiliatedInvalidationServiceProvider,
which manages a single shared connection for device policy pushing
and device-local account policy pushing, conserving server resources.

BUG=442800
TEST=New unit test

TBR=dcheng (profile_invalidation_provider_factory.h)

Review URL: https://codereview.chromium.org/822523003

Cr-Commit-Position: refs/heads/master@{#314562}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/874293007

Cr-Commit-Position: refs/heads/master@{#314561}

. Remove ThreadLocalState::id_, since it is the same as the thread-id.
  (http://crrev.com/3f8178ae)
. Remove WorkerThreadTaskRunner::current(), since it's no longer used.
  (http://crrev.com/3a4b2d1a)

BUG=none
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/898803003

Cr-Commit-Position: refs/heads/master@{#314560}

Reland of: 862103002 at patchset 120001
Reverted here: https://codereview.chromium.org/875983008/

BUG=454553, 433180
R=jww@chromium.org, bcwhite@chromium.org, jwd@chromium.org, sky@chromium.org
TBR=mlerman@chromium.org

Review URL: https://codereview.chromium.org/900583003

Cr-Commit-Position: refs/heads/master@{#314559}