- 04 Mar, 2020 40 commits
-
-
Min Qin authored
This will allow download in public chromium build to work on Q with MediaStore. BUG=1052490 Change-Id: I31476292b92c7a5882fa4ad80cc60b29f6b14dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057806Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746867}
-
Leonid Baraz authored
Changed namespace from media:: to policy:: for IntervalMap<...> and Interval<..> No functionality changes Bug: b/144279234 Change-Id: I1ebf9f005e779d813c0a25b777f9d02fa995d70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080790Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746866}
-
Colin Blundell authored
This CL moves knowledge of the //chrome-level AutofillAssistant out of ExternalNavigationHandler.java and into ExternalNavigationDelegateImpl.java via the ExternalNavigationDelegate interface. This change is a step toward componentization of ExternalNavigationHandler.java for sharing with WebLayer. Via this change, we also eliminate knowledge of //chrome's Tab object from ExternalNavigationHandler. The bulk of this change is in the tests, as ExternalNavigationHandlerTest had several tests of the functionality that this CL moves. We split those tests across the test of the handler and the test of the delegate impl: the tests in the handler now test that the handler behaves as expected when the intent is/is not handled by the the delegate in this case, while the delegate impl tests test that the behavior of the production method is as expected (i.e., these tests contain the bulk of the logic that was previously in the handler-level tests of the production code). Change-Id: If950a3fac701744af4610173e5c221bdb8a8a7c1 Bug: 1031465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081418 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#746865}
-
Matt Menke authored
This is what we're planning on shipping, so seems best to have default behavior match that. Alone, this flag has no effect aside from fully populating NetworkIsolationKeys. In order for that to change behavior, flags to enable respecting NIKs at other layers have to be enabled. Bug: 993801 Change-Id: I6647b813ddf32262bf59a84a0219e3a13489096f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087895Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746864}
-
David Tseng authored
When arrowing by line (up/down) through a text area and encountering a blank line in braille before: - braille would not correctly clear the previous line contents - e.g. "Testing testing one" "Testing testing" would remain displayed even though the caret was on the second (blank) line. after: Arrowing by line results in - blank display - a blinking cursor over the first cell Change-Id: I1cd770644f78c60e2c4cf4d074da5c048aff9e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085155 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#746863}
-
Yuly Novikov authored
1. Due to performance improvements we don't need as many shards now. 2. '\*' in filter was needed only on command line, launcher uses just '*'. TBR=kbr Bug: angleproject:4426, angleproject:4421 Change-Id: I97b1345cbfa592931f0f3dead05397b9f6b1c029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086299Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#746862}
-
Jonathan Backer authored
Bug: 1019787 Change-Id: Ib78e2b969d9fe27ec63895e7ecb8f8ea755d0309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087423Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746861}
-
Donn Denman authored
Temporarily disable the whole test suite due to multiple recent flakes. TBR=twellington@chromium.org BUG=1058362 Change-Id: Ie51fe66053cf346c2c8202635b7c5c11ad6d9f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088007Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#746860}
-
Julie Jeongeun Kim authored
This is a reland of 99fe56da It doesn't change anything since it's reverted due to the precursor CL, 52dbe8bb. The precursor CL is relanded at https://crrev.com/2071164. Original change's description: > Convert FrameMsg_EnforceInsecureRequestPolicy to blink RemoteFrame mojom > > This CL converts FrameMsg_EnforceInsecureRequestPolicy to method on > blink RemoteFrame mojom. It also updates the unit test with > intercepting RemoteFrame and removes checking the IPC message. > > BUG=1047284 > > Change-Id: I9578c49cfcc08b3a682ec2899627dc6503965654 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038513 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#743924} Bug: 1047284 Change-Id: I9f76888894caf55bd3c664b4fe4eb8254a778223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081717 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#746859}
-
Xinghui Lu authored
Previously, verdict_cache_manager is managed by services_delegate. This is not a typical way of managing objects keyed by a profile. In this CL, make verdict_cache_manager a child class of keyed_service. Also introduce verdict_cache_manager_factory as a keyed service factory to manage it. Bug: 1058179,1057937 Change-Id: Ia43d05c3f05f597770e906b1c6e20e8626fc7021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085632Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746858}
-
Brandon Wylie authored
Clients aren't expecting it and fail. Bug: 1058198,1015174 Change-Id: I8b06b1f47a963e5f3a300f2bc35311f64a43f2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086260Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746857}
-
Xiaohan Wang authored
This already exists in EmePromiseSystemCode and EmeTimeToResolvePromise but somehow got missed in EmePromise. Change-Id: Ibfd3cda5b19ef732c9393ebcdfbd99857a7059d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085708Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746856}
-
Kurt Horimoto authored
crrev.com/c/2005903 was an incomplete solution because the util functions generating the keyboard accessory views was only called once per OmniboxCoordinator's lifetime. This CL updates the coordinator to observe the voice search availability and reconfigure the keyboard accessory views when availability changes. Bug: 998524 Change-Id: Ica88b4690fac0ada1be6cc77bb6ca911f5a245e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075045Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746855}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fd4f5cda74d..fb875c61cf00 git log 0fd4f5cda74d..fb875c61cf00 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 taylori@google.com Merge "perfetto-ui: Fix thread state colors" Created with: gclient setdep -r src/third_party/perfetto@fb875c61cf00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I332fdeb99c434691a78e4868c341926b6aad8320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087940Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746854}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8800de8931b3..4eb885a01e2c git log 8800de8931b3..4eb885a01e2c --date=short --first-parent --format='%ad %ae %s' 2020-03-04 gabriel.luong@gmail.com Migrate Console and SegmentedRange tests into Ninja build 2020-03-04 gabriel.luong@gmail.com Rename Console.ts to Console_test.ts and SegmentedRange.ts to SegmentedRange_test.ts 2020-03-04 tvanderlippe@chromium.org Generate InspectorBackendCommands.js on presubmit 2020-03-04 mathias@chromium.org Support emulating vision deficiencies 2020-03-04 tvanderlippe@chromium.org Generate SupportedCSSProperties.js on presubmit Created with: gclient setdep -r src/third_party/devtools-frontend/src@4eb885a01e2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003700,chromium:1011811,chromium:1056614 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib01838c63e7928913ae596ff280cf8a9fba0fbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087943Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746853}
-
Gang Wu authored
https://chromium-review.googlesource.com/c/chromium/src/+/2063037 moved code to ShareImageFileUtilsTest.java, and removed file from build file, but forgot to delete this file. Change-Id: I00715dad85a69a73df5555097970ad0bc489c893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076524Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746852}
-
Nina Satragno authored
Enable the WPTs on the CI. Fixed: 1054809 Change-Id: I4029d8aa5f5a1cf1a8130c9331d528b4b9707add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079340 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746851}
-
Henrique Nakashima authored
This allows caching int-typed field trial parameters for use before native is loaded. Bug: 1041865, 1012975 Change-Id: I9192d5fc7ee27dd617843e3afc5355d274d6e48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086255Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#746850}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3f283eb209ad..27a813089d83 git log 3f283eb209ad..27a813089d83 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 xiaoxuan.liu@arm.com Vulkan: Re-enable RobustResourceInitTest.Texture test Created with: gclient setdep -r src/third_party/angle@27a813089d83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I0e5f67e9418758e29adb3ac542e2237473f59dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087936Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746849}
-
Stephen Chenney authored
There are too many Blink.UpdateTime events, resulting in significant "sampling" by the UKM system which in turn leads to way low client counts. Fix it by emitting two samples per page load: once before First Contentful Paint and one after, chosen uniformly at random within in period. Modify the test to test the new approach as best can be done. Design Doc (chromium.org): https://docs.google.com/document/d/1P49GrDe3mDDV9Q1yUm27ioWE4m1_Zz1FwRwVwGQh-ZI/edit?usp=sharing Bug: 1014195 First pass at updating sampling. Change-Id: I4461015346d506adf5d01bc65e14538d05f2b798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083686Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#746848}
-
Connie Wan authored
The primary feature change is in the group header. See inline comments for an issues I had with the editor bubble: the text field, which automatically gets focus when the bubble opens, would also spawn a context menu. There isn't a single event (in the sense of a keyboard event or mouse event) that catches this, so I had to manually work around stopping the propagation. Bug: 1056362 Change-Id: I8ca7f10bc4b05ece0ed1eb52be61a0341210e182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079835 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746847}
-
Alexandre Frechette authored
This reverts commit d65a5ea7. Reason for revert: Causing build failures in `blink_web_tests on ATI GPU on Mac Retina` and `blink_web_tests on Intel GPU on Mac`. Original change's description: > [DevTools] Support vision deficiency emulation in CDP > > This patch makes it possible to emulate various vision deficiencies, > including color vision deficiencies and blurry vision, in the Blink > Renderer. The various deficiencies can be triggered by the new > Emulation#setEmulatedVisionDeficiency command in the Chrome DevTools > Protocol. > > Design doc: https://goo.gle/devtools-cvd > > Bug: chromium:1003700 > Change-Id: Ie86d14b215b93aa219b91b0e7877898d2d47bc5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063136 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746715} TBR=caseq@chromium.org,vogelheim@chromium.org,mathias@chromium.org,futhark@chromium.org Change-Id: I596637b0b55eb04bd9adc99d3ef76b820eaf2fff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1003700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088013 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#746846}
-
Alexandre Frechette authored
This reverts commit ddfb5c89. Reason for revert: To allow the reverting of https://chromium-review.googlesource.com/c/chromium/src/+/2088013. Original change's description: > Clear emulated vision deficiency when disabling inspector > > CDP’s Emulation#setEmulatedVisionDeficiency no longer accepts > the empty string to clear the override. This patch updates > InspectorEmulationAgent::disable accordingly. > > Bug: chromium:1003700 > Change-Id: I3f08aafd4b2ff0ecdf119f1d6898a8960cc3eb71 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087672 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Auto-Submit: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746743} TBR=petermarshall@chromium.org,mathias@chromium.org Change-Id: Idc3bcc33d7cb09ad16c232987479fe9b025ae5dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1003700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087897Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#746845}
-
Alexandre Frechette authored
This reverts commit 96b8d308. Reason for revert: Caused compile failures - see https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/10808. Original change's description: > Adding mojolpm fuzzer. > > This adds code that generates libprotobuf-mutator based > structure-aware fuzzers as part of the mojom compilation process. > (changes in //mojo). > > It also adds a fuzzer for CodeCacheHost using this framework to demonstrate > how it will be used, and documentation explaining that fuzzer and how to use > this generator to write new fuzzers. (changes in //content/test). > > It finally includes a few changes to typemap and traits files that > were necessary to smooth over some inconsistencies in existing code > using mojo. > > Bug: 941849 > Change-Id: I660a57bd90c0963bd9a0b8608c746cdb767edc98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978739 > Commit-Queue: Mark Brand <markbrand@google.com> > Auto-Submit: Mark Brand <markbrand@google.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#746827} TBR=pkasting@chromium.org,dcheng@chromium.org,rockot@google.com,ochang@chromium.org,markbrand@google.com,mpdenton@google.com,tmathmeyer@chromium.org,tmathmeyer@google.com Change-Id: I3b92169e4d15940eda618f83566020a20b58e6ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087974Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#746844}
-
Luke Zielinski authored
Bug: 1056722 Change-Id: Ib0155de66b4ec29929799a52968928bcdf94b6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087619 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746843}
-
Anna Malova authored
Bug: 1007815 Change-Id: If2e4b3c5df6fb6b128eb3924040a38c17f256458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081429Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746842}
-
Dave Tapuska authored
This change makes all WebWidgets be created by blink. Since all WebWidgets are created by blink they have a common base member WidgetBase which will eventually create and own the compositing, input and emulation infrastructure. Change-Id: I306658e8d3b941bcbb93f864e503112387dbd169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042510Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#746841}
-
Natalie Chouinard authored
Move Language settings to org.chromium.chrome.browser.language package and add Language OWNERS. Bug: 1047357 Change-Id: Ie2edf897723515c85cd8830bcbc65f5ea2a094f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086292Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746840}
-
Jérôme Lebel authored
When the user taps on "settings" link, the sign-in needs to be triggered. Once the sign-in is finished, AdvancedSettingsSigninCoordinator needs to be presented. Related to: crrev.com/c/2050568 Bug: 971989 Change-Id: I754c0f2d0f58c2a8590f7b5b86fdbf86b27d6da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087811 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746839}
-
Jonathan Backer authored
Change-Id: Iafd0ac9d9c1507d586dc40939833ad8f847c37f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055006Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746838}
-
arthursonzogni authored
According to: https://github.com/whatwg/html/pull/2373 html and svg Element are hiding their nonce when there are at least one Content-Security-Policy defined from an HTTP header. The two implementation: - HTMLElement::InsertedInto - SVGElement::InsertedInto were hidding the nonce slightly differently. To prevent further divergence, factorize this implementation into Element::HideNonce() and call it from both places. Bug: 1053496 Change-Id: I3cbad88f70c61591bef060d4188c82388e6001d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078536 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#746837}
-
Alex Ilin authored
The test crashes on Android N builder. TBR: bsazonov@chromium.org Bug: 1014213 Change-Id: I7be993cffb7296735ffe1b8da5c1e3fb5e161f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087343Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746836}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c6d0fdfb4098..d71548adfb09 git log c6d0fdfb4098..d71548adfb09 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 bsalomon@google.com Add support for wrap modes to GrYUVtoRGBEffect. Created with: gclient setdep -r src/third_party/skia@d71548adfb09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: If48f35ccf591ec3dca9518955c6fa2ae117733fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746835}
-
Anna Malova authored
Both RegisterRequestHandler and RegisterDefaultHandler expect HandleRequestCallback which is RepeatingCallback. Bug: 1007815 Change-Id: I4f7c9a970e6a1a767e3c21ccc65b5e98c027774a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085313Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746834}
-
Ken Rockot authored
This allows the prlimit64 syscall in utility processes, with the contingency that it only operates on the calling process's PID and it always has the |new_limit| arg set to null. The getrlimit() implementation is backed by this syscall on Linux, and the utility sandbox config already allows SYS_getrlimit. The restrictions above prevent callers from changing the process's own limits, and from querying or changing other process's limits. Bug: 1052045 Change-Id: Iabe81ea2791b5c3d604a9176c7463e9d00ff6cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086814Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#746833}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/126720bd2e57..5ff1de5384c5 git log 126720bd2e57..5ff1de5384c5 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 amaiorano@google.com Subzero: fix regression in Optimizer Created with: gclient setdep -r src/third_party/swiftshader@5ff1de5384c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I41109ab81448e8b9e65ed29869682353a925377d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746832}
-
Antonio Gomes authored
This ensures that the AssociatedRemote<blink::mojom::LocalMainFrame> works after a crash. Analogously, the CL also resets |local_main_frame_host_receiver_|. BUG=None R=arthursonzogni@chromium.org Change-Id: I5f32afb6824afb30035051ba729377be40b0f374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085233 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#746831}
-
Xiaoqian Dai authored
For one navigation operation, we would like the nudge only be fired once. So this CL makes more restriction on when the navigation status change can be fired to show the nudge ui (and cancel the previous one if applicable). Bug: 1009005b Change-Id: I90b79e9ffb6219a66172364c976e69a9479670dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086553Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#746830}
-
Xiaoqian Dai authored
As requested by the UX. Bug: 1009005b Change-Id: I3c175dbbb8074c47400df3777ab849dc313294f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086072Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#746829}
-
Fergal Daly authored
This is a temporary addition to help track down a bug that only occurs in webview in the wild. Bug: 1006814,1056426 Change-Id: If5be906c7faf94ef994389f7b286ef2a70bba5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087236 Commit-Queue: Fergal Daly <fergal@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#746828}
-