- 01 Oct, 2020 40 commits
-
-
Martin Kreichgauer authored
Change CredentialManagementRequest factory methods and credential management related FidoAuthenticator interface methods to take a parsed TokenResponse where they were previously accepted raw pin token bytes. This is in line with how other CTAP messages are implemented and will make it easier to add new PIN protocol versions. Bug: 1129946 Change-Id: Ib10007b955abebb09ce4e3f3f12d8eeca832594d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438353 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#812749}
-
Pavol Drotar authored
The hashes were removed because the associated images were not uploaded and this causes failures in the scripts of the translation team. New images are planned to be uploaded when the associated strings are updated. Bug: 1133466 Change-Id: I310bbcd113ac147cedcc1a89a7b37e99079384c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442736Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Pavol Drotár <pavoldrotar@google.com> Cr-Commit-Position: refs/heads/master@{#812748}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d6055cbe1f06..dcffb3db73cd 2020-10-01 thestig@chromium.org Remove obsolete build_overrides entries. 2020-09-30 nigi@chromium.org Fix potential segmentation faults during annotation rendering. 2020-09-30 tsepez@chromium.org Create locale managers as-needed in pdf_cfgas_stringformatter_fuzzer.cc 2020-09-30 tsepez@chromium.org Avoid duplicate FXGC_Initialize() in public fuzzers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1132607,chromium:237527 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3ed4bff14df2174db3f57d90046852520ae4d8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812747}
-
Victor Hugo Vianna Silva authored
Interfaces and small structs don't need a .cc file just to have an default constructor/destructor. Bug: None Change-Id: I45767eb135b15c47a1e98dfbe0546d1bcb6c6547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440632Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#812746}
-
Gayane Petrosyan authored
beginning. Bug: 1132486 Change-Id: I7412855b1fc64613452d03517a5220850ffa7669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438881Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#812745}
-
W. James MacLean authored
This CL plumbs a bit from NavigationRequest::OnResponseStarted() via all pathways to ShouldOriginGetOptInIsolation(). This will allow removing the scoping mechanism previous used to determine when a NavigationRequest is trying to opt an origin into isolation, and resolve the associated bug in the process. Bug: 1099718 Change-Id: I98e0a9cf5974aae84d4895468734efefd427ddc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411423Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#812744}
-
Tanmoy Mollik authored
This cl reorders the account list shown in AccountManagementFragment and shows the signed-in account on top with "Manage your Google account" row. Screenshot: https://crbug.com/1131008#c5 Bug: 1131008 Change-Id: Ib9cbd8052da08dc37c2e85aaaa46060509e155d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435093Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812743}
-
Scott Violet authored
This is a regression from https://chromium-review.googlesource.com/c/chromium/src/+/2411161 . That patch meant that a newer client run with an implementation older than 86 would not properly clean up Tab's static map. This meant any calls to Tab.getTabsInBrowser would throw an exception because the tab was marked as destroyed but not removed from the map. The skew tests cover this. BUG=1131953 TEST=covered by skew tests Change-Id: I8f9ce175b316e75cfd752c2afa587ea3ad517393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442001Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812742}
-
John Z Wu authored
- Just use the inferred name or empty string - Always cancel the expiration flow Change-Id: I8e017deebcdd417347534d03740d60e16d372003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441846Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812741}
-
David Roger authored
Change-Id: I49b54f203f66969a4bb106bd9e9cf04e675857d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442538Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#812740}
-
Jordan Oroshiba authored
Bug: 1130668 Change-Id: Ia7fd692e01fdf1f59d75248ef980a5d64ef1f8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441135 Auto-Submit: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#812739}
-
Geoff Lang authored
glFinish has a fairly high chance of triggering the watchdog, make sure it gets the most time possible by reporting progress before and after calling glFinish. Bug: chromium:1014259 Change-Id: I110ab8499b0d480a1f96e385093e044e8484cd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436951Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812738}
-
Dylan Cutler authored
identifiability study. Even though the method takes two enums as an argument, the first is always gl.RENDERBUFFER, so really we are only interested in the second argument. In this instrumentation, we record parameters that leak information about the underlying GL implementation. Instead of making a new IdentifiableSurface type, it made sense to me to just include the high entropy parameters this method may receive in the WebGLParameter type. Bug: 973801 Change-Id: I2251c16e3f0187611b3bf01f3a3e0196a88d5ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437024 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812737}
-
Eric Orth authored
Fixed: 1091777 Change-Id: I06f21a2519dfd4991aea284a2835ed7f9705b708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436778 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#812736}
-
Michael Checo authored
- Will be updated to final mocks in the future. Screenshots: - Diagnostics App (before) http://shortn/_yLwB4ZAKfO - Diagnostics App (after) http://shortn/_bUefLJUyg6 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I8e5d1cca983b2311483a423f89ef305a53450252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441011 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812735}
-
Stepan Khapugin authored
Migrate kNetworkPredictionEnabled, kNetworkPredictionWifiOnly bool prefs to instead be one int pref. Bug: 538573 Change-Id: I053700eb909c3308ef3c8945133428f930dbd1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426704 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#812734}
-
chrome://gpudpapad authored
There are no tabs anymore in this page, and the use of cr.ui.TabPanel can simply be replaced by a plain div. Bug: 1028829 Change-Id: If7121f011d27dd93a3f276708e468c99744d67f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442498 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#812733}
-
Joe Mason authored
* Add a StartMeasurementForProcess method to V8PerFrameMemoryRequest * Add a MeasurementRequestQueue helper class that holds separate lists of lazy and bounded requests. * Add per-process MeasurementRequestQueue's as well as the existing global MeasurementRequestQueue. R=chrisha Bug: 1080672 Change-Id: I0257ad72482bff8fe5e478b19d8545947da483c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440695 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#812732}
-
Thomas Lukaszewicz authored
This CL adds a ChromeExtensionWebContentsObserver to the WebContents used by the Tab Search bubble. When the UI is shown in a full tab this is added for us but is otherwise not registered automatically. This is required to ensure we can collect metrics from the extension's metricsPrivate APIs for UMA histograms. This should result in no functional changes beyond enabling metrics collection on the front end. Bug: 1099917 Change-Id: I127aafeab79a11caac3d48ed9c9ce7b6233e4aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442485Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812731}
-
Mohammad Refaat authored
Update previousSessionInfo to retain the session id in the case of single window app, then use it on later runs for the first restore of the run. Bug: 1131031 Change-Id: I3b245826e9a9c40cb6df1d2e9c4123276c8d73f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442231 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#812730}
-
ckitagawa authored
Use 1/4 size tiles that represent 1/4 the current bitmaps we use. This results in less memory usage as less data will be used by edge tiles that aren't visible. Change-Id: I8d1164cdb9cd28b0681d86c94885d150d3e0df04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441322 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812729}
-
yiyix authored
This change removes the flag ExtendedTextMetrics.fontBoundingBoxAscent and Descent and references in code to ship attributes in TextMetrics: fontBoundingBoxAscent and fontBoundingBoxDescent. Currently chrome is only returning the width, actualBoundingBoxLeft/Right/Ascent/Descent of the measured text. https://html.spec.whatwg.org/multipage/canvas.html#textmetrics Intend-to-ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/GSmWjdqmgCA/m/c5Y8DfKyCAAJ Bug: 1129621 Change-Id: Id367f0f8d74aa82f6baa64f5909b325fede57b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440847 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812728}
-
Bailey Berro authored
This change makes SystemDataProvider an observer of PowerManagerClient. Whenever UpdateBatteryChargeStatus is called or an event is received from PowerManagerClient, updated BatteryChargeStatus information will be fetched from CrosHealthd + PowerManagerClient. Bug: 1128204 Change-Id: Icecaabf56da030734804194acc38e3716b01d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431726 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
chinsenj authored
If a user presses on a folder name textfield it selects the whole field. If they press the left/right arrow keys it does nothing. Only after the second left/right arrow key press does the textfield clears the selection and shows the cursor. This CL makes it so after the first left/right arrow key press the textfield clears the selection and shows the cursor. Bug: 1133681 Change-Id: I8c27ce850c05411f887bc8bf92f706485645c6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441999Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#812726}
-
Jan Wilken Dörrie authored
This reverts commit d0bda2ee. Reason for revert: Logging Password Length is not needed. Original change's description: > Add metrics to InsecureCredentialsManager > > This CL adds metrics about passwords weakness check. > > Bug: 1119752 > Change-Id: I20ff20dde480c84ebd5d252ce7684cecc4fc4c87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434336 > Commit-Queue: Irina Fedorova <irfedorova@google.com> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812625} TBR=rkaplow@chromium.org,jdoerrie@chromium.org,irfedorova@google.com Change-Id: I6b01baa8be4e0e351deb3ff8f5eae79e12c2ab4a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442971Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#812725}
-
chinsenj authored
This change enables interactive window cycle list, introducing new ways to interact with alt-tab. Fixed: 1067327 Change-Id: Ia93463d86134e22952ade8bc74b10cb4bc55ee66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441257 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812724}
-
Guido Urdaneta authored
These tests are flaking frequently on TSAN. Bug: 1127211 Change-Id: I063e6435f5c33659bfdc2f21c5a38b55cbaf9881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442791 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#812723}
-
Tanmoy Mollik authored
All the grey icons in settings page should be of same color. They should all use @color/default_icon_color value. ic_google_services_48dp and ic_signout_40dp icons uses a different shade of grey. This cl updates these icons. Screenshot: https://crbug.com/1132900#c6 Bug: 1132900 Change-Id: If24bda31f812513757c44d77815c71b156945687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435310 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL uses CoreAccountInfo as argument instead of Account in the method SigninTestUtil#signinAndEnableSync(). Bug: 1002056 Change-Id: Ia3882dde8dea95b6b8782823e0438362a5193255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438414Reviewed-by:
-
Hua, Chunbo authored
Bug: None Change-Id: I1cebed8f85622697230fe91dc165f3eb3d47e30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434144Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#812720}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2fde3fac998c..f01bf538a4ff 2020-10-01 taylori@google.com Merge "perfetto-ui: Order thread tracks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7e294276b5e0a7fbe82f4eba3701443289e0e328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442718Reviewed-by:
-
Greg Thompson authored
BUG=1089800 R=chromium-metrics-reviews@google.com Change-Id: Iabb68d2fb2189dcffee05d9d2a4be6a226b1d32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440667 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#812718}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. This cl does not address entropy leaked by MIDIConnectionEvents. Given those events only occur when a device is connected or disconnected, it is unlikely that they would be useful to fingerprinting scripts. Bug: 973801 Change-Id: I7b3ad5682126dbcbdb2196bdbac0fa985bfee404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432811Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Thomas Tellier authored
The current value for this policy indicates that it applies to all ChromeOS versions after M84, however this wasn't right as that policy was not released by then: it was ready after a change I made in M86. This CL updates the 'supported_on' value to match what the product actually supports. BYPASS_POLICY_COMPATIBILITY_CHECK=The previous value was incorrect but setting the correct value causes the policy checker to complain. Bug: b/169582602 Change-Id: I9c4d27a73f2ab78d13a95d6ab49dabc7d65c200d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435098 Commit-Queue: Thomas Tellier <tellier@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#812716}
-
Adam Langley authored
Previously the contents of the QR code changed because the keys were continually rotated. The latency of BLE adverts turned out to be significant however, so the acceptance window grew to the point where it wasn't providing very much security. The contents of the QR code no longer changes so this change animates the QR code by rotating the masking function applied. BUG=1002262 Change-Id: I5d1a179d0400b35e3840bf9fce356a038e5c2ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441300Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#812715}
-
Maksim Ivanov authored
This reverts commit dc61429b. Reason for revert: Speculative revert, see crbug.com/1133102 Original change's description: > [Payments][Metrics] Extend expiry for ever-green metrics. > > Also updated ownership. > > Bug: 1128111 > Change-Id: Iba6ba54d4a47e02579faa69ff7078ba6ab012333 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426977 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811232} TBR=mpearson@chromium.org,nhiroki@chromium.org,danyao@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1128111,1133102 Change-Id: Ib9e0eba5421247c1d9b556fbe4fd82b2408b4a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442793Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#812714}
-
David Bokan authored
This should make the tests more reliable since waitForAnimationEnd simply rAFs x frames. In web_tests, rAF intervals are artificially made much shorter than in the real world so this doesn't actually wait very long. The time based version waits using rAFs but breaks based on the wall clock time (currently 200ms without a change) so it doesn't depend on the rAF interval time. Bug: 915926 Change-Id: I052cede0a3712911a9bd385929bec56d987af7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442350 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#812713}
-
sandromaggi authored
This adds the non-implemented (or deprecated) actions from the backend to the list of reserved fields. Bug: none Change-Id: Id77bffb0da81c2d17362cf7a0e383fa810250528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440669 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#812712}
-
Joon Ahn authored
https://screenshot.googleplex.com/4HWAicLVp6pnhNp Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I5f53c37dd5e99631438b736eed8211214292d70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436953 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59f1d1e36d26..281fb1ed7ba9 2020-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 97f841d7..2cdb2cb6 (812293:812617) 2020-10-01 philipp.hancke@googlemail.com stop sending x-peer-id in peerconnection_server 2020-09-30 glahiru@webrtc.org Replace one use of sigslot with RoboCaller If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7651293284447a1dd64711116bab8b06ae9165a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442715Reviewed-by:
-
