- 20 Nov, 2018 40 commits
-
-
Brad Hall authored
This will allow them to try 10.13 first and fall back to 10.12 if there aren't any hosts available. Bug: 853356 Change-Id: I0fd82376ebb2c4e501a78360bbbc675c90ee7d34 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1330693 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#609743}
-
Reilly Grant authored
This change assigns owners for the following flags that are owned by myself: * enable-generic-sensor (launched) * enable-generic-sensor-extra-classes * new-usb-backend Bug: 897809 Change-Id: I7642770769398bb31035a18374b060a94f1b02cb Reviewed-on: https://chromium-review.googlesource.com/c/1340955Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#609742}
-
Jun Choi authored
When Bluetooth adapter is powered on and user has not previously connected with any Bluetooth authenticators, show Bluetooth device selection UI followed by PIN pairing UI. Also, record used Bluetooth authenticator ID on successful WebAuthN API in order to trigger WebAuthn BLE pairing UI for case when use has never paired to Bluetooth authenticator before. Bug: 877344 Change-Id: I312bdffa618c5f7d446fe24228acbad8e64f2067 Reviewed-on: https://chromium-review.googlesource.com/c/1333767 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#609741}
-
Clemens Arbesser authored
[Autofill Assistant] Fixed crash caused by TouchEventFilter when interacting with page after autofill assistant has given up. The crash was caused by listeners that were not properly unregistered. Bug: 806868 Change-Id: Id7514b6a1c6a2a6e97ecf57b4eb4c6812ed1cb4e Reviewed-on: https://chromium-review.googlesource.com/c/1344103Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#609740}
-
Johannes Kron authored
The kInvalid enum entries will be removed since they are not part of the standard T-REC H.273. kUNSPECIFIED may be used instead. Bug: webrtc:8651 Change-Id: I71ac3f5eebf73cb4188c5e15532b289a4be1bc50 Reviewed-on: https://chromium-review.googlesource.com/c/1343108Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#609739}
-
Becky Zhou authored
+ Removed experiment flags + Refactor app modal JavaScript dialogs to use modal dialog + Use property model for JavaScript dialogs + Clean up tests Bug: 899318, 874537 Change-Id: Id9d5bf83d9bc086ffd064c0589eafcaba495f26b Reviewed-on: https://chromium-review.googlesource.com/c/1340974Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609738}
-
Gauthier Ambard authored
This CL changes the way the top margin of the doodle is computed when the fullscreen flags are enabled and the NTP isn't contained directly in BVC. It uses the StatusBarHeight() instead of the passed topMargin which is wrong on cold start. Bug: 902259 Test: M71 fix, test all types of new tab animation and ntp layout. Change-Id: I33af04db418664c6fd033477329353d645379f4c Reviewed-on: https://chromium-review.googlesource.com/c/1337498 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609737}
-
Elly Fong-Jones authored
This will allow teams to own flags without either having a team email alias or having to list all their team members in each flag entry. Bug: 897809 Change-Id: I960c3327b5175e92abbb1cf1ad3e2832b1d1cfb6 Reviewed-on: https://chromium-review.googlesource.com/c/1344190 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609736}
-
Robert Sesek authored
This is a reland of 8f34427c Additional fix: - Increase a pixel expectation in BoundedLabelTest, which was affected by some macOS 10.11-specific font variation. Original change's description: > Fixes to get Views versions of message_center_unittests passing on Mac. > > This enables the views version of the message_center, in preparation > for removing the Cocoa implementation. > > Fixes: > - Use an EventGenerator in tests, rather than manually synthesizing > events. > - NotificationInputContainerMD::HandleKeyEvent() now explicitly clears > the text input field when handling VKEY_RETURN, as the test expects > this. > - Disabling notifications is no longer handled in > NotificationViewMD::ButtonPressed(), since it wasn't the button > Listener for the block_all_button_ (the > NotificationControlButtonsView is). Disabling is now handled in > ToggleInlineSettings() instead. > - The SlideOut tests are disabled on Mac because the test framework > doesn't support synthesizing gesture scroll events. > > Bug: 739386 > Change-Id: Id841779233662111f52d491ba78e5315422003b4 > Reviewed-on: https://chromium-review.googlesource.com/c/1341091 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609514} Tbr: estade@chromium.org Bug: 739386 Change-Id: Id7b6b05f5fa487ebb9caaff18ee8570cf5d4b99d Reviewed-on: https://chromium-review.googlesource.com/c/1343665Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#609735}
-
Morten Stenshorne authored
Percentages must be ignored when calculating min/max intrinsic / preferred inline sizes, since the inline size is by definition unknown at that point. This fixes the problem both in the legacy engine and in LayoutNG. Bug: 906663 Change-Id: Ib29a66ee3d6146e72e6f9ec3283293af48e633a0 Reviewed-on: https://chromium-review.googlesource.com/c/1344090Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#609734}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f0099596439..44974e143c90 git log 5f0099596439..44974e143c90 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 devicentepena@webrtc.org AEC3: Adding a correction factor for the Erle estimation that depends on the portion of the filter that is currently in use. 2018-11-20 nisse@webrtc.org Add const or GUARDED_BY on a few ChannelSend members Created with: gclient setdep -r src/third_party/webrtc@44974e143c90 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5f779466daac5f45fd1002e19b80ece0f44baaea Reviewed-on: https://chromium-review.googlesource.com/c/1342845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609733}
-
Hiroshige Hayashizaki authored
This reverts commit 98dc58ec. Reason for revert: crbug.com/906964 Original change's description: > Add off-main-thread-worker-script-fetch/external/wpt/referrer-policy > > Bug: 835717, 880027 > Change-Id: I074ea4b911132477853bf95be70a36b7d62c4f79 > Reviewed-on: https://chromium-review.googlesource.com/c/1330903 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609534} TBR=hiroshige@chromium.org,nhiroki@chromium.org Change-Id: Ic9c46e2efd39d774c3833aef324a654010f65bc2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835717, 880027, 906964 Reviewed-on: https://chromium-review.googlesource.com/c/1344257Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#609732}
-
Hiroshige Hayashizaki authored
This reverts commit ec589a5c. Reason for revert: crbug.com/906964 Original change's description: > Add referrer-policy module worker tests > > This CL adds WPT tests for referrer policy applied to > module worker top-level script fetch. > > The only manual changes are > - referrer-policy/generic/common.js > - referrer-policy/generic/referrer-policy-test-case.js > - referrer-policy/spec.src.json > and all other modifications are made by > referrer-policy/generic/tools/generate.py. > > Bug: 880027 > Change-Id: Ib1f9136161e8efacf317fb9b7e9ba0651a103c41 > Reviewed-on: https://chromium-review.googlesource.com/c/1330906 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609589} TBR=hiroshige@chromium.org,nhiroki@chromium.org,jochen@chromium.org Change-Id: I0931159c0494b981a1d6b07232af55b20f68f559 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880027, 906964 Reviewed-on: https://chromium-review.googlesource.com/c/1344213Reviewed-by:
-
Tommy Martino authored
This CL introduces the frontend changes for an upcoming new row type in the Autofill dropdown footer. Specifically, it: * Adds a new frontend ID type. * Checks against this frontend ID to the child view creation loop. * Extracts the logic for choosing the layout type into a virtual method, replacing the anonymous helper and the optional override parameter used by the Footer rows to modify the layout type. * Uses this new method to set the layout type in this new row type. * Adds a frontend_id() convenience method to ItemView. For more details see (Googlers only): https://docs.google.com/document/d/18oV-_0QfoWM7rgp-suzDn4WspFNHRPKxI-4epHDQZIg/edit?usp=sharing Bug: 905052 Change-Id: I370b3dc86a4fd7abc7dffa606acd2bd68213c4ba Reviewed-on: https://chromium-review.googlesource.com/c/1334415 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609730}
-
Yaron Friedman authored
As part of abuse mitigation, we'll no longer perform inline app installs overlaid on top of chrome. This change simplifies the app banner machinery greatly as we're now just intenting out to Play and no longer need support for dynamism in the UI. BUG=904566 Change-Id: I1ca74b1d8602f5e1911c1e75ec62e5a81e776beb Reviewed-on: https://chromium-review.googlesource.com/c/1338337 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#609729}
-
Varun Khaneja authored
crash/5186130e462b3265 suggests that the crashes reported in the linked bugs are happening when result_status != RESULT_STATUS_SUCCESS. This can be due to time out or internal error. Adding CHECKs for both of those conditions explicitly to understand what's causing that. Bug: 893110,889972 Change-Id: I51598b9642a09b31ad700bc83829636d2787fccd Reviewed-on: https://chromium-review.googlesource.com/c/1343521Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609728}
-
Sigurdur Asgeirsson authored
This is a reland of 15fef9cc Original change's description: > RC: Set Frame->Process association at RenderFrameHost creation. > > At present this is only done at navigation time, which can leave frames > disconnected from their hosting process. > > Bug: 901828 > Change-Id: I611eafebe5e7e54c046def38bbaf5b348dedfcb9 > Reviewed-on: https://chromium-review.googlesource.com/c/1318405 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608994} TBR=wfh@chromium.org,jochen@chromium.org Bug: 901828 Change-Id: I7809f666e7cccba865d2220f9409936b727d1556 Reviewed-on: https://chromium-review.googlesource.com/c/1342699 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#609727}
-
Gabriel Charette authored
TBR=oysteine@chromium.org Bug: 899897 Change-Id: Iaa1a9fbb2ae0d5122bfacb82a21f47e194221197 Reviewed-on: https://chromium-review.googlesource.com/c/1343177 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#609726}
-
Jan Lamecki authored
BTW This bug could be caught much earlier. We should consider enabling static code analysis, see https://checkerframework.org/. Test: passes static code analysis in Android Studio. Bug: internal b/119660059. Change-Id: Ia6d9a4fa5118e417fa01c667b8b0ebca2e2cbc38 Reviewed-on: https://chromium-review.googlesource.com/c/1343112Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Jan Lamecki <jachor@google.com> Cr-Commit-Position: refs/heads/master@{#609725}
-
Tommy C. Li authored
We stopped using this experiment some time ago. Bug: 900255 Change-Id: I95bf3e3b065ed7113d9cc172680a5095520f288f Reviewed-on: https://chromium-review.googlesource.com/c/1343279Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Mathias Carlen authored
Before this patch, the spacing between the details and the payment request UI were too large. This patch shows/hides the caroussel when the payment request is shown. It's an intermediate quick fix before we have the new UI architecture and works since the payment request is shown during a script execution, which in turn again means that the caroussel is empty. Showing the carousel reduces the margins of the details view. R=jdemeulenaere@chromium.org, szermatt@google.com Bug: 806868 Change-Id: I17d5d3bf138c8a2f68b24753fde55cada50984fa Reviewed-on: https://chromium-review.googlesource.com/c/1341542 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
Thomas Tangl authored
All sync configuration code is removed from UnifiedConsentService. This means that the UnifiedConsentService does *not* modify the sync state/settings anymore. Bug: 906031 Change-Id: I98fbc466feafc3dfb8474fcacdfdc506acd2ccaf Reviewed-on: https://chromium-review.googlesource.com/c/1340816Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#609722}
-
Colin Blundell authored
This CL introduces AccountsMutator, which will support the mutation of refresh tokens and seeding of account info for the user's Gaia accounts in the IdentityManager world. Its design is conceptually similar to that of PrimaryAccountMutator, although unlike that class it is supported on all platforms. The full design doc is here: https://docs.google.com/document/d/1kLjnxPnBAX0G6W-3u6OF_VguuJc0pXdgCRVR0z3yn-g/edit# This CL does the following: - Introduces the class - Implements an initial API and its unittest - Adds the ability to get the mutator from IdentityManager Followup CLs will complete the API surface. Bug: 887870 Change-Id: Iafc0d365766118ad07eef5038d2257f1630c254e Reviewed-on: https://chromium-review.googlesource.com/c/1333775Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609721}
-
Robert Kroeger authored
This reverts commit a6e3f5c9. Reason for revert: This change is on the blame list for a webgl conformance test failure in WebglConformance_conformance_uniforms_no_over_optimization_on_uniform_array_09 on Windows FYI. Reverting to see if this is so. Original change's description: > Implement WEBGL_video_texture > > This patch implement a WebGL draft extension: WEBGL_video_texture. This extension will bring a new type of texture for WebGL and can > share the video frame to WebGL texture directly. This should reduce on blit operation and should have performance improvement for > uploading video to texture. > > Bug: 776222 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Id052010bb726c328b0362c28d2486ce1986cc6e2 > Reviewed-on: https://chromium-review.googlesource.com/c/1235335 > Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609604} TBR=kbr@chromium.org,haraken@chromium.org,mlamouri@chromium.org,sandersd@chromium.org,shaobo.yan@intel.com,foolip@chromium.org,kainino@chromium.org Change-Id: Ia843571180c67a343d6db2c89eac484faf306fb5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776222 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1344251Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#609720}
-
Robert Sesek authored
In blink::LayoutThemeMac, various system color properties are retrieved from NSColor. These system colors are part of the "dynamic system color store", and trying to access them may cause issues with the sandbox. This augments the blink::WebSandboxSuport interface on Mac to look up system colors via a shared memory segment that is populated by the browser. In addition, this centralizes the various Mac implementations of that interface into a single one. System Prefs>General and change the Highlight Color. Upon going back to Chrome, the new highlight color should be visible. Bug: 641509, 36032 Test: Highlight some text on a web page. Then go to Change-Id: I3bc05c08ecab62b1fc68442d3edd93ec7edb8590 Reviewed-on: https://chromium-review.googlesource.com/c/1331133Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#609719}
-
Stepan Khapugin authored
Records user actions when one of the shortcuts is pressed. Records time the user spent with the popup open. Bug: none Change-Id: Icbc76437d0a6cc12ee040c393fa1b1ad61c86e9b Reviewed-on: https://chromium-review.googlesource.com/c/1337345 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#609718}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/655a9bc2..8f1238bc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id43771a1fb6e4b1370f3252fa58be8d894f8cc2f Reviewed-on: https://chromium-review.googlesource.com/c/1343573 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609717}
-
Sébastien Séguin-Gagnon authored
This will make it consistent with the Upstream prompt. Bug: 906560 Change-Id: I86a1753fc0ac8e4dfb6ef2a4d6c5efd282d5dd16 Reviewed-on: https://chromium-review.googlesource.com/c/1343070Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#609716}
-
Mikel Astiz authored
The legacy (pre-USS) implementation of session sync was the only remaining user of this field and has been deleted recently, so let's just remove the now unused API. This is convenient for pseudo-USS (SyncableServiceBasedBridge) because there is no need for additional plumbing to propagate this information through (it wasn't actually properly populated prior to this patch). Bug: 895455 Change-Id: I02a577978b5fd7a84ced4775cd200d0210928985 Reviewed-on: https://chromium-review.googlesource.com/c/1343003 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609715}
-
Mike Klein authored
Guard for https://skia-review.googlesource.com/c/skia/+/171908 TBR=fmalita@chromium.org Change-Id: I368fa8f6539b9072a0ae2b75e72040c5d2f68130 Reviewed-on: https://chromium-review.googlesource.com/c/1343009Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#609714}
-
Geoff Lang authored
ANGLE now exposes this extension under the same conditions as Chrome: on top of a native ES driver. BUG=angleproject:1552 Change-Id: I6552e51bccd5ece43b7405b26d63127283a90c46 Reviewed-on: https://chromium-review.googlesource.com/c/1342497Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609713}
-
gogerald authored
Bug: 806868 Change-Id: Ia2d3ab25ab95645db5215a2c6d8c4b0f1d9d3a1c Reviewed-on: https://chromium-review.googlesource.com/c/1343561Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#609712}
-
David 'Digit' Turner authored
This is mostly to get the bugfix from [1], which will allow the removal of 2 workarounds in our build system. See [2] [1] https://github.com/google/bundletool/issues/32 [2] https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/719231 BUG=891931 R=agrieve@chromium.org, ntfschr@chromium.org Change-Id: Ibc6f406ce3b2d920b19435e392b51181308e24a2 Reviewed-on: https://chromium-review.googlesource.com/c/1343107Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#609711}
-
Vaclav Brozek authored
The test was meant to check what happens if a password field has a CVC-like name. Instead, it tested what happens if a text field has this name. This CL fixes that mistake. The test thankfully still passes. This is a yak-shaving for adding the fallback pass, hence the below bug association. Bug: 906584 Change-Id: I9228c0252c97397fb5486e8a62c4cfb6a3f14cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1343269Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609710}
-
Koji Ishii authored
This patch fixes NGLineBreaker not to freeze when all of the following conditions met: * 'word-wrap: break-word' is set. * 'whitespace: pre-wrap' is set. * Two or more adjacent preserved spaces are split to two or more elements, and is the last space to fit in the line. e.g., <div style="whitespace: pre-wrap; word-break: break-word"> <span>xxx <span> yyyy </div> and "yyyy" does not fit. We need to handle trailing spaces not only when spaces follow a break opportunity but also spaces are after spaces. Bug: 903909 Change-Id: Ie4346a670ec22d35cca3a290b9a423161537e4e8 Reviewed-on: https://chromium-review.googlesource.com/c/1343466Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609709}
-
Tien Mai authored
Pass the hosted e-mail domain to the gaia sign in page through GCPW. Bug: 887444 Change-Id: Ie77034dadc3873de35bbf32a30d20364877ec328 Reviewed-on: https://chromium-review.googlesource.com/c/1333869Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#609708}
-
Anand K. Mistry authored
BUG=None Change-Id: If9ca23541732251aa800c0335c8b094235e631a7 Reviewed-on: https://chromium-review.googlesource.com/c/1343458 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#609707}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=csharp@chromium.org Bug: 903957 Change-Id: I5ff84cb3c4169e19e04d59e682916eb6632a848a Reviewed-on: https://chromium-review.googlesource.com/c/1338127Reviewed-by:proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#609706}
-
Bill Budge authored
- Adds kWasmCodeCache to blink::features. - Checks if enabled before creating the cache in the browser. - Checks if enabled before fetching from cache in renderer. This is patterned after the Javascript IsolatedCodeCache feature. Bug: chromium:719172 Change-Id: I1ffea5d8029b2b550c45e3ba25821889c7c2183c Reviewed-on: https://chromium-review.googlesource.com/c/1341071 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#609705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/316e4119ed88..afe4ec5b3170 Created with: gclient setdep -r src-internal@afe4ec5b3170 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I27157ee885e507b522fb506194f78c2841d242f6 Reviewed-on: https://chromium-review.googlesource.com/c/1342691Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609704}
-
