GitLab

BUG=398169

Review URL: https://codereview.chromium.org/428883013

Cr-Commit-Position: refs/heads/master@{#288363}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288363 0039d316-1c4b-4281-b951-d872f2087c98

Fixes issues with EWDTAH lifetime. Now EWDTAH lives as long as there is a scoped_refptr referencing it or the worker is alive.

Split off https://codereview.chromium.org/349033009/

BUG=389454

Review URL: https://codereview.chromium.org/405603002

Cr-Commit-Position: refs/heads/master@{#288362}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288362 0039d316-1c4b-4281-b951-d872f2087c98

Define charging attribute in terms of whether the device is
plugged in or not. Previously it was defined in terms of
BATTERY_STATUS_DISCHARGING property but some phones report
BATTERY_STATUS_NOT_CHARGING when the battery is not charging.
Also modified the tests accordingly.

TEST=http://jsbin.com/battery-status-test
BUG=360068

Review URL: https://codereview.chromium.org/451773002

Cr-Commit-Position: refs/heads/master@{#288361}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288361 0039d316-1c4b-4281-b951-d872f2087c98

Then I can convert recipes back to --analyzer and finally remove
--analyzer2. Oy!

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/447183006

Cr-Commit-Position: refs/heads/master@{#288360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288360 0039d316-1c4b-4281-b951-d872f2087c98

Intent.EXTRA_ALLOW_MULTIPLE is only available in JellyBean MR2 and
higher. So added missing check for same. To avoid warning at build
added @TargetApi annotation.

BUG=401333

Review URL: https://codereview.chromium.org/453963002

Cr-Commit-Position: refs/heads/master@{#288358}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288358 0039d316-1c4b-4281-b951-d872f2087c98

Response headers that are not valid UTF-8 can't be stored in a
base::StringValue, which is always a UTF-8 string, so escape any non-ASCII
values to be safe. This prevents a DCHECK when dev tools' network request
inspector is open and we receive these headers.

BUG=299880

Review URL: https://codereview.chromium.org/453483002

Cr-Commit-Position: refs/heads/master@{#288357}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288357 0039d316-1c4b-4281-b951-d872f2087c98

> Adding the VerifyModule function (and helpers) to safe browsing.
> 
> This function allows us to compare a module in memory with 
> its original on disk, and identify any differences (after 
> accounting for relocations).  The state of the module 
> (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is 
> returned along with a list of the possibly modified exported 
> functions of the module.
> 
> 
> BUG=401854
> 
> Review URL: https://codereview.chromium.org/406043003

TBR=krstnmnlsn@chromium.org

Review URL: https://codereview.chromium.org/458483003

Cr-Commit-Position: refs/heads/master@{#288356}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/454883002

Cr-Commit-Position: refs/heads/master@{#288354}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288354 0039d316-1c4b-4281-b951-d872f2087c98

When refactoring code it is easy to accidentally disregard the output of
base::StringPrintf. The code will still look superficially correct, and may even
pass code review (as happened with https://codereview.chromium.org/436133002/ ).

This type of bug can be prevented by annotating StringPrintf with
WARN_UNUSED_RESULT. Despite the name, this causes a compile error in our build
configuration (except on Windows, where it is ignored). This should ensure that
such errors are caught by the CQ if not sooner.

TEST=build all; base_unittests
BUG=400663

Review URL: https://codereview.chromium.org/440013003

Cr-Commit-Position: refs/heads/master@{#288353}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288353 0039d316-1c4b-4281-b951-d872f2087c98

* Update chrome://settings Privacy section to change int kNetworkPredictionOptions
instead of bool kNetworkPredictionEnabled.
* Introduce code to migrate user setting (and only user setting).
* Per UI review, keep UI unchanged.
* Note that policy handler for these two preferences has already landed, see https://crrev.com/431493003.

BUG=334602

Review URL: https://codereview.chromium.org/421653006

Cr-Commit-Position: refs/heads/master@{#288352}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401906

Review URL: https://codereview.chromium.org/452063002

Cr-Commit-Position: refs/heads/master@{#288351}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288351 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288350}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288350 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/acc125860053d0a65bc7b67dd1b886aa7932d292..b511042bb07a6a289b0d1146cb57f6e8b80580d6

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bungeman@google.com
BUG=

Review URL: https://codereview.chromium.org/456703002

Cr-Commit-Position: refs/heads/master@{#288349}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288349 0039d316-1c4b-4281-b951-d872f2087c98

The tests were crashing on the windows bots (e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%283%29/builds/29877/steps/unit_tests/logs/VerifyModuleModified):

SafeBrowsingModuleVerifierWinTest.VerifyModuleModified (run #1):
[ RUN      ] SafeBrowsingModuleVerifierWinTest.VerifyModuleModified
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\module_integrity_verifier_win_unittest.cc(43): error: Value of: mem_dll_handle_.is_valid()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\module_integrity_verifier_win_unittest.cc(48): error: Expected: (static_cast\u003CHMODULE>(0)) != (*mem_handle), actual: NULL vs NULL
Backtrace:
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x0278AD98+6714120]
	(No symbol) [0x01761388]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02493F49+3605689]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024940CE+3606078]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024946AE+3607582]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024943E9+3606873]
	IsSandboxedProcess [0x0465F878+12316280]
	IsSandboxedProcess [0x0465F5AA+12315562]
	IsSandboxedProcess [0x04683A62+12464226]
	IsSandboxedProcess [0x045801B7+11401143]
	BaseThreadInitThunk [0x74C0338A+18]
	RtlInitializeExceptionChain [0x77299F72+99]
	RtlInitializeExceptionChain [0x77299F45+54]

> Adding the VerifyModule function (and helpers) to safe browsing.
> 
> This function allows us to compare a module in memory with 
> its original on disk, and identify any differences (after 
> accounting for relocations).  The state of the module 
> (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is 
> returned along with a list of the possibly modified exported 
> functions of the module.
> 
> 
> BUG=401854
> 
> Review URL: https://codereview.chromium.org/406043003

TBR=krstnmnlsn@chromium.org

Review URL: https://codereview.chromium.org/452133002

Cr-Commit-Position: refs/heads/master@{#288348}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288348 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise it's possible to end up crashing when calling a null function
pointer, if a framebuffer does not have a color buffer attached.

This bug applies to at least some GLES3 platforms, where DrawBuffers
function is not bound (which is reasonable, since core version of the
function behaves subtly differently than DrawBuffersEXT in relation to
GLSL ES 1.0 shaders, if the EXT_draw_buffers extension is missing). Also
possibly GLES2 platforms which implement OES_depth_texture but not
EXT_draw_buffers.

BUG=401645
TEST=gpu_unittests, WebGL conformance tests

Review URL: https://codereview.chromium.org/448223002

Cr-Commit-Position: refs/heads/master@{#288347}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288347 0039d316-1c4b-4281-b951-d872f2087c98

More menus will be added in separate CL.

BUG=380438
TEST=None
R=mukai@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/448063005

Cr-Commit-Position: refs/heads/master@{#288346}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288346 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352290

Review URL: https://codereview.chromium.org/447193004

Cr-Commit-Position: refs/heads/master@{#288345}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288345 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288344}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288344 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179743:179816&mode=html

TBR=zerny@chromium.org

Review URL: https://codereview.chromium.org/455733002

Cr-Commit-Position: refs/heads/master@{#288343}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288343 0039d316-1c4b-4281-b951-d872f2087c98

It is trying to load some extension code that it's not available and thus breaking android.

BUG=401921

TBR=sky
NOTRY=true

ran all the linux and android bots but didn't want to wait for the windows ones to finish since it does not affect them and we need to fix the build

Review URL: https://codereview.chromium.org/447403003

Cr-Commit-Position: refs/heads/master@{#288341}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288341 0039d316-1c4b-4281-b951-d872f2087c98

TBR=phajdan.jr@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/454893002

Cr-Commit-Position: refs/heads/master@{#288339}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288339 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401526
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/442263004

Cr-Commit-Position: refs/heads/master@{#288335}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288335 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tmdiep
BUG=401028
NOTRY=true

Review URL: https://codereview.chromium.org/452853002

Cr-Commit-Position: refs/heads/master@{#288333}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288333 0039d316-1c4b-4281-b951-d872f2087c98

Currently only implements the Pending item view.

BUG=328847

Review URL: https://codereview.chromium.org/438893002

Cr-Commit-Position: refs/heads/master@{#288332}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288332 0039d316-1c4b-4281-b951-d872f2087c98

A fix to QUIC's test only SendAlgorithmSimulator to ensure it treats
lost packets correctly.

Merge internal change: 72754445
https://codereview.chromium.org/450043002/


Check return value of GetStringPiece for (optional) kCCRT/kCCS in
QuicCryptoServerConfig.

Merge internal change: 72727018
https://codereview.chromium.org/453693002/


Store client cert hashes as strings instead of StringPieces.

Avoids use-after-free (detected by ASAN) when the CHLO callback deletes
the CHLO request, and subsequently we try to access the stored
StringPieces.

Bug introduced in CL: https://codereview.chromium.org/449273002/

Merge internal change: 72724874
https://codereview.chromium.org/453663002/


Deprecate rolled out flag: FLAGS_quic_allow_port_migration.

Merge internal change: 72668120
https://codereview.chromium.org/451903002/


Along with sending the SCUP message, this CL includes small fixes which
allow messages to be sent on the crypto stream after handshake has
completed. This includes disabling HANDSHAKE_MODE in the sent packet
manager after the handshake is confirmed, and stopping processing of
handshake packets once we switch to forward secure and can no longer
decrypt them in crypto_test_utils.

Without a version bump, out of date clients will tear down the
connection if they get a SCUP message from the server.

QUIC_VERSION_22. Send a new source-address token when crypto handshake
completes.

Merge internal change: 72652054
https://codereview.chromium.org/449273002/


Trigger internal QUIC "trace graph" trace dumping also in cases where
connection termination is initiated by the server. Protected by existing
debug flag.

This CL adds a new OnConnectionClosed method to the
ConnectionDebugVisitor interface, which is called when the connection is
closed irrespective of how the connection is closed.

Merge internal change: 72571464
https://codereview.chromium.org/454563002/


Close a QUIC connection if there are too many unfinished streams being
tracked in the locally closed map. Protected behind
FLAGS_close_quic_connection_unfinished_streams (defaults to false).

Merge internal change: 72561976
https://codereview.chromium.org/448973002/


Remove unused version argument from QuicFramerTest's
GetMinStreamFrameSize.

Merge internal change: 72559549
https://codereview.chromium.org/447103002/


Fix typo in comment in QuicFramer. creation_time_ is the creation time
of the framer, not the frames.

Comment only change.

Merge internal change: 72558804
https://codereview.chromium.org/444323002/


Deprecate rolled out FLAGS_enable_quic_connection_flow_control_2.

Merge internal change: 72345333
https://codereview.chromium.org/444313002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/448313003

Cr-Commit-Position: refs/heads/master@{#288331}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288331 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
 This is breaking chrome ToT downstream  and the change quie complex so
    I don't feel qualified to try to fix it in place.
    
    The failure we hit is
     F/chromium( 2961): [FATAL:system_ui_resource_manager_impl.cc(35)] Check failed: !bitmap.empty().
    
    See an example of a failed run in
    https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/32007
    
    (but just trying to boot clank with this patch will trigger it)


Original issue's description:
> [Android] Use UIResource for overscroll glow
> 
> Introduce a SystemUIResourceManager class for loading and providing access to
> shared UIResourceId's.  Wire this class to the existing OverscrollGlow effect,
> using the shared id's with a UIResourceLayer for both glow and edge layers.
> 
> This patch is a subset of powei@'s original SystemUIResource patch found at
> https://codereview.chromium.org/377013002/.
> 
> BUG=326326
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288095

TBR=aelias@chromium.org,powei@chromium.org,yfriedman@chromium.org,sky@chromium.org,jdduke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=326326

Review URL: https://codereview.chromium.org/454863003

Cr-Commit-Position: refs/heads/master@{#288330}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288330 0039d316-1c4b-4281-b951-d872f2087c98

This is done by enabling "accurate mode" in tests and enabling the tests
to run on those platforms.

BUG=400158

Review URL: https://codereview.chromium.org/449833002

Cr-Commit-Position: refs/heads/master@{#288329}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288329 0039d316-1c4b-4281-b951-d872f2087c98

The root cause here is that it was assumed that creation of a
CompositingIOSurfaceMac and CompositingIOSurfaceContext
cannot not fail when, in fact, it can. This resulted in a NULL
reference later on.

Fix part of this by making CompositingIOSurfaceLayer's init function
fail if the CompositingIOSurfaceContext fails.

Fix the remaining part of this by removing the NULL references from
BrowserCompositorViewMacInternal::GotAcceleratedIOSurfaceFrame,
and make the function call AcceleratedLayerHitError if any errors are
encountered, which will cause the layer to re-attempt the frame with
a new context.

Also, split AcceleratedLayerDidDrawFrame into two functions,
AcceleratedLayerDidDrawFrame and AcceleratedLayerHitError, rather
than parameterizing success using a bool, since that naming was
deceptive.

BUG=401630

Review URL: https://codereview.chromium.org/447113004

Cr-Commit-Position: refs/heads/master@{#288328}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288328 0039d316-1c4b-4281-b951-d872f2087c98

This is a fairly straightforward patch which wires up the Blink platform
API over to the network stack.

BUG=378566

Review URL: https://codereview.chromium.org/430193002

Cr-Commit-Position: refs/heads/master@{#288327}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401890

Review URL: https://codereview.chromium.org/449383002

Cr-Commit-Position: refs/heads/master@{#288326}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288326 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a checkmark which is at the left of the currenly playing device on the cast menu.

BUG=none
TEST=manually tested

Review URL: https://codereview.chromium.org/456653002

Cr-Commit-Position: refs/heads/master@{#288325}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335644
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/446693005

Cr-Commit-Position: refs/heads/master@{#288324}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288324 0039d316-1c4b-4281-b951-d872f2087c98

This is a refactoring patch. Before this patch, ServiceWorkerRegisterJob is
responsible for updating ServiceWorkerRegistration object and document's
version attributes (ie. '.installing' etc) via ServiceWorkerProviderHost.

This change makes the provider host implement Registration::Listener.
Listers are notified when the registration is updated, so the register
job no longer has to manage the version attributes.


BUG=396400
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py --debug http/tests/serviceworker

Review URL: https://codereview.chromium.org/417043006

Cr-Commit-Position: refs/heads/master@{#288323}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340933
TEST=unit_tests

Review URL: https://codereview.chromium.org/453843002

Cr-Commit-Position: refs/heads/master@{#288322}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400892
TEST=manually tested

Review URL: https://codereview.chromium.org/450913002

Cr-Commit-Position: refs/heads/master@{#288321}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288321 0039d316-1c4b-4281-b951-d872f2087c98

Previously the aspect ratio is applied at the beginning of dragging after
pressing the buttons.

The CL also temporarily removes dimmable class from the container of aspect
 buttons to prevent the aspect buttons from being dimmed until a user starts
 dragging.

BUG=401312
TEST=manually

Review URL: https://codereview.chromium.org/454743002

Cr-Commit-Position: refs/heads/master@{#288320}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288320 0039d316-1c4b-4281-b951-d872f2087c98

This function allows us to compare a module in memory with 
its original on disk, and identify any differences (after 
accounting for relocations).  The state of the module 
(MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is 
returned along with a list of the possibly modified exported 
functions of the module.


BUG=401854

Review URL: https://codereview.chromium.org/406043003

Cr-Commit-Position: refs/heads/master@{#288319}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288319 0039d316-1c4b-4281-b951-d872f2087c98

Browser Test for Autocomplete's confusion about direction if inline style and inherited dir attribute are mixed.

This patch provides browser_tests for the corresponding blink patch:
https://codereview.chromium.org/419023007/ which deals with the Bug:Autocomplete
confused about direction if inline style and inherited dir attribute is mixed.

BUG=397831

Review URL: https://codereview.chromium.org/446843002

Cr-Commit-Position: refs/heads/master@{#288318}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315439
TEST=manually

Review URL: https://codereview.chromium.org/442393003

Cr-Commit-Position: refs/heads/master@{#288317}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288317 0039d316-1c4b-4281-b951-d872f2087c98

All browser tests of File.app were disabled unintentionally by crrev.com/444223003
This CL enables those tests and disables OpenVideoFile and OpenAudioFile individually.

BUG=400892
TEST=run browser_tests

Review URL: https://codereview.chromium.org/445933006

Cr-Commit-Position: refs/heads/master@{#288316}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288316 0039d316-1c4b-4281-b951-d872f2087c98