GitLab

This reverts commit 6f5d66e1.

Reason for revert: Test is failing on Windows 7 GPU bots.

Original change's description:
> Add viz_screenshot_sync_tests.
> 
> Add a new GPU test target that runs screenshot_sync a second time with
> --enable-features=VizDisplayCompositor. This test will verify that GPU
> compositing is working for OOP-D. The test only runs on Windows and
> Linux bots.
> 
> Bug: 812385
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I56de0d01922d1c08521f3fd5aed4f64c148374e3
> Reviewed-on: https://chromium-review.googlesource.com/1028613
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554529}

TBR=kbr@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 812385
Change-Id: Icf9c2d398312bebfd7ca5b7d47e2b0876716dd70
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1034392Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554682}

This is required for bookmarks to identify permanent folders such as
bookmarks bar.

Bug: 516866
Change-Id: If8d763479045c8bb9b9a8368382201bfff1dbe36
Reviewed-on: https://chromium-review.googlesource.com/1032788
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554681}

Tbr: slangley, yamaguchi
Bug: 833834
Change-Id: I0b1e1ad58e66e5822449e1d03b8ff7bdd9502df9
Reviewed-on: https://chromium-review.googlesource.com/1034413Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554680}

Move JSON conversion helper definitions into their class so we declare
and define them once only (less to read). Document class members.

Bug: 833834
Change-Id: Ic60e833271bce822795f63e34956992a51ad7f74
Reviewed-on: https://chromium-review.googlesource.com/1034412Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554679}

With [1], user-modify is updated as part of style recalc for the inner
editor element, and the inner editor element recalc is triggered from
LayoutTextControl::StyleDidChange().

This removes the last mutable style access from LayoutTextControl.

[1] https://crrev.com/4ef836ad2e67ce25e263514bcda94f808bfb02d6

Bug: 813068
Change-Id: I923e0081b2bb2a796b512e23a027550c35b045e4
Reviewed-on: https://chromium-review.googlesource.com/1034052Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554678}

In a previous patch, we created a dedicated function for reloading the
VK without recreating the KeyboardController. This patch replaces all
the remaining calls of CreateKeyboard that reload the VK to
ReloadKeyboard.

Note that some calls to CreateKeyboard are to enable the keyboard,
so they will be replaced with a different function later.

Bug: 731537
Change-Id: I2cf964d825433fb3fbeb19231e5c5757213a604f
Reviewed-on: https://chromium-review.googlesource.com/1031970Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554677}

Bug: 833834
Change-Id: I261665a70256ba03d838dddfe546dedcfd397865
Reviewed-on: https://chromium-review.googlesource.com/1034044Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554676}

Make helper routine GetTestFilePath internal to class TestVolume and its
derived classes, which are its only callers.

Also change its name to GetTestDataFilePath() since the file created, or
read, must reside in file manager's test data directory.

Bug: 833834
Change-Id: I49bc321916c2a2a0fabaa1570c6a47ea890d9568
Reviewed-on: https://chromium-review.googlesource.com/1034047Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554675}

Also change the DownloadsTestVolume Mount() code to match the way other
test volumes Mount().

No change in behavior, no new tests.

Bug: 833834
Change-Id: Ifc31a5d2157eb605e4d9763c40bde2b0ff367bb7
Reviewed-on: https://chromium-review.googlesource.com/1034045Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554674}

Disables testLongPressGestureFollowedByTapDoesntSelect on versions
before Android L because those tend to be flaky.  This was the case
until a recent CL speculatively enabled this test on all platforms.

TBR=twellington@chromium.org

BUG=837998

Change-Id: I8fe049da497f514bb2c390493fa716992258e23e
Reviewed-on: https://chromium-review.googlesource.com/1034285Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554673}

We previously disabled ExecutionContext.p.evaluate() from running
with 'timeout' option while paused. Now that it is supported by
inspector-protocol, we can allow these evaluations to run.

Bug: 810176
Change-Id: Icf81da3d533c719a347f49b3ccd63106e30412c7
Reviewed-on: https://chromium-review.googlesource.com/1033995Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554672}

Using wpt-import in Chromium 51556bb7.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16442

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

TBR=qyearsley

No-Export: true
Change-Id: I6bb2420dc1b1ce974115c24450c9a65cb506b2aa
Reviewed-on: https://chromium-review.googlesource.com/1034082
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554671}

This CL addresses comments raised on https://crrev.com/c/1013580 after
it landed:

* Changing name and the declaration comment of a FormFieldData method
  to reflect its effect on textarea fields.
* Adding some std::vector::reserve calls to avoid extra heap
  allocations when calling push_back in a loop with known maximal
  iteration count.

Bug: 807623
Change-Id: Ibc9fefbf29676563bbc317e1fd8a0386d245bdd2
Reviewed-on: https://chromium-review.googlesource.com/1032791
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554670}

https://chromium.googlesource.com/chromium/deps/mesa.git/+log/803b11320967..9d9b0710470f

$ git log 803b11320..9d9b07104 --date=short --no-merges --format='%ad %ae %s'
2018-04-26 tzik Regenerate chromium_gensrc with newer flex and bison

Created with:
  roll-dep src/third_party/mesa/src
BUG=752720

Change-Id: I29ff738aab99fb36f8a89ea0b3732ad5cba29ec0
Reviewed-on: https://chromium-review.googlesource.com/1032132
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554669}

https://skia.googlesource.com/skia.git/+log/cccafe8cfd23..efb4d08dd43c

$ git log cccafe8cf..efb4d08dd --date=short --no-merges --format='%ad %ae %s'
2018-04-29 skia-recreate-skps Update SKP version

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ib82fbaf0670bc304b9440805d71ad47cac79a063
Reviewed-on: https://chromium-review.googlesource.com/1034280Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554668}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ic833a4571a1a43df0ca24a32c3bbaaa0f1560f59
Reviewed-on: https://chromium-review.googlesource.com/1034278
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554667}

Previously this was only partially done due to issue 634270. Now that
issue has been fixed and we can mark more EME APIs with SecureContext.

In the current EME spec, there are 9 APIs marked with SecureContext.
This CL makes sure all of them are marked with SecureContext in Blink
IDL.

Also mark getStatusForPolicy() (not in EME spec yet) with SecureContext.

Bug: 692289
Test: Manually tested and verified no MediaKey* exposed in http://
Change-Id: If976d30b3371c4be2bcd33ab61268f21145232a1
Reviewed-on: https://chromium-review.googlesource.com/1030760Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554666}

crosreview.com/950683 introduces this enum.

BUG=b:35648315

Change-Id: I4f9a7ac56270d20ca60eb08d27a9ae30ff75cf2f
Reviewed-on: https://chromium-review.googlesource.com/1027127
Commit-Queue: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554665}

CL https://chromium-review.googlesource.com/1028836 adds patch
validation to ensure equivalence blocks for element pairs would not
span outside the regions for respective elements. The check assumes that
equivalences use absolute offsets for entire "old" or "new" archives.
This was mistaken (and missed in review), since equivalences in fact use
"local" offsets relative to the start of each element. As a result,
ensemble patching for Zucchini-apply would mistakenly trigger the check,
leading to patch failure.

This CL fixes the check. This removes the need for RangeIsInRegion()
(now removed), since RangeIsBounded() suffices.

Bug: 837096
TBR=grt@chromium.org

Change-Id: I2b1e575c4a44f112adebaf1487a41f12cf23f570
Reviewed-on: https://chromium-review.googlesource.com/1034274Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554664}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Id5ae0d575523bc1deaca09d20088aceefbed3a39
Reviewed-on: https://chromium-review.googlesource.com/1034218Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554663}

Bug: 599609, 832680
Change-Id: Ib8db17ca291203b6b676a6c74e16db20c14bf3d6
Reviewed-on: https://chromium-review.googlesource.com/1012934
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554662}

This bug occurs because of Clank's "resize main frame after layout"
behavior. In a nutshell: we want users to be able to zoom out to that
the entire width of the content fits on screen. Because we can't zoom
out further than the layout viewport (i.e. the main FrameView), after
a layout occurs we resize the main FrameView to match the content width.
This leaves us in an interesting situation - the viewport scroller is
actually larger than the initial containing block (i.e. the LayoutView
size). This situation cannot occur on desktop and generally doesn't
occur on well-behaved mobile sites (sites that don't allow zoom out).

The bug was occuring because the intersection observer used the
LayoutView/ICB size for the root element. This is incorrect in the
situation described above. We should really use the ViewRect which is
the scroller bounds.

Bug: 836408
Change-Id: I96029cdb11a6a16353d5b8b628b0182c13926a8d
Reviewed-on: https://chromium-review.googlesource.com/1031118Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554661}

Link to embedded options was missing "#". This adds it in.

Bug: none
Change-Id: I357816ddc23bc977655d5990483f7302ecbfa8c1
Reviewed-on: https://chromium-review.googlesource.com/1033825Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554660}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae26814f310e..f578e9249f18

$ git log ae26814f3..f578e9249 --date=short --no-merges --format='%ad %ae %s'
2018-04-28 dgarrett Revert "cbuildbot: Use previous build state for chroot reuse"

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:1014949,chromium:829665


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I969623ebc1f77fd01e3f65def944d980d6831199
Reviewed-on: https://chromium-review.googlesource.com/1034293
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554659}

https://skia.googlesource.com/skia.git/+log/5b6d4a354670..cccafe8cfd23

$ git log 5b6d4a354..cccafe8cf --date=short --no-merges --format='%ad %ae %s'
2018-04-28 bsalomon Rewrite SkVertices specified with triangle fans as indexed triangles

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: Ie92f92ddedc72c7083c3fd04187016a09eec2e3c
Reviewed-on: https://chromium-review.googlesource.com/1034211Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554658}

TBR=dmazzoni@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1f9cc5a5cacd43ce8ddc1913b721e0a1c80c0d4b
Reviewed-on: https://chromium-review.googlesource.com/1025216
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554657}

This CL merges the WorkerPerformance and Performance IDLs. The Exposed=Window
addition to |navigation| and |timing| cause the paths to no longer exist when
the frame is removed (as opposed to exist with trivial 0 values).

Bug: 707392
Change-Id: I1b8bcfc0731a2075254a727df3f38f5ce3aa5df9
Reviewed-on: https://chromium-review.googlesource.com/1026451
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554656}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/117b08a5550a..ae26814f310e

$ git log 117b08a55..ae26814f3 --date=short --no-merges --format='%ad %ae %s'
2018-04-27 manojgupta cros_setup_toolchain: Fix clang++ invocation.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:837889


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ia57694a643aa8feeae0f67b4dc009cb61c072729
Reviewed-on: https://chromium-review.googlesource.com/1034209
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554655}

Using wpt-import in Chromium 4eec0e90.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16365

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley

No-Export: true
Change-Id: I523cccff8e8f48c2482ff75415fede62e964abdc
Reviewed-on: https://chromium-review.googlesource.com/1034079
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554654}

This reverts commit 70fc0b01.

Reason for revert: Caused bugs found by clusterfuzz

Original change's description:
> [CI] Make paint property nodes non-ref-counted
> 
> Now all paint property nodes are owned by ObjectPaintProperties
> (and LocalFrameView temporarily before removing non-RLS mode).
> Others just use raw pointers or references.
> 
> Bug: 833496
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I2d544fe153bb94698623248748df63c8aa2081ae
> Reviewed-on: https://chromium-review.googlesource.com/1031101
> Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554626}

TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org

Change-Id: I02bb50d6744cb81a797246a0116b677e80a3c69f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 833496,837932,837943
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1034292Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554653}

Test: Manual
Bug: 837818
Change-Id: If9ac2878e9d3e302ece873ef32a81dd6a52214ca
Reviewed-on: https://chromium-review.googlesource.com/1033963Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554652}

Adds ability to drag the overview item up or fling the item up to close
the window. A later cl will add the fling animation. The feature is
hidden behind a newly added flag.

Test: added test coverage
Bug: 828646
Change-Id: I8e66fb3ed2a642deb6a833f30e9b7674d56b0fee
Reviewed-on: https://chromium-review.googlesource.com/1014490Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554651}

https://skia.googlesource.com/skia.git/+log/0f97bac4a53f..5b6d4a354670

$ git log 0f97bac4a..5b6d4a354 --date=short --no-merges --format='%ad %ae %s'
2018-04-28 liyuqian Call SkMatrix::getType to make it thread safe

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: Ibf9c83baa174a78a6f7eeb49fc2dcebf19d4e2a0
Reviewed-on: https://chromium-review.googlesource.com/1034204
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554650}

This CL is a refactor with no intended behavior change.

Most callers have already been fixed to accept a unique_ptr. Guest views and
headless are notable exceptions - this CL leaves TODOs to fix them up
afterwards.

This CL also fixes a layering issue in ViewsDelegate, which was incorrectly and
unnecessarily referencing contents/.

Bug: 832879
Change-Id: Ie00387ca6c182390b1d720a60deaebe8d770aa17
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1031314
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554649}

Using wpt-import in Chromium a5935950.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16328

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure

TBR=qyearsley

No-Export: true
Change-Id: If662cf86e2c637a850d089d88513f539e58706b1
Reviewed-on: https://chromium-review.googlesource.com/1034213
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554648}

base::RunLoop::QuitCurrentWhenIdle() can spin the run loop a few times
before it exits, sufficient to allow any chrome.test.SendMessage calls
arriving _after the test PASS or FAIL messages_ to be queued.

Such messages will not be processed once the message processing sees a
PASS or FAIL message, causing a CHECK in the extensions system code at
exit to remind us that unprocessed test.SendMessage's need a reply.

Fix: use modern base::RunLoop/Closure methods. Add |test_complete_| to
record when test PASS or FAIL messages arrive. Add a CHECK stop to the
test.SendMessage reader code to verify they are never received after a
PASS or FAIL message.

Tbr: mtomasz, slangley
Bug: 668680
Change-Id: I09cae80870d0471b214253beb2f05e8914fee0aa
Reviewed-on: https://chromium-review.googlesource.com/1034174Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554647}

This CL adds two histograms:
* Signin.RefreshTokenRevocationRequestProgress tracks the progress of
revocation requests, and can be used to check how many requests do not
complete and why.

* Signin.RefreshTokenRevocationStatus reports the status (including
error details) of token revocation requests after they complete.

TBR=atwilson, ellyjones

Bug: 834720
Change-Id: I9a78bdae4377047e71bd6c27fc0814d8f4a57383
Reviewed-on: https://chromium-review.googlesource.com/1025753Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554646}

This patch fixes ShapeResult::CopyRange to compute more accurate
glyph bounding box.

There were 2 problems before this patch:
1. It always truncated the right edge. This is problematic when
   Copying (0, 1) of ". " in RTL, which resulted in an empty
   result.
2. It assumed no glyph overflow at the edge. This resulted in
   common glyph overflows such as "t" or "m" were cut off.

This patch extracts the logic to compute glyph bounding box from
ComputeGlyphPositions to a new helper class. CopyRange uses the
class to compute the line-left/right most glyph bounding box.

Bug: 636993, 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7d2068566308081727c996e3ac0fe23aae6558d1
Reviewed-on: https://chromium-review.googlesource.com/1023536Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554645}

And use it to clean up registered apps before uninstalling Crostini.

Change-Id: I4331d3ca30f136f0880e9e886cad12e8fe9802ad
Reviewed-on: https://chromium-review.googlesource.com/1032672Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554644}

Current code does not finalize preflight requests correctly when
the preflight request failed without receiving HTTP response headers.

Bug: 803766
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1c91e3ecf76fdb368e3d55256885f52edf6fcbb3
Reviewed-on: https://chromium-review.googlesource.com/1027556
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554643}