GitLab

Implemented web-animations-1 spec changes introduces in [1].

- Update play and pause procedures to initialize start time of scroll
  animations to zero.
- Updated calculate play state procedure to return "running" state for
  animations that has start time resolved.
- Added/modified tests reflecting spec changes.


[1] https://github.com/w3c/csswg-drafts/pull/4842

Bug: 1070637
Change-Id: Ic83995899b2f3f8d8f985f84b8a2b438bbad7c35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150687
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761974}

https://skia.googlesource.com/skia.git/+log/cefc2d9a4582..5fc5c8128ce0

git log cefc2d9a4582..5fc5c8128ce0 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 egdaniel@google.com Add GrD3DPipelineStateBuilder class.
2020-04-23 mtklein@google.com stack-aware codegen?
2020-04-23 mtklein@google.com restore in-place FMAs
2020-04-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps
2020-04-23 jvanverth@google.com Implement GrMtlOpsRenderPass::onClear.
2020-04-23 fmalita@chromium.org [skottie] Initial outer/inner glow

Created with:
  gclient setdep -r src/third_party/skia@5fc5c8128ce0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jcgregorio@google.com
Change-Id: Ic4ebf48ec30532afb660611196f3887bf43495d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163052Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761973}

On Mac, the toolbar can be shown or hidden on full screen. The zoom
bubble changes its anchor position when the toolbar visibility
changes. We can not simply refresh the shown Zoom bubble if its anchor
position changed. So we need to allow Zoom bubble to be closed in that
case. Otherwise, double zoom bubbles may be shown as described in the
bug.

BUG=1072353

Change-Id: I5abc492e81b0e207556d528de3635e85f6bce9d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159315Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761972}

This reverts commit e3d5c44e.

Reason for revert: Flaky failures on multiple bots
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.TabsTest%23testUndo

Original change's description:
> Add tests for undo closure in stack tab switcher
> 
> Bug: 1064445
> Change-Id: I31bf5c42e013868282d1d220d7d871f411331494
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150060
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Reviewed-by: Mei Liang <meiliang@chromium.org>
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#761720}

TBR=yusufo@chromium.org,wychen@chromium.org,meiliang@chromium.org,yuezhanggg@chromium.org

Change-Id: I447c525cdf6da5c69e200f775804fde888e67f9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1064445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163386Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761971}

This CL is needed to land https://crrev.com/c/2160745 on the M83 branch. For more context see that CL.

Bug: 1072432, 1015841
Change-Id: I7284f92d8db2c60fe7209b215b71c26e45770ef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162925Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#761970}

This adds new tests that verify that invalid rules are ignored,
and don't affect other valid rules.

I also rewrote this test file to use utils.js more liberally. It makes
individual tests harder to understand for the uninitiated, but it
scales so much better as the number of test functions increases.

Bug: 973830
Change-Id: Ie19d85042a0475180cc4bbee4ad202ea08adba73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161005
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761969}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e57f0f5a22d..8094fa603805


Created with:
  gclient setdep -r src-internal@8094fa603805

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1067070
Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com
Change-Id: I1f1ecbf7e0407da6d36acf6ca27913d839844a8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163045Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761968}

This didn't have the fixit label initially, so I happened to miss
updating the expiry.

Bug: 1061962
Change-Id: Ib4b9311dccf6fa489e2a2a9180d38d7b4328a009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163068
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Auto-Submit: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761967}

- Added GetAllAwContent method in AwContentsLifecycleNotifier
- Changed AwContentsLifecycleNotifier to store AwContents pointer.
- Added AwPageLoadMetricsProvider which uses GetAllAwContent.

Bug: 1072770
Change-Id: Ief07426218df2ca28249de66bba2147f0a64a403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158914Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761966}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/160e12e11a72..00a02293c327

git log 160e12e11a72..00a02293c327 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 vapier@chromium.org cros_mark_android_as_stable: migrate to python3 only
2020-04-23 vapier@chromium.org cros_mark_chrome_as_stable: migrate to python3 only
2020-04-22 slangley@chromium.org reven: Do not run HW tests on reven builds.
2020-04-22 cjmcdonald@chromium.org run_pytest: Add '--quickstart' mode
2020-04-22 bpastene@chromium.org cros_chrome_sdk: Add support for --boards.
2020-04-22 morg@google.com Add (rammus|kukui)-arc-r to RVCPFQ boards
2020-04-22 lamontjones@chromium.org api: freshen python bindings.
2020-04-22 dburger@chromium.org Remove scheduling of qt_android_pfq, is retired.

Created with:
  gclient setdep -r src/third_party/chromite@00a02293c327

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I5a8a81684df0608b37cbce1d66c78d9009c946fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163048Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761965}

With this CL, if a declarative shadow root is already present when
attachShadow() is called, the contents of this shadow root are
removed, and the existing shadow root is returned. This is per Step 5
of the new spec [1], to allow coexistence of declarative content and
custom element hydration code.

This CL also adds an exhaustive test of all element types, both those
supporting and disallowing shadow root attachment.

[1] https://whatpr.org/dom/858.html#concept-attach-a-shadow-root

Bug: 1042130
Change-Id: Ie9fc39eeb324934f3cb13ab2eb6bc8a82d99d667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159987
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761964}

This CL removes the helper method used for test debugging in
BookmarkPersonalizedSigninPromoDismissTest. As the all the tests of
this class are enabled since February and are not flaky. We can safely
remove the helper method now.

Bug: 1045480
Change-Id: I4758cc717af3e8ff0d3f23f76786877b3f251484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159219Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761963}

The test creates a tree that has alternating ltr/rtl on each level,
which means css-logical properties must constantly be re-interpreted
(cascade-wise).

It is added in preparation of reworking how css-logical properties
works in StyleCascade.

Change-Id: Id2b882cbfa3a58f9bb62b41fde16ce66d1ea0f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162926Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761962}

The WaitForExtensions* member functions return a mix of
scoped_refptr<const Extension> and bare pointers. This CL makes
the return types consistent. This is necessary for proper Extension
instance lifetime management.

Bug: 1073567
Change-Id: I584da49d9c9a7924ef63e5e52fd565175e5bd1c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161380Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761961}

This reverts commit 28d8162b.

Reason for revert: Getting DRM connector causes a significant delay when
HDMI is connector to Kled. This code is not in use at the moment as
Rendering Buffer Compression is not currently enabled on Intel devices.

Original change's description:
>Disable Render Buffer Compression on external displays.
>
>When Getting format modifiers, exclude I915_FORMAT_MOD_Y*_TILED_CCS
>(Intel color control surface (CCS) for render compression) if it's not
>an internal display.
>This solves the bandwidth issue when driving more than 1 4K monitor with
>rbc enabled.
>
>BUG=996011,996036,994341,979736
>TEST=HardwareDisplayControllerTest.ModifiersWithConnectorType
>
>Change-Id: I31ce046fb20557eb66340bdf131efa1437bd7484
>Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918941
>Commit-Queue: Mark Yacoub <markyacoub@google.com>
>Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
>Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
>Cr-Commit-Position: refs/heads/master@{#715717}

BUG=979736,b/146874982

Change-Id: I3083e08501ef91cb395c4e2f3940d0a5cbcfd1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159758Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/master@{#761960}

Tests are failing on EG2 upstream.

Bug: 1073932
Change-Id: I6397f83d02ed047593771c485fbad057103261e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162752Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761959}

Look for one '-' instead of two '--', to process program options. Some
users have old habits like typing -? for help, for example.

Bug: 798943
Change-Id: I6d757b161ffb2082c8ad0a96e41a31f479969a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160955Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Auto-Submit: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761958}

When enabled, it will cause some jdk library symbols to be desugared
when dexing, and adds an extra classes.dex file to every .apk and .aab.

Bug: 1056751
Change-Id: Ib51b00f93fbe6120d44553782ce56ae60f7e6bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144357
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761957}

Currently if a webapp shows a safe-browsing interstitial, the webapp is
closed and the page is launched in browser mode. The purpose of this
logic was to work around bug where Chrome could not display multiple
interstitials (e.g. interstitial in webapp and interstitial in Chrome
browser). crbug.com/293717 Based on testing, the underlying bug is fixed
and the workaround is no longer needed.

BUG=1073748

Change-Id: If1aedb38d7c6c5eed08e3de2c61ed72818ce1244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161453Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761956}

Bug: 1073518
Change-Id: Ic29cf58a00cb200e5d3aa5565834621d50c169d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162825Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761955}

The image orientation is not applied when creating a CanvasImageSource
directly from an uploaded file. This is because we do not extract and
pass on the orientation from the decoder.

Fix it by obtaining orientation from the decoder on the worker thread
and passing it back to the original thread to create the image.

Bug: 1069965
Change-Id: I3f64519ed8b91e97bfa9afc802fe90ceb7eb2c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160353Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761954}

This class is meant to parse the JSON of the connector policies and
give a clean abstraction to get settings and to eventually cache these
settings.

Change-Id: I7b15dddc36a0a8727c26cd5421eec04e3fdde2a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147874Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761953}

Since the <script> tag appeared after defining the base URL of the
document, the script wasn't fetched and run. This likely worked out
anyway because of having Ahem available through other means.
Fix this and export the test to WPT while at it.

Change-Id: I9dff35db0bcfa6ccaa697d791583e897e47b768f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162888Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#761952}

Improper use of Unretained in asynchronous callbacks can lead to
crashes or even UAF. In this particular case, it appears that
we're using Annotator as a singleton, so Unretained might be okay - but
just to be safe, and to prevent future issues, using a WeakPtr is
super easy and provides some extra safety.

Bug: none
Change-Id: If01b73c142c8df3641b8112f62fe1e560f5d7d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161768Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761951}

This reverts commit c71eaf36.

Reason for revert: CL breaks chrome perf builder

Original change's description:
> Componentize ChannelsInitializer
> 
> ChannelDefinitions is made into an abstract class that exposes
> functionality to ChannelsInitializer, and defines useful types like
> PredefinedChannel. The channel definitions themselves live in the
> Chrome subclass, ChromeChannelDefinitions. Some of these definitions
> will be duplicated later for WebLayer.
> 
> ChannelsInitializerTest uses ChromeChannelDefinitions so it's left
> in //chrome. (We could replace ChromeChannelDefinitions with a
> TestChannelDefinitions, but that would reduce coverage of production
> code.)
> 
> Both the channel IDs and the channel group IDs will have to be different
> for WebLayer. It would be possible to account for this in code by
> judiciously prepending "org.chromium.weblayer.", and then keeping
> the channel definitions together, but that was both more complicated
> and seemed more error prone, as it would mean that the
> ChannelDefinitions.ChannelId type would no longer represent the Android
> system notification channel identifier. For example, code that used
> NotificationManagerProxy.getNotificationChannel() would have to be
> careful *not* to pass ChannelDefinitions.ChannelId without adding a
> prefix. In Chrome, which has no prefix, this would succeed, but in
> to-be-shared code, such as NotificationCompatBuilder, this would succeed
> for Chrome and fail for WebLayer.
> 
> Bug: 1069895
> Change-Id: I55890466797aafc34ef8a821a1cb43de8e3d03ab
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150066
> Commit-Queue: Evan Stade <estade@chromium.org>
> Auto-Submit: Evan Stade <estade@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#761922}

TBR=peter@chromium.org,dtrainor@chromium.org,estade@chromium.org,xingliu@chromium.org,knollr@chromium.org

Change-Id: I1e0af9d688d5c7a23b2977f0ef7471716c07c8ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1069895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162771Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#761950}

This change modifies the FieldPropertiesFlags enum to use kEnumStyle
instead of MACRO_STYLE for its enumerators.

Bug: 1071122
Change-Id: Iea64dce0effdc11c48542292b542f10dcd2df6f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162730Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761949}

Move the expiry date of the ReadingList histograms by one year.

Fixed: 1072582
Change-Id: Iea0c8dbe0b6e3c573a80f472b77173d76c7577e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159714
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761948}

Commit cb62c8fc
(https://chromium-review.googlesource.com/c/chromium/src/+/2155497)
removed the use of ChromeAsyncExtensionFunction from
media_galleries API, but left its #include behind.

This CL changes the include to the correct one:
"extensions/browser/extension_function.h"

This CL also removed unused "chrome_extension_function_details.h"

Bug: 634140
Change-Id: Id00bc2388beec26269c2470e6206a6c63d5b9f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162367
Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761947}

We're working to enable Clank to act as a security key. Behind a flag
it's now possible to exercise this code in Canary but, unlike in local
builds, trying to do so crashes with:

04-22 14:55:04.709 11850 11850 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.chrome.canary/org.chromium.chrome.browser.settings.SettingsActivity}: E9: Unable to instantiate fragment yy2: could not find Fragment constructor
...
04-22 14:55:04.709 11850 11850 E AndroidRuntime: Caused by: java.lang.NoSuchMethodException: yy2.<init> []

This is happening at the call here[1]. If I check the ProGuard mapping file, we indeed find:

org.chromium.chrome.modules.cablev2_authenticator.CableAuthenticatorModuleProvider -> yy2

However, if I pull the release APK from the device and disassemble it with apktool, yy2.smali contains:

.class public abstract Lyy2;
.super LH9;    // maps to Fragment
.source "chromium-Monochrome.aab-canary-412200223"

That explains why yy2.<init> cannot be found, but the class wasn't
abstract[2] when it started out! (There is a dynamic feature module in
play here, but this part of the code all lives in the base module.)

I'm guessing that Proguard is discarding the contents of the class
because it cannot see the use via reflection. Thus I'm taking a guess
that we need to explicitly configure it with this change. I have not
verified that this works, however. I'll probably need to wait for
another Canary release for that.

[1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/password_manager/settings/PasswordSettings.java;l=502;drc=2bec188eb6264f8decadf7629ede3de73cfe585c?originalUrl=https:%2F%2Fcs.chromium.org%2F
[2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/modules/cablev2_authenticator/public/java/src/org/chromium/chrome/modules/cablev2_authenticator/CableAuthenticatorModuleProvider.java;l=29;drc=2bec188eb6264f8decadf7629ede3de73cfe585c?originalUrl=https:%2F%2Fcs.chromium.org%2F

BUG=1002262

Change-Id: I708af8d222d18ece32976e882af531f9bc98aeb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161968Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761946}

Since NoStatePrefetch does not swap in prerenders, there is no reason to
keep this line in the deprecated code. The tests that run the deprecated
code don't have test coverage for this.

Bug: 10380658
Change-Id: I26807b1f44a83b273b0367f10eda11ba09002fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161966
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761945}

The restoration of the URL shouldn't be done for session restoration
URL, otherwise ther URL will be the session restoration URL of a session
restoratin URL, which create issues.
It also fixes tests, adding a timeout for checking the URL.

Fixed: 1073871, 1017147
Change-Id: Ia91e626d589d7ad5f04d34c9181160e8039f85fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162807
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#761944}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Iba562a6b740d6fdd70afe28b01c608fbb05a9c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163046Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761943}

synchronously.

Before this patch CompromisedCredentialsObserver operated on the UI thread.
- [UI] UpdateLogins
- [Background] change the password, notify the observers
- [UI] CompromisedCredentialsObserver processes the update
- [Background] compromised credential removed, observers are notified.

This is not ideal because removal of the compromised credential is
visible on the UI thread much later at unspecified time. Now:
- [UI] UpdateLogins
- [Background] change the password, notify the observers, compromised
password is removed, the observers are notified.
The UI thread sees the compromised credential gone as soon as the new
password value was updated.

Bug: 1049200
Change-Id: I9665bf77a216842925d913479c3d192597f3b606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162767Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761942}

Updates the expires_after attribute for 63 histograms that show
frequent access in the past 90 days.  These are the 100% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-10-18.

Change-Id: Ie66edd756524cc2e3b4f99dd1ae9cac5b1ad78dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162966
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761941}

These tests are timing out on Webkit Linux Leak. Bunch of similar tests
already have been disabled.

Tbr: hiroshige@chromium.org
Bug: 1068175
Change-Id: Idc4adb0e7a1d6bcba9a970c0662d5577c9554c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162728Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#761940}

The regressions is because we call sk_surface_->getCanvas(), it
will create a SkCanvas and cache it. Creating SkCanvas is not cost
free, so remove it for now.

Bug: 1071557,1071481
Change-Id: Ic21c8f066c4e4b3ece497bb9483f97bf012b462c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157286Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761939}

Update cros_healthd telemetry handling code to check for and log errors
from NonRemovableBlockDeviceInfo request.

Bug: chromium:1041153
Change-Id: I8d9d2af77d4b267fef2936dc71d5255dc3e3c5ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150965
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761938}

This is a pure mechanical CL that moves all password feature manager
helper methods from the passord_manager_util.cc to a dedicated
password_manager_featuers_util.cc

TBR=vasilii@chromium.org,

Change-Id: Ib86307c4756709f4508f7ce0d33e08417af0b76e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161075
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761937}

https://webrtc.googlesource.com/src.git/+log/9427b51d6ff5..e110a44628b1

git log 9427b51d6ff5..e110a44628b1 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 danilchap@webrtc.org Delete uri for the Generic Frame Descriptor v1
2020-04-23 ilnik@webrtc.org Revert "Launch external ref control for vp9 encoder"

Created with:
  gclient setdep -r src/third_party/webrtc@e110a44628b1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1027108
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I1fbb3e5ede385d5dc0494e0c35be481b976cf44d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163005Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#761936}

Bug: 1053101
Change-Id: I5c3ee229a94ff9326d9a9e3c19f2fed852aca4fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161448Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761935}