- 27 Nov, 2019 40 commits
-
-
Chris Hall authored
R=meredithl,dmazzoni Change-Id: I0bf51e5de97d19027c67dbd6dfae5d4ceb863bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936446Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719812}
-
Mike Wittman authored
Saves off the function pointer obtained from ntdll.dll so that we don't need to repeatedly query its module handle and take the loader lock while doing so. Bug: 1028808 Change-Id: I25c0dd2872524a28a87df7c4bf2db7551eab6311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940882 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#719811}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf46a27cdd73..73beaaa48fcc git log bf46a27cdd73..73beaaa48fcc --date=short --first-parent --format='%ad %ae %s' 2019-11-27 benjaminwagner@google.com [infra] Upgrade Radeon driver Created with: gclient setdep -r src/third_party/skia@73beaaa48fcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I41e20c7f072de4b0f1973d9b7da4a88d2e4ae5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719810}
-
Sunny Sachanandani authored
Validating command decoder CopySubTexture implementation attempts to GLImage::CopySubTexImage first before binding image. The expected behavior is that CopySubTexImage will return false if not supported, but a crash is not expected. This CL removes the NOTREACHED() calls that cause a crash in debug builds. This was observed when forcing low latency flag for all canvas to find conformance failures in https://crrev.com/c/1868845. Bug: 1011588 Change-Id: Iaf70c2f61d941ab67c2775122940786191a1a6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941056Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#719809}
-
Miyoung Shin authored
This CL removes unnecessary filters from "navigation:frame" interface filter. - Remove media.mojom.Renderer since this instance is brokered by InterfaceFactory. - Remove since there isn't PrefetchURLLoaderService mojo interface. Bug: 936482 Change-Id: I677782fe9bdd775287f149c26cc4b2e2cd6819bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939072Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#719808}
-
Yuly Novikov authored
conformance/textures/misc/tex-video-using-tex-unit-non-zero.html conformance2/textures/misc/npot-video-sizing.html TBR=bsheedy Bug: 1026468 Change-Id: I2bd346748dc8be2cc10f543afc05ee128e2d6ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941109Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719807}
-
Noel Gordon authored
Bug: 1029019 Change-Id: I991f34d115702c8a0224b2662e0527c5766f08f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940311Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719806}
-
Daniel Murphy authored
This changes adds dom_storage, blink_dom_storage, and storage_service as watchable categories. Also, this change adds dmurph@ to the watchlist for indexed_db, blink_indexed_db, dom_storage, blink_dom_storage, and storage_service. Change-Id: I7a82e79d5c9be729fd7f16adf252b24753d1283f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941192 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719805}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46665521b3e1..fa16617226b7 Created with: gclient setdep -r src-internal@fa16617226b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029038,chromium:1027271 Tbr: jbudorick@google.com Change-Id: Ica73abe485646188c938814c42e3b16be60b9151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940594Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719804}
-
Etienne Pierre-doray authored
Before: ReadElfBuildId() assumes that base_address is the start of the address space (address 0). This isn't true on Android for many modules, where sections have a load bias. Fix: Find the first LOAD executable segment and use p_vaddr as |load_bias|, which is subtracted from |base_address|. Consider libart.so: PHDR 0x000034 0x0000c034 0x0000c034 0x00120 0x00120 R 0x4 LOAD 0x000000 0x0000c000 0x0000c000 0x45c354 0x45c354 R E 0x1000 LOAD 0x45c840 0x00469840 0x00469840 0x09ab0 0x0bad1 RW 0x1000 DYNAMIC 0x463cf0 0x00470cf0 0x00470cf0 0x00178 0x00178 RW 0x4 NOTE 0x000154 0x0000c154 0x0000c154 0x00038 0x00038 R 0x4 |load_bias| = 0x0c000 (|base_address| is offset by |load_bias|). Reading NOTE at |base_address + 0x0c154| is invalid. Change-Id: If81c0052c19557ddcbe63ba8c3a0dee64140dc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894165Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#719803}
-
Kent Tamura authored
It was stored as a double, milliseconds from the Epoch and 0.0 as an invalid value. Representing it as base::Optional<base::Time> is reasonable because - Binding layer maps base::Time to JavaScript Date. - The source of anticipatedRemoval is base::Time::Exploded - anticipatedRemoval is encoded as base::Optional<base::Time> in mojo * This CL renames some instances of variables 'anticipatedRemoval' to 'anticipated_removal'. * This CL fixes an issue that anticipatedRemoval was sent via mojo as 1000 times larger value. DeprecationReportBody::AnticipatedRemoval() treated a milliseconds value as a seconds value. This CL should have no user-visible behavior changes. Bug: 988343 Change-Id: If4e12659badb5ad6d6c35d147e3f976dde0d2b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928094Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#719802}
-
Lukasz Anforowicz authored
This CL changes behavior of session-restore so that when recreating FrameNavigationEntries history entries for about:blank and/or data:... URLs we attempt to also recreate FrameNavigationEntry::site_instance_. After this CL, the SiteInstance will be recreated for all such about:blank and data:... frames ("all" = both for main frame and for subframes) but only if the FrameNavigationEntry::initiator_origin_ is available. The CL helps fix the following GetOriginForURLLoaderFactory CHECK: CHECK(policy->CanAccessDataForOrigin( navigation_request->GetRenderFrameHost()->GetProcess()->GetID(), result)); This CHECK is tracked in https://crbug.com/1026474. This CHECK would be hit by 3 of the new test cases added in this CL: BackToAboutBlank1, BackToAboutBlank2, BackToAboutBlankSubframe. This CL also adds a BackToAboutBlank1_Omnibox test for completeness (even though this test wouldn't hit the CHECK, because the CHECK is skipped for opaque origins which would be used when there is no initiator - for example in omnibox navigations to about:blank). Bug: 1026474 Change-Id: Ia20a3956237bcbe3ca307342b1748af413fd19ac Tbr: chrisha@chromium.org for //chrome/browser/sessions Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929850 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719801}
-
Anand K. Mistry authored
Google Drive API doesn't depend on extensions in any way. Bug: 809382 Change-Id: Ia0722108b0c847576d7fa484af9643d87e988611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939129Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#719800}
-
Jordan Bayles authored
This is a reland of 5848123a Original change's description: > Move dependencies on cast_channel protos > > This patch rectifies a duplicate definition error, since certain proto > definitions are defined both in components/cast_channel and in > third_party/openscreen, by moving all consumers of these protos to using > the Open Screen version. > > Change-Id: I0347424c019b1489eb09b3822fd4a97d062e0e0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902718 > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Jordan Bayles <jophba@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715462} NOTE: Attempting TBR after recommendation from @karandeepb. TBRing reviewers: halliwell: Please review changes to components/ TBR=halliwell@chromium.org Change-Id: I5cb0bcedaf10982542fe0bf2b6db36da7e958f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925133 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719799}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74a93d412a1e..2f875b2946bb git log 74a93d412a1e..2f875b2946bb --date=short --first-parent --format='%ad %ae %s' 2019-11-27 ilkos@google.com Plumb build fingerprint to trace processor Created with: gclient setdep -r src/third_party/perfetto@2f875b2946bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:b/142858742 Tbr: perfetto-bugs@google.com Change-Id: I6ed16cf51bd342bbf49c8489dd7dfbf7ab4974a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941008Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1d6155d8679a..30f0559dd278 git log 1d6155d8679a..30f0559dd278 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 rharrison@google.com Remove spvc's dependency on shaderc's util library (#914) 2019-11-27 rharrison@google.com Clean up how include dirs are propegated for spirv_cross (#912) Created with: gclient setdep -r src/third_party/shaderc/src@30f0559dd278 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Iece0afaf98dcf880f070892eff5211b1a8cbe6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940592Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1b6546d2..8b811565 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia02f0f91f657a36057b2de7cb6b02c69d8649e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940136Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719796}
-
Findit authored
This reverts commit 4c424ef5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 719737 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjNDI0ZWY1NWNmNGI5NTFiNTU0ZWE0MjdjMjk1MzEzNTI4MWQ4ZTYM Sample Failed Build: https://ci.chromium.org/b/8895602508996479984 Sample Failed Step: compile Original change's description: > Enable init_stack_vars for non-official Windows builds > > With crrev.com/c/1914359 merged so we can enable the flag on Windows. > Patch is similar to crrev.com/c/1795632 and crrev.com/c/1838383. > > Bug: 977230 > Change-Id: I166392ee0f65ed7fd7f68cbdd5b7a3b7d589539b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854805 > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719737} Change-Id: Id1e9211184814bdcbcacf5f1decd1774e16cb9e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941199 Cr-Commit-Position: refs/heads/master@{#719795}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=avi@chromium.org Bug: 953861, 1007763 Change-Id: I58af3a799b7b376f1a7a902823cda3ca0c5ffb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939965Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719794}
-
John Rummell authored
On some bots the license server is failing to start, so log a warning when it fails to hopefully indicate what is going wrong. Bug: 976083 Test: compiles Change-Id: Idff11ea2885289608c549396b6e11e28e095ed72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940954Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#719793}
-
Maggie Chen authored
If the GPU main thread makes a progress after waiting in OnWatchdogTimeout(), the arm_disarm_counter has changed. last_arm_disarm_counter_ saved before the wait functions is stale. Without updating it again, the GPU main thread is always considered making a progress in the next timeout cycle, which is not correct. Bug:949839 Change-Id: Ic54c7681e9bbe606004555fbf7f16cbebe91d9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940383Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic40f098e542d9d976d6e9007bf4570e97a6ec315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940557Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#719791}
-
John Lee authored
This CL makes the TabElement not animate any space it takes up, including width and padding, so that the window can immediately scroll to it without having to wait for the slideIn animation to finish. This is the first step to animating scroll. Bug: 1023492 Change-Id: I7b1ba8bf5fdb8400e1333c2542d644b9afbaa9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937782Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#719790}
-
Dominic Battre authored
Bug: 1028095 Change-Id: Ia788f2614345159d13c29c0fa6ab9f711480199a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940252 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719789}
-
Andrew Grieve authored
TBR=agrieve # Code style refactor Bug: 1029038 Change-Id: I19ae4d7d7a6672d9389cc9cf7d109fafe0473eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940489 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719788}
-
mark a. foltz authored
Remove myself from: - media_remoting - tab_capture TBR=miu@chromium.org Change-Id: I259e709b1ce00f01cfdeecc177fb0d34f1fd4db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941052Reviewed-by:
-
Joe DeBlasio authored
Based on more crash data, we can now safely exclude: - context-menu-inititated page-saves, - the extension download API, - extension installs, - Chrome-initiated top-level navigations, - reloads, and - anything triggered directly from the address bar. Bug: 1029003 Change-Id: I8a45fb27172dea211c5f2177306144d6a35a58a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940997 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719786}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=nasko@chromium.org Bug: 1007760 Change-Id: I7d8fb46c331a68ffa9567cd6ffa4c74a8529b19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940384 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#719785}
-
Yi Gu authored
The unique pointer params.hit_test_data_provider has been moved before we check whether it's null. Some unit tests which are supposed to test both v1 and v2 paths do not actually implement the v2 version. This bug was not exposed until the incorrect DCHECK was found. Bug: 1029012 Change-Id: I1dc8f8a0b2c0e355e6b578cd387c13b101a7039a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938828 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#719784}
-
Yi Gu authored
params.hit_test_data_provider should only be used in V1. Without the feature check, AsyncLayerTreeFrameSink will use the V1 path even if V2 is enabled. Bug: 1029014 Change-Id: Iad1c3bcdf4f1dcbf86b12e01561139a527684666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938727Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Ted Choc authored
This reverts commit f8030cb2. Reason for revert: crbug.com/1028641 - Breaks bottom toolbar hiding for the Duet experiment on Android. Original change's description: > viz: Remove unused bottom-controls data from compositor frame. > > The bottom_controls_height and bottom_controls_shown_ratio fields > in CompositorFrameMetadata are currently unused. Their usage has been > replaced by the same fields in RenderFrameMetadata. So remove these > fields. > > BUG=none > > Change-Id: I96af75cc5f933821cfb486fdeb1e314daa2a7030 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927973 > Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717874} TBR=sadrul@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: If66edb5c9184b8041c79dc9215bd725eb9f2cece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940490Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719782}
-
Erik Staab authored
TBR=jam@chromium.org Bug: 1007791 Change-Id: I032614bf31a6428dae9e974968d8889fabb39587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935179Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2559fc0b842c..00b1e38f3b09 git log 2559fc0b842c..00b1e38f3b09 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 rharrison@chromium.org Re-enable spirv-cross fuzzers Created with: gclient setdep -r src/third_party/dawn@00b1e38f3b09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie1330a5ad7ea3c393befe7144a2c1452cff7ef36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940491Reviewed-by:
-
Xiaocheng Hu authored
While clipboard markup is allowed to carry style sheets to style the elements to be pasted (e.g., when copying from Excel), @import rules should be disabled for security reasons. This patch disables @import rules when sanitizing the markup in a dummy document to make sure we don't initiate any stylesheet loading during the process. Bug: 1017871 Change-Id: I484341dc34e2ceea1891a18ac158ed2cc4920c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935429 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#719779}
-
Mark Cogan authored
TabModel was only used inside BrowserCoordinator to pass into the PageInfoLegacyCoordinator, which only needs a WebStateList. BrowserCoordinator has a public Browser property, which means any code that actually needs the TabModel can get it from that. That's what BrowserCoordinator now does. All usage of TabModel in BrowserCoordinator is thus removed. Change-Id: I3db57f468659ec07d4b7cbe013dc8e5fa326dafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939980 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#719778}
-
Jeremy Roman authored
Bug: 964481 Change-Id: I4551e1eeb3de15239b9a0f46778d6c81594b7992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940967 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#719777}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e60e76b2. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I16f105966a17cf90bb2c9d498abddf06d6d8de1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940133Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719776}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=avi@chromium.org Bug: 953861, 1007763 Change-Id: I2aa07b6b7541aae252347628759be6f0fa80814f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940875Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719775}
-
Collin Baker authored
This is a reland of 26ae2ec0 The original CL was reverted due to the test uncovering existing bug 1029086. This reland includes the fix for the uninitialized read. Original change's description: > Re-focus View on tab strip close > > When the WebUI tab strip's WebContents gains focus, the focused > TextInputClient changes while the focused View does not. This causes > text input to stop working in the omnibox despite it having Views-focus. > > This blurs and re-focuses the currently focused View. For the Omnibox, > this makes it re-install itself as the focused TextInputClient. > > This is a workaround and should be removed once bug 994350 is fixed. > > Bug: 1027375, 994350 > Change-Id: I2be055110535dc6164a7d31a64a3cf503fae7a7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935729 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719473} Bug: 1027375, 994350, 1029086 Change-Id: I7f12945c9df64190df2d3d30726acd38d3457834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940869Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#719774}
-
Ted Meyer authored
Turns out I missed a double serialization! Bug: 1027412 Change-Id: I0a79c7fcc4cdba9df54f08d46fd8e422c5f4c14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938465 Auto-Submit: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
-
