GitLab

This CL introduced a checking of |provisionally_saved_credentials| for sync credentials, instead of |pending_credentials|. That's more correct, since |provisionally_saved_credentials| is the submitted form, on other hand |pending_credentials| is a combination of already saved and submitted form. In case of saving both these forms are the same, but for updating they are different.

BUG=663896

Review-Url: https://codereview.chromium.org/2604783002
Cr-Commit-Position: refs/heads/master@{#440844}

This will significantly reduce the wasted bandwidth consumed
when these bots are no longer archiving 13 GB for every build.

Add a new Android Builder that will build 'all' in Release mode,
but not archive the build.

This is a prerequisite for https://chromium-review.googlesource.com/423051

BUG=657315
NOTRY=True

Review-Url: https://codereview.chromium.org/2605873002
Cr-Commit-Position: refs/heads/master@{#440843}

Context states transit from Uninitialized to Initialized, and then to Detached.

- isGlobalInitialized() returns true when the context state is Initialized or Detached.
- isContextInitialized() returns true when the context state is Initialized.

Thus !isContextInitialized() is stronger than !isGlobalInitialized().
Hence we can remove if(!isGlobalInitialized()) from WindowProxy::updateDocument().

BUG=677253

Review-Url: https://codereview.chromium.org/2603953002
Cr-Commit-Position: refs/heads/master@{#440842}

By checking scriptState->contextIsValid(), we don't need to check isContextInitialized().

BUG=677253

Review-Url: https://codereview.chromium.org/2605853002
Cr-Commit-Position: refs/heads/master@{#440841}

The only call site of existingWindowProxy() is V8Initializer::messageHandlerInMainThread().
However, as commented in the code, that code should not be needed because
if the context is during initialization it should already have bailed out at
the if(!scriptState->contextIsValid()) check at the very beginning of
V8Initializer::messageHandlerInMainThread().

If the reasoning is correct, we can simply remove all code around existingWindowProxy().

BUG=677253

Review-Url: https://codereview.chromium.org/2607743002
Cr-Commit-Position: refs/heads/master@{#440840}

We don't need to check isContextInitialized() in clearForClose() and
clearForNavigation() because it is already checked in WindowProxy::disposeContext().

Also this CL moves the ScriptState::Scope into disposeContext()
Though we don't need to enter ScriptState::Scope in case of clearForClose()
by accident, it looks safer to enter the scope always.

BUG=677253

Review-Url: https://codereview.chromium.org/2601033002
Cr-Commit-Position: refs/heads/master@{#440839}

In RuleData we have array field, which is not initialized at
construction of the object. And after object constructed, we iterate
through this array by pointer. This code look dangerous and MSan detect
this problem.
To be safe during this iteration need initialize this array. It was
done.

R=skobes
BUG=None

Review-Url: https://codereview.chromium.org/2600123002
Cr-Commit-Position: refs/heads/master@{#440838}

Cr-Commit-Position: refs/heads/master@{#440837}

A lot of IME tests were flaky and marked with @RetryOnFailure. Now they
are (almost) all deflaked, so we don't need @RetryOnFailure any more.

BUG=628964,603991

Review-Url: https://codereview.chromium.org/2607723002
Cr-Commit-Position: refs/heads/master@{#440836}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cf7481bd..d17870c6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2607703002
Cr-Commit-Position: refs/heads/master@{#440835}

It's already guaranteed that WindowProxy::initialize never returns null.
This CL just does some refactoring to make the fact clearer.

BUG=

Review-Url: https://codereview.chromium.org/2601773002
Cr-Commit-Position: refs/heads/master@{#440834}

The clang-format Javascript style changed in crrev.com/440558 to prevent
single-line functions. This CL updates the Javascript in MD History to
follow this change.

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2607653002
Cr-Commit-Position: refs/heads/master@{#440833}

ActiveDOMCallback is just checking if the associated ExecutionContext
is suspended or detached. We can do the check using m_scriptState->getExecutionContext().
Then we can remove ActiveDOMCallback.

BUG=610176

Review-Url: https://codereview.chromium.org/2605683002
Cr-Commit-Position: refs/heads/master@{#440832}

Cr-Commit-Position: refs/heads/master@{#440831}

Reason: Currently rebaseline-cl will add all files in LayoutTests/ to the index even if they are files unrelated to rebaseline-cl.

In this CL:
 - In git.py, add a method unstaged_changes() which just lists currently unstaged changes. There were already methods for listing files that are different from HEAD; that includes staged changes, but I believe we don't want to abort if there are already staged changes to baselines, right? If that's not the case, then this CL could potentially be made simpler.
 - In rebaseline.py, add a method unstaged_baselines(), which just lists unstaged changes to baselines. Additionally, when adding files after rebaselining, only add staged baselines to the git index, not other files.
 - In rebaseline_cl.py, add a check for unstaged baselines at the start and abort with an error message if there are any.

BUG=662584

Review-Url: https://codereview.chromium.org/2590693002
Cr-Commit-Position: refs/heads/master@{#440830}

This CL uses mojo::MakeRequestForTesting() to internally create the message pipe
on which mojom::AssociatedInterfaceProvider will be associated.

BUG=

Review-Url: https://codereview.chromium.org/2603743002
Cr-Commit-Position: refs/heads/master@{#440829}

This is just a cleanup and does not change behavior.

BUG=n/a

Review-Url: https://codereview.chromium.org/2604733003
Cr-Commit-Position: refs/heads/master@{#440828}

The following globals were namespaced:

    InspectorFrontendAPIImpl => Host.InspectorFrontendAPIImpl
    SourceMapV3 => SDK.SourceMapV3
    TreeElement => UI.TreeElement
    TreeOutline => UI.TreeOutline
    TreeOutlineInShadow => UI.TreeOutlineInShadow
    registerCustomElement => UI.registerCustomElement
    createTextButton => UI.createTextButton
    createRadioLabel => UI.createRadioLabel
    createLabel => UI.createLabel
    createCheckboxLabel => UI.createCheckboxLabel
    createSliderLabel => UI.createSliderLabel

BUG=none

Review-Url: https://codereview.chromium.org/2604883002
Cr-Commit-Position: refs/heads/master@{#440827}

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=vmpstr

Review-Url: https://codereview.chromium.org/2607493004
Cr-Commit-Position: refs/heads/master@{#440826}

http://crrev.com/2558633005 modified
LayoutObject::hasClipRelatedProperty() to consider clip path,
unintentionally introducing this issue.

BUG=675081
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2602823002
Cr-Commit-Position: refs/heads/master@{#440825}

BUG=662172

Review-Url: https://codereview.chromium.org/2591753003
Cr-Commit-Position: refs/heads/master@{#440824}

BUG=645667
TEST=FrameThrottlingTest.MutatingThrottledFrameDoesNotCauseAnimation etc. with --enable-slimming-paint-invalidation

Review-Url: https://codereview.chromium.org/2598073003
Cr-Commit-Position: refs/heads/master@{#440823}

ContextClient is more lightweight than ContextLifecycleObserver.
Classes that don't override contextDestroyed should use ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2607533002
Cr-Commit-Position: refs/heads/master@{#440822}

[SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in FrameView::setNeedsPaintPropertyUpdate() when RLS is enabled

BUG=645667
TEST=Many test cases in webkit_unit_tests with RLS enabled with --enable-slimming-paint-invalidation

Review-Url: https://codereview.chromium.org/2603703002
Cr-Commit-Position: refs/heads/master@{#440821}

BUG=579229
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2600603002
Cr-Commit-Position: refs/heads/master@{#440820}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/70bee166..cf7481bd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2603883002
Cr-Commit-Position: refs/heads/master@{#440819}

Update the interface for CTVerifier to use a base::StringPiece
for the OCSP and TLS SCT extension, rather than an std::string.
By allowing this to be zero-copy from the underlying SSL* that
stores this information, this allows pruning the ocsp_response_
member from SSLSocketImpl, which can save an extra 2K-12K per
socket for those that staple OCSP responses, and eliminate an
extra copy for the CT information.

As this required touching every CTVerifier-derived class, this
also fixes the API wart that crept in regarding
CTVerifier::Verify() having a return code. As the actual
verification of policy compliance is handled not by CTVerifier
but by CTPolicyEnforcer, there's no actual status code to return
from CTVerifier. To make future cleanups easier, and to align the
API and implementations for consistency, this also replaced the
various stub verifiers that grew with explicit
DoNothingCTVerifiers that skip all parsing entirely.

BUG=571203
TBR=sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2604513002
Cr-Commit-Position: refs/heads/master@{#440818}

cancel-and-start-new.html is now a testharness test.

We don't check the property value at a precise time, instead we verify
that a transition is occurring.

BUG=248938

Review-Url: https://codereview.chromium.org/2588313002
Cr-Commit-Position: refs/heads/master@{#440817}

Currently, the argument validation and and argument conversion happens
in a single step. This is good for the case when we need the JSON
serialized arguments, but in the case of custom JS hooks, the work is
unnecessary. However, we still need to match arguments to a signature
in that case.

Add another method to allow for matching, but not converting, the
arguments, and use it when we have a handle request JS hook.  This is
in line with what the curent JS implementation does, and thus what our
custom bindings expect.

We also need to add support for parsing arguments that are functions,
since we are now validating for requests with custom handlers (which
can have functions as arguments other than callbacks).

Add a test that invoking a method with a custom binding with an invalid
invocation throws an error.

BUG=653596

Review-Url: https://codereview.chromium.org/2583273002
Cr-Commit-Position: refs/heads/master@{#440816}

The sync (i) icon in the top-right of the page uses the iron-dropdown
Polymer element to display its content. This element was implicitly
imported by cr-shared-menu, meaning that after cr-shared-menu was
removed (in crrev.com/440308) from the history page, the dropdown
stopped working.

This CL restores the import of iron-dropdown, fixing the dropdown.

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2594303002
Cr-Commit-Position: refs/heads/master@{#440815}

BUG=None
TBR=marq@chromium.org

Review-Url: https://codereview.chromium.org/2604853003
Cr-Commit-Position: refs/heads/master@{#440814}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/26758366..70bee166

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2604903002
Cr-Commit-Position: refs/heads/master@{#440813}

This will allow different schedulers to write to different histograms.

BUG=

Review-Url: https://codereview.chromium.org/2590013002
Cr-Commit-Position: refs/heads/master@{#440812}

BUG=655203

Review-Url: https://codereview.chromium.org/2562193002
Cr-Commit-Position: refs/heads/master@{#440811}

Revert of Tab (and AuraWindow) Capture: Capture refresh frame after Resume() (patchset #2 id:20001 of https://codereview.chromium.org/2603533002/ )

Reason for revert:
Speculative revert because WebContentsVideoCaptureDeviceTest.StopWithRendererWorkToDo is crashing with media::ThreadSafeCaptureOracle calling CopyRGBToVideoFrame.

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56009

Original issue's description:
> Tab (and AuraWindow) Capture: Capture refresh frame after Resume()
>
> Adds a refresh frame capture upon Resume(). This solves a problem where
> the tab capture device can be suspended for a significant length of time
> and then resumed; but if the content of the tab isn't changing when the
> resume takes place, no compositor events will be firing to cause any new
> frames to be captured. Thus, the content in the video stream could be
> very stale. Issuing a refresh frame capture guarantees the video stream
> will be up-to-date immediately after a resume.
>
> BUG=643964
>
> Review-Url: https://codereview.chromium.org/2603533002

TBR=xjz@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=643964

Review-Url: https://codereview.chromium.org/2604833003
Cr-Commit-Position: refs/heads/master@{#440810}

BUG=579229

Review-Url: https://codereview.chromium.org/2599153002
Cr-Commit-Position: refs/heads/master@{#440809}

GetIndexForOffset() should decrease resulting index by 1 for pending
transient items to allow going back from interstitials that were added
to the middle of the stack.

BUG=677190

Review-Url: https://codereview.chromium.org/2600263002
Cr-Commit-Position: refs/heads/master@{#440808}

BUG=

Review-Url: https://codereview.chromium.org/2582173002
Cr-Commit-Position: refs/heads/master@{#440807}

The animations potentially slow down shutdown, without providing positive
utility.

BUG=571908

Review-Url: https://codereview.chromium.org/2598393003
Cr-Commit-Position: refs/heads/master@{#440806}

BUG=615156
NOTRY=true

Review-Url: https://codereview.chromium.org/2607643002
Cr-Commit-Position: refs/heads/master@{#440805}