GitLab

TBR=benmason@chromium.org

Change-Id: If2cc99aab5712c139bb83cb72d535e8098caed21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762748
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688774}

This flag uses a very old switch and will disappear in M78 without this
CL.  While I think we can likely get rid of this flag/switch and its
functionality, that won't be perfectly clear until the Derelict House
project fully launches right before the Autofill Auth project launches.
Extending this flag until that time comes.

Change-Id: I3ef6e1e7546dc59a6009179c936d6c9cd9e44ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762656
Auto-Submit: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688773}

https://dawn.googlesource.com/dawn.git/+log/0beb43809ae9..87ded961eea9

git log 0beb43809ae9..87ded961eea9 --date=short --no-merges --format='%ad %ae %s'
2019-08-20 cwallez@chromium.org Remove 16 bit normalized texture formats

Created with:
  gclient setdep -r src/third_party/dawn@87ded961eea9

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I13644e5e844f6ac2717ba9eea8c8bf3bfac7883f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762810Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688772}

When we have nested main_frame->parent_frame->child_frame and only the
mid-level parent_frame has kHitTestAsk flag, we should not directly
dispatch the event to the child_frame because the parent_frame may have
overlapping regions with main_frame divs. Instead RWHIER should always
ask when it encounters a mid-level kHitTestAsk flag.

To fix the drag and drop issue (crbug.com/804633) in V1, the logic above
was broken as a temporary workaround. Now that the drag and drop bug has
been formally fixed, we should resume the correct logic.

Bug: 995850
Change-Id: Idc380b0249e650d3b73af60f2a1d99f30bee1a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762531Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688771}

This pulls several recent changes to the server-side protos into
Chrome, so the server and client now agree on the proto definitions.

Change-Id: I14b427970897ed72264acd6608e9d65f2906f1ce
Bug: 980784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761466Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688770}

Bug: 955104
Change-Id: Ib1dc5ae02e0dec5eab4206ba017ac0be2bb624f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762818
Auto-Submit: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688769}

Bug: 995737,912946
Change-Id: I1074c408436e3cffe33184176d924c7604d80bf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762719Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688768}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/15b9f9d6..9f6ab93c

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic4a740b885317552f592a466ffc6f2be8877eae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762423Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688767}

Previously, it could be fired before the final layout of the animation.
Now it will be fired after the final layout is applied, so the child
views are all in their final states.

Bug: 995596
Change-Id: Idbc187e4d4b2bf28cf720845180a427a2d04778a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762060
Auto-Submit: Dana Fried <dfried@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688766}

https://chromium.googlesource.com/catapult.git/+log/0d7ff782762c..5f609ed24082

git log 0d7ff782762c..5f609ed24082 --date=short --no-merges --format='%ad %ae %s'
2019-08-20 rmhasan@google.com [Telemetry] Get user friendly names for AOSP device types

Created with:
  gclient setdep -r src/third_party/catapult@5f609ed24082

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=crouleau@google.com

Bug: chromium:994956
Change-Id: Ice6b667add24893de1ffc5d398df9d4f3cedd21d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762811Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688765}

https://chromium-review.googlesource.com/c/chromium/src/+/1386464 added
a histogram to track use counters on `file:` URLs, but neglected to add
that new histogram to the XML file. This patch takes care of that minor
oversight.

We'd like to keep this histogram around long enough to make a decision
about whether/how to deprecate and remove `file:` URLs' capabilities
over time to reduce the attack surface we're exposing to locally-hosted
pages. Setting the expiry to the end of the year seems like a
reasonable timeline to aim for.

Bug: 794098
Change-Id: I0e659be03ceb7c86477d5a54f30e4b58e81c7b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760208Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688764}

TBR=steimel@chromium.org

Bug: 831720
Change-Id: I22a9a233fd8442d29a849dd72c0fa75ae8dab30e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762928Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688763}

TBR: rayankans
Bug: 989210
Change-Id: Ic01d431f539751ebcd01efa08a0739dfedbfe877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762510Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688762}

https://chromium.googlesource.com/angle/angle.git/+log/265fdf0c5fd6..396527c92105

git log 265fdf0c5fd6..396527c92105 --date=short --no-merges --format='%ad %ae %s'
2019-08-20 jonahr@google.com Autogenerated kFunction* variables detected as mutable constants
2019-08-20 clemendeng@google.com Get rid of gl_ViewID_OVR for ESSL1
2019-08-20 lujc@google.com Separate dirty bit for attrib's binding VBO change
2019-08-20 timvp@google.com Vulkan: Full support for program interface queries
2019-08-19 clemendeng@google.com Get Desktop GL games running on desktop frontend
2019-08-19 jmadill@chromium.org Suppress nonportable include path warning.
2019-08-19 clemendeng@google.com Auto-generated variables detected as mutable constants
2019-08-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 7b4e5bd5ec82..bc62722b80a6 (3 commits)
2019-08-17 gwatson@mozilla.com Fix occasional corruption of vertex textures in HD4600 GPUs.
2019-08-17 jdarpinian@chromium.org Miscellaneous build fixes for WebKit
2019-08-16 dongja@google.com Add test for array of arrays of samplers
2019-08-16 jmadill@chromium.org Clean up trace output.
2019-08-16 clemendeng@google.com Add desktop GL built-in functions to symbol table

Created with:
  gclient setdep -r src/third_party/angle@396527c92105

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@chromium.org,jonahr@google.com

Bug: chromium:995046,chromium:None,chromium:3439
Change-Id: Id46e492a76dbb36160ccba6ef57563c502406a5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762809Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688761}

Bug: 969558
Change-Id: I7e4a21484a2327e25241b0259cf007327abec317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761401
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688760}

R=cmp@chromium.org

Bug: 995687
Change-Id: I3635e097390c548c55b2f652d9c8fb4c66a90f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761440
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688759}

With crrev.com/c/1700112, the test was refactored to (hopefully)
eliminate flakiness by deterministically decoding WebP images in YUV
or RGB.

Bug: 981137
Change-Id: Ieb49b9562d5a1e1d048ab04326eb777b77d88b15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762338
Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688758}

Add Web IDL for XRAnchor and related interfaces along with stub
implementation so that everything compiles & links.

Additionally, refactor XRPlaneSet into an XRSetlike template class to
allow for code reuse between XRPlaneSet, XRAnchorSet, and potentially
other setlikes.

Bug: 992027
Change-Id: I59f1b622dcfb6cd3034ca6f493381443d2094956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746955
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688757}

Bug: 985486, 984780, angleproject:3701
Change-Id: Ic43c10daf5949566b66a31cbaf3c1c2446291839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760284
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688756}

This is
 1) s/TestBrowserThreadBundle/BrowserTaskEnvironment/ on src/
 2) s/([^/])\b\w*thread_bundle(_)?/\1task_environment\2/ on files modified in (1)
 3) git cl format
 4) Manually fix up remainder "ThreadBundle" and "thread_bundle" found via
    string search on the whole of src/.

For ease of review:
 * Step #3 is the diff between patch sets 1..2
 * Step #4 is the diff between patch sets 2..3

TBR=dcheng@chromium.org
(for post-review owners bypass per mechanical change)

Bug: 992483
Change-Id: I4945141f6d78bdc6c98444198e5012ddc8e5bff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758440Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688755}

This CL adds an optional file descriptor to LoggingSettings, which can
be used to initialize logging to an already open file. Previously,
logging to a file required passing a path and letting the logging
system open() it for append. Passing a file-descriptor means that a
process can be sandboxed to have no access to the log directory, but
can still be passed a file-descriptor to log to.

This is needed for the Network Service on ChromeOS, whose logging needs
to be reinitialized to a new location after it's already started.

Bug: 977415
Change-Id: I2d07dc13a7e9f0f57d0802e4816628c181f183cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699477
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688754}

Switching out the Executor for a SequencedTaskRunner, backed by the
native thread pool.

Local measurements suggest we won't see any significant performance
gain (or loss) with this change, but it's still a reasonable cleanup to
switch to the standard Chromium threading APIs.

Bug: 995465
Change-Id: I847cff117887f866de3fe0c79d1bc1f735c19a95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761428
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688753}

When a URL is rejected by //ios/web policy in
decidePolicyForNavigationResponse, didFailProvisionalNavigation will be
invoked later with "kWebKitErrorFrameLoadInterruptedByPolicyChange". In
this case, the WKNavigation should be removed from
CRWWKNavigationHandler.navigationStates so that WebStateObservers will
not get URL of the rejected navigation.

Bug: 994044
Change-Id: Ia764442316a32bddbd686460160f5e064d1cfa70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762229Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688752}

Create SCBadgeCoordinator to manage BadgeViewController in Showcase.
Creates SCBadgeTestCase to test that BadgeViewController properly
shows the incognito badge and passwords badge when pass their
BadgeItems through addBadge:

Screenshot: https://drive.google.com/open?id=16ZrtCPJF1E6dTBwPZBzar67jARRTGljU

Bug: 994045
Change-Id: I14d27ee6964a4e96e2c8fbb9755bc359e14f3a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755056
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688751}

Eager Mode test requires different driver capabilities than other
ChromeDriverTest methods. Creating a second driver causes the test to
fail when run on Android. Moved the test to a new class with no
default setup to enable a custom setup without failing on  Android.

Bug: chromedriver:3016
Change-Id: I8dcbc267328a18bd75e91db8b04383834da49d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761609
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688750}

Precursor to https://chromium-review.googlesource.com/c/chromium/src/+/1759056

Windows-build now compiles with this.

@OWNERS: Please confirm that the ThreadPool was indeed the intended
destination for these tasks. Destination is becoming mandatory in parts
because some callsites erroneously assumed that the default set of
traits meant "current thread".

R=csharrison@chromium.org, thestig@chromium.org

Bug: 968047
Change-Id: I1f2c7b2fdb00de3dff7e3497d9318080ddfb04af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762450
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688749}

Add the `SetUserVerified` WebAuthn command to ChromeDriver.

This is one in a series of patches intended to create a Testing API for
WebAuthn, for use in Web Platform Tests and by external webauthn tests.

For an overview of overall design, please see
https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing

Bug: 922572
Change-Id: Ic5d64fae2abb48e21bf65cc1f9791e32cd184256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762701Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688748}

This patch ensures that we recalculate child visual overflow when laying out
flex children. Without this, there can be artifacts that appear
(see referenced bug).

R=eae@chromium.org, chrishtr@chromium.org

Bug: 981519, 993476
Change-Id: I7b6b4c6165bebed96a7135d7de3a5879304c9dee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762635
Commit-Queue: vmpstr <vmpstr@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Auto-Submit: vmpstr <vmpstr@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688747}

Generating result without full name will cause
DCHECK failure while printing results for tests not run.

Also replaced all DCHECKs with CHECKs.

Change-Id: I3bb9181e62c01255630d3004a074c9325b23e177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762693Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#688746}

This change updates Mojo::bindInterface() to use
BrowserInterfaceBrokerProxy if a script passes a new
"useBrowserInterfaceBroker" parameter.
Also converts an interceptor web test as a use case.

Bug: 985117
Change-Id: Ib4685210cf6c3cf2f371d69f5e12d85d6194904f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760026
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688745}

Bug: 900973
Change-Id: I67570ec7f0fcf7daa9bd1234d17ae5a9c9b9bf23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761634Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688744}

This change adds a SetBinderForTesting() method to
BrowserInterfaceBrokerProxy and modifies MojoInterfaceInterceptor to
call this new method if a script passes a new "useBrowserInterfaceBroker"
parameter.
Also converts IdleManager to use BrowserInterfaceBrokerProxy as a use
case for overriding interface handlers in web tests.

Bug: 985118
Change-Id: I8dc3fc1c4beb2ae375a2534b03cd890ce1e3b52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756480
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688743}

Change-Id: Id9c20b4f4c7f34e5d8e3670889703e87ad17fc45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762582Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@google.com>
Cr-Commit-Position: refs/heads/master@{#688742}

Another hopeful fix.

Bug: 969163
Change-Id: I797e2053d455b0d921ffdb5e6badac5c53135961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762793Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688741}

cr.icon.getFavicon previously took in a URL and used regex to determine
if the URL is a favicon or a site/page URL, but each caller already knows
if the URL is an icon or a page URL.

This is to ultimately be able to use this method for the WebUI tab strip
given a favicon URL and bypass the regex check since favicons out in the
web can technically be gifs, jpgs, data URLs, etc.

This CL also fixes an issue where favicon .ico/.png URLs had params added
at the end and were therefore not detected by the regex.

Bug: 989131
Change-Id: I999ccf7d75e4e2401d54e861c735487c33ee1bdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761327
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688740}

This adds operator<<(std::ostream&) overloads for <webauthn.h> types and
FIDO_LOGs for each call to the WebAuthNMakeCredential() and
WebAuthNGetAssertion() Windows API functions.

Change-Id: I8c70efbe7c91daeb11fe66871379d8f457a6681d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759224
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688739}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/35815c5fbd26..4bc8f4f7252c

git log 35815c5fbd26..4bc8f4f7252c --date=short --no-merges --format='%ad %ae %s'
2019-08-20 saklein@chromium.org TestService: Add cros_signing tests endpoint.

Created with:
  gclient setdep -r src/third_party/chromite@4bc8f4f7252c

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I1e367f338b3877e6989d3ef82cabb8e30a9b5639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688738}

Color of |vertical_label_minutes_| will be set through
TimeView::SetTextColorBasedOnSession at
https://cs.chromium.org/chromium/src/ash/system/time/time_view.cc?rcl=3886244ecee4d53af5684b966f679ba9c8838de9&l=115

No need to SetEnabledColor for it anymore.

Bug: 982950
Change-Id: I2d867f9e55c47c42d1ced5da52895bbb6b774857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762698Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688737}

Use FakeDisplaySnapshot::Builder to avoid the very-long argument list
for DisplaySnapshot.

Fix include-what-you-use.

Bug: none
Change-Id: I83f5f1d0a240c9e589d5de1baa6bd2159127a1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761445Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688736}

This is part of the flags experiment cleanup. We need this flag for a little longer.

Bug: 951392
Change-Id: I97b381c6d8eeb4ce6581b4d142c4f437447deaea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762530
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688735}