- 05 Nov, 2020 40 commits
-
-
Yuheng Huang authored
Doc: https://docs.google.com/document/d/1-1ijT7wt05hlBZmSKjX_DaTCzVqpxbfTM1y-j7kYHlc Usage: tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top10:2020 tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top50:2020 tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top100:2020 Change-Id: I684024f9cf3264ac2ed4feca15c6059342a493c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461224 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#824599}
-
Stefan Zager authored
During a BeginMainFrame(), LocalFrameView::UpdateAllLifecyclePhases will always be called while a DocumentLifecycle::AllowThrottlingScope is on the stack. Outside of a BeginMainFrame(), there are situations where we do a "force-unthrottled" lifecycle update, meaning that throttled frames are forced to run the update because there is no AllowThrottlingScope on the stack. We do this, for example, when performing a hit test that requires up-to-date layout, even in throttled frames. The thesis of this patch is: a force-unthrottled update should never paint. It may update the lifecycle to any state prior to paint, but it should not paint. This is an important axiom, because it enables a nice optimization: during a force-unthrottled update, a frame that would be throttled during a full, throttling-allowed update can skip paint invalidation. This is true because a force-unthrottled update *cannot* paint, so paint invalidation is unnecessary. This patch adds AllowThrottlingScope to LocalFrameView::UpdateAllLifecyclePhases, and it prevents side-channel violation of the only-paint-when-throttling-allowed axiom by adding this to LocalFrameView::UpdateLifecyclePhases: DCHECK(DocumentLifecycle::ThrottlingAllowed() || target_state < DocumentLifecycle::kPaintClean); The bulk of the code change is updating our test code to be more consistent with how we run lifecycle updates. In particular, any call to UpdateAllLifecyclePhases in test code should mirror, as closely as possible, the behavior of a full BeginMainFrame(), which means that LocalFrameView::RunPostLifecycleSteps() should also run. This patch adds LocalFrameView::UpdateAllLifecyclePhasesForTest(), and updates all call sites in test code to use it consistently. Finally, this CL cleans up the usage of AllowThrottlingScope, by removing unnecessary instances of it and getting rid of the DocumentLifecycle& parameter to the constructor, since it is unused. Change-Id: I64b6e19e983f5882e035824f995cb0bfc5f4e2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518095Reviewed-by:Yi Xu <yiyix@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#824598}
-
Javier Fernández García-Boente authored
The CSS Text 3 specification states on its 'Phase II: Trimming and Positioning' section: https://www.w3.org/TR/css-text-3/#white-space-phase-2 3- A sequence at the end of a line of collapsible spaces is removed, as well as any trailing U+1680 OGHAM SPACE MARK whose white-space property is normal, nowrap, or pre-line. 4- If there remains any sequence of white space and/or and/or other space separators, at the end of a line: If white-space is set to pre-wrap, the UA must hang this sequence. It may also visually collapse the character advance widths of any that would otherwise overflow. Summarizing, other space separator are not considered as collapsible spaces and should be hang, or broken in case of 'break-spaces', according to the value of the 'white-space' property. This CL tries to implement such behavior, since we were not considering this kind of spaces in the hanging/collapsing logic. For now this change affects LayoutNG only, but it'll be implemented for Legacy in a different CL. Bug: 972952 Change-Id: Idb0aff05f7f423f5b62f5169177c0240917435a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687411Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#824597}
-
Andre Le authored
Ensure we don't accidentally log PII by only logging the size. Bug: 1106937 Change-Id: I428ac50ea33b6bc5780fcf0fc47ca92cb151a612 Fixed: 1143033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522190 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#824596}
-
Dale Curtis authored
Finally got around to generating test media for this issue... and it looks like the original fix was incomplete! We didn't read the full box header before parsing CoLL and SmDm atoms. R=cassew Fixed: 1123430 Test: Updated unittest. Change-Id: I7aca462f623cd12cb4842c2cfa1b0b9758ba2ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518898 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Will Cassella <cassew@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824595}
-
Bo Liu authored
kWebViewEnableVulkan is renamed to kWebViewDrawFunctorUsesVulkan. It is set automatically when webview detects on start up that hwui is using vulkan composite. This flag is then passed to renderer and gpu processes. Add kWebViewVulkan and default to true, and add it to webview dev ui. This only takes effect if kWebViewDrawFunctorUsesVulkan is set, and controls whether to use gl interop or vulkan composite. So with this patch, the control is mainly in hwui. If hwui uses vulkan, then webview will use vulkan composite. But it also allows the user to manually fallback to gl-interop path. Also force enable skia renderer and viz if hwui uses vulkan. Bug: 1141683 Bug: 1141686 Change-Id: I53b7ae0da22884fab3cd1a401baec057c4eda241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513786 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824594}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e5e8e66e9b4f..a2d6b31f66f5 2020-11-05 ethannicholas@google.com Additional SkSL benches 2020-11-05 michaelludwig@google.com Use GrTBlockList instead of SkAutoSTMalloc to reduce GrAtlasTextOp size 2020-11-05 johnstiles@google.com Allow constant propagation for negated constant-vectors and ints. 2020-11-05 michaelludwig@google.com Compact fixed state tracked in GrAtlasTextOp 2020-11-05 fmalita@chromium.org [svg] Minor parser tweaks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: Ie75d6dea0f30a224c706d01c0157b76b183da114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824593}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c07bd2f23d7e..56ea854ec5e7 2020-11-05 lexa.knyazev@gmail.com Metal: Allow unswizzled BC1 RGB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I21110865b4ce509359c163a64b039795af0a50b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521634Reviewed-by:
-
Mason Freed authored
This CL implements most of the suggestions from [1], which effectively block declarative Shadow DOM from being used by any fragment parser entry point, unless an explicit opt-in is toggled. The opt-ins include: - DOMParser.allowDeclarativeShadowDom = true; - HTMLTemplateElement.allowDeclarativeShadowDom = true; - XMLHttpRequest.allowDeclarativeShadowDom = true; - DocumentFragment.allowDeclarativeShadowDom = true; - Document.allowDeclarativeShadowDom = true; // For innerHTML - A new <iframe> sandbox flag: allow-declarative-shadow-dom This mitigates the potential client-side XSS sanitizer bypass detailed in the explainer and at [1]. Assuming these changes are functional, and mitigate the issue, this new behavior will be folded into the spec PRs at [2] and [3]. But given the security implications of the existing code, I'd like to get this landed first. [1] https://github.com/whatwg/dom/issues/912#issue-733465826 [2] https://github.com/whatwg/html/pull/5465 [3] https://github.com/whatwg/dom/pull/892 Bug: 1042130 Change-Id: I088f28f63078a0d26e354a4442494c0132b47ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513525 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824591}
-
Liquan (Max) Gu authored
Changes: * PRService takes over PaymentAppFactoryDelegate, PaymentAppFactoryParams from CPRService. These two interfaces need to be moved together, otherwise it would be subjected to the use-after-close issue of CL[1]. * Removed @Nullable from PRService#mPaymentOptions because it's not possible to be null[2]. * Wrapped canUserAddCreditCard in supportPaymentSheetBasedPaymentApp, because "whether users can add credit card" is not at the same semantic level as other methods of PaymentRequestService. PRService knows about basic-card payment app, and CPR knows about whether users can add credit card on the basic card payment app. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2519759 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/payments/content/android/java/src/org/chromium/components/payments/PaymentRequestService.java;l=259;drc=df872ce8fcce25af51aa6b0f9fe8b1135b687524 Bug: 1146049, 1146051, 1145803 Change-Id: Ib02f9d15b4e0777e55d63770ec6f2b68b9fe6b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520277 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824590}
-
Daniel Hosseinian authored
Simultaneously, put existing event types in enums. Bug: 1134208 Change-Id: Ia4a3d7f6d03c0969b1f18961db0899a8a7f51b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512368 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#824589}
-
Luke Zielinski authored
wptMetadataBuilder for desktop wpt bots. This will give us a clearer picture of what the true status of tests are in preparation for triaging them. Bug: 1142905 Change-Id: If0dc015ef3f7633f209ca2bd2a94c55f8ee77c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503772Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824588}
-
Francois Beaufort authored
VideoCaptureDeviceFactoryAndroid was getting zoom support for each device every time when enumerating devices. This was problematic on some devices where opening a camera breaks existing stream for that camera. This CL adds cache of zooms in VideoCaptureDeviceFactoryAndroid. This allows to workaround the bug by getting zoom support only once for each device. Bug: 1138608, 934063 Change-Id: I52895ee5a538c44ce2ff53bc27714da88b9be54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517465 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824587}
-
Abigail Klein authored
caption bubble. If 5 seconds pass with no activity, hide the caption bubble. Activity is defined as one of the following occurring: - Transcription received from the speech service - User interaction, such as clicking a button or focusing the bubble More refinements to this will occur in a follow-up, such as clearing the caption text. Bug: 1055150 Change-Id: I33c96c09bc89bbfe68b1c8899f3aa5289ed44f76 AX-Relnotes: N/A (feature has not launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518129Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#824586}
-
Eugene But authored
According to Stability.iOS.UTE.MobileSessionAppState, a large number of Unexplained Termination Events happen in background. There is an assumption that "clean exit beacon" does not get written because prefs file is protected. This CL allows removing protection in the experiment. The experiment will be run on Canary and Dev to test the assumption. There is no intention to roll this out to Beta or Stable. If experiment will confirm the assumption, then clean exit beacon file will be decoupled from prefs to remove the protection. Bug: None Change-Id: If816c4b3ed28ba5b2649e63526d5cfea93f839c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506175Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#824585}
-
dpapad authored
In preparation of moving all IDR_WEBUI_JS_* resources to webui_generated_resources.grd, the new webui_generated_resources.pak file needs to be included in fuchsia/engine/. Bug: 1132403 Change-Id: I5c762bb01d30401866b266f9b9c374636e78ec69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521841 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824584}
-
Chong Gu authored
Add fuchsia-board-astro tag. Apply tag to flaky/failing tests. Bug: 1080853 Change-Id: If2c42204b690ac8b6ccf3e47d2edea91e73ef622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520719Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#824583}
-
Scott Violet authored
When history adds a page with redirects the transition qualifier is not applied to redirects. This resulted in FROM_API_3 being dropped, and pages that should be hidden being shown. This patch adds FROM_API_3 to CHAIN_END if FROM_API_3 was present in the requested transition. It's only necessary to add for CHAIN_END, as CHAIN_END must be present in order for the visit to be considered visible. BUG=1145208 TEST=HistoryBackendTest.AddPageWithRedirectsAndFromApi3IsNotVisible Change-Id: I4ac41e5385fe58b249532f1251612b6c1112005b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521833 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824582}
-
Allen Bauer authored
Add metadata - remove manually overridden GetClassName. Add view builders and update view tree construction to use the builder. TBR=katie@chromium.org Bug: 772945, 938501, 1130078 Change-Id: Id105b26afb15138ee6e70e7ade5e43be11671a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505880Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#824581}
-
Daniel Cheng authored
Bug: 1131879 Change-Id: I12e46e7c7edcbf41a6c51b5f2210a3eaed1412ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521872Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#824580}
-
Ben Pastene authored
crrev.com/i/3385048 allocates the machines for these builders, so this can't land until that is deployed. Bug: 1140727 Change-Id: Ib09a59fdfd0aa4bba54a091606c08f76b59c48f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521352Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#824579}
-
Evan Stade authored
Bug: 1144109 Change-Id: I2b61d941b7538cbb504e2b8bab87b9ff2091169a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520201Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#824578}
-
Mitsuru Oshima authored
Bug: None Change-Id: I0235c23d4bb1664d1e701b54dfe196d36cc473db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521200 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#824577}
-
Lijin Shen authored
More unit tests of message queues so that delegate methods are called as expected. Bug: 1123947 Change-Id: Ibc23469925bd68cce19b126f4cc395bcc0877789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505745 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#824576}
-
Regan Hsu authored
* Indents subfeatures. * Clicking on the row of editable features that don't link to a subpage will cause the feature to toggle. Specs: https://carbon.googleplex.com/cros-ux/pages/phone-hub/settings Screenshots: https://screenshot.googleplex.com/3qpNqzYoNvdL8dN https://screenshot.googleplex.com/5ejywFFaUtfetrF Fixed: 1141609 Bug: 1106937 Change-Id: I342aa77a067b4301f3d676177bfa920ae86a385b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518424 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0c27a3cfcc80030ca5ff83e7e6f136fb4f8d378d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521045Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#824574}
-
Clark DuVall authored
In some cases, a library with the name we want will be present in a system directory such as /system/product/lib. The isolated split class loader will then "find" the lib there and return it. To get around this, first we check for libs with the base class loader, then fallback to ContextUtils.getApplicationContext() class loader if it's not found. Bug: 1126301 Change-Id: I551b6a59c75711bdf6cccae0dde8d7c658eff0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521293 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824573}
-
Piotr Bialecki authored
Change-Id: I82cc7d33ec13eff0e036cb346af40cc25f29a755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521289 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#824572}
-
Christopher Cameron authored
Use IOSurfaceAlignProperty to align the following properties: - kIOSurfacePlaneBytesPerRow - kIOSurfacePlaneSize - kIOSurfacePlaneOffset - kIOSurfaceBytesPerRow - kIOSurfaceAllocSize Clean up the structure of CreateIOSurface by merging the two "if (num_planes > 1)" branches. Bug: 1134712 Change-Id: Ib5d7c936b5f21359657af4f27f78fb1eca1d14e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518763Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#824571}
-
Gary Tong authored
Bug: 1144980 Change-Id: I892abaaf83429269c325b4bf27d836fe29f49f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517990Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#824570}
-
Gavin Williams authored
When selected in the select dialog, 'My files' returns the path "/home/chronos/u-..../MyFiles" and Google Drive 'My Drive' returns the path "/media/fuse/drivefs-..../root". When either of these two directories are selected, return the preferred display name to the UI. Bug: 1059779 Change-Id: Ic67a666d5c8948b0ffa30eef25fad39712d96ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511209Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
Bug: None Change-Id: Iab090de501e3589e93b05c08a7d07bd4356ad4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520381 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824568}
-
Francois Doray authored
This CL adds a UKM which counts "pageloads" by type for each top-level. document. This will be used to diagnose changes to the "total pageloads" shown on stability dashboard. UKM review: https://docs.google.com/document/d/1Nd5sKBdsq_sBqZ03OaWVBEloo4RGA00k_msYatkiV_0/edit?usp=sharing Bug: 1075553 Change-Id: Ieadcd6b92eee371a695ebf9af1c8f0bce371d68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508441 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#824567}
-
Elly Fong-Jones authored
Per the waterfall launch plan for this feature. Bug: 1138688 Change-Id: I9a8bacae2ebc6d45aa243835e4124c41c4271117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521099 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#824566}
-
Stephen McGruer authored
Bug: 1124430 Change-Id: I69b3f9de37b1331feb8e4bf0462c22e9b2b2a2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521204Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#824565}
-
Xing Liu authored
This CL sets up the class structure for bookmark bottom sheet. Details will be added in following CLs. A instrumentation test is also added, which only contains a simple test to check the bottom sheet opened with a title text view. Bug: 1128074,1133496 Change-Id: I02d7a488ffa46e9ee4f6993003dfade8e7fbb3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473078 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#824564}
-
Sigurdur Asgeirsson authored
This moves users of ScopedObserver to either base::ScopedObservation or base::ScopedMultiSourceObservation in the performance_manager. Bug: 1145565 Change-Id: Ide766fc0139134ebc6f9cdfff58864fccb1b78f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520246 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#824563}
-
Samuel Huang authored
Previously, generate_commit_size_analysis.py takes: * --apk-name for SuperSize "main file" input (.apk or .minimal.apks). * --mapping-name for "mapping file" input. This worked fine for Monochrome. However, for Trichrome, the SuperSize "main file" is now an .ssargs file that specifies 3 "container files", which for Monochrome, coincided with the "main file". To centralize the specification of all these files from BUILD files, we define "size config JSON" file to specify the following: * Mapping files (as a list). * Arguments to be passed to resource_sizes.py (which already supports Trichrome). * Supersize main file, which can be {.apk, .minimal.apks, .ssargs}. * Version numeric string (for late ruse). This CL adds size config JSON support. Details: * Add GN template "android_resource_size_config" to specify size config JSON files. Files are generated during "gn gen", and written to config/ under Chromium output dir. * Add GN targets to generate size config JSON files for Monochrome and Trichrome * resource_size_config_monochrome_public_minimal_apks -> config/MonochromePublic_size_config.json * resource_size_config_trichrome -> config/Trichrome_size_config.json * In generate_commit_size_analysis.py: * Add --size-config-json to specify size config JSON path. * If specified, the file is copied to the staging dir. * If the "main file" is .ssargs, then it's also copied to the staging dir. * Add Trichrome support to call resource_sizes.py * In trybot_commit_size_checker.py: * Add --size-config-json-name to specify size config JSON *filename*, which will be searched in {before, after} dirs. * If specified, "mapping files" are directly extracted from the size config JSON files for "ForTest" symbol extraction. * This will replace the --apk-name argument. With this CL, size config JSON files and supports are available but unused. Usages will be added in follow-up work. Bug: 1040645 Change-Id: Ie3328ac413af3a15cd1cbb0957881da7d2d1f839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518126 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Andrew Xu authored
This CL does two things: (1) Ignore the MenuItemView instance in accessibility events handling. Then we can customize accessibility behaviors of the multipaste menu in ClipboardHistoryItemView class. (2) When the delete button gets the pseudo focus, the accessibility side is notified. Bug: 1145773 Change-Id: Ibd73b04637b89cc8200ca2f74721a10a44e857c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513502Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824561}
-
Chan Li authored
Re-enable the experiment on try builders, because: - led issue (crbug.com/1141272) has been fixed - web test runner/sink integration makes blink_web_tests on win builders slow issue (crbug.com/1141606) has been worked around - now blink_web_tests are handled be result_adapter. Bug: 1108016 Change-Id: I9cacc5da63f4197ce6c22d9fa3181ee65375e14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521834Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824560}
-
