GitLab

chrome/browser/master_prefs.mm reads the user master prefs file
from ~/Application Support/Google/Chrome, not ~/AS/Google. Found
by Mike Graboski!

BUG=128462

Review URL: https://chromiumcodereview.appspot.com/10836274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151768 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151765 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151764 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the behavior of the web notification tray with launcher auto-hide.
It also fixes visibility of the web notification tray in the lock screen.

BUG=142506

Review URL: https://chromiumcodereview.appspot.com/10834338

TBR=stevenjb@google.com
Review URL: https://chromiumcodereview.appspot.com/10854175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151763 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/142962
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151762 0039d316-1c4b-4281-b951-d872f2087c98

- Modified chromoting.py to enable me2me automation
- Added chromoting_helper.py to handle install, uninstall, enable, disable, changepin which requires admin privilege
- Added chromoting.base.py as the base for all chromoting test cases
- Modified chromoting_basic, renamed it it2me_basic and moved it under chromoting dir
- Added auth, me2me_enable, me2me_connect test
- Added a cert and a private key for signing host on mac
- Added mock_pref_pane.* files to mock the pref pane for different scenarios


NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151717

Review URL: https://chromiumcodereview.appspot.com/10821015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151760 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134929

Review URL: https://chromiumcodereview.appspot.com/10828166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151758 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130206

Review URL: https://chromiumcodereview.appspot.com/10828198

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151755 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141281

Review URL: https://chromiumcodereview.appspot.com/10855182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151754 0039d316-1c4b-4281-b951-d872f2087c98

Some video capture device has odd number for width/height. Need to chop them to even number.

BUG=139004
Review URL: https://chromiumcodereview.appspot.com/10837225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151753 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the behavior of the web notification tray with launcher auto-hide.
It also fixes visibility of the web notification tray in the lock screen.

BUG=142506

Review URL: https://chromiumcodereview.appspot.com/10834338

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=jhorwich

Review URL: https://chromiumcodereview.appspot.com/10829347

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151751 0039d316-1c4b-4281-b951-d872f2087c98

Original review: http://codereview.chromium.org/10442098/

BUG=113993
TEST=./net_unittests --gtest_filter=AddressSorter*:HostResolverImplDnsTest.DnsTaskUnspec

Review URL: https://chromiumcodereview.appspot.com/10855179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151750 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140317
TEST=compiles, tests pass.
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827358

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151749 0039d316-1c4b-4281-b951-d872f2087c98

We are seeing significant fraction of DnsTransactions failing with
DNS_SERVER_FAILED but can't tell if it's a socket error or an actual
response from the server.

BUG=142918

Review URL: https://chromiumcodereview.appspot.com/10830338

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151748 0039d316-1c4b-4281-b951-d872f2087c98

* Move GDataDirectoryService declaration, definition and related classes, structs, constants, etc to gdata_directory_service.h, .cc.
* Split unit test into gdata_directory_service_unittest.cc
* For now, gdata_directory_service.h includes gdata_files.h. Change all includes of gdata_files.h to include gdata_directory_service.h instead. Very soon, gdata_files.h will be removed from gdata_directory_service.h, and only included as needed. We will eventually deprecate gdata_files.h/.cc entirely and use GDataEntryProto and friends.
* Some #includes are redundant. These will be sorted out in a future patch.

BUG=140317
TEST=compiles.
TBR=ben@chromium.org (for gypi changes)
Review URL: https://chromiumcodereview.appspot.com/10827343

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151747 0039d316-1c4b-4281-b951-d872f2087c98

Memcheck:Leak
   fun:_Znw*
   fun:_ZN3ash27DesktopBackgroundController16InstallComponentEPN4aura10RootWindowE
   fun:_ZN3ash27DesktopBackgroundController29InstallComponentForAllWindowsEv
   fun:_ZN3ash27DesktopBackgroundController29SetDesktopBackgroundImageModeEv
   fun:_ZN3ash27DesktopBackgroundController20CreateEmptyWallpaperEv
   fun:_ZN3ash12_GLOBAL__N_126DummyUserWallpaperDelegate19InitializeWallpaperEv
   fun:_ZN3ash5Shell4InitEv
   fun:_ZN3ash5Shell14CreateInstanceEPNS_13ShellDelegateE
   fun:_ZN3ash4test11AshTestBase5SetUpEv

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/12953

BUG=141563, 141676, 142042

Review URL: https://chromiumcodereview.appspot.com/10854153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151746 0039d316-1c4b-4281-b951-d872f2087c98

This prevents the script from failing on 32-bit Ubuntu where the 32-bit
compat packages don't exist.

BUG=138234

Review URL: https://chromiumcodereview.appspot.com/10825369

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151745 0039d316-1c4b-4281-b951-d872f2087c98

r151720 sadly, but unavoidably, pulled in zlib. This change
updates our size expectations to reflect this.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151742 0039d316-1c4b-4281-b951-d872f2087c98

This makes ChromeOS more consistent with Linux, which uses the DISTRIB_DESCRIPTION from /etc/lsb-release here.  We have a different pre-existing mechanism in the code for reading the value (since ChromeOS doesn't have the lsb_release tool), but it's conceptually the same thing.

This makes it possible to search / catagorize ChromeOS crash reports based on the build, or other information about the ChromeOS version.  It also allows the matching build/symbols to be more easily found given a crash report.

There's no need for Aura customization of distro anymore - that was added when
Aura was experimental.  All ChromeOS is now Aura.

BUG=142630


Review URL: https://chromiumcodereview.appspot.com/10827322

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151741 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141533
TBR=scherkus@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830342

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151740 0039d316-1c4b-4281-b951-d872f2087c98

PNaCl is installed.

How it looks with pnacl enabled:
http://www.corp.google.com/~jvoung/with-pnacl.png

and without pnacl enabled:
http://www.corp.google.com/~jvoung/without-pnacl.png

BUG= 114444
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2813

Review URL: https://chromiumcodereview.appspot.com/10823214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151739 0039d316-1c4b-4281-b951-d872f2087c98

Resolves missing or relative suggested paths relative to the last opened directory, and when the path is a directory itself, browse files under it rather than itself under its parent.  Determining the latter takes a file system interrogation because the syntax isn't sufficient.

BUG=140799

Review URL: https://chromiumcodereview.appspot.com/10697010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151738 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10827334

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151737 0039d316-1c4b-4281-b951-d872f2087c98

We could just add a parameter to a similar test, but I think most of them have enough parameters already, and this keeps it simpler.

BUG=137764


Review URL: https://chromiumcodereview.appspot.com/10854046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151735 0039d316-1c4b-4281-b951-d872f2087c98

Fix race condition with windowless plugin buffers. The problem, which is already fixed for Mac, is that the buffers can be deleted during a paint because of a resize during an NPN_Evaluate call. So keep a local reference.

BUG=139462
Review URL: https://chromiumcodereview.appspot.com/10855141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151734 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137351
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10824300

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151732 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151731 0039d316-1c4b-4281-b951-d872f2087c98

This was causing build failures on the Win2008 dbg builder.
http://chromesshgw.corp.google.com/i/chromium/builders/Win%20Builder%202008%20%28dbg%29/builds/4501


r1464: Use flock-style lock on Windows to limit number of concurrent links
r1465: Fix usage of shlex in unit tests on windows.
r1466: Fixes an issue where OutputDirectory and IntermediateDirectory were
       being incorrectly generated without a trailing slash on MSVS 2008.
r1467: This makes it easier to test combinations of msvs version without having
       to muck with environment variables
r1468: Fix the Android Eclipse CDT generator.
r1469: Prepend 'call' to all non-cygwin commands to prevent incredibuild from
       aborting the scripts early.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10836254

TBR=newt@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:12316


Review URL: https://chromiumcodereview.appspot.com/10854146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151728 0039d316-1c4b-4281-b951-d872f2087c98

The flag was there to make checking of inner classes optional
until all inner classes could be fixed.

We must still parse the flag until this has been rolled in and
plugin_flags.sh has been updated not to pass in the flag anymore.

BUG=136863


Review URL: https://chromiumcodereview.appspot.com/10837254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151727 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dhollowa
BUG=137223
TEST=unit_tests pass.

Review URL: https://chromiumcodereview.appspot.com/10825367

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151726 0039d316-1c4b-4281-b951-d872f2087c98

The new test fails on some bots:
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20ASAN%20Tests%20%281%29/builds/992/steps/browser_tests/logs/stdio
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%281%29/builds/1195/steps/browser_tests/logs/stdio

The smoke test is simple - it checks that Chrome can load nexes.  The more
interesting part of this CL is that it lays the groundwork for adding more NaCl
tests to browser_tests.  This will allow many nacl_integration tests to be
rewritten as browser_tests.  This CL adds an extensible jig for decoding
messages from Javascript, which makes it easier to add test logic in the web
page.  This CL also establishes locations in the build directory for nexes and
other test data.

There are two followup CLs planned: 1) simplify how nexes are built in GYP
and 2) share the code for running tests in Javascript with the PPAPI test
suite.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959
TEST= browser_tests --gtest_filter=NaClBrowserTest*


Review URL: https://chromiumcodereview.appspot.com/10837207

TBR=ncbray@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827356

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151724 0039d316-1c4b-4281-b951-d872f2087c98

Don't use NSDistributedLock, which uses a lock that isn't cleaned up on
unexpected program termination, and which strongly recommends to not
call -breakLock (which makes this class fairly pointless).

Instead, use a flock(), which is cleaned up by the OS on process exit.
Suggested by shess@.

BUG=141108

Review URL: https://chromiumcodereview.appspot.com/10823329

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151723 0039d316-1c4b-4281-b951-d872f2087c98

- Modified chromoting.py to enable me2me automation
- Added chromoting_helper.py to handle install, uninstall, enable, disable, changepin which requires admin privilege
- Added chromoting.base.py as the base for all chromoting test cases
- Modified chromoting_basic, renamed it it2me_basic and moved it under chromoting dir
- Added auth, me2me_enable, me2me_connect test
- Added a cert and a private key for signing host on mac
- Added mock_pref_pane.* files to mock the pref pane for different scenarios


NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10821015

TBR=yihongg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151722 0039d316-1c4b-4281-b951-d872f2087c98

Unlike Seek(), calling Start() while running is a clear programmer error. If the pipeline did stop running and you called Start() again, make sure to no-op inside StartTask().

Review URL: https://chromiumcodereview.appspot.com/10857018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151721 0039d316-1c4b-4281-b951-d872f2087c98

(This is a reland of r151502, which was reverted in r151517 because it
broke the Linux Official build.)

This may break the Official build for a brief window while a two-sided
patch lands.

BUG=139744

Review URL: https://chromiumcodereview.appspot.com/10837057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151720 0039d316-1c4b-4281-b951-d872f2087c98

- Modified chromoting.py to enable me2me automation
- Added chromoting_helper.py to handle install, uninstall, enable, disable, changepin which requires admin privilege
- Added chromoting.base.py as the base for all chromoting test cases
- Modified chromoting_basic, renamed it it2me_basic and moved it under chromoting dir
- Added auth, me2me_enable, me2me_connect test
- Added a cert and a private key for signing host on mac
- Added mock_pref_pane.* files to mock the pref pane for different scenarios


NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10821015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151717 0039d316-1c4b-4281-b951-d872f2087c98

The smoke test is simple - it checks that Chrome can load nexes.  The more
interesting part of this CL is that it lays the groundwork for adding more NaCl
tests to browser_tests.  This will allow many nacl_integration tests to be
rewritten as browser_tests.  This CL adds an extensible jig for decoding
messages from Javascript, which makes it easier to add test logic in the web
page.  This CL also establishes locations in the build directory for nexes and
other test data.

There are two followup CLs planned: 1) simplify how nexes are built in GYP
and 2) share the code for running tests in Javascript with the PPAPI test
suite.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959
TEST= browser_tests --gtest_filter=NaClBrowserTest*


Review URL: https://chromiumcodereview.appspot.com/10837207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151716 0039d316-1c4b-4281-b951-d872f2087c98

Removing temporary code put in place to allow WK92278 to land.


Review URL: https://chromiumcodereview.appspot.com/10854081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151715 0039d316-1c4b-4281-b951-d872f2087c98