- 11 Sep, 2019 34 commits
-
-
Caleb Rouleau authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=733612#c6 for details. Also add tests both for windows and non-windows. Bug: 733612 Change-Id: Id656635a5fc79ea8f805658873599b526e764406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796572Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#695429}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dbca865e55f7..d207f492cae8 git log dbca865e55f7..d207f492cae8 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d207f492cae8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I659da31fb3e1b3cd421f9adfa0478197af0d2709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695428}
-
Yue Li authored
Move native Assistant related enums and interfaces to assistant_state_controller.mojom Rename VoiceInteractionState to AssistantState and update enum descriptions and names. Keep the original VoiceInteractionState definition to match the arc side interface. (Will remove once the arc side dependency is fully deprecated) Bug: b/138679823 Test: Run existing tests Change-Id: I9dd1c5c41714971d0597c12fc8c96ed4a6ea5750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793929 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695427}
-
Karen Qian authored
Bug: 996624 Change-Id: Ibdaf0267017ff652431822bd53bf1d982b254401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795757Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Karen Qian <karenqian@google.com> Cr-Commit-Position: refs/heads/master@{#695426}
-
Darren Shen authored
We assumed that autocap flag would always be explicitly set to something, but turns out native textfields omit the flag entirely, so we remove the NOTREACHED check. TBR=shuchen@chromium.org Bug: 1002713 Change-Id: Ifab485d978282f80b92fe631bb8dc30976afb175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797507Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#695425}
-
Matt Mueller authored
Although keys < 2048 bits are considered weak on 10.15, they do not cause the certificate to be considered invalid like < 1024 bit keys. Bug: 998845 Change-Id: I9194b364b8da97a5cead791daedc05ab61bba2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794302 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695424}
-
Austin Eng authored
Bug: dawn:153 Change-Id: Icf184299866a54b170a1ef3558bcc4e2bf1fcc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790384 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#695423}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/369f46e37423..38ad70f364e7 git log 369f46e37423..38ad70f364e7 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 rmhasan@google.com [Telemetry] Add sierra and highsierra to telemetry's set of typ tags Created with: gclient setdep -r src/third_party/catapult@38ad70f364e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:999335 Change-Id: I1437de73c1ab8f3e83f9af56427a6471da22ae8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797328Reviewed-by:
-
Maksym Onufriienko authored
Since XC11 new bundle file format to extract data need to use command `xcresulttool export --type directory --id DIAGNOSTICS_REF --output-path /export_folder --path ./RB.xcresult` Data will be stored in %xcresult%_diagnostic folder Bug: 978929 Change-Id: I1c7a76d24a88350409be8800bb9e3086af4d456d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761190Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695421}
-
Bettina authored
Bug: 999369 Change-Id: Idd673b572d979815d5bf15ff020d743af4eba86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796887 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#695420}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f637a9deab9..cac3effba788 Created with: gclient setdep -r src-internal@cac3effba788 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iea7ceac511bc7e94b811062b4702499c1889e4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695419}
-
Miyoung Shin authored
This CL converts LocalMuterAssociatedRequest and StreamFactoryPtr in content to the new Mojo types. Bug: 955171 Change-Id: I08356dd12197b7db14730f7045da0b1742e69804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786891Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#695418}
-
Simon Que authored
Reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1792505 Changes in reland: migrate correct builder instead of linux-gcc-rel. Migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 ======== Original CL contents ========== This was previously reverted due to reaching the Goma RBE server capacity limit. https://chromium-review.googlesource.com/c/chromium/src/+/1786872 The limit has since been increased. Bug: 1001231,950413 Change-Id: Ie036dd49599f0e2ee8695b363958d87396cfb465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792584Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#695417}
-
Tommy Steimel authored
This CL adds an X button to the sessions in the Global Media Controls dialog (when paused) that dismisses the session from the dialog. This also updates the MediaNotificationContainer API to receive MediaSessionInfo updates and foreground color updates so that we know when to show the button and what color to make it. Bug: 1001302 Change-Id: Ia14df4cbefc39feb28e275d6a483a02415b66cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787595 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#695416}
-
Matt Mueller authored
10.15 adds two certificate requirements that were tripped by the cert generated for this test: * validity period must be 825 days or less. * must specify ExtendedKeyUsage. See https://support.apple.com/en-us/HT210176 Bug: 1001601 Change-Id: Id4b77f4b0df726e704e7ddcffe0b1c9ae4cf11cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796743Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#695415}
-
Tao Bai authored
Added IsPrerender() in PageLoadMetricsEmbedderInterface, so we can decouple prerender from page_load_metrics implementation. Bug: 995880 Change-Id: I5088afc7a80f3a050e09f1a827a1d80767a41f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796314Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#695414}
-
Theresa Wellington authored
- AlwaysDismissedDialog - AccessibleTextView - BoundedLinearLayout - AlertDialogEditText - DualControlLayout - FadingEdgeScrollView - LoadingView - VerticallyFixedEditText BUG=951455 Change-Id: I41793adba0bb869ba849c6c58e7035b9ab9674ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795758Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#695413}
-
Xing Liu authored
For a few failure cases, we should invoke the ScheduleCallback and reports a failure in ScheduledNotificationManager. Bug: 998998 Change-Id: I22e623001412007e05d7788d15267992b5c9ab11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797138Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695412}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/619935f7f249..f35dcfe60a62 git log 619935f7f249..f35dcfe60a62 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 enga@chromium.org Implement ErrorScopes for synchronous errors Created with: gclient setdep -r src/third_party/dawn@f35dcfe60a62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I438f25ffd086bfbfcb02a2d27345d9b48604499f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797323Reviewed-by:
-
Dominik Röttsches authored
Define HAVE_ROUNDF according to recommendations in https://github.com/harfbuzz/harfbuzz/pull/1953#issuecomment-527424349 https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/bbad1b829812..170b5dd856b1 $ git log bbad1b829..170b5dd85 --date=short --no-merges --format='%ad %ae %s' 2019-09-08 behdad [aat] Minor 2019-09-08 behdad [aat] Minor 2019-09-09 ebrahim [number] Add static to hb-number-parser.hh functions 2019-09-09 ebrahim [number] Optimize _pow10 constants (#1963) 2019-09-08 behdad Change HB_VAR_ARRAY to 1 again 2019-09-07 ebrahim [number] Add overflow checks used to be done in parse_bcd 2019-09-06 ebrahim Replace strtod with a ragel implementation 2019-09-07 ebrahim Minor, remove unused header 2019-09-06 behdad [kerx] Fix offset issue in kern format 2 2019-09-06 behdad Change HB_VAR_ARRAY from 1 to 0 2019-09-06 behdad Rename VAR to HB_VAR_ARRAY 2019-09-06 behdad Fix a few struct size declarations 2019-09-06 razrfalcon Remove duplicated tests from test-ot-tag (#1958) 2019-09-06 behdad Revert "[null] Silence undefined-behavior complaints with too-small null bytes" 2019-09-06 behdad [null] Silence undefined-behavior complaints with too-small null bytes 2019-09-01 behdad [subset] Use newer iter tools in SinglePosFormat1 2019-09-01 behdad [iter] Partialize hb_zip() 2019-09-01 behdad Minor 2019-09-04 ebrahim Use roundf to fix cast to int difference of msys2 w64 2019-09-04 ebrahim Check roundf availibity in autotools 2019-09-04 ebrahim Use hb_parse_double in CFF::dict_opset_t::parse_bcd 2019-09-04 ebrahim [number] Turn hb_parse_float into hb_parse_double 2019-09-03 ebrahim [number] Add whole buffer check and test it 2019-09-03 ebrahim Don't check null terminaion of source in hb_codepoint_parse 2019-09-03 ebrahim [test] resolve msvc complain on signedness comparing 2019-09-03 ebrahim Use hb_parse_uint in deserializer token parser 2019-09-03 ebrahim [number] Add test 2019-09-03 ebrahim [number] Minor tweak on parser related codes 2019-09-03 ebrahim [number] Remove parsing code duplication of the calls using lambda 2019-09-03 ebrahim Move hb_codepoint_parse to hb_parse_uint 2019-09-03 ebrahim Merge and aggregate number parsing logics to form hb-number 2019-09-03 ebrahim Fallback if roundf didn't exist, like in dietlibc (#1953) 2019-09-02 ebrahim Revert in-house pow10 (d80a3ea) and fix oss-fuzz/16922 2019-09-02 ebrahim [subset] Use internal API of hb_set_t 2019-09-02 ebrahim [subset] Run once for a tag 2019-09-01 khaledhosny [ft] Prefer symbol cmap subtable if found (#1948) 2019-09-01 ebrahim [editorconfig] Treat Ragel files also as C sources 2019-09-01 ebrahim [cff] Implement in-house power of 10 2019-09-01 ebrahim Don't allow reference blob be accessed using empty tag in hb_face_reference_table (#1947) 2019-08-31 behdad [iter] Simplify hb_chop() 2019-08-31 behdad [iter] Add hb_chop() 2019-08-31 behdad [iter] Add hb_take() specialization for arrays 2019-08-31 behdad [iter] Add hb_len() 2019-08-31 behdad [iter] Add hb_take() 2019-08-31 behdad [iter] Make iota() accept invokable for increasing to next item 2019-08-30 behdad [algs] Fix hb_inc/dec signature 2019-08-30 behdad [iter] Add hb_repeat() 2019-08-30 behdad [iter] Remove some && 2019-08-30 behdad [iter] Use hb_ridentity instead of lazy + 2019-08-30 behdad [iter] Separate hb_iota implementation from hb_range 2019-08-30 behdad [iter] Rename 2019-08-30 behdad [algs] Add hb_inc() and hb_dec()) 2019-08-30 behdad Revert "[array] Add chop()" 2019-08-31 ebrahim [subset] minor 2019-08-29 behdad [array] Add chop() 2019-08-29 behdad [iter] Change item_size to get_item_size() 2019-08-29 behdad [array] Add truncate() method 2019-08-29 behdad [array] Use injected class name more 2019-08-29 behdad Minor 2019-08-29 48925186+qxliu76 bug fix in optimizing coverage table format (#1942) 2019-08-29 behdad [subset] in SingleSubst subsetting, check for substitute in glyphset 2019-08-29 ebrahim [gsub] Fix clang's semicolon complains 2019-08-29 ebrahim [test] Avoid alloca use as clang complain 2019-08-29 ebrahim [subset] Don't allow malicious fonts to insert unlimited table headers 2019-08-28 behdad [subset] Implement AlternateSubst subsetting 2019-08-28 behdad Minor 2019-08-28 behdad [subset] Implement MultipleSubst subsetting 2019-08-28 behdad [GSUB] Use dagger in Ligature::intersects() 2019-08-28 behdad Minor 2019-08-28 behdad Rename 2019-08-28 behdad [subset] Subset ligature substitutes! 2019-08-28 behdad Beef up HeadlessArrayOf<> 2019-08-28 behdad Add ArrayOf::pop() 2019-08-28 behdad Add arithmetic operators to IntType<> 2019-08-28 behdad [debug] Minor 2019-08-28 behdad Add ArrayOf::serialize_append 2019-08-28 adrianwjw Adjustments to the generated Indic table output (#1936) 2019-08-27 ebrahim Use hb_bytes_t as<T> in hb_blob_t 2019-08-27 ebrahim [glyf] Move GlyphHeader::from_bytes to hb_bytes_t, introduce .as<T> () 2019-08-27 ebrahim [glyf] Revert the way indexToLocFormat is set 2019-08-27 ebrahim [subset] Remove subset table size assertion 2019-08-24 ebrahim Turn 8 spaces to tab across the project 2019-08-25 ebrahim [subset] Raise the bar in new vs old table size 2019-08-25 ebrahim [glyf] minor 2019-08-25 ebrahim [glyf] Move GlyphHeader size checking to a static method 2019-08-24 ebrahim [glyf] Move GlyphHeader related logics to its, making its fields protected 2019-08-24 ebrahim [glyf] format source 2019-08-24 ebrahim [subset] Consider instruction length place itself 2019-08-23 ebrahim [subset] Fail on table grow more than 16x+4096 2019-08-23 ebrahim [subset] Fix blob leak of _subset2 when returns early 2019-08-23 behdad [debug] Fix extra semicolon issue 2019-08-23 behdad Whitespace 2019-08-23 behdad [debug] Fix build with HB_DEBUG 2019-08-23 khaledhosny [doc] Update list of default features in the manual 2019-08-22 behdad 2.6.1 2019-08-21 behdad [ot-font] Prefer symbol cmap subtable if found 2019-08-21 ebrahim Remove hb_directwrite_shape_experimental_width public API 2019-08-20 behdad [test] Add test for aaa85931f3542639cd9d0dfb92fd6baab5b0298d 2019-08-20 behdad [font] Update multipliers when creating sub_font Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: I658578a297968bfdb5f7069ae86bae00cd92031c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795003 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Behdad Esfahbod <behdad@chromium.org> Reviewed-by:
Behdad Esfahbod <behdad@chromium.org> Cr-Commit-Position: refs/heads/master@{#695410}
-
Alex Gough authored
This will eventually support a chrome://sandbox WebUI for Windows. Adds PolicyList and PolicyInfo types, the GetPolicyInfo() interface to the sandbox (broker) and a basic implementation which simply returns an empty list. The intention is that GetPolicyInfo() will be called on a low priority thread, and will then wait until the tracking thread can complete the work of cloning policy information before returning. PolicyInfo is merely stubbed out at the moment and will be expanded to describe more of the policy once this gets plugged into the webui later. Change-Id: Ie6ea8180e26ad71fa9e1628a2e9eef8f46a93fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756952 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#695409}
-
Kurt Horimoto authored
A presentation context cannot present a view controller until its coordinator's view has been added to a window. However, overlay UI supported using child view controllers can be presented immediately. This is preferable to waiting for the context to have a window because the |-didMoveToWindow| signal is sometimes received later than expected after a transition animation, allowing for a flicker between when the view is visible and when overlay UI can be presented upon it. This CL adds support for OverlayRequestCoordinators implemented using child view controllers to be presented immediately, rather than waiting for the view to be added to the window. This is tracked by an activation state enum that is updated according to the context's coordinator's presentation capabilities. This means that now a presentation context's coordinator is set the entire time the coordinator is started, and signals from its view moving to a new window are used to update the state. Follow-up CLs will update alerts in OverlayModality::kWebContentArea to use child view controllers where we have more control over the presentation style. Bug: 1001235 Change-Id: If6a016a42fe9f1478fdd034b4457790c98a0870c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787562Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#695408}
-
Ahmed Fakhry authored
This CL implements the new specs of the mini_views and the new desk button borders, which are designed to have a gap between the view's contents and the border so it's more obvious against white/light contents or background. Only the active, highlighted, or hovered-over mini_views will have borders. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=996490#c9 BUG=1001230, 996490 TEST=Manually Change-Id: Iedd05a55ec36b9c6193c80f36e1d0d252ef93412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796112 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#695407}
-
James Cook authored
The row is sometimes clickable, depending on whether you are looking at browser vs. OS settings, and whether ChromeOSAccountManager is enabled or not. When it is clickable, ensure the <div> elements are "actionable" so we get the right cursor. Also fix a problem where the avatar icon wasn't clickable in the OS settings people section. Screenshot from Chrome OS showing actionable row in OS settings: https://screenshot.googleplex.com/ygC6Bn208dB Screenshot from Linux (unchanged): https://screenshot.googleplex.com/efW97d7diRY Bug: 1002024 Test: added to browser_tests Change-Id: Ib3a9f17e2d0f9b72eb6793e845c4679c141ccc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797122Reviewed-by:
-
Renjie Tang authored
Also removed some unused logs. Change-Id: Ie23768f8f9fd5ceb6814df9dadd5f896bc809aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793444 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#695405}
-
Alan Cutter authored
src/tools/run-swarmed.py uses src/results as the output directory by default. We should avoid treating them as source files in the repository. Change-Id: I69ee66aa7c65382d0068bbd949fa761e638a5dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781925 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695404}
-
Kristi Park authored
If the page was loaded with Most Visited shortcuts, the maximum number of shortcuts was set to 8. This was not updated if users swapped to custom links, so an error was thrown. Do update the maximum number of shortcuts, and remove the error since we can ignore any shortcuts over the max. Change-Id: I95e3941ed2c9f2b266075edad7f8a60bddddd93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793230 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#695403}
-
Alex Cooper authored
Bug: 1002737 Change-Id: I74070a0ad0f0633521247e1c74ea0147ccc0505d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797248 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#695402}
-
Matt Falkenhagen authored
The code path these test doesn't happen when the feature is on: * EmbeddedWorkerInstanceTest.DetachDuringProcessAllocation * EmbeddedWorkerInstanceTest.StopDuringProcessAllocation Bug: 824858 Change-Id: Iadfc474fc1a0acb56ec9562a17fed28023927931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795530Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695401}
-
Andres Calderon Jaramillo authored
This CL refactors how we use the feature flags for image decode acceleration. The goal is that for a given image type (i.e., JPEG or WebP), we only check the corresponding hardware decode acceleration feature flag after we know that OOP-R is enabled and the device supports hardware decoding images of that type. The reason is that we only want hardware decode acceleration finch experiments to include users from that population (otherwise, both the control and enabled groups would always avoid accelerated decodes). To achieve this, we compute two bool members in the GpuImageDecodeCache ctor, |allow_accelerated_jpeg_decodes_| and |allow_accelerated_webp_decodes_|. These are computed by first checking for OOP-R and hardware decoding support for the corresponding image type. We also remove the feature flag checks in VaapiImageDecodeAcceleratorWorker::Create() (which happens during the the GPU process startup). This implies that the supported decoder profiles are always advertised to the renderers. However, the checks in [1] remain intact and they ensure that the service side only accepts requests for accelerated decoding if one of the feature flags (JPEG or WebP) is on. Furthermore, we check the flags again in VaapiImageDecodeAcceleratorWorker::GetDecoderForImage() to ensure that if a flag for a specific image type is off, we don't use the decoder for that type. This is all to prevent compromised renderers from triggering hardware decodes forbidden by the feature flags. [1] https://cs.chromium.org/chromium/src/gpu/ipc/service/image_decode_accelerator_stub.cc?l=118-123&rcl=4fbe89686751aa0c90da185c82d796f9f01cf2aa Bug: 995155 Test: Adds GpuImageDecodeCache test coverage for the new behavior. Change-Id: I4957f9e2606b012aef337c93b45732eaf010248a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787594 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#695400}
-
Saman Sami authored
Currently for accelerated 3D resources we skip SharedImage provider and fall through to Texture provider which is not compatible with Vulkan. Bug: 985366 Change-Id: Ibc7a6ad38ba62c9e82b86822dcf1dff06a7d2096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796307 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium eaa5aa87. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I08c071c7915b4428a9b35ec803e049a4e76340dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796904Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695398}
-
ziyangch authored
Bug: internal b/140761503 Test: audio_video_pipeline_impl_unittest. Change-Id: I77f8f44dc8fe71e018599e927e48a915c76093d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796643Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#695397}
-
Tibor Goldschwendt authored
Before, the flags were passed to the test APK. + Fix flags to make bundle smoke test run. Bug: 989654 Change-Id: I175b57af7b0c0ad9badb5d16b341f0eae4b8369a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795311Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695396}
-
- 10 Sep, 2019 6 commits
-
-
Henrique Nakashima authored
This is the only function in IntentUtils that depends on chrome/browser. IntentUtils can then be moved to a separate util build target. Bug: 995916 Change-Id: I25307932e08b605f292947f7af2d4fe2be98b70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774301Reviewed-by:
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled. This makes most tests involving extension service workers to pass. Bug: 824858, 984522 Change-Id: Ide0d60cbe9be15ea6149d29761a50506ac4376fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763560 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#695394}
-
nancy authored
BUG=1002351 Change-Id: Ib351d0251b0914220d55b269079c958ed06ac9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794522Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695393}
-
Gabriel Charette authored
[TaskEnvironment] Get rid of the last explicit usages of MAIN_THREAD_ONLY that snuck in during the transition TBR=dcheng@chromium.org Bug: 992483 Change-Id: I1c95dfd52690fdedb0ae35ffa7da9081e2af182f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796753Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#695392}
-
Xing Liu authored
This icon db initialization flow loads the entry keys in https://chromium-review.googlesource.com/c/chromium/src/+/1788308. We can log the record count for icon db now. Bug: 963298 Change-Id: I9bd04a9205484d0b9023ed8bc7816680bf235d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793824 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/52f7ae7c8988..c5d29588605e git log 52f7ae7c8988..c5d29588605e --date=short --no-merges --format='%ad %ae %s' 2019-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 56140e7d..b5e2f020 (695187:695291) Created with: gclient setdep -r src/third_party/webrtc@c5d29588605e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie4d88c24461de874f0afedb05e017b10d762e115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796124Reviewed-by:
-
