- 25 Feb, 2020 40 commits
-
-
K. Moon authored
The PDF.LoadStatus metric expires on 2020-03-01. We're planning changes that might affect PDF loads, and so are still interested in tracking how successful PDF loads are. Fixed: 1043729 Change-Id: Ia1bf6833a280d4f82e229265aedef7df48bedfcb Bug: 1043729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071375Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#744389}
-
sczs authored
Bug: 1049088 Change-Id: I435c8b4c0bbec9130cecf845321391914df529d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071241Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744388}
-
nancy authored
Change-Id: I011eab8c3b2bd21ce1a9e3e2718c736d586d0a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071455Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744387}
-
Elly Fong-Jones authored
The value in the controller is const (yay!) so it's safe to simply set it once in the constructor. Bug: 1011446 Change-Id: I5d71936957717ccd5a15c1c81537f8d826d9b4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072663Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#744386}
-
Collin Baker authored
Bug: 1009881 Change-Id: I0c784e4ac16bb14e5515b95680adfea3b5e3148c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069499Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#744385}
-
Rakesh Soma authored
Bug: 1055726 Change-Id: Ibbdfdaff9c56175dd6f3b795f08b395f0f3bbcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072118 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#744384}
-
Daniel Cheng authored
This is a reland of 6c9388f9. This broke a number of legacy builders which have since been removed from the waterfall ^_^ Original change's description: > Allow FROM_HERE to be backed by base::Location::Current(). > > This allows the functionality of base::Location::Current() to be > verified in releases while still allowing a simple revert. > > One minor difference from before is that the helper macro > FROM_HERE_WITH_EXPLICIT_FUNCTION is no longer supported. Since > cc::BeginFrameTracker is the only user of this macro and doesn't > appear to need it, just revert it to use FROM_HERE directly. > > Bug: 974061 > Change-Id: Iae09bc02caf9f095a3ace9ea3ac70ded3dd493e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990262 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Auto-Submit: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731804} Bug: 974061 Change-Id: I075a6340bf356883a044c4a87e2b0038c518782e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072579Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744383}
-
Tom Anderson authored
This is a reland of 388f1d99 Original change's description: > Reland "Enable ATK and Glib on Linux/Ozone" > > This is a reland of 16c153e6 > > Original change's description: > > Enable ATK and Glib on Linux/Ozone > > > > BUG=988094,1014934 > > R=sky > > CC=nickdiego,msisov,adunaev > > > > Change-Id: I05b4bae5ccce53053ad4ae8269db849c2db9e569 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056570 > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#742233} > > TBR=sadrul,jamiewalch > > Bug: 988094, 1014934 > Change-Id: Ide8b89767eddbdd6e6751db58c92d64e2d756fec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062911 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742315} R=sadrul CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng Bug: 988094, 1014934 Change-Id: I48b857751cfa3a1beaaf0555dcdba495dcde8670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063729 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#744382}
-
Adam Langley authored
This change pulls the caBLE v2 handshake and message encryption out of FidoCableV2HandshakeHandler and FidoCableDevice, implements the authenticator side of it, and adds tests. BUG=1002262 Change-Id: I6370cab017407c9e4c62fe718303180b92b0cb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067556 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#744381}
-
Andrew Grieve authored
And removes last remnant of JDK8: sun_java_tools Bug: 693079 Change-Id: I4a1988a739543a561accbd4d6a8dbaad75d545b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956048Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#744380}
-
Nico Weber authored
It existed for XP compat, and we dropped XP support long ago. Cq-Include-Trybots: chromium/try:win7-rel Bug: 1055787 Change-Id: I331d734becb0fa68e987d590dc118404afa0f66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072357 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744379}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f89b6c850ab..4be48f5a3603 Created with: gclient setdep -r src-internal@4be48f5a3603 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094,chromium:1051997,chromium:1055749 Tbr: jbudorick@google.com Change-Id: I50b083b22b045ef4cdbcd0ba367c02898296c80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072452Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744378}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0165d5c32c87..d6fb409d463d git log 0165d5c32c87..d6fb409d463d --date=short --first-parent --format='%ad %ae %s' 2020-02-25 hbos@webrtc.org [Overuse] Make some should-be-const methods const. 2020-02-25 eshr@google.com Support injecting new Resources for overuse Created with: gclient setdep -r src/third_party/webrtc@d6fb409d463d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I153582d5a3bf12263d9d584282b8d2df7d8e2d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744377}
-
Bill Budge authored
- Remove WasmCodeCache feature flag, now that it has launched. Bug: chromium:719172 Change-Id: Ic84d2efc3dd27e4abe5ade7225fc8292c568f107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068880Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Benjamin Beaudry authored
According to http://www.w3.org/TR/core-aam-1.1/#exclude_elements2, some elements (e.g., buttons) needs to hide their children to accessibility APIs. Apparently, this constraint is implemented in Narrator and explains why navigating with Scan Mode inside of such controls that contains other objects (like an image) fails. To an end user, Narrator simply 'gets stuck' on such elements. In CL:1828124, we added AXPlatformNodeWin::ShouldHideChildrenForUIA and more to prevent returning the descendant of a node that should hide its children and instead returning the ancestor node that shouldn't have children in AXPlatformNodeTextRangeProviderWin::GetEnclosingElement. In AXPlatformNodeTextRangeProviderWin::GetChildren, I noticed that we were still returning the children for a node even though that node should actually hide its descendants. This change ensures that we don't return any child for a node that shouldn't expose its children. In short: 1. Added HasPresentationalChildren to ax_role_properties.cc. 2. Updated the implementation of AXPlatformNodeWin::ShouldHideChildrenForUIA to use that new helper. 3. Moved and renamed BrowserAccessibility::GetDescendants to BrowserAccessibilityWin::GetUIADescendants. 4. Updated the implementation of GetUIADescendants for two reasons: 1. Fix issue with ignored nodes being returned. 2. Hide children that for objects that should hide their children. 5. Added two unit tests: 1. One for the new implementation of BrowserAccessibilityWin::GetUIADescendants. 2. One for the end user experience with UIA in ax_platform_node_textrangeprovider_win_unittest.cc. Bug: 928948 Change-Id: I81f392f5991d9e21f911b802fe0fc69b3ec774d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057863Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744375}
-
Rakesh Soma authored
Bug: 1055719 Change-Id: Ie799e85b40348707ee4d29b6f3d955d192aa8cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072097 Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b185002d559b..5b7ce876b01c git log b185002d559b..5b7ce876b01c --date=short --first-parent --format='%ad %ae %s' 2020-02-25 jmadill@chromium.org Vulkan: Update buffer accumulation TODO bug IDs. Created with: gclient setdep -r src/third_party/angle@5b7ce876b01c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Idb04f7796fb21fc0e7c12895a9117e6282c475f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072598Reviewed-by:
-
Ken MacKay authored
This allows you to specify minimum and maximum volume multipliers for all streams that fall into a given filter group, or for all streams with a specific device ID. Example configuration fragment: { "streams": ["communications", "other"], "volume_limits": { "min": 0.001, "max": 0.75, "other": {"min": 0.0, "max": 1.0} }, "processors": [ ... ] } Note that the min and max values are multipliers, so 0.0 is silence and 1.0 is max volume. Bug: internal b/144181483 Change-Id: Ica0fab5e3b191237979d7b42e29b250c9897ab39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071483Reviewed-by:Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#744372}
-
chrome://faviconArchana Simha authored
Count the number of times an extension uses the chrome://favicon resource. Bug: 104102 Change-Id: Iff3cd505c7468b3c32a1baede0869abdc5d884d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023517Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#744371}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e58e709f7730..f2c28cd7657f git log e58e709f7730..f2c28cd7657f --date=short --first-parent --format='%ad %ae %s' 2020-02-25 fmayer@google.com Mark ContiguousMemoryRange::size as const. Created with: gclient setdep -r src/third_party/perfetto@f2c28cd7657f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0462f9e580c13be78768345aa53bdd564f6f67f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072601Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c1e60dcf1165..4cc54b409feb git log c1e60dcf1165..4cc54b409feb --date=short --first-parent --format='%ad %ae %s' 2020-02-25 capn@google.com Fix Android build after SPIRV-Tools update Created with: gclient setdep -r src/third_party/swiftshader@4cc54b409feb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I980d0f912bf913f8486c21fcdb1e8a3e69b8d897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072379Reviewed-by:
-
Katie D authored
This reverts commit ce64e25e. A fix was made so the title does not change on iOS either. Original change's description: > Adjustments to reader mode view page title on desktop. > > Reader mode view page title now says "Loading..." instead of > "Simplified view" on Desktop before the article title is populated. > > The article title is followed by "- Reader mode" to provide an > indication to screen reader users that they are in a distilled page tab. > > Bug: 1016461 > Change-Id: Ie7ab1ab1e89090e182c4c556bd22878ee876b818 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052487 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744120} Change-Id: I363ada8dfedd60673e46d09d57bab75c88144fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072124 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#744368}
-
Chong Gu authored
Remove require_kvm arg from GetDeploymentTargetForArgs. Replace useless no-kvm flag with allow-no-kvm. Bug: 1000906 Change-Id: I6d85d351e4089384721d85f697909b4d9280fe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071136 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#744367}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3eb0df2c199c..d2b5e7801939 git log 3eb0df2c199c..d2b5e7801939 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 lanwei@chromium.org Disable InspectorMemoryTest.testGetDOMStats on ChromeOS Created with: gclient setdep -r src/third_party/catapult@d2b5e7801939 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055815 Tbr: sadrul@google.com Change-Id: Ic58dba09d13bfa4794867f02aaf4d681967ab638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072456Reviewed-by:
-
Peter Kasting authored
This replaces the slower, more generic RunAllTasksUntilIdle() and saves code to boot. I thought this might make the tests less flaky, but it turned out to be unrelated to the flakiness I was investigating. Still seems worth doing. Bug: none Change-Id: I66814c7596bac79f1e5b05356a86fd87984983cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071586 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
David Black authored
Previous versions of LibAssistant did not implement AddTimeToTimer. Now that they do, we can do away with our previous workaround of cancelling the timer and scheduling a new one. Bug: b:149574352 Change-Id: Icea605a009574ec170c1c725deba2008d32458e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057158 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744364}
-
Xiaocheng Hu authored
CanvasRenderingContext2D stores a font to draw text, but doesn't always update it when the document's font cache is invalidated. In particular, it's not notified when @font-face rules are added or removed. This patch makes CanvasRenderingContext2D to ensure font validity when using the font, by updating the font if it's invalid. Bug: 1051715 Change-Id: I29d89a897b9ccaf14848dab0f33b115f4b3eee0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053508Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744363}
-
Jian Cai authored
Pattern initialization has been turned on by http://crrev.com/c/2067928 for Linux, therefore enabled on ChromeOS. There is no need of this variable any more. Bug: 1042451 Change-Id: I30aa3a82ab56dac09f7d41fc0ad8cfed4c43f204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070972Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tiancong Wang <tcwang@google.com> Commit-Queue: Jian Cai <jiancai@google.com> Cr-Commit-Position: refs/heads/master@{#744362}
-
sczs authored
Since infobarModalPresentedFromBanner is called as completion for the Modal presentation, there's a chance the Infobar could've been destroyed by then, if this is the case passwordInfoBarDelegate was set to nil in stop, and we shouldn't call InfobarPresenting. Bug: 1055340 Change-Id: I603b7e6bdbd39094dc7cecea7f0e8084a91b6b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072646Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744361}
-
chrome://flagsJosh Simmons authored
This also changes feature flag behavior so that the PerformanceHintsObserver is enabled when kContextMenuPerformanceInfo is enabled. Enabling the UI without enabling the Observer is not a scenario we're interested in. Bug: 1040661 Change-Id: I4970534ad4b21127ef603955c2b22bb7f5ce40dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067690 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#744360}
-
Henrique Nakashima authored
Night mode flags are default enabled and can be removed to simplify the code. Bug: 1012975, 1018268 Change-Id: Ib380598ebcd0ca3ae1b2dc26df8cf7e311219adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070115Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#744359}
-
Huanzhong Huang authored
Bug: 1045348 Change-Id: I9f682aedcb5c849293aea49090e5895c8e813e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069143 Auto-Submit: Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744358}
-
Francois Doray authored
MessagePump::Delegate::DoWork/DoDelayedWork are being removed in favor of DoSomeWork. This CL updates NestedMessagePumpAndroid to use DoSomeWork to unblock that migration. Bug: 885371 Change-Id: I0bd84f9f54f7509f7cbfed985d80ed3c6150f8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070330Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
David Grogan authored
Purely bookkeeping, no behavior change or new tests. Bug: 1053825 Change-Id: Idf1eae594c9bb755de2325d023bf1706408c97a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072658 Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#744356}
-
Chris Cunningham authored
Lots of time outs. BUG=1055853 TBR=tbarzic Change-Id: Iaeeff3379dc445466450c2514312330b58f191da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071962Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#744355}
-
Yue Ru Sun authored
Also adding screen info and CPU metric providers, and checked that they populate additional fields on system profile proto. Omitted GPU metric provider because it seems not applicable from here https://cs.chromium.org/chromium/src/components/metrics/BUILD.gn?l=212 Bug: 1046923 Change-Id: I0c291aed07a1743811d47f884e17b049945974c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050673 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#744354}
-
Toni Barzic authored
The shelf widget delegate view, which also acts as a shelf widget's contents view, contains two views - login shelf view, and the drag handle. Currently it uses fill layout manager for layout, which makes sense for login shelf view, but not so much for the drag handle. To avoid drag handle from getting resized to the whole shelf view bounds, the shelf widget resets the delegate view layout manager when session state changes. This works because login shelf and drag handle are mutually exclusive. With new final first user run oobe screen mocks, which may have swipe from shelf gesture enabled, login shelf may require drag handle, which now break with fill layout manager. This CL changes shelf widget delegate view to manage its own layout - it sets the login shelf view to full shelf bounds, and centers the drag handle within the shelf bounds. Also, it makes relationship between delegate view and login shelf view more explicit, as the login view is now added to delegate view using explicit AddLoginShelfView method, instead of using GetContentsView()->AddChildView from shelf widget. BUG=976949 Change-Id: Ic5a26c4ab657194c4cf4dfc5a4473eca4807146e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071289 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Cathy Li authored
Change-Id: Ib77234174ece4facb35596808fd964a18db04311 Bug: 1054944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048409 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
-
Patrick Monette authored
This is a temporary check that creates a crash report when a DLL is loaded on a thread with background priority. Once a sufficient number of crashes have been reported, this CL will be reverted. Bug: 973868 Change-Id: Ibb777eb64ada04454f50b080a54cb6d2fc371c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067625Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#744351}
-
Adithya Srinivasan authored
We shouldn't set the portal element's content frame if SubframeLoadingDisabler::CanLoadFrame() returns false, this can lead to discrepancies in the connected subframe count and result in frames not being disconnected. In the test case in this CL, we try inserting a portal into a subtree that is being disconnected. Bug: 1041406 Change-Id: I7e0377392457f5b0ca6537c27cb6a5835b8eedd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002859 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
-
