- 26 Jun, 2018 40 commits
- 
- 
Sergey Ulanov authoredThe AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8086dee1d331ee7f2eba14c39f23ed66b2ed025f Reviewed-on: https://chromium-review.googlesource.com/1114343 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570300} 
- 
Sam McNally authoredBug: 256520 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic1fdaf1b3790dfcac589e2f802f39136cd3fc6a6 Reviewed-on: https://chromium-review.googlesource.com/1113165Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#570299} 
- 
Makoto Shimazu authoredRedirects with referrer-policy header need to respect a new referrer policy. This tries to check if it's working when the request is in a service worker's scope. Bug: 855948 Change-Id: Icb923fa8b8345c128f02c41e042775ba5bf499ad Reviewed-on: https://chromium-review.googlesource.com/1113171 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#570298} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/ff168d9258e0..fcd480bcab9e git log ff168d9258e0..fcd480bcab9e --date=short --no-merges --format='%ad %ae %s' 2018-06-25 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-25 herb@google.com Fix compiler warning for MSVC 2018-06-25 caryclark@skia.org explicitly include blurimagefilter include 2018-06-25 brucewang@google.com Implement onMakeClone function on all subclasses of SkTypeface except Created with: gclient setdep -r src/third_party/skia@fcd480bcab9e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I9aa3cb584bd537ab4e62b1e4a2d94c306699a50c Reviewed-on: https://chromium-review.googlesource.com/1114045Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570297} 
- 
Sergey Ulanov authoredScenicSurfaceFactory is a simple SurfaceFactory implementation for the Scenic ozone platform that allows displaying 2D images on the screen on Fuchsia. Bug: 829980 Change-Id: Ic8326b4fcc000a2e435e63a6e6778d861f5f17a7 Reviewed-on: https://chromium-review.googlesource.com/1080980 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#570296} 
- 
v8-ci-autoroll-builder authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d5feb1ea..1360b227 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib6c9303fd1b6f4e5d2e416705e94ab8d28f5b69f Reviewed-on: https://chromium-review.googlesource.com/1114290Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570295} 
- 
Sam McNally authoredThe identity service fails fast if chrome's refresh tokens are not yet loaded. However, it does not distinguish between a transient failure due to the refresh tokens not having loaded yet and a persistent failure due to not having a refresh token for the requested account. Avoid this by returning transient errors until the refresh tokens are loaded. Bug: 855002 Change-Id: I4cfa1d52987a3ed9fbec9a8600c87c535b9e0252 Reviewed-on: https://chromium-review.googlesource.com/1113086Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#570294} 
- 
Becca Hughes authoredThis sends the safe areas from Android to Blink using the DisplayCutoutClient Mojo interface. This CL also includes instrumentation tests for end to end testing of Display Cutout on Android. BUG=847652 Change-Id: Ide2bed7878a22d649914fde66083c28374f4d768 Reviewed-on: https://chromium-review.googlesource.com/1097802 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570293} 
- 
Lei Zhang authoredBUG=137767 Change-Id: I695459f8b60ecdce8d0b476d7eb373464c5e4be7 Reviewed-on: https://chromium-review.googlesource.com/1112775 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570292} 
- 
David Black authoredLogic was previously in AssistantInteractionController. Bug: b:80542452 Change-Id: I3e92d2ed8cbf1afa3577a7180eef5260a592f8d6 Reviewed-on: https://chromium-review.googlesource.com/1112656 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#570291} 
- 
Ted Meyer authoredBug: 827648 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I75f2ebe01cd6a0af212b7d4a2d823d16f2cbba8b Reviewed-on: https://chromium-review.googlesource.com/1102085 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#570290} 
- 
Koji Ishii authoredLayoutTextTest and LayoutTextFragmentTest do not set font-size when SetAhemBody is used. This caused DCHECK failures added in CL:1111895 due to too much rounding errors. This patch fixes that by setting the font-size to 10px. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6e945a6f07902c50bbfcbca4014d324ba1ae1d0a Reviewed-on: https://chromium-review.googlesource.com/1113697Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570289} 
- 
pdfium-chromium-autoroll authoredhttps://pdfium.googlesource.com/pdfium.git/+log/8c955c9d3072..76fb29d5ebae git log 8c955c9d3072..76fb29d5ebae --date=short --no-merges --format='%ad %ae %s' 2018-06-25 thestig@chromium.org Clean up CPDF_StreamContentParser::AddTextObject(). Created with: gclient setdep -r src/third_party/pdfium@76fb29d5ebae The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idcc5ad4ff3b25f66ab34efce1909a826325f113f Reviewed-on: https://chromium-review.googlesource.com/1113827Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570288} 
- 
Bret Sepulveda authoredBug: 855286 Change-Id: I35b3fcce765c41f7b845ec3e5ec7924750b8a1c2 Reviewed-on: https://chromium-review.googlesource.com/1114334Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#570287} 
- 
James Darpinian authoredWhen piping Chrome stdout/stderr through asan_symbolize.py, we want it to output every line immediately. Python line iterators buffer multiple lines, so switch to using readline() directly instead. Change-Id: I90d712c14094929e411b395d0a8d3ae00c0e9d05 Reviewed-on: https://chromium-review.googlesource.com/1114308Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#570286} 
- 
wutao authoredThis cl changes several specs of TabbedPane in highlight vertical mode: 1. Max row length should be capped at 192, with right padding of 8px. For long text, truncate with ellipsis. 2. Change active color from #4285F4 to #1A73E8. 3. Do not show MdTab border when focusing in highlighted mode. Instead hightlighing with darker blue. Bug: 822382 Test: manual. Change-Id: I455aa2ecdf6d07c4aa34a2438af1dca1266030a3 Reviewed-on: https://chromium-review.googlesource.com/1114288 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#570285} 
- 
Qiang Xu authoredFeature is landed in M66. Now we can remove the flag in M69. Bug: 778438 Test: manual Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icd56cda2c4cd61677f4724c11ccf4b946eae24ae Reviewed-on: https://chromium-review.googlesource.com/1113077Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#570284} 
- 
Han Leon authoredThis reverts commit 987fd487. Reason for revert: need to change module of the mojom Original change's description: > [SWOnionSoup] Move dispatch_fetch_event_params.mojom into Blink > > BUG=789846 > > Change-Id: I1866746cd240b26d2d059a64309aa595eccb9cac > Reviewed-on: https://chromium-review.googlesource.com/1113203 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Han Leon <leon.han@intel.com> > Cr-Commit-Position: refs/heads/master@{#570278} TBR=kinuko@chromium.org,shimazu@chromium.org,leon.han@intel.com Change-Id: Idced63d7ae3902f94304fdddb76371da9de3c5fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789846 Reviewed-on: https://chromium-review.googlesource.com/1113847Reviewed-by: Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#570283} 
- 
Christopher Cameron authoredMove to a separate header in preparation for adding a matching RenderWidgetHostNSViewRemote. Bug: 821651 Change-Id: Iefeca67957e7810a2e057f77eeb8e61db2d96643 Reviewed-on: https://chromium-review.googlesource.com/1111036Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#570282} 
- 
rbpotter authoredFix chopped text and missing dropdown image in the account select in the destinations dialog. Bug: 855012 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I577f471c17d1889e82468f05aeb8cdda62753d6e Reviewed-on: https://chromium-review.googlesource.com/1111457 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570281} 
- 
Andrew Grieve authoredSo far seems to be working fine and not becoming overloaded. Bug: 702625 Change-Id: I1a83fc0594f1b1ac69ff0b70f9997b59c08db3c8 Reviewed-on: https://chromium-review.googlesource.com/1114318Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570280} 
- 
Ahmed Fakhry authoredWe found out that the hardware split gamma mode doesn't do interpolation of the values, which led to some bad side effects such as ugly banding in blur effects. This CL removes all the default gamma tables, and uses the newly exposed data to identify if the hardware does color correction in linear gamma space or not. This lets us select which type of matrix to apply. BUG=851156,749250 TEST=Expanded tests Change-Id: I0342b6e4a0257e833c7d13690930dfd32ce89fe7 Reviewed-on: https://chromium-review.googlesource.com/1112734Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570279} 
- 
Han Leon authoredBUG=789846 Change-Id: I1866746cd240b26d2d059a64309aa595eccb9cac Reviewed-on: https://chromium-review.googlesource.com/1113203Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#570278} 
- 
Becky Zhou authoredOn History/Download/Bookmarks, if we set close icon to "always" shown as action, the other items can be collapsed into an overflow menu that appears to the right of the close icon. We should temporarily set the showAsAction back to "ifRoom" until we figure out a better way to customize collapsing the items into an overflow menu. Bug: 849849 Change-Id: Ic94f8d9071dc0295ec5adc10e36ab74eb4a2150b Reviewed-on: https://chromium-review.googlesource.com/1114307Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570277} 
- 
Kevin Marshall authoredCertain packages, like services and runners, are not meant to be run directly from the command line. This CL introduces a flag "--install-only" which copies packages to a device, but does not run them. Change-Id: Ibb53f04a8ef6a93cc39d31b651666512a42b3c6a Reviewed-on: https://chromium-review.googlesource.com/1114292 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570276} 
- 
Yuichiro Hanada authoredIn crrev.com/c/1098869, new category of input method id, ArcImeId was introduced. Before this CL, enabled ids of ARC IMEs are stored in kLanguagedPreloadEngines, but they should be stored kLanguageEnabledExtensionImes because the former pref is for component extension IMEs, which is pre-installed system IMEs. Bug: 845079 Test: Unit tests are added. Change-Id: I62d509895359284df8162c2852ca7ccae40ca7ff Reviewed-on: https://chromium-review.googlesource.com/1109441Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#570275} 
- 
Jared Saul authoredThe "send detected values" experiment was launched in M65 and has been default-enabled at ToT for a while now. We've delayed removing the flag code because it (correctly) resulted in a QPS increase for Payments, but things have gone well, so I'm now removing the flag and making the behavior default. Bug: 855788 Change-Id: If34db8ac090732cbdc44cfec17f2530d22b00e04 Reviewed-on: https://chromium-review.googlesource.com/1112753 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#570274} 
- 
Mounir Lamouri authoredBug: 850479 Change-Id: Id1e953e3416f1f971f981bc5e5247fa40233538e Reviewed-on: https://chromium-review.googlesource.com/1114256Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#570273} 
- 
webrtc-chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/d5b8ee1e175e..111fdfd73204 git log d5b8ee1e175e..111fdfd73204 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 steveanton@webrtc.org Refactor RtpSender to take the sender ID as a constructor argument Created with: gclient setdep -r src/third_party/webrtc@111fdfd73204 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I50e42012d5c6e505fdc12c472a61a47dc7ce66c2 Reviewed-on: https://chromium-review.googlesource.com/1114042Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570272} 
- 
Ned Nguyen authoredChange-Id: I9e2e1be12907bc93a2e2b9f60a1a406878b4c7e6 BUG: chromium:533481 Reviewed-on: https://chromium-review.googlesource.com/1114259Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570271} 
- 
Lei Zhang authoredBUG=137767 Change-Id: If68b726d3f007e2144856bdf691c070c5d1533c1 Reviewed-on: https://chromium-review.googlesource.com/1112770 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570270} 
- 
Stephen Martinis authoredAlso removes iannucci@, since he doesn't work on these scripts anymore. Change-Id: Id6191a752a1a22f48714f96eb767c2a92552e82b Reviewed-on: https://chromium-review.googlesource.com/1114183 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#570269} 
- 
Chris Lu authoredBefore Screenshot: https://drive.google.com/file/d/18YJwgnQAsZ2c0YV2fDVx_p8oDwOPAUPy/view?usp=sharing After Screenshot: https://drive.google.com/file/d/1_V8gJ9lD76oCwC95T-_ZK16ThncguFnI/view?usp=sharing Change-Id: I7d57917ae1e330c6d109d5676b84eb5d87f3ff2d Reviewed-on: https://chromium-review.googlesource.com/1114140Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#570268} 
- 
Stefan Zager authoredEven before RLS landed, this functionality appears only to have been accessed by an obsolete internals API. BUG=823365 R=skobes@chromium.org,pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I599103f2ba4ff4270eddfa11bef2eb016e612484 Reviewed-on: https://chromium-review.googlesource.com/1114067 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570267} 
- 
Tien-Ren Chen authoredA pending frame with no deadline can never activate if it refers to a future surface ID from a deleted sink. This blocks future valid frames to be generated, causing a deadlock. This CL makes SurfaceDependencyTracker to unblock dependencies to all future surface IDs for a deleted frame sink. BUG=667551,672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I90ecd75d575b41211cfd104184657f5c89ffb266 Reviewed-on: https://chromium-review.googlesource.com/1111273Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570266} 
- 
Peter Williamson authoredThis reverts commit 7e1ee3f6. Reason for revert: Sheriff is reverting on suspicion of causing build failures in Linux-chromeos-dbg. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6482 BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x0000030708cc base::debug::StackTrace::StackTrace() #1 0x000002a06b85 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f1b84f32cb0 <unknown> #3 0x000001b623b4 chromeos::OobeUIDialogDelegate::GetOobeUI() #4 0x000001b5e99e chromeos::LoginDisplayMojo::LoginDisplayMojo() #5 0x000001b58e56 chromeos::LoginDisplayHostMojo::LoginDisplayHostMojo() #6 0x000001b5e397 (anonymous namespace)::ShowLoginWizardFinish() #7 0x000001b5dcc3 chromeos::ShowLoginWizard() Original change's description: > cros: Views-login prevent gaia from being dismissed. > > Sometimes the dialog should not be dismissed, such as when there are no users. > > Bug: 839583 > Change-Id: Iee275fb636e5842ba2e99b799b8c04539ea1c3bd > Reviewed-on: https://chromium-review.googlesource.com/1093882 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570105} TBR=xiyuan@chromium.org,jdufault@chromium.org Change-Id: I031f7ab7e627f1aedea76fb24f8ad4b2f97eb804 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839583 Reviewed-on: https://chromium-review.googlesource.com/1114048Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#570265} 
- 
Noel Gordon authoredUse the TestBrowserThreadBundle RunUntilIdle to flush all tasks at the end of the test, rather than base::Runloop::RunUntilIdle, which caused flakes on the MSAN/ASAN bots. Test: unit_tests --gtest_filter=FileManagerFileWatcher*WatchLocalFile Bug: 813483 Change-Id: I867e5d914074e6c9d389a5f932836cd6cd8a627c Reviewed-on: https://chromium-review.googlesource.com/1113399Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570264} 
- 
Tom Anderson authoredCL [1] propagates the FONTCONFIG_FILE environment variable to subprocesses and thus ensures, child/utility processes receive the correct fontconfig testing environment. This means adding a command line switch to indicate a testing environment for fontconfig is no longer necessary. R=drott,thestig BUG=849923 Change-Id: I2234802904e9f725fa0b221fd65aced4885e0023 Reviewed-on: https://chromium-review.googlesource.com/1112768 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#570263} 
- 
Alexei Filippov authoredThe function makes a DCHECK(IsValid()) thus causing it to crash in debug. BUG=848398 Change-Id: I3af4495edeffff652507637e914da61dac5c5476 Reviewed-on: https://chromium-review.googlesource.com/1114182Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#570262} 
- 
Theresa authoredBUG=835398 Change-Id: I7c34d074403767b45d2f26398ec97e37f0edacb9 Reviewed-on: https://chromium-review.googlesource.com/1114177 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#570261} 
 
-