- 02 Aug, 2019 40 commits
-
-
Sergio Villar Senin authored
It's much better located in wtf/ and the WTF namespace than directly under platform/ under the blink namespace. In order to limit the amount of required changes it was decided to add a forward declaration to wtf/forward.h so that all the current usages of SharedBuffer do not have to explicitly use the WTF:: namespace. Bug: 919385 Change-Id: I26e029c9ba17e95a1921c12cd87d6433df26cc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715373 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683609}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 69fc937e. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6790530d "[WPT/common/security-features] Make subresourceContext unmodified" 219bce7d "Worker: Add upgrade-insecure-requests tests for top-level classic shared worker script loading" 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ibc2c3905ccc1dd1e05f5aa80db7cf4a3cf9c8fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732173Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683608}
-
Robbie Gibson authored
Bug: 976665 Change-Id: Iaab827e250e73c7ea788442285ddfd5ad2050f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731903 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#683607}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/36fb019c0657..b9d6775dfb5f git log 36fb019c0657..b9d6775dfb5f --date=short --no-merges --format='%ad %ae %s' 2019-08-02 treehugger-gerrit@google.com Merge "Use using ::testing::* declarations in tracing_service_impl_unittest" Created with: gclient setdep -r src/third_party/perfetto@b9d6775dfb5f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I93418397b0846310bf93244b70ed0a325ad7c302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733450Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683606}
-
Mugdha Lakhani authored
When initing the BackgroundSyncManager for the storage partition, we're not setting the origin of the registrations on the internal map. This causes problems down the line when checking for site engagement. Also add a unit test to verify we're getting the expected origin after restart. Bug: 990338 Change-Id: I2416fee5f9c4d3fa3302f20704d3ea4837f50fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731944 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#683605}
-
Stephane Zermatten authored
This change allows the assist app calling direct actions to provide a definition of the action they want to run to bypass the need to make RPCs to the server. This is just meant as a speedup and is not supposed to fully replace definitions on the server. For example, if RPCs are already made, the definition from the server is used instead of the local one. This is done by passing an opaque base64 encoded proto to list_assistant_actions. Bug: b/138278201 Change-Id: I9a7303357e8a44c517e77c9519d8c54d84ffe305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718948 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#683604}
-
Chris Sharp authored
This reverts commit 8f5f3e89. Reason for revert: Revert wasn't needed Original change's description: > Revert "Reland "Remove references to MessagePump::Type"" > > This reverts commit 1c1d61e5. > > Reason for revert: I suspect this is causing a compile failure on the Linux ChromiumOS Full Bot. > > Output: > FAILED: obj/chromeos/services/assistant/tests/service_unittest.o > /b/s/w/ir/cache/goma/client/gomacc ../../third_par... > ../../chromeos/services/assistant/service_unittest.cc:12:10: fatal error: 'ash/public/interfaces/constants.mojom-forward.h' file not found > #include "ash/public/interfaces/constants.mojom-forward.h" > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > Original change's description: > > Reland "Remove references to MessagePump::Type" > > > > This is a reland of bfca9d67 > > > > Was reverted because an optional trybot failed due to a missing include in an unrelated file. > > That was fixed in https://crrev.com/c/1729634 and https://crrev.com/c/1730894 > > > > Original change's description: > > > Remove references to MessagePump::Type > > > > > > It is going away soon, replace with the real thing: MessagePumpType > > > > > > Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h). > > > > > > This is a mechanical change that will be reviewed according to > > > https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes > > > > > > Bug: 891670 > > > TBR=gab@chromium.org > > > > > > Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058 > > > Commit-Queue: Carlos Caballero <carlscab@google.com> > > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#682731} > > > > TBR=gab@chromium.org > > > > Bug: 891670 > > Change-Id: I7654fb4ff3a5e8c0505aafb33939d2035f28f88b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730416 > > Commit-Queue: Carlos Caballero <carlscab@google.com> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683592} > > TBR=gab@chromium.org,carlscab@google.com > > Change-Id: Ie479741cf8092d9110a9ee6c5fa81e7e084c6788 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 891670 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733432 > Reviewed-by: Chris Sharp <csharp@chromium.org> > Commit-Queue: Chris Sharp <csharp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683602} TBR=gab@chromium.org,csharp@chromium.org,carlscab@google.com Change-Id: Ieb323e7afaf248384c05b8cb0c13d6ec50856c75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733434Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683603}
-
Chris Sharp authored
This reverts commit 1c1d61e5. Reason for revert: I suspect this is causing a compile failure on the Linux ChromiumOS Full Bot. Output: FAILED: obj/chromeos/services/assistant/tests/service_unittest.o /b/s/w/ir/cache/goma/client/gomacc ../../third_par... ../../chromeos/services/assistant/service_unittest.cc:12:10: fatal error: 'ash/public/interfaces/constants.mojom-forward.h' file not found #include "ash/public/interfaces/constants.mojom-forward.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Original change's description: > Reland "Remove references to MessagePump::Type" > > This is a reland of bfca9d67 > > Was reverted because an optional trybot failed due to a missing include in an unrelated file. > That was fixed in https://crrev.com/c/1729634 and https://crrev.com/c/1730894 > > Original change's description: > > Remove references to MessagePump::Type > > > > It is going away soon, replace with the real thing: MessagePumpType > > > > Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h). > > > > This is a mechanical change that will be reviewed according to > > https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes > > > > Bug: 891670 > > TBR=gab@chromium.org > > > > Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058 > > Commit-Queue: Carlos Caballero <carlscab@google.com> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#682731} > > TBR=gab@chromium.org > > Bug: 891670 > Change-Id: I7654fb4ff3a5e8c0505aafb33939d2035f28f88b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730416 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683592} TBR=gab@chromium.org,carlscab@google.com Change-Id: Ie479741cf8092d9110a9ee6c5fa81e7e084c6788 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733432Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683602}
-
Egor Pasko authored
There are a couple of benefits for doing so: 1. to get informed in case there is data loss in unknown amounts 2. document the assumptions so that the pattern of reusing read(3) without handling EINTR does not get copied elsewhere Bug: 981536 Change-Id: I6ac638e3a9bd692b3b437fda4d77d7782a7c17be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729256 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#683601}
-
Chris Sharp authored
This reverts commit 8d648953. Reason for revert: Causing failures on WebKit Linux Leak Failure output: 06:31:06.621 2998 worker/6 virtual/audio-service/media/autoplay/document-user-activation.html failed: 06:31:06.621 2998 worker/6 leak detected: ({"numberOfLiveContextLifecycleStateObservers":[0,2],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,135],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]}) Original change's description: > Add web tests virtual suite for audio service - Take 2 > > Adds extra expectations with respect to reverted > https://chromium-review.googlesource.com/c/chromium/src/+/1715811 > > Bug: 976696 > Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683565} TBR=guidou@chromium.org,armax@chromium.org Change-Id: I15488e069bee7e6e1282bcc78dfe2088339b7036 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733508Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683600}
-
Asanka Herath authored
The test data directory for testserver.py defaults to "../../../../test/data" which is outside the repository. Instead point it at "../../data" which is where the test data for //net is located. Bug: None Change-Id: I6dd8c69ce9c1e12a0c031ab5a41a09fc4556e2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732694Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#683599}
-
Vladimir Levin authored
This patch ensures that we only check whether paint is blocked for children once per paint layer. Since there can be many blocks under a paint layer, we instead save the information on PaintInfo and pass that down. This reduces the checks to a single bool check as opposed to loading LayoutObject/Node to check whether there is a display lock context and whether it's locked. Since we ensure that layout containment is present at style time, this is safe since every display-lockable object would have a paint layer. R=chrishtr@chromium.org Bug: 989165 Change-Id: I95311115f46c5bbc1f3ae37ee326c653853c14e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730763Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683598}
-
Mehran Mahmoudi authored
It appears that items shown in the touchless modal dialog's listview are not focusable by default, when running on Android M. This explicitly makes them focusable and thus fixes a broken test. Bug: 984004,988000 Change-Id: Id59a1dd3ed4119c60711a8daa06d330d9441dee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726813Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683597}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fdd03910d6c6..06eacf44d50f git log fdd03910d6c6..06eacf44d50f --date=short --no-merges --format='%ad %ae %s' 2019-08-02 michaelludwig@google.com Add new SkImageFilters factory API 2019-08-02 egdaniel@google.com Rework maxRenderTargetSampleCount and isFormatRenderable in GrCaps. Created with: gclient setdep -r src/third_party/skia@06eacf44d50f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I2fb5c72251984eb19968f00483617c0097c4ed1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683596}
-
Sami Kyostila authored
Bug: 863341 Change-Id: I05ed35411ecfcfc82ba3f9ccf41c08319013bb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731905 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683595}
-
Gauthier Ambard authored
This CL removes the NTP code used in the pre-UIRefresh UI. Bug: 761817 Change-Id: I0d861b77c342d929bf12b8855d9b3d5b060ae826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731842 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#683594}
-
Caitlin Fischer authored
This is done because docstrings with backslashes should start with r""" instead of """. Change-Id: I55c15f3380d04a92e79169c69009bba92ddffa5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732473 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#683593}
-
Carlos Caballero authored
This is a reland of bfca9d67 Was reverted because an optional trybot failed due to a missing include in an unrelated file. That was fixed in https://crrev.com/c/1729634 and https://crrev.com/c/1730894 Original change's description: > Remove references to MessagePump::Type > > It is going away soon, replace with the real thing: MessagePumpType > > Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h). > > This is a mechanical change that will be reviewed according to > https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes > > Bug: 891670 > TBR=gab@chromium.org > > Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682731} TBR=gab@chromium.org Bug: 891670 Change-Id: I7654fb4ff3a5e8c0505aafb33939d2035f28f88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730416 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#683592}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f63c4e51101a..59d55a331c46 git log f63c4e51101a..59d55a331c46 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 srisser@google.com Update ANGLE docs to match MakeCurrent status Created with: gclient setdep -r src/third_party/swiftshader@59d55a331c46 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: If43ca942232891232dcd01a1a73b2e82e986af46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733448Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683591}
-
Ovidio Henriquez authored
This change adds an entry for the Native File System API write permission in the Page Info dialog box. This permission controls whether the current site is allowed to ask for permission to save changes to the original file that was selected by the user through the API. Bug: 983726 Change-Id: I5e61d6a899b6ca09d9c8108cdc7239d0acb87152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718353 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683590}
-
Yasmin authored
This refactoring is needed for other features which reuse the same logic. Bug: 988461 Change-Id: I658318864ba6fb86c918411954943cf2fd6fd20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730459Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683589}
-
Jérôme Lebel authored
When sign-in with a new gmail account, the Chrome identity was initialized with no hosted domain since the SSO profile was not fetched yet. The property was never updated later. Even when the AuthenticationFlow was fetching hosted domain using the AuthenticationFlowPerformer. During the sign-in process To fix the issue, -ChromeIdentity.hostedDomain is remove. ChromeIdentity stays just a proxy for SSOIdentity. ChromeIdentityService::GetCachedHostedDomainForIdentity() is added to get the hosted domain. Bug introduced with: + crrev.com/c/1687254 + crrev.com/i/1434627 + crrev.com/c/1687254 Related to: => crrev.com/c/1732084 (adding new API) <= + crrev.com/i/1560989 (adding new implementation) + crrev.com/c/1732085 (switching implementation) + crrev.com/i/1560990 (old implementation cleanup) + crrev.com/c/1732101 (cleanup API) Bug: 987380 Change-Id: I2dab7a36927530ca400bdf6e99d645ff325159c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732084Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#683588}
-
Caitlin Fischer authored
Change-Id: I8940a62ceb8d6586a9551607aaaa9e0b63fcac9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731989 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#683587}
-
Jérôme Lebel authored
Opening an URL using |DispatcherForActiveBrowserViewController()| takes extra time in: + testSignInCancelIdentityPicker + testSignInCancelAuthenticationFlow + testSignInCancelFromBookmarks + testSignInCancelAddAccount This is a quick fix for iOS 13. This need to be solved correctly by adding a method in ChromeEarlGrey to simulate opening an URL with UIApplication. See bug: crbug.com/990259 Change-Id: Icb1c122d5d3a94ffabad2b6056e9ea10a608cf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731831Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683586}
-
Jann Horn authored
Currently attempts to report non-ASAN crashes (e.g. CHECK() failure) from an ASAN build fail because iov[6] is {.iov_base=NULL, .iov_len=kMaxAsanReportSize + 1}, causing sendmsg() to fail with -EFAULT. Since the protocol relies on everything being fixed-length, fix it by supplying an "ASAN report" consisting of nullbytes only. Test: build with is_asan=true, run with ASAN_OPTIONS=detect_odr_violation=0 and --enable-crash-reporter-for-testing, navigate to chrome://checkcrash/. Bug: 984778 Change-Id: Icfb1de2d6b99ef19c5b2b08cdeba7eba22746bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705196Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jann Horn <jannh@google.com> Cr-Commit-Position: refs/heads/master@{#683585}
-
Tim Volodine authored
Remove code that is not used anymore with the network service enabled, second iteration. In particular updates/removes: - android_protocol_handler - aw_url_request_context_getter - init_native_callback - aw_safe_browsing_ui_manager - aw_download_manager_delegate - aw_settings and all related call sites and usages. Also removes code and checks which check for features::kNetworkService being enabled/disabled. BUG=989104 Change-Id: I9d18af050cb262ad0f07e64a3e850e5c7fb56f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731929 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683584}
-
Matthias Körber authored
[PasswordManager] Added password-requirement attributes and generated-password-changed flag to internal logging. Change-Id: If3f022fd7951e2c1a785abb12db94a0a1949db7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730060 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683583}
-
Edvard Thörnros authored
Move tests that can be wp-tests to the corresponding folder. The tests should stay exactly the same. Bug: 985335 Change-Id: I61b76803c935c6dd4cc69241d7de76720eaf668e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730457 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#683582}
-
Jan Wilken Dörrie authored
This change implements the necessary change to the renderer to suppress the soft keyboard in case the Touch To Fill UI should be shown. It does so by adding an always_hide_ime field to RenderWidget and TextInputState and modifying ImeAdapterImpl.java to always hide the IME if this flag is set. Bug: 957532 Change-Id: I835f89991aeca931c8c963ce6e8e165187188ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619788 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683581}
-
Eric Willigers authored
The logical overscroll-behavior-* properties do not inherit. https://drafts.csswg.org/css-overscroll-behavior/#property-index Change-Id: Ia9b69006d8d908f43be600a4862f23670db14dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731339 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683580}
-
Christopher Grant authored
generate_breakpad_symbols.py uses sys.platform as the default platform if one isn't specified. For me, using crashpad_stackwalker is now assuming Linux, and failing to generate symbols. Since crashpad_stackwalker is an Android tool, we can be explicit about what platform symbols are being generated for. Bug: None Change-Id: Iead76cd68b7ffff2b6d4f05d919fa2974687c6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730581Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#683579}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59bbd6556111..054e3bbbe792 git log 59bbd6556111..054e3bbbe792 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 chxg@google.com Reland "Replace the implementation of `GetContributingSources()` on the audio side." Created with: gclient setdep -r src/third_party/webrtc@054e3bbbe792 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: If582ccea3c440fa0418b3f6020686878aa779c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683578}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a0eb5efd2bad..3cea2e5882e3 git log a0eb5efd2bad..3cea2e5882e3 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 cepheus@frii.com Bump revision and give the bots another chance to work. Created with: gclient setdep -r src/third_party/glslang/src@3cea2e5882e3 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I08e8b4c6224a038825ff6e07b3833531c07c6d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733197Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683577}
-
Charlie Andrews authored
This is needed for Android support of stack sampled metrics (SSM). SSM takes stack samples, which requires unwinding the stack. Ahead-of-time compiled Java unwind instructions are stored in an xz-compressed section of MiniDebugInfo. This is why libunwindstack, the library that we'll be using for unwinding, requires lzma to support decompression. These files are separated into their own static library. This allows them to be shipped independently from the rest of the lzma SDK. SSM is only enabled for Chrome dev/canary now and will only ever roll out to a small portion of stable users, if any. Because of this, it makes sense not to ship the extra ~15kB required for lzma xz decompression to the vast majority of Chrome Android users. More context is available in the broader design doc at http://bit.ly/2YjttvL R=grt@chromium.org Bug: 989100 Change-Id: I3a2a6c1b8d89779b94f92cb02f72b13adb1d7d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730793Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#683576}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e52728367fa3..36fb019c0657 git log e52728367fa3..36fb019c0657 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 fmayer@google.com Add intern table for source files. Created with: gclient setdep -r src/third_party/perfetto@36fb019c0657 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:138725313 Change-Id: I4878a85e9aab926283f3712914692094e23a02b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683575}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ccb8f1c82e61..fdd03910d6c6 git log ccb8f1c82e61..fdd03910d6c6 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 nathanrogers@google.com Add a TRACE_EVENT for SkGpuBlurUtils::GaussianBlur Created with: gclient setdep -r src/third_party/skia@fdd03910d6c6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I59cf53c197e36b191873408d3b0a887f3ec7a4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733196Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683574}
-
Pavol Marko authored
Bug: none Change-Id: I6bf4514fdef5339b76e188c5f50dba9c2d8e38a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731843 Auto-Submit: Pavol Marko <pmarko@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#683573}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ccf13eb..33faa512 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f624222d6794088d6e76676652164db2e355d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731341Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683572}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ec6ed57a688e..4f68ff26e4e9 git log ec6ed57a688e..4f68ff26e4e9 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 perezju@chromium.org Revert "[Telemetry] Fix GetRecentMinidumpPathWithTimeout log spam" 2019-08-01 rmhasan@google.com [Typ] Expectation tags in tag declaration lists are not case insensitive 2019-08-01 crouleau@chromium.org Revert "Reland "[Telemetry] Do not allow iterating over results while running stories"" 2019-08-01 ianstruiksma@google.com Add quiet mode option to wpr to skip verbose logging on replay. 2019-08-01 bsheedy@chromium.org [Telemetry] Fix GetRecentMinidumpPathWithTimeout log spam 2019-08-01 perezju@chromium.org [Telemetry] Remove Run-/AddProcessArgs from benchmark module 2019-08-01 rnasri@google.com Add rects based speed index metric Created with: gclient setdep -r src/third_party/catapult@4f68ff26e4e9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:985530,chromium:973936,chromium:973837,chromium:990036,chromium:988509,chromium:985530,chromium:985712,chromium:982025 Change-Id: I48f21fc3010e5154a3bda9ab82bb6501c03e8078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733198Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683571}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1cff9e2ff2c..9873ee0de15a Created with: gclient setdep -r src-internal@9873ee0de15a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ia3623e531917d3eb65c40566c3f122229c02accd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733195Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683570}
-