GitLab

Screenshot on the bug.

BUG=276956

Review URL: https://codereview.chromium.org/128033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243608 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164682:164685&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/126753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331831

Review URL: https://codereview.chromium.org/118633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243606 0039d316-1c4b-4281-b951-d872f2087c98

SearchResultView's |result_| could be NULL and should be handled properly.

BUG=332012

Review URL: https://codereview.chromium.org/120553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243602 0039d316-1c4b-4281-b951-d872f2087c98

CastStreamingAPITest.Basics has been failing on OSX bots, so disable it.

BUG=332427
TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/128853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243601 0039d316-1c4b-4281-b951-d872f2087c98

This will be used by the VariationsService to simulate newly
received variations seed, to evaluate whether there's sufficient
new changes to badge the UI to suggest a restart (similar to
what happens during auto updates).

This is the initial version of this class and still
has some missing pieces, left as TODOs.

BUG=315807
TEST=Unit tests.
TBR=joi@chromium.org

Review URL: https://codereview.chromium.org/41623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276675

Review URL: https://codereview.chromium.org/110863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243592 0039d316-1c4b-4281-b951-d872f2087c98

Also improves the tests to check that audio muting doesn't mute video
and vice versa.

BUG=328196,331045

Review URL: https://codereview.chromium.org/120773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243591 0039d316-1c4b-4281-b951-d872f2087c98

It is actually what this is doing in practice but only because
SHOW_STATE_INACTIVE implementation is broken and usually creates active
windows.

BUG=None

Review URL: https://codereview.chromium.org/118283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243590 0039d316-1c4b-4281-b951-d872f2087c98

Removed the old VideoEncoderController interface and
made video_encoder a pure virtual class that
ExternalVideoEncoder and VideoEncoderImpl implements. 
This CL also remove the possibility to send in
pre-encoded video frames.

BUG=325998

Review URL: https://codereview.chromium.org/116623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243589 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/128223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243587 0039d316-1c4b-4281-b951-d872f2087c98

Widget::InitParams: Added override_show_in_taskbar value to force popup
and bubble windows (including the App Launcher) to appear in the taskbar
when they otherwise would not.

BUG=332007
TEST=Launch App Launcher. It should appear in the Unity launcher.

Review URL: https://codereview.chromium.org/122353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243585 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243583 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
http://crbug.com/308843

Review URL: https://codereview.chromium.org/126513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243578 0039d316-1c4b-4281-b951-d872f2087c98

Usages of AwSettings.LayoutAlgorithm need to be replaced with
WebSettings.LayoutAlgorithm.

This change also fixes a couple of trivial presubmit warnings in
existing code.

BUG=332089

Review URL: https://codereview.chromium.org/115253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243576 0039d316-1c4b-4281-b951-d872f2087c98

Relying on local-auth is not sufficient because locking can be enabled when no local credentials are present.  Also, changing the password outside of this instance of Chrome would require using the old password to unlock, now no longer the case.

This affects only new-profile-management.

BUG=328017

Review URL: https://codereview.chromium.org/99373008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243575 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243573 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164663:164681&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/128263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324166

Review URL: https://codereview.chromium.org/127663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243571 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496

Review URL: https://codereview.chromium.org/126433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243569 0039d316-1c4b-4281-b951-d872f2087c98

DoCreateStream time in the HttpNetworkTransaction. This hook allows
for experimentation with the ResourceScheduler so that it can defer
after first checking the cache, gathering the cookies, and starting
the WebRequest but before going to the network.

BUG=328741

Review URL: https://codereview.chromium.org/122453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243568 0039d316-1c4b-4281-b951-d872f2087c98

The dependency path is
  src/chrome/chrome.gyp:common ->
  src/components/components.gyp:policy_component ->
  src/components/components.gyp:user_prefs ->
  src/content/content.gyp:content_browser

This was introduced in https://codereview.chromium.org/102973005. The issue is
that URLBlacklistManager::RegisterProfilePrefs() uses a PrefServiceSyncable
which comes from user_prefs, and user_prefs depends on content::BrowserContext.

This fix splits the policy/common files into a policy_component_common target
that does not depend on user_prefs. chrome.gyp:common now depends on
policy_component_common, and chrome.gyp:browser depends on policy_component.

BUG=332030

Review URL: https://codereview.chromium.org/124393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243567 0039d316-1c4b-4281-b951-d872f2087c98

Update PowerPolicyController to not send an empty policy to
powerd when Chrome starts or exits. Empty policies were
originally sent to ensure the system wouldn't be stuck with
an old policy, but they also mean that powerd could briefly
revert to its default settings with undesireable results
when the system first boots or the user logs out (e.g. an
enterprise policy has disabled the lid-closed action, but
powerd reverts to its default settings and shuts down
automatically when the user logs out).

BUG=329930
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/116983008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243566 0039d316-1c4b-4281-b951-d872f2087c98

This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
  instead of TokenWebData::FromBrowserContext.

BUG=332107
TBR=thakis

Review URL: https://codereview.chromium.org/109783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243564 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243563 0039d316-1c4b-4281-b951-d872f2087c98

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/127983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243562 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243561 0039d316-1c4b-4281-b951-d872f2087c98

r1830 - generator output should be relative to depth
r1829 - win msvs: make express editions not use x64-x64 compiler

BUG=none
TBR=joi@chromium.org

Review URL: https://codereview.chromium.org/127953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332237

Review URL: https://codereview.chromium.org/127113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243559 0039d316-1c4b-4281-b951-d872f2087c98

Quite a few changes were made downstream, keep them in sync:
- specify the #include files.
- inject the common DCHECKs for class and native pointers.
- inject the check exception call.

BUG=

Review URL: https://codereview.chromium.org/115103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243558 0039d316-1c4b-4281-b951-d872f2087c98

We already load chrome.pak and en-US.pak which includes all the necessary
strings and images for the tests.

This also fixes the following errors I'm seeing in ui_unittests target.

[18617:18617:0104/164229:7580537011:ERROR:memory_mapped_file.cc(23)] Couldn't open /home/tfarina/chromium/src/out_cros/Debug/ui_unittests_strings/chrome_100_percent.pak
[18617:18617:0104/164229:7580537130:ERROR:data_pack.cc(78)] Failed to mmap datapack
[18617:18617:0104/164229:7580537189:ERROR:resource_bundle.cc(607)] Failed to load /home/tfarina/chromium/src/out_cros/Debug/ui_unittests_strings/chrome_100_percent.pak
Some features may not be available.

BUG=144345
TEST=ui_unittests, app_list_unittests, message_center_unittests
R=tony@chromium.org
TBR=ben

Review URL: https://codereview.chromium.org/104783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=194304

Review URL: https://codereview.chromium.org/100963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243556 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org
TBR=eroman@chromium.org
BUG=324225

Review URL: https://codereview.chromium.org/127923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/121673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243554 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=thakis@chromium.org
BUG=162825,293049,332271,332328,332329,332330,332335

Review URL: https://codereview.chromium.org/127933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243553 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243552 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164656:164662&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/127913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243551 0039d316-1c4b-4281-b951-d872f2087c98

Actual implementation will come later. This CL just addes the interface.

BUG=324166

Review URL: https://codereview.chromium.org/127463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=checkdeps passes
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/126893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243549 0039d316-1c4b-4281-b951-d872f2087c98