- 24 Nov, 2019 33 commits
-
-
Mike Jackson authored
Refactored the code to use common methods (which didn't exist when the test was written), and fix the time out in the test. The fix for the time out was to reduce the size of the allocation we were making as data into indexeddb. Change-Id: Id5889c923e421dc195a5a9edf58fedd37e39ca9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927219 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718490}
-
Kent Tamura authored
from |double| to |base::Optional<base::Time>|. This CL is the first step to stop using |double| for file timestamps in Blink. Though base::Time can be an is_null() value, we apply base::Optional<base::Time> instead of just base::Time because: - In JavaScript, the null base::Time, which represents 1601-01-01 00:00 UTC, is a valid time. We have to use base::Optional<base::Time> in some parts of Blink. - data_element.mojom applies |mojo_base.mojom.Time?| for file timestamps, and it is mapped to |base::Optional<base::Time>| in C++. This CL should have no user-visible behavior changes. Bug: 988343 Change-Id: I91f592b31cf8e61053969530fafc689eea8ff538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930756 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#718489}
-
ishell@chromium.org authored
... by adding use_unaligned=1 to default LSAN_OPTIONS. With pointer compression in V8 the external pointers from V8 heap are guaranteed to be only 4-byte aligned so without this flag LSAN is not able to find all the external pointers. Bug: chromium:328552 Change-Id: I4bb7eb68d023ae4fb4324cf13d317e3ee011669d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926472Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc1dc5a0c78d..61b3a554547f Created with: gclient setdep -r src-internal@61b3a554547f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2f12f5bf6e2a5850b1ce42a2cb408ef2ce65063f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932245Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718487}
-
Emircan Uysaler authored
This reverts commit 516d3a4f. Reason for revert: Caused a bunch of regressions: crbug.com/1027725 crbug.com/1027878 crbug.com/1027879 crbug.com/1027880 Original change's description: > Reduce min_height_for_gpu_raster_tile for low memory devices > > Bug: 1025408 > Change-Id: I2cc6418f4dbbaf7b91f35fdc11ee8d5093d19fe6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922470 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717815} TBR=jonross@chromium.org,haraken@chromium.org,emircan@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1025408 Change-Id: Ifcf4c012c36325a55deb4807ab985f87a0426bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933447Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718486}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f29d2eb. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I97c9c50d60994aaf1d3cb72172b7078b31f577b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932835Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718485}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e7259224a7e..fc1dc5a0c78d Created with: gclient setdep -r src-internal@fc1dc5a0c78d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I837315b48f55780f58403cecff453af992ac3159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933121Reviewed-by:
-
Ken MacKay authored
Bug: internal b/144923441 Change-Id: I0700c880c7600c31de8e5515df5ff1f900ea3568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931755Reviewed-by:
Le-Chun Wu <lcwu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#718483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bc2f8e355d2..0e7259224a7e Created with: gclient setdep -r src-internal@0e7259224a7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I3e2e1d97bd9dbdc44ed402697110dcdf8b3f26db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933119Reviewed-by:
-
Tim Schumann authored
Fails on linux-chromeos-rel. BUG: 1027940,1000959 TBR=rockot@chromium.org Change-Id: Ia973627fc1fae89e00c875d9cb6d08ce3ee17736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932660Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#718481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ee9a7d5e486..0bc2f8e355d2 Created with: gclient setdep -r src-internal@0bc2f8e355d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I80d9b9d554bc8bf489aac06679a82b8aaacc4f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933118Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 371 379 384 385 388 389 390 391 392 393 394 395 396 397 439 lines were removed and 76 lines were deflaked by consecutive results since 384. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ie96de61574c526c3e64b50a02578e3367d11ea6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930278Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#718479}
-
Tim Schumann authored
As tests are failing on linux-chromeos-dbg (which apparently does not set OS_CHROMEOS so disable the test on linux instead). TBR=yoshiki@chromium.org Change-Id: I4bf298ed79ff4fb20174d493594e61e55c94dfa4 BUG: 1027919 Change-Id: I39ab2707f53185be90781796747e7b20b039202e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932658Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5fdf0df32d85..5ee9a7d5e486 Created with: gclient setdep -r src-internal@5ee9a7d5e486 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Idddd2fdc5fda71bf6f81eec1833d1d398f784fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933117Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 68560574. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7b81c1f1c64a0ccb72dab3bdb7273f7099ead97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932828Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fad83bcb97f9..5fdf0df32d85 Created with: gclient setdep -r src-internal@5fdf0df32d85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Icd5dc86a5c2d02cbcef0ce4752bb533261edef5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932892Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4ad9eb5b8dd..fad83bcb97f9 Created with: gclient setdep -r src-internal@fad83bcb97f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I858f42482847b870493500151a693b3b73334e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932890Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5b50ce5a465a..e4ad9eb5b8dd Created with: gclient setdep -r src-internal@e4ad9eb5b8dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5bdb2be26e2c4502ea32a25150ace935cdecfe24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932889Reviewed-by:
-
Julien Isorce authored
This resolved the TODO pointed to the below bug. This also fixes the following build error on Desktop Linux when the user adds use_vaapi=true in its gn build args. LINK ./vaapi_unittest FAILED: vaapi_unittest error: undefined symbol: media::LocalGpuMemoryBufferManager::LocalGpuMemoryBufferManager() >>> referenced by vaapi_jpeg_decoder_unittest.cc "ninja -C out chrome" is working but above error is encountered when running "ninja -C out" which builds all targets. Bug: 974437 Change-Id: Ibb36e02138431b1f95fd9f4d6de3e05134ee9751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902667Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#718472}
-
Zinovy Nis authored
Bug: 1025143 Change-Id: I0b2af82249f78831e70ea398ff06da4c79eaf2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920667 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#718471}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/30319dfe..2cab5168 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib8d4f1e517689c90901bcf1c7c81d166b5644098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718470}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9259c834e642..5b50ce5a465a Created with: gclient setdep -r src-internal@5b50ce5a465a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I03232e0f5c144eeaeedbcd5f1cd4f8fde420a9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932887Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c2afc9928ece..9259c834e642 Created with: gclient setdep -r src-internal@9259c834e642 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Id3d538b8df1eb889bb4860bf57522c5c4fe30861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932400Reviewed-by:
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: I5b80b2322b3c9c15aa271dbe02a7f56a360d1e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929773 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#718467}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Id84f9b7c3ee07002cf77f8ba8f6bd6edf556b9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932159Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718466}
-
Koji Ishii authored
This patch fixes ink-overflow computation for FragmentItem. Currently in the phase 1 of LayoutNG, we compute ink-overflow by traversing |LayoutObject| tree, using data in |NGPhysicalFragment| for objects laid out by LayoutNG. The initial implementation for FragmentItem missed this point and stored all ink-overflow to |NGFragmentItem|. In future, we will want to walk the fragment tree and fragment item lists. Fixes ~100, regresses 5 by revealing accidental passes. Bug: 982194 Change-Id: I0848d95c53baf9b9d9d08be58c87ae4271650361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928462Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#718465}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5843d1e79594..c2afc9928ece Created with: gclient setdep -r src-internal@c2afc9928ece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ic669a0d7399968a611cf52d81faf2b637af0f322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932398Reviewed-by:
-
Jinsuk Kim authored
This CL defines Tab as an interface, and provides a concrete implementation of it (TabImpl). Initially the codebase switches to TabImpl for accessing non-public interface methods. The interface starts with a subset of methods and gradually includes more, and eventually replace all the references of TabImpl with Tab. See https://bit.ly/2WibHVy for the design proposal. Bug: 995903 Change-Id: Iab5b9f703732f2c6b33b1fce8836de37acf21a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883270 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#718463}
-
Maggie Chen authored
GPU.WatchdogThread.Event(kGpuWatchdogStart) was added too early (eg. watchdog creation time) that it couldn't be persistent. This histogram data was lost after crash or browser exit. Now delay the recording of kGpuWatchdogStart until the first OnWatchdogTimeout() to ensure this metric is created in persistent memory. Bug: 988344, 949839 Change-Id: I8829d31209511d34220eb17a4f39017929d7e0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929867 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718462}
-
Aran Gilman authored
Bug: 1027612 Change-Id: Ic4f4e1e43eb59a9aa24595a15e35d9003c718733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929860 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Tim Schumann authored
This reverts commit 4951143a. Reason for revert: PaintPreviewCompositorCollectionBrowserTest.TestInitializationSuccess fails on linux-chromeos-google-rel CI: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel?limit=100 Instance: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9587 example logs: [ RUN ] PaintPreviewCompositorCollectionBrowserTest.TestInitializationSuccess [1:1:1123/144534.806495:WARNING:hugepage_text.cc(182)] The ordering seems incorrect, fall back to small page [17651:17651:1123/144534.888293:WARNING:audio_manager_linux.cc(52)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [17651:17651:1123/144534.982920:INFO:profile_network_context_service.cc(206)] Using built-in cert verifier. [17651:17651:1123/144534.988049:ERROR:proximity_auth_profile_pref_manager.cc(189)] Failed to find local state prefs for current user. [17651:17651:1123/144535.011423:INFO:profile_network_context_service.cc(206)] Using built-in cert verifier. [17651:17651:1123/144535.017906:INFO:profile_network_context_service.cc(206)] Using built-in cert verifier. [17651:17651:1123/144535.019873:INFO:remote_commands_service.cc(40)] Fetching remote commands. [17651:17651:1123/144535.019945:WARNING:remote_commands_service.cc(42)] Client is not registered. [17651:17651:1123/144535.019973:INFO:remote_commands_invalidator.cc(34)] Initialize RemoteCommandsInvalidator. [17651:17651:1123/144535.019993:INFO:remote_commands_invalidator.cc(59)] Starting RemoteCommandsInvalidator. [17651:17651:1123/144535.020014:INFO:remote_commands_invalidator.cc(130)] RemoteCommandsInvalidator ReloadPolicyData. [17651:17651:1123/144535.020034:INFO:remote_commands_invalidator.cc(172)] Unregister RemoteCommandsInvalidator. [17651:17651:1123/144535.022879:WARNING:wallpaper_controller_client.cc(370)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [17651:17651:1123/144535.064656:ERROR:account_manager_migrator.cc(248)] Could not find a refresh token for the Device Account. [17651:17733:1123/144535.158896:WARNING:google_brand_chromeos.cc(39)] Brand code file missing: /opt/oem/etc/BRAND_CODE ../../content/public/test/browser_test_base.cc:605: Failure Failed RunLoop::Run() timed out. Stack trace: #0 0x55f14751ff09 (/b/s/w/ir/out/Release/browser_tests+0x70a8f08) [17651:17651:1123/144605.264003:INFO:remote_commands_invalidator.cc(47)] Shutdown RemoteCommandsInvalidator. [17651:17651:1123/144605.264078:INFO:remote_commands_invalidator.cc(70)] Stopping RemoteCommandsInvalidator. [17651:17651:1123/144605.264095:INFO:remote_commands_invalidator.cc(172)] Unregister RemoteCommandsInvalidator. [17651:17651:1123/144605.271554:WARNING:pref_notifier_impl.cc(40)] Pref observer for native_printing.external_print_servers_whitelist found at shutdown. [17651:17651:1123/144605.307536:WARNING:pref_notifier_impl.cc(40)] Pref observer for media_router.cast_allow_all_ips found at shutdown. [17651:17651:1123/144605.307567:WARNING:pref_notifier_impl.cc(40)] Pref observer for EulaAccepted found at shutdown. [17651:17651:1123/144605.307579:WARNING:pref_notifier_impl.cc(40)] Pref observer for browser.relaunch_heads_up_period found at shutdown. [17651:17651:1123/144605.307587:WARNING:pref_notifier_impl.cc(40)] Pref observer for browser.relaunch_notification_period found at shutdown. [17651:17651:1123/144605.307595:WARNING:pref_notifier_impl.cc(40)] Pref observer for browser.relaunch_notification found at shutdown. [ FAILED ] PaintPreviewCompositorCollectionBrowserTest.TestInitializationSuccess, where TypeParam = and GetParam() = (30599 ms) Original change's description: > [Paint Preview] Add font access for Linux > > Testing on Cluster Telemetry with Linux found an issue where SkFontMgr > wasn't initialized properly resulting in inability to start the > compositor. This is due to the lack of font access since we didn't > call EnsureBlinkInitializedWithSandbox. However, the compositor only > needs a fraction of the features that come with that call. This CL > starts the font_service which enables the SkFontMgr to initialize. Note > that we don't require WebSandboxSupport to be initialized (at least for > Linux) as all the fonts are stored in the provided SkPictures. > > Test coverage for this will be added as part of the end-to-end tests > for the player. That should catch any issues with other platforms. > > Bug: 1023377 > Change-Id: I95a224f6f3759b1b8f8df2989222757ebbd4f12e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908062 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718149} TBR=vollick@chromium.org,drott@chromium.org,jochen@chromium.org,ckitagawa@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1023377 Change-Id: I0de7093d6612f2836ff8bfce30db5758d06da258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932797Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6761e5fe15f3..5843d1e79594 Created with: gclient setdep -r src-internal@5843d1e79594 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I71a774fa425311a06add10ebada2a48e8d14877f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932705Reviewed-by:
-
Yuly Novikov authored
Suppress WebGL2 OpenGL failures due to which testing was paused. Also re-enable angle_perftests claimed to be fixed by this driver. TBR=bsheedy Bug: 1016459, 1026468, 1002313, 1023745 Change-Id: Iaafa8a2ee290bbc56df201f9ac51dea2f8612c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932884Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718458}
-
- 23 Nov, 2019 7 commits
-
-
Tim Schumann authored
As tests are failing on linux-chromeos-dbg TBR=yoshiki@chromium.org Change-Id: I4bf298ed79ff4fb20174d493594e61e55c94dfa4 BUG: 1027919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932657Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79330b60ac89..6761e5fe15f3 Created with: gclient setdep -r src-internal@6761e5fe15f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2ba76fe1ae7e6b806ce5f47d33586eab29ad9d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932757Reviewed-by:
-
Tim Schumann authored
Flaky on Windows and Mac platforms. TBR=crouleau@chromium.org BUG: 1027902 Change-Id: I354fd7411f1c7e65748550fcc297f576f0753e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932656 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
David Bokan authored
This threshold goes all the way back to: https://crrev.com/ee5bc3acd0986e8fa87df7f804c49c120b8c9bc2 and was initially added to avoid superfluous scrolling of form controls on horizontally scrollable pages. If an element horizontally overlaps the scrollport by at least this threshold it's considered "fully visible" as per the scroll into view algorithm: https://drafts.csswg.org/cssom-view/#scroll-an-element-into-view Horizontal scrollable pages and partially visible form controls should be rather uncommon and we should remove magical numbers from platform behavior. If this behaivor is truly required for form controls we can special case those but lets first try removing this altogether. This does have some small impact on web-facing APIs in that scrollIntoView (as well as fragment navigations) will now align an element that's only partially on screen with the left edge. This matches the behavior in FireFox and the spec. I've modified the input-placeholder-paint-order.html and the ShowUnhandledTapUIIfNeeded tests to avoid scrolling and anchor-frames-same-origin.html to expect horizontal scrolling for this reason. [Reland Note] When first landed this caused SitePerProcessHitTestBrowserTest.ScrolledNestedPopupMenuTest/0 to start failing on linux-chromeos-rel with viz disabled. It now passes when relanded on ToT since https://crrev.com/c/1928895 turned Viz on by default on ChromeOS so this CL is a simple reland. TBR=szager@chromium.org Bug: 916631,1027403 Change-Id: Ic830083defa3684b0f2570edc5ae92249a6d9f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931381Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718454}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a346870b. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5206e5aa3180fa00fb999f5918d22e525ed71646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932676Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8ffff17ad6f..79330b60ac89 Created with: gclient setdep -r src-internal@79330b60ac89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I90e85c758bb3f2a08a107173fa693a605e1158bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932696Reviewed-by:
-
Maggie Chen authored
After adding more thread time and 60 seconds to the watchdog timeout, we don't need full 60 seconds for initialization timeout. 30 seconds (kInitFactor=2) should be a good number. We can adjust it later when Timeout histogram data is available. (gpu/OWNERS is added to the owner list of gpu_watchdog_timeout.h. The constants defined in this file are for watchdog internal use and there is no security concern.) Bug: 988344, 949839 Change-Id: I9c5148f961e5db53c1b7123a7d5c7e2b13de6b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930143Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
