- 20 Jun, 2017 40 commits
-
-
juncai authored
//device/generic_sensors already has all the sensors that can be used to implement the DeviceOrientation event: https://w3c.github.io/deviceorientation/spec-source-orientation.html Currently, //content/renderer/device_sensors uses sensors from //device/sensors as its backend, and this is one of the CLs that refactor //content/renderer/device_sensors to use sensors from //device/generic_sensor as the backend and removes //device/sensors. This CL refactors DeviceMotionEvent to use sensors from //device/generic_sensor. The issue page contains the design doc link for this change. BUG=721427 Review-Url: https://codereview.chromium.org/2896583005 Cr-Commit-Position: refs/heads/master@{#480934}
-
pcc authored
The most important thing that this gives us is the symbolizer data dependencies in //base (for producing symbolized stack traces on the swarming bots) but it also allows us to clean up the gn files in a few places. R=thakis@chromium.org BUG=732652 Review-Url: https://codereview.chromium.org/2943863002 Cr-Commit-Position: refs/heads/master@{#480933}
-
afakhry authored
Adds localization for the custom schedule slider legend marker lebels, as well as the time bubbles. BUG=705816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2951483003 Cr-Commit-Position: refs/heads/master@{#480932}
-
mfomitchev authored
TBR=rockot@chromium.org BUG=NONE Review-Url: https://codereview.chromium.org/2951743003 Cr-Commit-Position: refs/heads/master@{#480931}
-
dschuyler authored
This CL removes some js includes that don't appear to be in use any longer. BUG=677338 Review-Url: https://codereview.chromium.org/2944743002 Cr-Commit-Position: refs/heads/master@{#480930}
-
Eric Seckler authored
OnSurfaceCreated is not called for pre-existing surfaces. This leads to the DisplayScheduler ignoring expected surface damage. This patch removes the use of OnSurfaceCreated and initializes tracking state in OnSurfaceDamageExpected instead. Bug: 734942, 697086 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I737293e3b72202aa5fc7fdb4dd6aab4937aabea7 Reviewed-on: https://chromium-review.googlesource.com/541278 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#480929}
-
brucedawson authored
Running the static_initializers tool on the canary build of chrome_child.dll showed a few dozen static initializers. It was run like this: > tools\win\static_initializers\static_initializers.exe chrome_child.dll | find "obj/" | find "initializer" Many of these are trivially avoidable by tagging the objects in question as constexpr. This saves some startup cost, some code size, and it avoids creating so many private pages in the data segment. Testing with a non-official 32-bit release build shows that this change avoids eight static initializers. Once we switch to VC++ 2017 we will be able to use constexpr in more places. The static keyword was removed in a few places because it is redundant to const/constexpr. The effect on non-VC++ builds is unknown. It should be strictly neutral or an improvement. BUG=341941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2942273002 Cr-Commit-Position: refs/heads/master@{#480928}
-
moshayedi authored
After https://codereview.chromium.org/2872343003/ dispatching to input method has moved to WindowEventDispatcher, which should also work for Cast. BUG=NONE Review-Url: https://codereview.chromium.org/2946973002 Cr-Commit-Position: refs/heads/master@{#480927}
-
estevenson authored
BUG= Review-Url: https://codereview.chromium.org/2948683002 Cr-Commit-Position: refs/heads/master@{#480926}
-
dimu authored
Cr-Commit-Position: refs/heads/master@{#480925}
-
rnephew authored
TBR=charliea@chromium.org Bug: 735107,713222 Change-Id: I514c99a7cf93c4f90ba00f6ee9afd7044fb805ff Reviewed-on: https://chromium-review.googlesource.com/541617Reviewed-by:
rnephew <rnephew@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#480924}
-
Francois Doray authored
This field indicates whether a tab is in a visible window. It will be used to allow tabs in non-visible windows to be discarded. This CL does not change any observable behavior. Bug: 731145 Change-Id: I00206e5213da1cfbefd056fe4f66ac3571334847 Reviewed-on: https://chromium-review.googlesource.com/539855Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#480923}
-
Scott Graham authored
https://codereview.chromium.org/2925073002/ moved this from blink to base. This doesn't seem to be exposed from musl so filed bugs and stubbed (as it doesn't compile right now.) Bug: 706592, 735087 Change-Id: I106eb6875d4ba7b283d831ba33aded5f850c9e1b Reviewed-on: https://chromium-review.googlesource.com/541655Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#480922}
-
pdr authored
This test is flaky on all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fblending%2Fbackground-blend-mode-gif-color-2.html&testType=webkit_tests TBR=schenney@chromium.org Bug: 734422 Change-Id: Id3a880f6514e7f6b31f43f91d13bf84e21f6f776 Reviewed-on: https://chromium-review.googlesource.com/540787Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#480921}
-
Joy Yu authored
In some situations, table percentage widths exceed 100%, causing division by zero. The previous code would divide by an arbitrarily small number to avoid division by zero and get an arbitrary high value. Since FF/Edge always set to a max width (which is still unspecified), we now also set to a max width (kMaxTableWidth). Bug: Change-Id: I2baae89addc89417aa7999c84e17ef5dfbc588ab Reviewed-on: https://chromium-review.googlesource.com/540261Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Joy Yu <joysyu@google.com> Cr-Commit-Position: refs/heads/master@{#480920}
-
pdr authored
This test is flaky on all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&showExpectations=true&tests=fast%2Fevents%2Fwheel%2Fmouse-wheel-scroll-latching.html TBR=sahel@chromium.org Bug: 735130 Change-Id: I1268bfd45c2df6623cfc334de8db0cfb4e218780 Reviewed-on: https://chromium-review.googlesource.com/541715Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#480919}
-
erikchen authored
Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. BUG=624049 Review-Url: https://codereview.chromium.org/2941293003 Cr-Original-Commit-Position: refs/heads/master@{#480685} Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55ebee56c4a55c Review-Url: https://codereview.chromium.org/2941293003 Cr-Commit-Position: refs/heads/master@{#480918}
-
jsbell authored
Within the Indexed DB back end code, use BindOnce when posting tasks and setting mojo pipe connection error handlers, and make transaction operations OnceCallbacks since they never execute twice. (The storage::QuotaClient API still requires the generic base::Bind for now even though the callbacks are logically Once.) BUG=714018 Review-Url: https://codereview.chromium.org/2941353002 Cr-Commit-Position: refs/heads/master@{#480917}
-
aelias authored
UMA data shows that users disambiguate to the touch adjustment preferred node twice as often as the next best candidate. This shows the disambiguation feature is overtriggering -- ideally, the probability would be equal. There is already logic to throw out candidates if their overlap area is strongly outweighed by the best candidate. This uses an arbitrary ratio of 50%. Increasing it to 75% doesn't visibly undertrigger when I expect it to on desktop NYTimes sidebars on my Nexus 6P, so try that threshold to improve the stats. BUG=704323 Review-Url: https://codereview.chromium.org/2950553003 Cr-Commit-Position: refs/heads/master@{#480916}
-
skym authored
BUG=701032 Review-Url: https://codereview.chromium.org/2940863003 Cr-Commit-Position: refs/heads/master@{#480915}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e644f98aab3b..821867d51814 $ git log e644f98aa..821867d51 --date=short --no-merges --format='%ad %ae %s' 2017-06-20 sullivan Update perf dashboard documentation links Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9b2877fedccf0b4429e55f18716ff05095df6513 Reviewed-on: https://chromium-review.googlesource.com/541600 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#480914}
-
Shanmuga Pandi M authored
Update MaxColspan value from 8190 to 1000 for below. a) colspan attribute of td and th elements. b) span attribute of colgroup and col elements. Spec change: https://github.com/whatwg/html/pull/1993 https://github.com/whatwg/html/pull/2734 Spec: https://html.spec.whatwg.org/#dom-tdth-colspan https://html.spec.whatwg.org/#dom-col-span https://html.spec.whatwg.org/#dom-colgroup-span BUG=715559 Change-Id: I90807a5c30cd4b0985de5d4cde6ebaa04cfa7fea Reviewed-on: https://chromium-review.googlesource.com/539435Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#480913}
-
Dmitry Titov authored
Note not all functionality of the tab helper is tested, only added one. Filed a bug (734759, FixIt) for tests for the rest of it. Bug: 701939 Change-Id: I151b16894d454ffca889b2580135fa60745b8294 Reviewed-on: https://chromium-review.googlesource.com/540496 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#480912}
-
James Cook authored
Wire up UserActivityForwarder in the browser process so that code that uses UserActivityDetector won't crash and will get correct activity notifications. Bug: 716244 Test: manual, run chrome --mash on enterprise enrolled device, no crash Change-Id: I3d6d5aeabde2880e053738847ca08c3813efab86 Reviewed-on: https://chromium-review.googlesource.com/540282Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#480911}
-
Pavel Feldman authored
Bug: 712963 Change-Id: Id694978ae94a019f91a27a37b6b0f552169df728 Reviewed-on: https://chromium-review.googlesource.com/538972 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#480910}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/012bdf8cb526..ffa8484eb061 $ git log 012bdf8cb..ffa8484eb --date=short --no-merges --format='%ad %ae %s' 2017-06-20 reed Revert "Revert "remove unused api on xfermodeimagefilter"" 2017-06-20 reed Revert "Revert "remove unused api"" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I5332c1d99e99b677a7657eb2ac03c89b56152f70 Reviewed-on: https://chromium-review.googlesource.com/541657Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#480909}
-
rbpotter authored
Add a policy/command line flag to use the system default printer as the default destination in Print Preview instead of the most recently used destination. BUG=375238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2885363003 Cr-Commit-Position: refs/heads/master@{#480908}
-
dougarnett authored
Enables DataReductionProxyDecidesTransform Feature. BUG=701802 Review-Url: https://codereview.chromium.org/2944663002 Cr-Commit-Position: refs/heads/master@{#480907}
-
mahmadi authored
In addition to comparing the autofill profile's region against avaialable region codes and names, it also avoids settings a default region when creating an address. BUG=602666 Review-Url: https://codereview.chromium.org/2950843002 Cr-Commit-Position: refs/heads/master@{#480906}
-
Albert J. Wong authored
TBR=haraken Bug: none Change-Id: I1bc2263d19902a55b94baf0b3ca96b9592ee64df Reviewed-on: https://chromium-review.googlesource.com/540655Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#480905}
-
scottchen authored
BUG=720927 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2938933002 Cr-Commit-Position: refs/heads/master@{#480904}
-
Evan Stade authored
initial load. Bug: 734104 Change-Id: I69bd97a025c3510dd32948ded8ba13e8a620fc38 Reviewed-on: https://chromium-review.googlesource.com/538922 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#480903}
-
derat authored
Add settings allowing users to control the idle and lid-closed power management behavior. BUG=633455 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2853113004 Cr-Commit-Position: refs/heads/master@{#480902}
-
Greg Thompson authored
It is intended for comprehension by Chrome developers, so it makes sense for it to always be in english. BUG=579504 Change-Id: I633810b43ceedeaf5f7b32ed5d948010154d7e79 Reviewed-on: https://chromium-review.googlesource.com/541318Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#480901}
-
Kevin Peng authored
This moves the if and else keywords out of the list of target types and also marks true and false as keywords, bringing this mode in line with the GN grammar. Also remove a seemingly unnecessary line. Change-Id: I9b28f7ca5bc60adae6302c9702960059e0285f1d Reviewed-on: https://chromium-review.googlesource.com/540777Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Peng <kevpeng@google.com> Cr-Commit-Position: refs/heads/master@{#480900}
-
Ken Rockot authored
The use of RUN_CHILD_ON_PIPE+END_CHILD macros makes clang-format do sad and non-block-like things. clang-format's MacroBlockBegin/End feature is also quite slow and should therefore not have its use expanded further to alleviate this annoyance. This kills the aforementioned macros in favor of using the test fixture's API directly. The resulting code is probably cleaner to read anyway, and naturally results in the desired block formatting for test client handlers. Win-win. BUG=None R=jcivelli@chromium.org Change-Id: Ia7f11424cf30d6f6391c28ac44bc4f58dddf3874 Reviewed-on: https://chromium-review.googlesource.com/541577Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#480899}
-
dbeam authored
R=stevenjb@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2944703004 Cr-Commit-Position: refs/heads/master@{#480898}
-
sahel authored
https://codereview.chromium.org/2928793003 is the original cl. The added browser tests were flaky on Android since device scale factor was not taken into account in the expected scroll offsets. This cl adds device scale factor to the expected scroll offsets in while loop conditions of the added browser tests. TBR=tdresser@chromium.org BUG=526463 Review-Url: https://codereview.chromium.org/2948663002 Cr-Commit-Position: refs/heads/master@{#480897}
-
Scott Violet authored
With grouping beased on functionality. This also enables tests that are now passing. BUG=none TEST=none R=erg@chromium.org Change-Id: If6dafe350655a4224ac595f4c1aeb1fe04005e68 Reviewed-on: https://chromium-review.googlesource.com/540816 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#480896}
-
Leonard Mosescu authored
Add back the required step to configure Git before fetching the sources (in particular the core.autocrlf setting) Change-Id: Id0be3f4877ce86fa62e3735e8326534d6ff87b37 Reviewed-on: https://chromium-review.googlesource.com/541240Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Leonard Mosescu <mosescu@chromium.org> Cr-Commit-Position: refs/heads/master@{#480895}
-