GitLab

This is a further step in the direction of controlling re-layouts in
a top-down manner instead of letting components at the bottom of the
tree trigger re-layouts when they change, which leads to a lot of
extra work and redraw.

Remove the "ShelfUpdatedWhenStatusAreaChangesSize" test which doesn't
make much sense any longer: the shelf is sizing itself to match the
various components' needs, children and target bounds, not just when
one of them happens to artificially change its bounds.

Bug: 1042918, 1047012
Change-Id: Ib0408aac401b32a2adcc306f3012f3943c05e220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070825
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744453}

When a swipe happens, an ET_GESTURE_SCROLL_END is not sent. This would
cause the tab strip to get stuck partially open in some cases.

With this CL, the tab strip will always fully open after a swipe. This
also adds ET_GESTURE_END handling to avoid similar bugs if an
unsupported gesture is sent.

Bug: 1043374
Change-Id: I98397e7557eb3e40fb1de04f429866925c60daed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070969
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744452}

The validation layers in ANGLE are necessary for security reasons and to
support the robust client memory extension required by client-side GL
contexts. But it can be avoided for the service-side GL context used by
skia with OOPR and SkiaRenderer.

R=geofflang@chromium.org

Bug: 1028418
Change-Id: Ia1f59752e0f5aed2fc8542cc5b3fb2ba81922c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057563
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744451}

Returning early from the function if the service is null to guard
against a potential race condition affecting beta.

Bug: 1055274
Change-Id: Ibb419037e67b2bce7cc31b3f0371ed1264ca01fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070823
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744450}

These two dialogs will use Extension install prompt dialog with
different text.

User can confirm extension request dialog for requestable extension to
upload request.
Extension request pending dialog is for information only.

When either dialog is shown, the
webstorePrivate.beginInstallWithManifest3 function will returns user
cancel to stop extension installation.

This dialog will be used till CWS lands the button change. UI has been
approved by UX team.

These two dialogs are temporary solution for extension request feature
as CWS team can't migrate to the new webstorePrivate.requestExtension
API in time. The dialogs will be deprecated once the migration is done.

Screenshots:
https://drive.google.com/file/d/1rFp4sc-C-MyDLTS1wAHrolf1gdYK6TLs/view?usp=sharing
https://drive.google.com/file/d/196GO6xUgMZMNmOv5maopDP5MgYd_bVRH/view?usp=sharing

Bug: 1006899
Change-Id: If9b439d2cf2e9d4eabf0d146e45b9df3a5adcf93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065594
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744449}

Some frames like srcdoc frames inherit URLLoaderFactories from their
parents and can make network requests before a corresponding commit.
Hence if the parent frame is allowlisted, this CL allowlists the child
frame as well when the child frame is created (as opposed to waiting for
a commit in DidFinishNavigation).

This also fixes another bug where a frame which underwent multiple
navigations didn't have the correct allowAllRequests frame action
associated with it. This was because std::map::insert doesn't insert if
the corresponding key already exists in the map. We correct this by
always erasing the key before inserting in
RulesetMatcherBase::OnDidFinishNavigation.

BUG=1050536

Change-Id: I59d809b160ff534c100cfc7b44b82965a236b48d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069023
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744448}

This CL update the function DeleteDataForOriginOnFileTaskRunner to use
dedicated Origin type instead of GURL.

Bug: 598424
Change-Id: I597a2d31944ad41427b2c8b42586f069c5478e45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071522Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#744447}

This will make it easier to check for new issues when running `git cl
lint`.

Bug: 1053888
Change-Id: Ib3199e868ddda532198f84070a155ff5ffa85fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063000Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#744446}

Getting display from the WindowManager may raise errors in future
versions of android because the API implies it supports multi-display
but it actually depends on the Context being used. Application context
definitely will not support multi display.

Instead retrieve the default display from DisplayManager does not have
this limitation and also makes it clear in code that this code is not
multi-display aware.

Note an earlier version of this to use DisplayAndroid was reverted
because this code does not run on the UI thread.
https://chromium-review.googlesource.com/c/chromium/src/+/2026354

Bug: 1042063
Change-Id: I1066c9f5b7dfed572c47ece72acd012329a863c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070331Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744445}

All ContextFactoryPrivate implementations are also ContextFactory
implementations. Move the two remaining ContextFactoryPrivate functions
into ContextFactory and clean up usage.

Bug: 1042259
Change-Id: I48063717cd6e51ccfc94e0a160d50d95d7629388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047728
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744444}

This metric stores the same values as
Variations.FirstRun.SeedFetchResult, but stores results for all WebView
seed requests, rather than Clank's first-run request.

See doc/1qNASRaqCeRdpbH84IpqsSPzR8R8U6M-sUyHeAZCVrzw for more details.

Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'AwVariationsSeedFetcherTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedLoaderTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedServerTest#*'
Test: Manually verified correct metrics were being recorded by adding
Test: logging when recording the metrics.
Bug: 1047536
Change-Id: I3f216084844198ed8828695d615a359bb83c41e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067275Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744443}

Bug: 1054843
Change-Id: I6ea53913579f94b6725902f7038c214dea05c9bc
Fixed: 1054843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071046
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744442}

Bug: 634140
Change-Id: Ied0092d83f179dc47130c9bf882cc43aca647da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066477Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744441}

AppServiceAppIconLoader should replace the ArcAppIconLoader, so update
arc_app_unittest to use AppServiceAppIconLoader.

Fix the unit tests failures:
1. AppServiceAppIconLoader should support ARC shelf id, so add
shelf_app_id_map_ to record the map from app_id to shelf id.

2. Move GetAppFromAppOrGroupId from ArcAppIcon to arc_app_utils, because
AppService icon loader calls that function to get the app id from the
ARC group id.

3. Update the unit tests, WaitForIconUpdates, the expected callback
on OnAppImageUpdated should be once:
From:
delegate.WaitForIconUpdates(scale_factors.size());
To:
delegate.WaitForIconUpdates(1);

Because AppService will callback once when all supported scale factor is
loaded:
https://cs.chromium.org/chromium/src/chrome/browser/apps/app_service/arc_icon_once_loader.cc?l=101

4. Update AppService icon loader to call ArcAppIcon to generate the
default icon in case the icon load failed.

BUG=1016159

Change-Id: I1c8ebc018eab3becb37351f51116f63a395f6f7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050143
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744440}

Disables AccessibilityInputDateWithPopupOpenMultiple
and XmlInIframeCrash on all platforms.

Bug:1055764
Change-Id: I5f048849bcea1f400e69a65bae9bbedfa97d5f55

TBR=vicfei@microsoft.com

Change-Id: I5f048849bcea1f400e69a65bae9bbedfa97d5f55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072931Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744439}

Experiment has expired and we currently don't want to pursue this.

Change-Id: I434333da5980be149f1f61fd74aa267ce9653ca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071858Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744438}

Worth it to only have to review all of these once a year.

Bug: 1055383
Change-Id: I6948ea46796dc0a6891e017a59fac0ce86cb36e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070831Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744437}

It used to be |has_audio| to differentiate audio message and non-audio
message. But now we have one more type of message, i.e., metadata
message. Meanwhile, add new util method to populate metadata message.

Merge-With: eureka-internal/357770
Bug: internal: 140736325
Test: On device. Unittests.
Change-Id: Ic89ffb293b75ce303631dda08ace720f949c318c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049025Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Kehuang Li <kehuangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744436}

Clunky commands:
find chrome/browser/ -type d \( -wholename '*java/src' -or -wholename '*junit/src' -or -wholename '*javatests/src' \) | sort | sed -e 's/\(.*\)$/    <classpathentry kind="src" path="\1"\/>/gm'
find components/ -type d \( -wholename '*java/src' -or -wholename '*junit/src' -or -wholename '*javatests/src' \) | sort | sed -e 's/\(.*\)$/    <classpathentry kind="src" path="\1"\/>/gm'

BUG=

Change-Id: I3fca1ab27b5c52bf62b5d048c782bba95ce5c06c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072875Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744435}

This CL adds a new bucket to the Download.InitiatedByWindowOpener
histogram. The new bucket records if the opener (the tab that
initiated the download) or the openee (the tab on which the download
was initiated) is a non-HTTP or HTTPs URL such as about:blank.

Bug: 121259
Change-Id: Ic45a82df693422419a15849a19027002697e0838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072678
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744434}

Apply the 'Fuchsia x64' CI and fuchsia-fyi-arm64-rel FYI builder
exceptions to the 'Fuchsia ARM64' CI builder.

This is being done before tests are enabled on the 'Fuchsia ARM64' CI
builder.

Bug: 1042512
Change-Id: Ie439d47b14d60a548335489e21ab47f4f9e10c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071368Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#744433}

This reverts commit 756673ee.

Reason for revert: <INSERT REASONING HERE>
interactive_ui_tests fails
BrowserFocusTest.PopupLocationBar
PasswordBubbleInteractiveUiTest.AutoSigninNoFocus
OmniboxFocusInteractiveTest.NtpReplacementExtension_LocationAssignment
BrowserFocusTest.FocusOnReload
...26 more failure(s) (30 total)...
on Builder Linux TSan Tests
https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests

Original change's description:
> Enable WebUITabStrip in fieldtrial_testing_config.json
> 
> Bug: 1009881
> Change-Id: I0c784e4ac16bb14e5515b95680adfea3b5e3148c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069499
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Collin Baker <collinbaker@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744385}

TBR=jwd@chromium.org,collinbaker@chromium.org

Change-Id: I8be4824fcc9e2ccb873807d44faee7105d865dbd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1009881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073159Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744432}

This lets test authors put their HTML and JS content in an external file
instead of inlining it into the LoadHTML call.

Also update MetricIntegrationTest.LayoutInstability to use this
capability.

Bug: 1045064
Change-Id: I7b8de053b468f5cf82747a875a2730242665891d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067348Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744431}

Consistently use 'const Module' rather than 'Module' in the interface.
Modules are not to be mutated by the ModuleCache or its users.

Rename InjectModuleForTesting to InjectNativeModuleForTesting to be
clearer about what it does.

Have GetModules() return both native and non-native
modules to make the behavior consistent with the function
name. The only current user of GetModules(),
content::protocol::MemoryHandler::GetBrowserSamplingProfile(), does
not add any non-native modules to the ModuleCache so returning
non-native modules from the function will not affect it.

Bug: 1035855
Change-Id: Ie1cd38e081ee48297df3c7a15b8e4997d1df1589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062883
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744430}

This reverts commit 38ee3ee4.

Reason for revert: UX would like a complete review before making this change.

Original change's description:
> Compute omnibox background color from toolbar color.
> 
> This makes the omnibox/toolbar contrast ratio 1.3 by default.
> Theme authors can manually override the default colors.
> 
> Bug: 878664
> Change-Id: I24b95e8d225fd375b573b48e403fbf147013e940
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986244
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#730295}

TBR=pkasting@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 878664
Change-Id: I1fb8a3c7cfd1b8cd57a260cc9d7f00aa8131e024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070601Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744429}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4be48f5a3603..be4da4f63d35


Created with:
  gclient setdep -r src-internal@be4da4f63d35

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1054683,chromium:1055510
Tbr: jbudorick@google.com
Change-Id: I864092390084e0c4c586a5c77467f9fdb2ce8522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072843Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744428}

This CL implements an entry point for ambient mode where it will show
when user switches to the lock screen, e.g. by pressing the icon, with
feature flag turned on. This CL also adds the first unit test case for
the ambient controller.

Bug: b/149245177
Test: run unittest.
Change-Id: I8cf4424d861b1eac707db2d1dd978af6b7e0efce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065614Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744427}

When referencing a line name in the grid-placement properties, if the
first track was defined using the auto repeat() syntax, then the code
would assume that the line had to appear after the repeated tracks.

However, it can precede them, e.g.
    grid-template-columns: [first] repeat(auto-fill, 10px)

This patch fixes this by removing the special casing for auto repeat()
being the first tracks.

BUG=966090

TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-002.html

Change-Id: Ic9c1199532f8ed06c958b80aef4580b7a318490c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071873Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#744426}

the PLOG(ERROR) calls were removed on friday as part of a macro cleanup,
but we need non-debug builds to have notices that dll loading has failed
to avoid totally silent errors.

Bug: 1055602
Change-Id: I0d83eca6caecca8b8bde3183ae02e52c1733d3c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071580Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744425}

Currently, Vulkan function pointers are called from everywhere in
Chrome. All those files have to be in the CFI backlist. To reduce the
CFI blacklist, this CL generates inline wrapper methods in
vulkan_function_pointers.h to call Vulkan function pointers, and only
puts those wrapper methods in CFI blacklist.

Bug: 1055376
Change-Id: I967c8ce9543073c46695c64f0544abbc8aa391d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072339Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744424}

HTML:time element doesn't support accessible value but listed what makes accessible name computation alg to ignore its content

R=dmazzoni@chromium.org

Bug: 1053507
Change-Id: Ifba735b2c017c00676169ab8cea80ae2d44d73fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070715Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744423}

It's flaky.

TBR=agrieve@chromium.org

Bug: 1054637
Change-Id: I2e3bdd2ea2f70a8a821c89443ecf9674a334ed95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073057Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#744422}

Bug: 807080, 1054637

TBR=agrieve@chromium.org

Change-Id: Ie45bd0e5b4906135acaf1f1ac33062c0abf03324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072999
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#744421}

https://webrtc.googlesource.com/src.git/+log/d6fb409d463d..422f9dd5df8e

git log d6fb409d463d..422f9dd5df8e --date=short --first-parent --format='%ad %ae %s'
2020-02-25 thomasanderson@chromium.org Conditionally use OPUS_GET_IN_DTX if available

Created with:
  gclient setdep -r src/third_party/webrtc@422f9dd5df8e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1047860
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I5781a7ad712b7249eda5ee83d97a82fb2a4e8189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072901Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744420}

This reverts commit 8411cc66.

Reason for revert: <INSERT REASONING HERE>
ResetFirstAfterBootTest.ViewsLogic fails on Builder linux-chromeos-chrome
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome

Original change's description:
> OOBE - Improve reset screen confirmation dialog
> 
> - Replace the dialog on the reset screen with the oobe-help-dialog
>   that complies with UX specs and reuses available code.
> 
> - Refactor the confirmation dialog logic so that it lives in the
>   main element 'oobe-reset'.
> 
> - Remove the intermediate oobe_reset_screen by using LoginScreenBehavior
> 
> - Add a waiter to test::OobeJS for waiting upon the presence of an
>   attribute. Such as waiting on the 'open' attribute of dialogs.
> 
> - Add constants and modifications to the browser tests of the reset
>   screen.
> 
> Fixed: 933310
> Change-Id: I54001745326b60ab5a0a19519923c54dffa5baec
> Bug: 933310
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041474
> Commit-Queue: Renato Silva <rrsilva@google.com>
> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
> Auto-Submit: Renato Silva <rrsilva@google.com>
> Cr-Commit-Position: refs/heads/master@{#744288}

TBR=antrim@chromium.org,rsorokin@chromium.org,rrsilva@google.com

Change-Id: I5a98467310e478ccd20c0cb3c9b92461229c5b3f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 933310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072916Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744419}

This happens when a JavaScriptDialog is showing with the count of
| in_flight_event_count | is greater than zero then we hide and
re-show the view which will trigger the
RestartInputEventAckTimeoutIfNecessary.

Change-Id: I728d4ea26809c2f6ffcf7a46e0e3b124bb63b781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071191Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744418}

This CL moves chromeOS strings for settings Kerberos add Accounts
dialog page strings from settings_strings.grdp to
os_settings_strings.grdp. It continues the process of moving all
chromeOS specific strings.


Bug: 967883
Change-Id: I4693a83d86f7eafb1f0ac780df15bc9a0d177e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067254
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744417}

AXMenuListOption currently inherits from AXMockObject. As a result, AXMenuListOption often misses various pieces of semantics computed by AXNodeObject.
For example, restriction for something like
<select><option disabled>foo</select>

The option never gets the disabled restriction.

Test: manual
Change-Id: I477e1c1f1b9b06780609bd29e2b1d0ab25443e4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071066Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744416}

This CL was generated with android_studios. See
https://developer.android.com/jetpack/androidx/migrate

The android_deps/BUILD.gn file was modified so weblayer's
build.gn DEPS will provide the required androidx libraries.

NativeBrowserTestActivity.java needs to move to androidx as well
otherwise compiling will fail as it links the code with android
support library instead of androidx, thus causing a cast error.


Bug: 1052460
Change-Id: Ifd21f96e32991d96bcc43092f8905bc9817817f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065409
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744415}

To use SetManifestRequestFilter, need to move it to chromeos/components
to avoid circular dependencies. This affects os_settings that was also
using the function.

Also adds the strings that will be used for additional search queries.

Bug: b/149720483
Change-Id: Id1fe34dbb6a463963522bd256d0ccfa3366d1e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062116Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Cr-Commit-Position: refs/heads/master@{#744414}